From fc6a3e203f7ac3e10fc4c35bae0a8038ce19d8af Mon Sep 17 00:00:00 2001 From: Devesh Kumar Singh Date: Wed, 15 Apr 2020 02:11:14 +0530 Subject: [PATCH] Added returncode check in completion tests --- tests/functional/test_completion.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/functional/test_completion.py b/tests/functional/test_completion.py index a3986811b..e00f0b037 100644 --- a/tests/functional/test_completion.py +++ b/tests/functional/test_completion.py @@ -107,9 +107,10 @@ def test_completion_alone(autocomplete_script): """ Test getting completion for none shell, just pip completion """ - result = autocomplete_script.pip('completion', allow_stderr_error=True) + result = autocomplete_script.pip('completion', expect_error=True) assert 'ERROR: You must pass --bash or --fish or --zsh' in result.stderr, \ 'completion alone failed -- ' + result.stderr + assert result.returncode == 1 def test_completion_for_un_snippet(autocomplete): @@ -314,3 +315,4 @@ def test_completion_uses_same_executable_name( executable_name, 'completion', flag, expect_stderr=deprecated_python, ) assert executable_name in result.stdout + assert result.returncode == 0