Addressed review comments

This commit is contained in:
Devesh Kumar Singh 2020-04-08 13:59:33 +05:30
parent a73ad91c8b
commit fe6920bc2f
4 changed files with 19 additions and 9 deletions

View File

@ -281,11 +281,11 @@ def test_check_include_work_dir_pkg(script):
script.run('python', 'setup.py', 'egg_info',
expect_stderr=True, cwd=pkg_path)
# Add PYTHONPATH env variable
script.environ.update({'PYTHONPATH': pkg_path})
# Check should mention about missing requirement simple
# when run from package directory
# when run from package directory, when package directory
# is in PYTHONPATH
result = script.pip('check', expect_error=True, cwd=pkg_path)
expected_lines = (
"simple 1.0 requires missing, which is not installed.",

View File

@ -819,6 +819,14 @@ def test_freeze_path_multiple(tmpdir, script, data):
_check_output(result.stdout, expected)
def test_freeze_direct_url_archive(script, shared_data, with_wheel):
req = "simple @ " + path_to_url(shared_data.packages / "simple-2.0.tar.gz")
assert req.startswith("simple @ file://")
script.pip("install", req)
result = script.pip("freeze")
assert req in result.stdout
def test_freeze_skip_work_dir_pkg(script):
"""
Test that freeze should not include package
@ -833,7 +841,7 @@ def test_freeze_skip_work_dir_pkg(script):
# Freeze should not include package simple when run from package directory
result = script.pip('freeze', cwd=pkg_path)
assert 'simple==1.0' not in result.stdout
assert 'simple' not in result.stdout
def test_freeze_include_work_dir_pkg(script):
@ -848,9 +856,9 @@ def test_freeze_include_work_dir_pkg(script):
script.run('python', 'setup.py', 'egg_info',
expect_stderr=True, cwd=pkg_path)
# Add PYTHONPATH env variable
script.environ.update({'PYTHONPATH': pkg_path})
# Freeze should include package simple when run from package directory
# Freeze should include package simple when run from package directory,
# when package directory is in PYTHONPATH
result = script.pip('freeze', cwd=pkg_path)
assert 'simple==1.0' in result.stdout

View File

@ -1842,6 +1842,8 @@ def test_install_skip_work_dir_pkg(script, data):
result = script.pip('install', '--find-links',
data.find_links, 'simple',
expect_stderr=True, cwd=pkg_path)
assert 'Requirement already satisfied: simple' not in result.stdout
assert 'Successfully installed simple' in result.stdout
@ -1861,10 +1863,10 @@ def test_install_include_work_dir_pkg(script, data):
# Uninstall will fail with given warning
script.pip('uninstall', 'simple', '-y')
# Add PYTHONPATH env variable
script.environ.update({'PYTHONPATH': pkg_path})
# Uninstalling the package and installing it again will fail
# Uninstalling the package and installing it again will fail,
# when package directory is in PYTHONPATH
result = script.pip('install', '--find-links',
data.find_links, 'simple',
expect_stderr=True, cwd=pkg_path)

View File

@ -291,10 +291,10 @@ def test_show_include_work_dir_pkg(script):
script.run('python', 'setup.py', 'egg_info',
expect_stderr=True, cwd=pkg_path)
# Add PYTHONPATH env variable
script.environ.update({'PYTHONPATH': pkg_path})
# Show should include package simple when run from package directory
# Show should include package simple when run from package directory,
# when package directory is in PYTHONPATH
result = script.pip('show', 'simple', cwd=pkg_path)
lines = result.stdout.splitlines()
assert 'Name: simple' in lines