1
1
Fork 0
mirror of https://github.com/pypa/pip synced 2023-12-13 21:30:23 +01:00
Commit graph

136 commits

Author SHA1 Message Date
Stéphane Bidoul (ACSONE) 0e1e0ef566 _should_cache does not depend on check_binary_allowed
_should_cache is only called by _get_cache_dir.

In pip install mode, _get_cache_dir is never called when
check_binary_allowed returns False because in that case
should_build_for_install_command has returned False before
and the build was skipped.

In pip wheel mode, check_binary_allowed always returns True
(because it is not passed to the build function).

So _should_cache can use _always_true for check_binary_allowed.

*Alternative*

Alternatively, we could have passed check_binary_allowed
to build in pip wheel mode. The only difference is that wheels built
locally from *legacy* packages would then not be cached,
when pip wheel is used with --no-binary.
2020-01-20 10:41:48 +01:00
Stéphane Bidoul (ACSONE) 5aa3b3d2f0
Remove unused build() argument 2020-01-05 23:52:42 +01:00
Stéphane Bidoul (ACSONE) 66e010980a
Remove WheelBuilder
build is now a function
2020-01-05 23:52:42 +01:00
Stéphane Bidoul (ACSONE) 212ee12474
Filter requirements to build beforehand in install command
One more step so build() becomes only concerned with building.
2020-01-05 23:52:41 +01:00
Stéphane Bidoul (ACSONE) 3ae13f7d28
Move is_wheel_installed to utils 2020-01-05 23:52:40 +01:00
Stéphane Bidoul (ACSONE) 4bdca1a09a
Remove now useless build_wheels function 2020-01-05 23:52:40 +01:00
Stéphane Bidoul (ACSONE) 10ff58d7be
Simplify install by calling build once
We filter what to build beforehand so we
can call build once. We then filter failures
to detect PEP 517 failures.
2020-01-05 23:52:38 +01:00
Stéphane Bidoul (ACSONE) 8601bb5d06
Make build_wheels return all failures
Check for PEP 517 build failures by
filtering failures.
2020-01-05 23:52:03 +01:00
Stéphane Bidoul (ACSONE) 8784fb419a
Make build_wheels return successes too
In preparation for moving the unpacking
out of WheelBuilder.build
2020-01-05 18:47:52 +01:00
Stéphane Bidoul (ACSONE) 261c286de9
Make wheel_cache an argument of build() 2019-12-29 18:51:45 +01:00
Stéphane Bidoul (ACSONE) 3828699ddc
Move build options from WheelBuilder to build function 2019-12-29 18:49:54 +01:00
Christopher Hunt 711cf4deaf
Merge pull request #7517 from sbidoul/wheel-builder-disentangle-6-sbi
Move final wheel builder copy operation to wheel command
2019-12-29 13:46:02 +08:00
Stéphane Bidoul (ACSONE) 1ee270a8d4
Check that the cache is writable in _main()
This avoid code duplication (for the wheel and http
cache) and repeated warnings.
2019-12-28 13:04:54 +01:00
Stéphane Bidoul (ACSONE) cf21401fd7
Make wheelbuilder.build return successes too
Also, pluralize variable names for readability and consistency with
similar variables in callers.
2019-12-26 21:43:57 +01:00
Chris Hunt fe320a3da0 Remove redundant build_dir normalization 2019-12-12 21:46:04 +08:00
Chris Hunt b6e007c6a8 Remove redundant src_dir normalization 2019-12-12 21:46:04 +08:00
Chris Hunt b8f626ace6 Deprecate install-location-related options in --install-option 2019-11-30 17:42:48 -05:00
Pradyun Gedam 1405a403fe
Merge branch 'master' into add-use-user-site-to-preparer 2019-11-11 08:40:20 +05:30
Pradyun Gedam c9606b86e1
Add use_user_site to RequirementPreparer 2019-11-10 13:51:29 +05:30
Pradyun Gedam c40a9d332d
Update callsites for RequirementTracker 2019-11-10 12:33:25 +05:30
Chris Hunt deac2343dc Don't pass PackageFinder to Preparer from Resolver
Preparer's overall responsibilities align more with having its own
reference to finder, which will help us remove it from resolver later.
2019-11-05 20:57:14 -05:00
Chris Hunt f305f66eb2 Trace common finder info outside resolver
There's no reason for Resolver to trace this information about our
PackageFinder, we just need a common one-time function to trace useful
information.
2019-11-05 20:57:14 -05:00
Christopher Hunt 31460e5ed7
Merge pull request #7299 from chrahunt/refactor/make-setuptools-args-explicit
Make setuptools args explicit
2019-11-05 20:52:35 +08:00
Chris Hunt 431727a4e4 Set home in setuptools args functions 2019-11-04 19:48:24 -05:00
Chris Hunt b28d05bb50 Set user and prefix in setuptools args functions
Previously we were adding arguments to install_options in response to
command-line parameters, which leads to spooky action at a distance.
Now we provide the arguments explicitly.
2019-11-04 19:40:00 -05:00
Pradyun Gedam da9a432576
Move WheelBuilder and friends to a dedicated module 2019-11-04 11:49:02 +05:30
Chris Hunt 3076c39f25 Remove unused Resolver.session 2019-11-03 14:31:38 -05:00
Chris Hunt 44cc3aeb0a Use session from RequirePreparer, not Resolver 2019-11-03 14:26:47 -05:00
Chris Hunt 9dc065972f Return InstallationResult from requirement installation 2019-10-29 21:50:48 -04:00
Thomas Kluyver 1310fc276a Use truthiness of everything but None for use_user_site 2019-10-25 08:26:11 +01:00
Thomas Kluyver d631a9355c Allow for use_user_site being set to an integer
This can come from tox config, see:
https://github.com/pypa/pip/pull/7002#issuecomment-545108292
2019-10-24 11:59:22 +01:00
Pradyun Gedam c729a84b48
Merge pull request #7002 from takluyver/install-user-fallback
Default to --user install in certain conditions
2019-10-22 08:44:06 +05:30
Thomas Kluyver 42b1ef3537 Clarify comment 2019-10-21 13:52:50 +01:00
Thomas Kluyver fbc0588c01 Add unit tests of decide_user_install() 2019-10-20 21:48:18 +01:00
Thomas Kluyver 16174f4ad0 Add logging for decide_user_install 2019-10-20 21:28:56 +01:00
Thomas Kluyver 79f0591630 Don't check write access on the same path twice 2019-10-20 21:23:49 +01:00
Pradyun Gedam 9ab9040d75
Remove RequirementSet.require_hashes (#7068) 2019-10-20 13:23:40 +05:30
Thomas Kluyver ecac7a17b5 Line length 2019-10-19 11:28:51 +01:00
Pradyun Gedam e94e7877ab Polish & clarify decide_user_install() function 2019-10-19 11:23:27 +01:00
Chris Hunt b8fb97a815 Remove unused RequirementSet.require_hashes 2019-10-13 13:19:49 -04:00
Sebastian Jordan e3089c5bff Merge remote-tracking branch 'origin/master' into issue-6222 2019-10-11 19:23:45 +02:00
Thomas Kluyver 5f14682749 Factor out code for handling the --user option & its default 2019-10-09 17:34:16 +01:00
Thomas Kluyver a9405b22fc Ensure necessary install_options are set for default user install 2019-10-09 08:48:33 +01:00
Thomas Kluyver a6b13b637b Fix maximum line length 2019-10-09 08:43:58 +01:00
Thomas Kluyver 14e76d0eaf Remove unused import 2019-10-09 08:38:58 +01:00
Thomas Kluyver 042d4844e8 Default to --user install in certain conditions 2019-10-09 08:34:29 +01:00
Albert Tugushev 10b9421193 Fix a typo 2019-10-06 01:10:59 +07:00
Sebastian Jordan 6a2d2dbb81 Merge branch 'master' of https://github.com/pypa/pip into issue-6222 2019-10-03 08:36:19 +02:00
Maxim Kurnikov 3692097cca add per-file disallow_untyped_defs=False, and set it to True globally 2019-09-29 23:31:15 +02:00
Sebastian Jordan cd0d6e8239 Delete unnecessary empty line addition 2019-09-25 07:04:56 +02:00