Chris Hunt
0b0d53e8fa
Use wheel helper function instead of pre-created wheel file
2020-07-04 14:22:15 -04:00
Chris Hunt
00191b2db1
Explicitly test that header file was created as-expected
...
Since this is the special part of this test. This gives us more
confidence that we're doing the right thing when removing the standalone
wheel file next.
2020-07-04 14:22:15 -04:00
Pradyun Gedam
6437bec269
Warn on to-be-removed forms of constraints
2020-07-04 18:01:38 +05:30
Pradyun Gedam
20431888cb
Move check_invalid_constraint_type to req_install.py
2020-07-04 18:01:28 +05:30
Pradyun Gedam
ace5485836
Change reject_invalid_constraint_types to be reusable
2020-07-04 17:50:42 +05:30
Nguyễn Gia Phong
512221e1c1
Make utils.parallel tests tear down properly
2020-07-04 15:07:38 +07:00
Christopher Hunt
feb2a24f14
Merge pull request #8537 from chrahunt/refactor/read-record-from-wheel
...
Read RECORD from wheel file directly during install
2020-07-03 22:00:34 -04:00
Christopher Hunt
196f5487f9
Merge pull request #8535 from chrahunt/refactor/extract-console-script-spec-source
...
Extract console script spec calculation from install_unpacked_wheel
2020-07-03 21:58:57 -04:00
Chris Hunt
d7b5a776b3
Move record_path closer to first use
2020-07-03 20:53:56 -04:00
Chris Hunt
d441f9518b
Get wheel RECORD directly from wheel file
...
This reduces our dependence on disk files, and removes some complexity
around Python 2/3 compatibility with the csv module.
2020-07-03 20:49:16 -04:00
Christopher Hunt
231211a7ab
Merge pull request #8531 from chrahunt/simplify-get-entrypoints
...
Get entrypoints directly from wheel during installation
2020-07-03 20:26:29 -04:00
Chris Hunt
0433200135
Move dest_info_dir construction closer to first use
...
Reducing the scope of variables makes it easier to refactor, since
we can extract whole contiguous chunks of code later.
2020-07-03 19:46:45 -04:00
Chris Hunt
3930e4b063
Drop unused argument
2020-07-03 19:46:45 -04:00
Chris Hunt
479154b4ae
Get Wheel entrypoints from Distribution instead of file
...
Since the Distribution pulls its data directly from the Wheel file,
without extracting intermediate files to disk, this brings us closer to
installing from Wheels without extracting everything.
2020-07-03 19:46:45 -04:00
Chris Hunt
d49d97f19f
Pass Wheel distribution to install.wheel.get_entrypoints
...
Right now we're just wiring up the arguments. Next we will actually use
them.
2020-07-03 19:46:45 -04:00
Chris Hunt
a953787152
Extract entrypoint test text construction into variable
...
We need this to construct the new argument to `get_entrypoints`.
2020-07-03 19:46:45 -04:00
Christopher Hunt
dd38d81a6e
Merge pull request #8536 from chrahunt/add-no-entrypoint-test
...
Test `wheel.get_entrypoints` when none are expected
2020-07-03 19:40:22 -04:00
Pradyun Gedam
0acdbf8943
Merge pull request #8504 from McSinyx/list-speed-up-nw
...
Parallelize pip list --outdated and --uptodate
2020-07-04 03:31:26 +05:30
Chris Hunt
3fad029b77
Test get_entrypoints
when none are expected
2020-07-03 17:49:56 -04:00
Chris Hunt
94421cfb1a
Extract console script spec calculation from install_wheel
...
This big chunk of code was independent of the rest of our wheel
installation process. Moving it out enforces that there are no
dependencies between it and the original function, and makes it easier
to read the original function.
2020-07-03 17:43:33 -04:00
Christopher Hunt
e2bcc56f71
Merge pull request #8533 from chrahunt/read-record-separately
...
Expect a plain list in get_csv_rows_for_installed
2020-07-03 17:05:43 -04:00
Chris Hunt
dcd5cadcfd
Expect a plain list in get_csv_rows_for_installed
...
This makes get_csv_rows_for_installed simpler, because it is not
modifying its arguments. We can also more easily refactor RECORD file
reading since it is now decoupled from getting the installed RECORD file
rows.
2020-07-03 12:25:12 -04:00
Christopher Hunt
ea7ee7d8e0
Merge pull request #8526 from chrahunt/reduce-dependence-on-files
...
Reduce dependence on disk files during Wheel installation
2020-07-03 11:32:38 -04:00
Christopher Hunt
e3ba8d9a49
Merge pull request #8529 from chrahunt/optimize-wheel-subdir-getter
...
Simplify and optimize getting zip subdirs
2020-07-03 11:30:46 -04:00
Pradyun Gedam
49b793cd03
Set correct envvar for new-resolver tests
2020-07-03 20:11:36 +05:30
Pradyun Gedam
a8eaf11d7f
Use the correct flag name
...
Co-authored-by: Stéphane Bidoul <stephane.bidoul@acsone.eu>
2020-07-03 19:20:58 +05:30
Pradyun Gedam
26e29aa70e
Disallow --unstable-feature, pointing to --use-feature instead
2020-07-03 18:49:57 +05:30
Pradyun Gedam
79de2c8911
Switch to --use-feature for determining which resolver to use
...
Also changes all invocations in the tests, to the new flag.
2020-07-03 18:49:56 +05:30
Pradyun Gedam
cd95531951
Add --use-feature and --deprecated-feature flags
2020-07-03 18:49:51 +05:30
Christopher Hunt
cba5f11057
Merge pull request #8524 from chrahunt/remove-always-applicable-comments
...
Remove encouraging comments
2020-07-03 09:17:53 -04:00
Christopher Hunt
8097de5364
Merge pull request #8528 from chrahunt/simplify-get-entrypoints
...
Remove redundant entrypoint text normalization
2020-07-03 09:10:10 -04:00
Chris Hunt
8259528ed9
Simplify and optimize getting zip subdirs
...
Since we only care about the first path part, we can stop at 1 split. We
do not need a list, so the unnecessary conversion has been dropped.
2020-07-03 09:02:30 -04:00
Chris Hunt
abed1d6d39
Set data_dirs
closer to first use
...
Reducing the scope of variables reduces possible dependencies between
parts of this function, and will make it easier to extract this section
into its own function.
2020-07-03 09:00:07 -04:00
Chris Hunt
01e0d8befb
Get data directories directly from zip
...
This reduces our dependence on the files being extracted to the
filesystem.
Compare the name extraction to the similar code in
`utils.wheel.wheel_dist_info_dir`.
We don't need to give `.data` directories the same strict
treatment (yet) because it isn't inconvenient if there happen
to be multiple of them in a single Wheel file.
2020-07-03 08:59:36 -04:00
Chris Hunt
d93b8b3e53
Do not shadow outer variable in loop
...
`source` is provided as an argument to this function. Shadowing it can
lead to type errors if the intermediate types change.
2020-07-03 08:59:12 -04:00
Devesh Kumar Singh
245bcd0456
Check should_ignore in if condition and remove function creation
2020-07-03 12:27:13 +05:30
Devesh Kumar Singh
d3295265e1
Assert spinner instead of if condition check
2020-07-03 12:27:13 +05:30
Devesh Kumar Singh
da2448ca13
Assert proc.stdin and proc.stdout
2020-07-03 12:27:13 +05:30
Devesh Kumar Singh
59e19ea743
Update type of local_only and user_only to bool
2020-07-03 12:27:13 +05:30
Devesh Kumar Singh
126d1de990
Add news entry
2020-07-03 12:27:13 +05:30
Devesh Kumar Singh
7e05571117
Type annotations in pip._internal.utils.subprocess
2020-07-03 12:27:13 +05:30
Devesh Kumar Singh
940107d5ed
Type annotations for pip._internal.operations.freeze
2020-07-03 12:27:13 +05:30
Devesh Kumar Singh
65e55e2540
Type annotations for pip._internal.operations.check
2020-07-03 12:27:13 +05:30
Stéphane Bidoul
af3080f43e
Merge pull request #8525 from chrahunt/trivial-early-return
...
Add early return in fix_script
2020-07-03 08:42:36 +02:00
Chris Hunt
541ce8748a
Remove redundant entrypoint text normalization
...
Currently we do processing in `get_entrypoints` so incoming text is more compatible
with `pkg_resources`. It turns out that `pkg_resources` is already doing the same normalization,
so we can omit it.
This simplifies `get_entrypoints`, opening the way for us to pass it a plain string instead
of a file path.
2020-07-02 21:50:11 -04:00
Chris Hunt
7c2fa59cd3
Add early return in fix_script
...
No behavior change, just making this function easier to refactor.
2020-07-02 20:57:51 -04:00
Chris Hunt
09d75b8a58
Remove encouraging comments
...
These comments are relevant to this function, since it is long
overdue for refactoring. This code isn't special in that regard, and we
should feel free to consider any piece of code eligible to be broken up
or put into a class. So we remove these comments in fairness to the rest
of the code, and to remove a distraction during upcoming code reviews.
2020-07-02 20:40:02 -04:00
Christopher Hunt
4645ecbdb0
Merge pull request #8447 from jku/use-valid-signals-on-py38
...
test server: Don't mask invalid signals on py38
2020-07-02 12:03:11 -04:00
Jussi Kukkonen
23ec070cf1
test server: use set of signals
...
This is what signal.pthread_sigmask() really wants and matches signal.valid_signals() output
Co-authored-by: Christopher Hunt <chrahunt@gmail.com>
2020-07-02 18:00:29 +03:00
Xavier Fernandez
09f9b0030d
Merge pull request #8096 from deveshks/list-config-files
...
Add option to list config files with pip config
2020-07-02 15:01:35 +02:00