Commit Graph

276 Commits

Author SHA1 Message Date
Maxim Kurnikov 3692097cca add per-file disallow_untyped_defs=False, and set it to True globally 2019-09-29 23:31:15 +02:00
Pradyun Gedam 03392873ec
Refactor metadata directory handling (#7087) 2019-09-28 17:34:43 +05:30
Pradyun Gedam 1cbc28a28c
Simplify handling of PEP 517 metadata temp dir (#7100) 2019-09-28 15:35:00 +05:30
Pradyun Gedam f916fbe333
Simplify handling of PEP 517 metadata temp dir 2019-09-28 12:17:41 +05:30
Pradyun Gedam ad33ecef74
Move PipSession to network.session (#7089) 2019-09-28 11:55:15 +05:30
Chris Hunt cf7ebdbbc2 Move PipSession to network.session 2019-09-27 01:02:52 -04:00
Pradyun Gedam ec5e9d30d3
Improve move_to_correct_build_directory
Why: Changes made are IMO much clearer, with a step by step flow to this
method that is easier to reason about.
2019-09-27 10:32:25 +05:30
Pradyun Gedam b01f301c75
Update get_dist to directly use metadata_directory 2019-09-27 10:32:25 +05:30
Pradyun Gedam 26fd8f24b0
Always set InstallRequirement.metadata_directory
Why: expecting metadata_directory to exist, once metadata is generated,
is easier to reason about, than considering that some kinds of
distributions set it while others do not.
2019-09-27 10:32:24 +05:30
Pradyun Gedam e7bd10115e
Start returning metadata directory from metadata generators
Why: Since the result is a single directory and it's better for the
resposibility of computing the exact location of the metadata directory
should be with the generator, that generates it.
2019-09-27 10:32:21 +05:30
Pradyun Gedam c6a2f0aac7
Rename {setup_py_dir -> unpacked_source_directory}
Why: Because PEP 517 means you won't have a setup.py in your unpacked sources.
2019-09-27 00:53:24 +05:30
Pradyun Gedam b926290a50
Merge pull request #7078 from pradyunsg/revamp-linting-processes
Revamp linting processes
2019-09-25 20:57:36 +05:30
Pradyun Gedam b447f438df
Move path_to_url() to utils/urls.py (#7075) 2019-09-25 10:00:33 +05:30
Pradyun Gedam 108f9b6786
Cleanup InstallRequirement.egg_info_path (#7081) 2019-09-25 09:34:09 +05:30
Pradyun Gedam 618714b1bf
Factor out logic for locating egg-info directories
Why: A named function brings clarity to expressing what is happening.
2019-09-25 08:04:15 +05:30
Pradyun Gedam 72d5d140be
Define a function to use as sorting key
Why: It makes it clearer what the funky expression means.
2019-09-25 08:04:14 +05:30
Pradyun Gedam 14cbc5f8a4
Return early from the function
Why: Allows reducing indentation of the function body.
2019-09-25 08:03:57 +05:30
Pradyun Gedam ea68afab93
Enable isort in pre-commit 2019-09-24 18:03:22 +05:30
Christopher Hunt 928f86a162
Merge pull request #7048 from chrahunt/refactor/always-create-tempdirectory
Always create TempDirectory.path at __init__
2019-09-24 08:27:44 -04:00
Chris Jerdonek 0435316fde Move path_to_url() to utils/urls.py. 2019-09-24 02:01:52 -07:00
Christopher Hunt f7d06671dc
Merge pull request #7066 from chrahunt/refactor/editable-requirement-parts
Factor editable requirement parsing into dedicated function
2019-09-22 14:14:09 -04:00
Chris Hunt ad82dd0981 Move RequirementParts above new function 2019-09-22 12:03:47 -04:00
Chris Hunt 8fe2eb068a Factor out editable parsing into a function 2019-09-22 12:02:14 -04:00
Pradyun Gedam 15154079d2
Move run_egg_info into operations.generate_metadata (#7063)
Merge pull request #7063 from pradyunsg/refactor/metadata-generator-legacy
2019-09-22 20:01:57 +05:30
Pradyun Gedam c787fcb3e1
Merge pull request #7064 from pradyunsg/rename-correct-build-location
Better name for _correct_build_directory
2019-09-22 19:37:11 +05:30
Chris Hunt 903580cace Use RequirementParts to populate editable InstallRequirement 2019-09-22 09:51:25 -04:00
Pradyun Gedam 359a670ba8
Use `ZipFile` as context manager in `InstallRequirement.archive` (#6988) 2019-09-22 12:51:42 +05:30
Pradyun Gedam 596b77c149
Better name for _correct_build_directory
Why: the older name doesn't clearly signal what is happening.
2019-09-22 12:49:20 +05:30
Chris Hunt 85dcaa74bb Unconditionally create TempDirectory.path 2019-09-22 00:02:46 -04:00
Pradyun Gedam 7fabb1621d
Merge pull request #7051 from pradyunsg/refactor/metadata-generator
Call into operations.generate_metadata to generate metadata
2019-09-21 22:34:49 +05:30
Pradyun Gedam 8a144447d7
Move run_egg_info logic into generate_metadata 2019-09-21 11:27:47 +05:30
Christopher Hunt 16f1b4b5dd
Merge pull request #7046 from chrahunt/refactor/constructors-req-parsing
Refactoring req.constructors requirement parsing
2019-09-20 12:16:03 -04:00
Pradyun Gedam fbe8fe21ab
Normalize usage of TempDirectory (#7047) 2019-09-20 19:46:31 +05:30
Pradyun Gedam 6d8c3fdd29
Pass self to the metadata generation function 2019-09-20 19:43:14 +05:30
Pradyun Gedam b5495b4d1e
Introduce an operations.generate_metadata module
As things stand, it'll completely delegate all the metadata generation
to InstallRequirement's methods.

Follow ups will move related code into this module.
2019-09-20 19:43:13 +05:30
Christopher Hunt 33ba61c373
Merge pull request #7039 from pradyunsg/misc/cleanups-in-req_set
A few cleanups in req_set.py
2019-09-19 23:50:25 -04:00
Chris Hunt fbdd02e2fd Manage InstallRequirement._temp_build_dir itself instead of its path 2019-09-19 22:09:01 -04:00
Chris Hunt d0336be3ee Move requirement parsing to separate function in req.constructors 2019-09-19 21:30:00 -04:00
Chris Hunt 1ae28f6946 Add RequirementParts to hold parsed requirement info 2019-09-19 21:23:13 -04:00
Chris Hunt 8d19b31b66 Remove unnecessary else in convert_extras 2019-09-19 19:28:54 -04:00
Pradyun Gedam 1bc6b94dc1
Canonicalize names stored in RequirementSet 2019-09-19 14:56:24 +05:30
Pradyun Gedam bd26e768c7
Drop "name = install_req.name"
It didn't help with formatting style and added just enough confusion
when reading that I think this is a worthwhile change.
2019-09-19 14:56:24 +05:30
Pradyun Gedam 061be18ed3
Cleanup RequirementSet str/repr computation 2019-09-19 14:55:51 +05:30
Pradyun Gedam 83780a2991
Merge pull request #7025 from chrahunt/refactor-1
Clean up req.constructors.install_req_from_line
2019-09-19 11:17:23 +05:30
Chris Hunt 6a8b47d20b Move file type info to utils.filetypes. 2019-09-17 23:40:02 -04:00
Christopher Hunt b1bc41b2c3
Merge pull request #6914 from sbidoul/pip6892-sbi
uninstall: remove symlinks created by flit install --symlink
2019-09-17 21:14:28 -04:00
Chris Hunt 5e785993b8 Normalize style. 2019-09-17 19:14:39 -04:00
Chris Hunt 0555261087 Move extra conversion to function. 2019-09-17 19:02:59 -04:00
Chris Hunt ec8bf2cc22 Clean up source location message creation. 2019-09-17 19:02:59 -04:00
Pradyun Gedam c3e6329039
Rename InstallRequirement.{build_location -> ensure_build_location} (#7021)
Merge pull request #7021 from pradyunsg/refactor/rename-build-location
2019-09-17 18:30:08 +05:30