Commit Graph

7994 Commits

Author SHA1 Message Date
Pradyun Gedam 108f9b6786
Cleanup InstallRequirement.egg_info_path (#7081) 2019-09-25 09:34:09 +05:30
Pradyun Gedam 9798d0fff2
Dedent hooks in .pre-commit-config.yaml 2019-09-25 09:30:23 +05:30
Chris Hunt 8c94b70354 Address review comments 2019-09-24 22:43:06 -04:00
Pradyun Gedam 618714b1bf
Factor out logic for locating egg-info directories
Why: A named function brings clarity to expressing what is happening.
2019-09-25 08:04:15 +05:30
Pradyun Gedam 72d5d140be
Define a function to use as sorting key
Why: It makes it clearer what the funky expression means.
2019-09-25 08:04:14 +05:30
Pradyun Gedam 14cbc5f8a4
Return early from the function
Why: Allows reducing indentation of the function body.
2019-09-25 08:03:57 +05:30
Pradyun Gedam 10beeea0b0
Allow passing hook-ids to `tox -e lint`
Why: To allow running a specific hook when running locally.
2019-09-25 07:57:59 +05:30
Wilson Mo 08a0eeb90c Fix #3907 tar file placed outside of target location 2019-09-24 22:25:18 -04:00
Chris Hunt 3e98ee8464 Use from ... import ... style 2019-09-24 21:36:16 -04:00
Christopher Hunt 9611394a5b
Merge pull request #7062 from chrahunt/refactor/network-modules
Move SafeFileCache to network.cache
2019-09-24 21:03:18 -04:00
Pradyun Gedam 38f75f90a5
Merge pull request #7077 from pradyunsg/nicer-getting-started
Nicer getting started
2019-09-24 23:32:31 +05:30
Pradyun Gedam 1d1e67269e
Add invocation of mypy -2, to pre-commit 2019-09-24 22:24:04 +05:30
Pradyun Gedam 45bc66ae1a
Add a space I missed. 2019-09-24 22:13:14 +05:30
Pradyun Gedam f646349e1b
Add pre-commit hook for check-manifest
Why: This brings back functionality removed in prior commits
2019-09-24 18:36:17 +05:30
Pradyun Gedam 033a01333c
Drop tox -e packaging from CIs 2019-09-24 18:35:53 +05:30
Pradyun Gedam 8296b1a17e
Do twine check in Azure Pipeline's Package job 2019-09-24 18:34:25 +05:30
Pradyun Gedam 9a362abd72
Exclude .pre-commit-config.yaml from distributions 2019-09-24 18:23:42 +05:30
Christopher Hunt 67867d32ae
Merge pull request #7036 from chrahunt/refactor-2
Move some URL-related functions to utils.urls.
2019-09-24 08:40:36 -04:00
Pradyun Gedam ff53e6d7d3
Drop dedicated CI job for NEWS fragment check
Why: This task is now handled as a part of pre-commit's checks.
2019-09-24 18:03:23 +05:30
Pradyun Gedam c47e1b6e5d
Enable rst-backticks for ReST files and NEWS fragments 2019-09-24 18:03:22 +05:30
Pradyun Gedam ea68afab93
Enable isort in pre-commit 2019-09-24 18:03:22 +05:30
Pradyun Gedam 7224a1155c
Enable trailing-whitespace 2019-09-24 18:03:22 +05:30
Pradyun Gedam 6f8c29aa77
Enable end-of-file-fixer 2019-09-24 18:03:22 +05:30
Pradyun Gedam 40a0f189b9
Enable check-builtin-literals 2019-09-24 18:03:22 +05:30
Pradyun Gedam 0a25c7d4a6
Document that pre-commit is used for linting 2019-09-24 18:03:22 +05:30
Pradyun Gedam 7b005c2d7d
Switch to using pre-commit in `tox lint` 2019-09-24 18:03:18 +05:30
Christopher Hunt 928f86a162
Merge pull request #7048 from chrahunt/refactor/always-create-tempdirectory
Always create TempDirectory.path at __init__
2019-09-24 08:27:44 -04:00
Pradyun Gedam 3b0f2c32dd
Make the role of tox, in test running, clearer 2019-09-24 17:07:10 +05:30
Pradyun Gedam 2bbbc0756a
Oops! I'd missed a word. 2019-09-24 17:07:10 +05:30
Pradyun Gedam 96fd796334
Some hand-holding to tell folks to install Python 2019-09-24 17:07:10 +05:30
Pradyun Gedam d0df9d375f
Drop references to lint-py2 and mypy in documentation 2019-09-24 17:03:39 +05:30
Pradyun Gedam 9eab9d1e95
Drop lint-py2 and mypy from GitHub Actions CI 2019-09-24 17:03:39 +05:30
Pradyun Gedam ea80263958
Drop lint-py2 and mypy from Travis CI 2019-09-24 17:03:38 +05:30
Pradyun Gedam dc5d2b91c8
Drop lint-py2 and mypy from tox environment
Why: They would become redundant in following commits, which move the
linting workloads over to pre-commit.
2019-09-24 17:03:31 +05:30
Pradyun Gedam 096cfb2de0
Add initial pre-commit configuration
Why: pip's linting requirements aren't special and there are benefits to
using pre-commit, including a simpler workflow and access to the
ecosystem of tooling around pre-commit.
2019-09-24 16:02:51 +05:30
Chris Jerdonek 0435316fde Move path_to_url() to utils/urls.py. 2019-09-24 02:01:52 -07:00
Chris Hunt e6bde63620 Assert TempDirectory.path has not been cleaned up on access 2019-09-23 20:09:04 -04:00
Chris Hunt 7ea1fcdb13 Remove outer class for temp_dir tests 2019-09-23 18:49:12 -04:00
Chris Hunt 236fb82a1f Move temp_dir tests to separate file 2019-09-23 18:47:28 -04:00
Chris Hunt 97ec73881e Switch TempDirectory.path to property 2019-09-23 18:41:31 -04:00
Christopher Hunt 828da22e02
Merge pull request #7067 from chrahunt/maint/update-removal-wording
Update auto-svn+ removal wording
2019-09-23 16:57:21 -04:00
Chris Jerdonek 99ec6a5e31
Merge pull request #7057 from cjerdonek/remove-iter-links
Remove HTMLPage.iter_links()
2019-09-23 05:55:54 -07:00
Chris Jerdonek ec892cec97 Reflect that headers are non-optional in _get_encoding_from_headers(). 2019-09-23 05:12:33 -07:00
Chris Jerdonek 6c9e0c2536 Remove HTMLPage.iter_links(). 2019-09-23 05:12:33 -07:00
Chris Jerdonek 4ad5a58376 Change HTMLPage.__init__ to accept an encoding. 2019-09-23 05:12:29 -07:00
Chris Jerdonek d30bc69073 Move make_fake_html_page() elsewhere in the module. 2019-09-23 05:08:27 -07:00
Chris Hunt ea91012bee Update auto-svn+ removal wording 2019-09-22 17:37:48 -04:00
Christopher Hunt f7d06671dc
Merge pull request #7066 from chrahunt/refactor/editable-requirement-parts
Factor editable requirement parsing into dedicated function
2019-09-22 14:14:09 -04:00
Chris Hunt ad82dd0981 Move RequirementParts above new function 2019-09-22 12:03:47 -04:00
Chris Hunt 8fe2eb068a Factor out editable parsing into a function 2019-09-22 12:02:14 -04:00