Stéphane Bidoul
fe5682627a
Quote 'setup.py install' when calling it legacy
...
We want to make it clear that it is the setup.py install command we consider
legacy, not setup.py itself.
2020-07-18 13:46:19 +02:00
Stéphane Bidoul
462d6ca590
Deprecate install fallback when bdist_wheel fails
2020-07-18 13:46:19 +02:00
d363b4a427
Replace tabs by spaces for consistency
2020-07-18 17:00:59 +07:00
Chris Hunt
d2eb0ef817
Merge pull request #8423 from McSinyx/logging-format
...
Nitpick logging calls
2020-07-17 20:10:43 -04:00
Pradyun Gedam
25802ad726
Merge pull request #8595 from pradyunsg/news-file-cleanup
...
Cleanup NEWS file
2020-07-17 13:07:35 +05:30
Pradyun Gedam
6fa4a9a0a7
Clean up code style changes
...
Toward minimizing style changes in the overall PR diff, or toward
consistency with the future use of black (in cases where I wasn't sure
of a good way to minimize the diff).
2020-07-17 14:33:19 +07:00
f8b06a3906
Enable flake8-logging-format
2020-07-17 14:33:19 +07:00
05bdc69aa3
Make test more explicit
2020-07-17 14:33:19 +07:00
cb8d81d135
Nitpick logging calls
2020-07-17 14:33:19 +07:00
Pradyun Gedam
2c8645276f
Merge pull request #8593 from pradyunsg/fix-link
...
Fix the link on new-resolver dependency conflicts
2020-07-17 07:32:25 +05:30
Pradyun Gedam
c8b98f2d3a
🎨 while I'm at it
2020-07-17 06:41:41 +05:30
Pradyun Gedam
97645f1022
Cleanup NEWS file
2020-07-17 06:40:05 +05:30
Pradyun Gedam
b419ca7317
Fix the link on new-resolver dependency conflicts
2020-07-17 06:03:01 +05:30
Pradyun Gedam
2a07a2444c
Merge pull request #8590 from pradyunsg/install-conflict-warning-move
...
Change when we warn about dependency conflicts during `pip install`
2020-07-17 05:35:53 +05:30
Pradyun Gedam
7ddbcc2e67
Return early for clarity
2020-07-17 03:25:53 +05:30
892018eaf2
Use local server for an unit test for lazy wheel
2020-07-16 21:09:59 +07:00
Pradyun Gedam
eafbec5aa6
Move conflict warning to just-before success message
...
This is a much better location for these errors, since they're in a much
more visible spot. We've had reports in the past of users missing these
messages, and changing where we present these warnings should help
resolve that issue.
We do lose the ability for an advanced user to potentially see the
warning and abort installation before the conflicts are introduced, but
given that we don't even pause for input, I don't think that's a strong
argument and neither do I view this as necessary.
2020-07-16 13:15:39 +05:30
Pradyun Gedam
de741fa0dd
Clearly note where code duplication exists
...
The duplication of this code isn't really that bad, but saying
"pip check" makes it ambigous which file is relevant. Changing to
reference the exact filename makes this clearer.
2020-07-16 13:14:35 +05:30
Pradyun Gedam
67cbd0ca18
Break up pip install's "conflict check" function
...
Making this into two functions allows for separating the "check"
and "print warnings" step in a follow up commit.
2020-07-16 13:14:29 +05:30
Chris Hunt
02a10920c0
Merge pull request #8587 from shireenrao/add-links
...
Add references to get started with Git
2020-07-15 19:54:16 -04:00
Chris Hunt
af89994eb3
Merge pull request #8574 from chrahunt/refactor/simpler-exception-handling
...
Simplify wheel install entrypoint exception handling
2020-07-15 16:53:25 -04:00
Chris Hunt
c40d7b2122
Merge pull request #8575 from chrahunt/tests/add-better-entrypoint-test
...
Make wheel entrypoint error test higher-level
2020-07-15 16:52:35 -04:00
Srinivas Nyayapati
d6ac9a07a2
fix hyper link in patch
2020-07-15 16:31:59 -04:00
Pradyun Gedam
e3e916be8d
Add a dedicated type for check_install_conflicts
2020-07-16 01:38:36 +05:30
Srinivas Nyayapati
c56f93539c
Add references to get started with Git
2020-07-15 15:39:49 -04:00
Pradyun Gedam
fa2fceecf1
Merge pull request #8189 from gutsytechster/remove_raise_for_status
2020-07-15 18:06:27 +05:30
Pradyun Gedam
61d497120f
Merge pull request #8424 from jku/8288-deprecate-nonconforming-extras
2020-07-15 18:03:00 +05:30
db217992bd
Use more descriptive exception when range requests are unsupported
2020-07-15 16:28:53 +07:00
Chris Hunt
9a10d82b29
Merge pull request #8561 from pypa/8512-feature-flag-docs
...
Add feature flag documentation
2020-07-14 19:41:41 -04:00
Chris Hunt
607ec6c342
Merge pull request #7416 from chrahunt/maint/add-coverage
...
Add basic test coverage configuration
2020-07-14 19:22:56 -04:00
Chris Hunt
328e4c06da
Merge pull request #8502 from uranusjr/new-resolver-binary-compat-on-target
...
Ensure binary compat is checked in --target
2020-07-13 20:38:13 -04:00
Chris Hunt
77ead320b0
Merge pull request #8571 from McSinyx/conf-nit
...
Clean up Configuration.unset_value and nit __init__
2020-07-13 17:52:37 -04:00
Jussi Kukkonen
76b20d738e
Deprecate requirements format "base>=1.0[extra]"
...
This requirements format does not conform to PEP-508. Currently the
extras specified like this work by accident (because _strip_extras()
also parses them). The version checks end up being done with a
misparsed version '1.0[extra]' -- this is not changed in this commit.
Add deprecation warning and fix the corresponding resolver test. Add a
command line test.
Note that we really only check that the Requirement has SpecifierSet
with a specifier that ends in a ']'. A valid version number cannot
contain ']' and no wheels currently on pypi have versions ending in ']'.
2020-07-13 12:33:50 +03:00
Chris Hunt
05f2d9ebf6
Make entrypoint error test higher-level
...
The current tests didn't catch the bug that the new tests do,
so they have been removed. Using higher-level tests can give us more
confidence that things work end-to-end and are less likely to get in
the way of refactoring.
The new test has been marked xfail since the bug is still present.
2020-07-11 15:45:18 -04:00
Chris Hunt
677b4e7f11
Remove redundant try ... except
2020-07-11 15:34:06 -04:00
Chris Hunt
145b7add7e
Move error message construction into MissingCallableSuffix
...
Now, we are free to throw MissingCallableSuffix from anywhere and don't
have to worry about catching it in the middle of our processing.
2020-07-11 15:34:06 -04:00
Chris Hunt
f48c44e203
Add req description to error in install_wheel
...
Moving this value up from `_install_wheel` means that we do not need to
pass `req_description` anymore. This will also let us move our
entrypoint error handling around without worrying about losing the
context from the previous message.
2020-07-11 15:34:06 -04:00
c5e19c01c4
Clean up Configuration.unset_value and nit __init__
2020-07-11 15:56:34 +07:00
Chris Hunt
8bf5731b84
Merge pull request #8562 from chrahunt/extract-direct-from-zip-refactoring
...
Install directly from wheels, without unpacking into an intermediate directory
2020-07-10 21:33:16 -04:00
Chris Hunt
83078470a6
Merge pull request #8566 from deveshks/mypy-configuration
...
Add type annotations to pip._internal.configuration
2020-07-10 20:09:30 -04:00
Pradyun Gedam
eebab795d5
Merge pull request #8570 from avinashkarhana/master
...
Fixed useless `else` clause after loop inside `get_version` function
2020-07-11 04:46:25 +05:30
Avinash Karhana
135e9c1369
Fixed useless else
cluase after loop inside get_version
function in setup.py
2020-07-11 02:15:29 +05:30
Devesh Kumar Singh
4cc731c62b
Add type annotations to pip._internal.configuration
2020-07-11 01:38:19 +05:30
Chris Hunt
15b7afbcad
Merge pull request #8266 from gutsytechster/add_logs_for_install
...
feat(): Add logs for pip environment when installing
2020-07-10 09:36:13 -04:00
Prashant Sharma
f7abe1f874
test(functional/test_install): Use shared_data for installing package
2020-07-10 16:20:30 +05:30
Chris Hunt
46bd55f371
Merge pull request #8565 from deveshks/mypy-cache
...
Add type annotations to "pip._internal.cache"
2020-07-09 21:53:06 -04:00
Chris Hunt
e9508591ce
Merge pull request #8556 from chrahunt/maint/fail-on-install-location-options
...
Disallow explicitly passing install-location-related arguments in --install-options
2020-07-09 21:25:20 -04:00
Chris Hunt
d13ec25361
Prevent path traversal when installing wheels directly
2020-07-09 21:21:35 -04:00
Chris Hunt
80a2a94955
Add news
2020-07-09 18:25:11 -04:00
Chris Hunt
4605b32c49
Don't unpack wheel before installing
2020-07-09 18:25:11 -04:00