Christopher Hunt
59289f58f8
Merge pull request #7371 from chrahunt/removal/deprecate-location-options
...
Deprecate location-related options in --install-option
2019-12-01 07:30:59 +08:00
Chris Hunt
b8f626ace6
Deprecate install-location-related options in --install-option
2019-11-30 17:42:48 -05:00
Chris Hunt
55a943e556
Add distutils args helpers
...
The utils.distutils_args.parse_args function can recognize distutils
arguments so we can deprecate their usage.
2019-11-30 17:39:56 -05:00
Christopher Hunt
e13c1f1e8f
Minimize scope of try block ( #7415 )
...
This more clearly separates the flow control in the function, which will
make refactoring easier.
2019-12-01 05:39:57 +08:00
Chris Hunt
aaabdfc2f7
Switch to early-return in _prepare_download
...
Makes this function simpler by removing a local variable and reduces
overall lines of code.
2019-11-29 10:26:37 -05:00
Chris Hunt
d279807a0e
Extract chunks into separate variable
2019-11-29 10:24:56 -05:00
Chris Hunt
46adcc89a6
Remove outdated comment in operations.prepare
...
There are several reasons why we don't trace progress as indicated a few
lines above.
2019-11-29 10:21:24 -05:00
BorisZZZ
4659fe16bd
#6426 Cannot install packages on Docker in Ubuntu in WSL (Windows). ( #6427 )
2019-11-28 12:05:17 +08:00
Pradyun Gedam
2c9ee4ad04
Merge pull request #7405 from chrahunt/maint/refactor-install-req-dirs
...
Remove dead code related to InstallRequirement build directories
2019-11-28 01:43:43 +05:30
Christopher Hunt
68c847f70d
Merge pull request #7221 from hugovk/add-3.8-travis-ci
...
Travis CI: Test Python 3.8
2019-11-27 11:25:10 +08:00
Chris Hunt
8ab7d239fa
Use pip 19.3.1+ for vendoring task
2019-11-26 21:36:40 -05:00
Chris Hunt
dbd80ec2c0
Remove unused code related to moving build directory
2019-11-26 18:47:12 -05:00
Chris Hunt
99c7598eb9
Remove dead code from move_to_correct_build_directory
2019-11-26 18:41:25 -05:00
Chris Hunt
9886e8dea1
Assert that we aren't using most of "move_to_correct_build_directory"
...
Since self._ideal_build_dir is only either None or a string, we must
have always been returning from this function.
This goes back to pip 10.0.0, so this code has been dead for some time.
2019-11-26 18:39:19 -05:00
Hugo van Kemenade
229981192d
Merge branch 'master' into add-3.8-travis-ci
2019-11-26 08:13:47 +02:00
Christopher Hunt
5ba702894a
Remove old workaround for Debian Python patch ( #7401 )
2019-11-26 11:58:46 +08:00
Xavier Fernandez
db1a2754bb
Fix logging of cached response
...
Cached responses often (always ?) provide a length meaning they were
never logged as such.
2019-11-25 23:15:00 +01:00
Paul Moore
4f6a965f14
Merge pull request #7394 from takluyver/i6599
...
Fix building packages with backend-path in pyproject.toml
2019-11-25 21:40:33 +00:00
Xavier Fernandez
95576102c5
Tweak format_size utility function to include a space ( #7399 )
2019-11-25 22:09:10 +01:00
Albert Tugushev
83a9a12f96
Cache pre-commit in GitHib Actions ( #7400 )
...
See https://pre-commit.com/#github-actions-example
2019-11-25 22:02:53 +01:00
Xavier Fernandez
8114003e62
Add basic tests for format_size
2019-11-25 14:53:23 +01:00
Christopher Hunt
b3aced9617
Merge pull request #7395 from chrahunt/tests/fix-setuptools-unexpected-warning
...
Ignore WARNING emitted by setuptools during test
2019-11-24 07:36:46 +08:00
Chris Hunt
8d38b37052
Ignore WARNING emitted by setuptools during test
2019-11-23 16:17:35 -05:00
Thomas Kluyver
59550aaec3
Add an integration test of installing a project with a local PEP 517 backend
2019-11-23 18:45:09 +00:00
Thomas Kluyver
400cf8d71e
Add a test combining local PEP 517 backend with external dependency
2019-11-23 16:57:24 +00:00
Thomas Kluyver
edc525add9
Remove leftover debugging code
2019-11-23 16:53:01 +00:00
Thomas Kluyver
81f6ba3fc1
Default None instead of []
2019-11-23 16:52:24 +00:00
Thomas Kluyver
da0ff0db76
Capital S in BuildSystemDetails
2019-11-23 16:46:40 +00:00
Thomas Kluyver
6f55872bf3
Convert tuple return type to a named tuple
2019-11-23 15:29:30 +00:00
Thomas Kluyver
dd7b1ee5c3
Fix building packages with backend-path in pyproject.toml
...
Closes gh-6599
2019-11-23 14:38:27 +00:00
Christopher Hunt
3ff2513537
Merge pull request #7384 from chrahunt/refactor/cleanup-prepare-3
...
Cleanup operations.prepare more
2019-11-22 20:52:33 +08:00
Christopher Hunt
81f05720b2
Merge pull request #7374 from chrahunt/maint/use-server-fixture-not-internet
...
Use server fixture for network test
2019-11-22 08:32:47 +08:00
Chris Hunt
59f22068d4
Move Downloader construction to RequirementPreparer.__init__
...
Just one step away from pulling this out of operations.prepare
altogether.
2019-11-21 19:11:46 -05:00
Chris Hunt
3c8be92c32
Move Downloader out of unpack_url
...
This simplifies the work done in the operations.prepare helper functions
and also opens up the door to remove session and progress_bar from
RequirementPreparer itself.
2019-11-21 19:11:46 -05:00
Chris Hunt
19806574e5
Move Downloader out of unpack_http_url
...
Reduces scope of session and progress_bar.
2019-11-21 19:11:46 -05:00
Chris Hunt
4be0a5445a
Move Downloader up out of _download_http_url
...
Reduces exposure of session and progress_bar.
2019-11-21 19:11:46 -05:00
Chris Hunt
3ce317890e
Introduce Downloader for progress-showing downloads
2019-11-21 19:05:42 -05:00
Chris Hunt
e4d2d34fe1
Represent download as its own type
...
This abstraction will let us hide details about the actual downloading
and display of progress from most of operations.prepare.
2019-11-21 19:04:28 -05:00
Pradyun Gedam
a25bdab31a
Improve a NEWS fragment ( #7389 )
2019-11-21 12:01:47 +05:30
Pradyun Gedam
46c20698c6
Improve a NEWS fragment
2019-11-21 11:04:32 +05:30
Keith Maxwell
b7a4b022d6
Better document the requirements file format ( #7386 )
...
Change the documentation for the requirements file format so that it
matches the implementation [0]. Also change the order of the options in
the implementation so that the documentation reads better.
Before this change the documentation included an incomplete list of
supported options.
This change adds the missing options and changes the order to match, so
that the two locations are easier to keep in sync. After this change the
list in the documentation matches SUPPORTED_OPTIONS in
src/pip/_internal/req/req_file.py
[0]: https://github.com/pypa/pip/blob/master/src/pip/_internal/req/req_file.py#L60
2019-11-20 12:45:21 +08:00
Chris Hunt
e706af20fe
Simplify writing file chunks
...
A plain loop is easier to follow than chained generators consumed by
a helper function, and reduces the number of objects being passed around
just to download a file.
2019-11-19 17:06:18 -05:00
Chris Hunt
dca556fdaa
Check hashes after download is complete
...
Instead of computing hashes on-the-fly we do it after fully downloading
the file. This step will let us move hash checking to a higher-level
function without introducing a lot of complexity.
2019-11-19 17:06:18 -05:00
Christopher Hunt
9ae2e6440d
Merge pull request #7365 from chrahunt/refactor/cleanup-prepare-2
...
Cleanup operations.prepare download functions
2019-11-20 06:05:25 +08:00
Christopher Hunt
1b4c0866ab
Remove untyped defs ( #7382 )
2019-11-19 11:46:26 +08:00
Christopher Hunt
e5a350951f
Merge pull request #7370 from chrahunt/refactor/cleanup-get-supported-2
...
Factor platform getter functions out of get_supported
2019-11-19 09:18:34 +08:00
Chris Hunt
2af6112751
Cleanup pep425tags version handling
2019-11-18 19:31:46 -05:00
Chris Hunt
49549fcd69
Move manylinux arch backfilling into separate function
2019-11-18 19:29:30 -05:00
Chris Hunt
83babc7629
Move mac arch calculation to separate function
2019-11-18 19:29:30 -05:00
Christopher Hunt
b802331fd2
Simplify abi3 usage in pep425tags ( #7367 )
...
abi3 refers to the CPython stable ABI, so we should only ensure it
applies in that particular case.
This simplifies the logic in get_platforms() and makes us more
compatible with the behavior of packaging.tags, which only includes abi3
for cpython_tags() and only the literal "abi3".
2019-11-19 08:24:04 +08:00
