Commit Graph

9203 Commits

Author SHA1 Message Date
Pradyun Gedam 9e884a46f6
Merge pull request #7755 from pradyunsg/docs/conventions
Add initial draft for documentation conventions
2020-02-26 03:40:27 -08:00
Pradyun Gedam c04798f5fd
Merge pull request #7786 from xavfernandez/appdirs_patch
vendoring: move /etc appdir patch to pip wrapper
2020-02-26 02:57:47 -08:00
Pradyun Gedam 0d7f5d1372
Merge pull request #7773 from chrahunt/refactor/move-legacy-resolver
Move legacy_resolve to resolution.legacy.resolver
2020-02-26 02:55:31 -08:00
Xavier Fernandez db377cec28 vendoring: move /etc appdir patch to pip wrapper 2020-02-25 23:52:18 +01:00
Chris Hunt 8362c20da5 Rename legacy resolver unit tests
It's a little long, but better to be consistent with our other test file
naming conventions until we come up with better ones.
2020-02-25 09:04:07 -05:00
Chris Hunt fd74d0362c Move legacy_resolve to resolution.legacy.resolver
This gives us a concrete place to put the new resolver code and
resolver-specific modules (`resolution.resolver`).

The reason for another level of hierarchy compared to other modules
is to allow us to move other modules here as they
become implementation details of the legacy resolver. Examples I
have in mind are: `req.req_set`, `req.req_install`,
`req.constructors`, and `operations.prepare`.
2020-02-25 09:04:06 -05:00
Christopher Hunt 35181cdf01
Merge pull request #7775 from chrahunt/refactor/better-handle-build-dir
Globally manage temp build dir in requirement commands
2020-02-25 12:22:01 +08:00
Pradyun Gedam 80b952b6e2
Apply suggestions from code review
Co-Authored-By: Christopher Hunt <chrahunt@gmail.com>
2020-02-25 04:06:25 +05:30
Chris Hunt 60a2fa4dce Inline unconditionally-executed blocks 2020-02-23 18:05:09 -05:00
Chris Hunt 45911713db Globally manage temp build dir
This will let us remove the indentation associated with the `with`
statement and eventually refactor these functions more easily.
2020-02-23 18:04:46 -05:00
Christopher Hunt ea47be571e
Merge pull request #7772 from chrahunt/refactor/command-level-scoped-tracker
Use Command context helper to cleanup requirement tracker
2020-02-24 06:51:06 +08:00
Christopher Hunt 94c83c0766
Merge pull request #7771 from chrahunt/refactor/remove-extra-no-clean
Do not update `no_clean` option value in install/wheel
2020-02-24 06:50:54 +08:00
Christopher Hunt 5fffbb6c82
Merge pull request #7774 from chrahunt/refactor/move-networking-unit-tests
Move network unit tests to align with subpackage names
2020-02-24 06:49:22 +08:00
Anudit Nagar e6ed38dbce
Add info log when wheel building is skipped (#7768) 2020-02-23 22:56:36 +01:00
Chris Hunt 40bc4ea8fe Move network unit tests to align with subpackage names 2020-02-23 16:22:30 -05:00
Chris Hunt eb91e8ca39 Use Command context helper to cleanup requirement tracker
The lifetime of the requirement tracker will be essentially the same,
but now we have more flexibility on where in the code we create it.

In a followup we can do the same thing with build_dir and remove the
`with` statement (and its indentation) entirely from these commands.
2020-02-23 14:37:01 -05:00
Chris Hunt 83b0295be9 Dedent block 2020-02-23 14:29:01 -05:00
Chris Hunt ccc6d77a73 Do not update `no_clean` option value on PreviousBuildDirError
Since a recent refactoring of our temporary directory handling,
`no_clean` is only read prior to these `except` blocks. Since it's not
needed, remove it!
2020-02-23 14:28:59 -05:00
Christopher Hunt 40523794d8
Merge pull request #7747 from pfmoore/parsed_requirement
Refactor parse_requirements to be independent of InstallRequirement
2020-02-24 00:21:28 +08:00
Christopher Hunt 2b6fb95ba4
Reorder imports 2020-02-23 23:44:13 +08:00
Anudit Nagar 082c0f01d2
Update old-style formatting to new-style formatting (#7762) 2020-02-21 21:48:14 +05:30
Nitesh Sharma ce1e0f470a
Move UI helpers to cli subpackage (#6727) 2020-02-21 14:01:13 +05:30
Pradyun Gedam 82b4566a7f
Merge pull request #7611 from webknjaz/testing/gh-actions-ci-cd-linters
Adjust GitHub Actions CI/CD linters
2020-02-19 20:03:46 +05:30
Pradyun Gedam cc7494033a
Merge pull request #7754 from pradyunsg/docs/consistent-formatting
Consistent formatting across pip's documentation
2020-02-19 17:23:12 +05:30
Pradyun Gedam c93c5e84bf
Add initial draft for documentation conventions 2020-02-18 11:01:27 +05:30
Pradyun Gedam 0f513ddbea
Synchronize upgrade-options.rst 2020-02-18 10:56:55 +05:30
Pradyun Gedam e648e00dc0
pip is spelt all-lowercase 2020-02-18 10:55:16 +05:30
Pradyun Gedam 59c47ab88c
Link to our architecture documentation 2020-02-18 10:55:16 +05:30
Pradyun Gedam 2d87d5f689
Enforce blank lines before directive-blocks 2020-02-18 10:55:16 +05:30
Pradyun Gedam 4089cdd0de
Enforce 1 blank line before h3 2020-02-18 10:55:16 +05:30
Pradyun Gedam 404f89305e
Enforce 2 blank lines before h2 2020-02-18 10:55:15 +05:30
Pradyun Gedam 49b978dd8a
Make heading style consistent 2020-02-18 10:55:15 +05:30
Pradyun Gedam 9944ad114f
Make page-title heading style consistent 2020-02-18 10:55:11 +05:30
Pradyun Gedam 06fd2a0409
Merge pull request #7752 from pfmoore/upgrade_docs
Add documentation to internals on upgrade options
2020-02-18 10:46:13 +05:30
Paul Moore 5da3a7d3cf Add documentation to internals on upgrade options 2020-02-17 14:02:44 +00:00
Paul Moore f085bb0e0e Merge branch 'master' into parsed_requirement 2020-02-14 20:34:44 +00:00
Paul Moore cfbfff0b4c
Merge pull request #7750 from asottile/patch-1
Bump cache key after it was poisoned by virtualenv 20.x
2020-02-14 20:30:02 +00:00
Anthony Sottile 0df2a3d51d
Bump cache key after it was poisoned by virtualenv 20.x
The symlinks issue has been fixed as of virtualenv 20.0.2, however caches built by virtualenv 20.0.0 and 20.0.1 will continue showing this error

Resolves #7749
2020-02-14 09:44:49 -08:00
Paul Moore 29a06ef947 Add a trivial news marker 2020-02-14 12:25:01 +00:00
Paul Moore aac5d821f9 Move make_requirement to pip._internal.req.constructors (and rename it) 2020-02-14 12:22:50 +00:00
Paul Moore 90e4eb3eed Make parse_requirements return a ParsedRequirement 2020-02-14 11:52:53 +00:00
Pradyun Gedam cdae7277ef
Merge pull request #7596 from uranusjr/6446-link-url-quoting
Fix incorrect quoting Link.url
2020-02-14 16:00:43 +05:30
Paul Moore e2a57fd1e6 Refactor to reduce coupling.
* Make ParsedLine record the type of line
* Split handle_line to allow passing arguments only where needed
* Remove unneeded attributes from ParsedRequirement
2020-02-14 09:56:42 +00:00
Paul Moore f2e49b3946 Use a new ParsedRequirement class to communicate between handle_line and parse_requirements 2020-02-13 10:39:17 +00:00
Pradyun Gedam 025e99ec61
Merge pull request #7719 from uranusjr/virtualenv-20-detection
Swap venv and virtualenv checks
2020-02-12 12:16:43 +05:30
Paul Moore 732b4a0010
Merge pull request #7700 from pfmoore/refactor_legacy_install
Refactor legacy_install to not take an install_req
2020-02-11 17:45:51 +00:00
Paul Moore 73d472bb87 Merge branch 'master' into refactor_legacy_install 2020-02-11 16:53:01 +00:00
Pradyun Gedam 540d3aa0ec
Fix nox -s docs 2020-02-11 19:10:27 +05:30
Tzu-ping Chung 6104060580 Swap venv and virtualenv checks
Environments created by pypa/virtualenv >=20 can pass both real_prefix
and base_prefix checks, but are only able to use the pyvenv.cfg values,
not the legacy `no-global-site-packages.txt`. So we need to check for
venv (PEP 405) first.
2020-02-11 17:56:40 +08:00
Pradyun Gedam 723b84517d
Merge pull request #7717 from pradyunsg/virtualenv-bodgefix-ci
Workaround breaking changes in virtualenv for CI
2020-02-11 14:16:37 +05:30