Pradyun Gedam
1b2ae22e7b
Don't print that form link after the end of month.
2020-07-27 19:51:40 +05:30
Pradyun Gedam
4e4951066d
Reverse if statement's condition
2020-07-27 13:52:54 +05:30
Pradyun Gedam
8db354260a
Move the form link to make the linter happy
2020-07-27 13:49:21 +05:30
Pradyun Gedam
efdb66ed16
Add messaging variation based on "new resolver" usage
2020-07-27 13:49:21 +05:30
Pradyun Gedam
42c62a08f7
Short circuit when there's nothing to report
2020-07-27 13:49:20 +05:30
Pradyun Gedam
d77b5c234c
Refactor the logging calls into a dedicated loop
2020-07-27 13:49:11 +05:30
Stéphane Bidoul
d924b16b0d
Give mypy some love after rebase
2020-07-18 13:46:19 +02:00
Stéphane Bidoul
fe5682627a
Quote 'setup.py install' when calling it legacy
...
We want to make it clear that it is the setup.py install command we consider
legacy, not setup.py itself.
2020-07-18 13:46:19 +02:00
Stéphane Bidoul
462d6ca590
Deprecate install fallback when bdist_wheel fails
2020-07-18 13:46:19 +02:00
Pradyun Gedam
6fa4a9a0a7
Clean up code style changes
...
Toward minimizing style changes in the overall PR diff, or toward
consistency with the future use of black (in cases where I wasn't sure
of a good way to minimize the diff).
2020-07-17 14:33:19 +07:00
Nguyễn Gia Phong
f8b06a3906
Enable flake8-logging-format
2020-07-17 14:33:19 +07:00
Nguyễn Gia Phong
cb8d81d135
Nitpick logging calls
2020-07-17 14:33:19 +07:00
Pradyun Gedam
7ddbcc2e67
Return early for clarity
2020-07-17 03:25:53 +05:30
Pradyun Gedam
eafbec5aa6
Move conflict warning to just-before success message
...
This is a much better location for these errors, since they're in a much
more visible spot. We've had reports in the past of users missing these
messages, and changing where we present these warnings should help
resolve that issue.
We do lose the ability for an advanced user to potentially see the
warning and abort installation before the conflicts are introduced, but
given that we don't even pause for input, I don't think that's a strong
argument and neither do I view this as necessary.
2020-07-16 13:15:39 +05:30
Pradyun Gedam
de741fa0dd
Clearly note where code duplication exists
...
The duplication of this code isn't really that bad, but saying
"pip check" makes it ambigous which file is relevant. Changing to
reference the exact filename makes this clearer.
2020-07-16 13:14:35 +05:30
Pradyun Gedam
67cbd0ca18
Break up pip install's "conflict check" function
...
Making this into two functions allows for separating the "check"
and "print warnings" step in a follow up commit.
2020-07-16 13:14:29 +05:30
Chris Hunt
15b7afbcad
Merge pull request #8266 from gutsytechster/add_logs_for_install
...
feat(): Add logs for pip environment when installing
2020-07-10 09:36:13 -04:00
gutsytechster
0ccbad8367
feat(): Add logs for pip environment when installing
2020-07-09 18:15:43 +05:30
Chris Hunt
f878fcdeec
Rename function that reject location install options
...
Since it no longer shows a deprecation warning, the previous name
doesn't fit.
2020-07-07 19:11:11 -04:00
Chris Hunt
89572a7d40
Throw CommandError on any location-related install options
2020-07-07 19:11:11 -04:00
Devesh Kumar Singh
fb05730898
Align write_output types with logger.info
2020-07-07 15:23:05 +05:30
Devesh Kumar Singh
87249b9850
Assert target_temp_dir instead of if check
2020-07-07 15:06:27 +05:30
Devesh Kumar Singh
21ca1620d1
Change target_temp_dir type to TempDirectory
2020-07-07 14:57:42 +05:30
Devesh Kumar Singh
61f344b040
Add type annotations for pip._internal.commands.install
2020-07-07 14:57:42 +05:30
Devesh Kumar Singh
e0d625ba93
Add type annotations for pip._internal.commands.configuration
2020-07-07 14:57:42 +05:30
Devesh Kumar Singh
ac624f1e4f
Reword news entry
2020-07-06 13:42:09 +05:30
Devesh Kumar Singh
04fedfe53c
Create custom get_distribution function
2020-07-06 13:42:05 +05:30
Christopher Hunt
4ba51d2e9c
Merge pull request #8501 from uranusjr/refactor-create-link-collector
...
Tidy up link collector constructor imports
2020-07-05 21:44:31 -04:00
Pradyun Gedam
0acdbf8943
Merge pull request #8504 from McSinyx/list-speed-up-nw
...
Parallelize pip list --outdated and --uptodate
2020-07-04 03:31:26 +05:30
Nguyễn Gia Phong
dd3a3b5eb7
Parallelize network operations in pip list
2020-06-29 15:48:41 +07:00
Devesh Kumar Singh
6e62481568
Add unit tests for pip config debug
2020-06-28 16:22:01 +05:30
Devesh Kumar Singh
f0f692e8e9
Add env and env var values
2020-06-28 16:22:00 +05:30
Devesh Kumar Singh
2fcad8ffa7
Rename subcommand from list-files to debug
2020-06-28 16:22:00 +05:30
Devesh Kumar Singh
b9d19a64d7
List values per configuration file
2020-06-28 16:22:00 +05:30
Devesh Kumar Singh
7a8f374c39
Add option to list config files with pip config
2020-06-28 16:22:00 +05:30
Tzu-ping Chung
ec7324fba0
Tidy up link collector constructor imports
...
make_link_collector() was in self_outdated_check, a module responsible
for checking whether the currently-running pip is outdated, but is
imported by things that has nothing to do with this outdated check. Move
the function to be a class method in LinkCollector so the module
hierarchy makes more sense.
2020-06-26 17:31:28 +08:00
Paul Moore
f162236360
Fix deletion of temp dir when exception occurs
2020-06-25 13:00:11 +01:00
Devesh Kumar Singh
76257e4b65
Use module.__file__
2020-06-10 00:36:03 +05:30
Devesh Kumar Singh
d3f012cb3b
Fix argument type for ca_bundle_info
2020-06-10 00:36:03 +05:30
Devesh Kumar Singh
76a130105c
Fix src/pip with flake8-bugbear
2020-06-10 00:36:03 +05:30
Stéphane Bidoul
7ed5e12ae8
Merge pull request #8336 from deveshks/remove-isinstance-fixme
...
Remove isinstance FIXME from pip._internal.commands
2020-05-30 10:34:56 +02:00
Pradyun Gedam
c348c4215b
Merge pull request #8287 from sbidoul/ref-install_given_reqs-sbi
2020-05-30 13:24:28 +05:30
Devesh Kumar Singh
b01eb958d0
Fix run type annotation in base_command and configuration
2020-05-30 10:57:40 +05:30
Pradyun Gedam
f9b1a54009
Apply suggestion from review comments
2020-05-23 19:32:27 +05:30
Devesh Kumar Singh
99660b8d86
Fix pip cache docstring to render correctly in docs
2020-05-23 19:27:32 +05:30
Pradyun Gedam
75b2800dec
Merge pull request #8073 from deveshks/pip-config-docstring-fix
2020-05-23 17:11:46 +05:30
gutsytechster
b82516c9ca
fix(_internal/commands): Define a default add_option to child commands
2020-05-23 14:55:37 +05:30
gutsytechster
72a42197a4
refactor(commands): Add method add_options and remove __init__
...
This removes the __init__ method of child classes and defines
explicit method for adding command options.
2020-05-23 14:50:57 +05:30
Devesh Kumar Singh
e8b842389c
Always return SUCCESS from download.run
2020-05-22 19:44:29 +05:30
Devesh Kumar Singh
5e33373a07
Remove req.name check
2020-05-22 00:42:37 +05:30