pip/tests
Stéphane Bidoul (ACSONE) 0e1e0ef566 _should_cache does not depend on check_binary_allowed
_should_cache is only called by _get_cache_dir.

In pip install mode, _get_cache_dir is never called when
check_binary_allowed returns False because in that case
should_build_for_install_command has returned False before
and the build was skipped.

In pip wheel mode, check_binary_allowed always returns True
(because it is not passed to the build function).

So _should_cache can use _always_true for check_binary_allowed.

*Alternative*

Alternatively, we could have passed check_binary_allowed
to build in pip wheel mode. The only difference is that wheels built
locally from *legacy* packages would then not be cached,
when pip wheel is used with --no-binary.
2020-01-20 10:41:48 +01:00
..
data Do not attempt setup.py clean for failed pep517 builds (#7477) 2020-01-02 12:11:32 +00:00
functional Touch command may not be available on Windows (#7601) 2020-01-15 16:08:17 +00:00
lib Add comments to unicode workarounds 2020-01-09 13:11:30 +05:30
scripts Switch pip to use Warehouse by default 2018-04-16 15:54:11 -04:00
unit _should_cache does not depend on check_binary_allowed 2020-01-20 10:41:48 +01:00
yaml Misc. trivial typos 2018-03-27 06:51:44 -04:00
__init__.py Port to Python3 2011-03-15 15:49:48 -04:00
conftest.py Add comments to unicode workarounds 2020-01-09 13:11:30 +05:30