The context is implicitly copied by or operator when it is evaluated to false,
but we should ensure it's always copied as it's updated with action values
issue6336
review34771002
The fingerprint is no more used for certificate verification but only to
prevent fallback to plain http connection.
The system CA is used by default if no ca_certs is configured.
issue6270
review27991002
Keeping the autocomplete always up to date is very expensive especially for
large list because the method is called once per field for each record.
Indeed autocomplete is only needed when the Char widget is displayed. So we
could just load it at display and keep it up to date when fields are changed.
issue6167
review34611002
In GTK3, it is the proper way to compute coordinates instead of using
get_origin. This allows to fix the different behaviour for popup position of
datetime widget.
issue6162
review29911002
This customization breaks the default rendering of many widgets so it is better
to disable it until a better solution is found.
issue6145
review29111002
As database management was removed in changeset 9da26612368c, we can use an
empty list when access is denied and thus show back again the entry.
issue6151
review27001002
The value of a time widget can be a datetime instance.
The changeset acffa8c5cf89 changed the strftime by datetime_strftime but it can
not format time instance so the value must be converted into time and use
strftime.
issue5930
review33711002
The select function signature is different between GTK2 and GTK3 but as we do
not use the arguments, they can be ignored in a argument list.
issue6141
review31841002
It is not needed and it break the event type received by do_button_press_event
which receives an Event instead of an EventButton.
issue6144
review32921004
The implementation of placeholder for GTK+-2 must manage the case when the
placeholder is set multiple times. So when setting placeholder, if it does not
have the focus and it contains the default placeholder, the text should be
removed to have _focus_out set the new placeholder.
issue6137
review25921003
This makes the test in the code in accordance with the comment.
Also it prevent a comparison between integer and None which is no more allowed
in Python3.
issue6106
review29811002
The context parameter could be None and so generating an AttributeError. Then
it is better to use self.context which is guarantee to be always a dictionary.
issue6082
review34531002
Instead of setting date_format in every context (which will be included in
url), it is better to store the default value on the Screen. Also it should be
stored privately on the Screen to avoid modification which could result into an
inconsistency on the display.
issue6082
review25841002