Use declarative index definition for ModelSQL

issue5757

product.py

@@ -51,7 +51,7 @@ class Template(metaclass=PoolMeta):
             ('clarified-wine', 'Clarified Wine'),
             ('wine', "Wine"),
             ('bottled-wine', "Bottled Wine"),
-            ], "Agronomic Type", select=True)
+            ], "Agronomic Type")
     container = fields.Many2One('agronomics.container', 'Container',
         states={
             'invisible': Eval('agronomic_type') != 'bottled-wine',
@@ -174,27 +174,27 @@ class ProductCrop(ModelSQL):
     "Product - Crop"
     __name__ = 'product.product-agronomics.crop'
     product = fields.Many2One('product.product', 'Product',
-        ondelete='CASCADE', select=True, required=True)
+        ondelete='CASCADE', required=True)
     crop = fields.Many2One('agronomics.crop', 'Crop',
-        ondelete='CASCADE', select=True, required=True)
+        ondelete='CASCADE', required=True)
 
 
 class ProductDO(ModelSQL):
     "Product - DO"
     __name__ = 'product.product-agronomics.denomination_of_origin'
     product = fields.Many2One('product.product', 'Product',
-        ondelete='CASCADE', select=True, required=True)
+        ondelete='CASCADE', required=True)
     do = fields.Many2One('agronomics.denomination_of_origin', 'DO',
-        ondelete='CASCADE', select=True, required=True)
+        ondelete='CASCADE', required=True)
 
 
 class ProductEcological(ModelSQL):
     "Product - Ecological"
     __name__ = 'product.product-agronomics.ecological'
     product = fields.Many2One('product.product', 'Product',
-        ondelete='CASCADE', select=True, required=True)
+        ondelete='CASCADE', required=True)
     ecological = fields.Many2One('agronomics.ecological', 'Ecological',
-        ondelete='CASCADE', select=True, required=True)
+        ondelete='CASCADE', required=True)
 
 
 class ProductPriceListType(ModelSQL, ModelView):

production.py

@@ -102,18 +102,18 @@ class ProductionTemplateInputsProductTemplate(ModelSQL):
     'Production Template Inputs- Product Template'
     __name__ = 'production.template.inputs-product.template'
     production_template = fields.Many2One('production.template',
-        'Production Template', ondelete='CASCADE', required=True, select=True)
+        'Production Template', ondelete='CASCADE', required=True)
     template = fields.Many2One('product.template', 'Template',
-        ondelete='CASCADE', required=True, select=True)
+        ondelete='CASCADE', required=True)
 
 
 class ProductionTemplateOutputsProductTemplate(ModelSQL):
     'Production Template Inputs- Product Template'
     __name__ = 'production.template.outputs-product.template'
     production_template = fields.Many2One('production.template',
-        'Production Template', ondelete='CASCADE', required=True, select=True)
+        'Production Template', ondelete='CASCADE', required=True)
     template = fields.Many2One('product.template', 'Product',
-        ondelete='CASCADE', required=True, select=True)
+        ondelete='CASCADE', required=True)
 
 
 class ProductionTemplateLine(ModelSQL, ModelView):
@@ -683,8 +683,7 @@ class OutputDistribution(ModelSQL, ModelView):
 class ProductionEnologyProduct(ModelSQL, ModelView):
     'Production Enology Product'
     __name__ = 'production.enology.product'
-    production = fields.Many2One('production', 'Production',
-        select=True)
+    production = fields.Many2One('production', 'Production')
     product = fields.Many2One('product.product', 'Product', required=True)
     uom = fields.Many2One('product.uom', 'Uom')
     unit_digits = fields.Function(fields.Integer('Unit Digits'),

quality.py

@@ -68,7 +68,7 @@ class QualitySample(ModelSQL, ModelView):
     'Quality Sample'
     __name__ = 'quality.sample'
 
-    code = fields.Char('Code', select=True, readonly=True)
+    code = fields.Char('Code', readonly=True)
     reference = fields.Char('Reference')
     products = fields.Many2Many('product.product-quality.sample', 'sample',
         'product', "Products",
@@ -77,8 +77,7 @@ class QualitySample(ModelSQL, ModelView):
             },
         depends=['company'])
     collection_date = fields.DateTime('Collection Date', required=True)
-    company = fields.Many2One('company.company', 'Company', required=True,
-        select=True)
+    company = fields.Many2One('company.company', 'Company', required=True)
 
     @staticmethod
     def default_company():
@@ -113,9 +112,9 @@ class ProductQualitySample(ModelSQL):
     __name__ = 'product.product-quality.sample'
 
     product = fields.Many2One('product.product', 'Product', required=True,
-        ondelete='CASCADE', select=True)
+        ondelete='CASCADE')
     sample = fields.Many2One('quality.sample', 'Sample', ondelete='CASCADE',
-        required=True, select=True)
+        required=True)
 
 
 class QualityTest(metaclass=PoolMeta):
@@ -177,7 +176,7 @@ class QualityTest(metaclass=PoolMeta):
 
 class TestLineMixin(Model):
     __slots__ = ()
-    product = fields.Function(fields.Many2One('product.product', 'Product', select=True),
+    product = fields.Function(fields.Many2One('product.product', 'Product'),
         'get_product', searcher='search_product')
 
     def get_product(self, name):

weighing.py

@@ -30,7 +30,7 @@ class Weighing(Workflow, ModelSQL, ModelView):
     __name__ = 'agronomics.weighing'
     _rec_name = 'number'
 
-    number = fields.Char('Number', readonly=True, select=True)
+    number = fields.Char('Number', readonly=True)
     weighing_date = fields.Date('Date', states={
             'readonly': Eval('state').in_(READONLY),
             'required': True