From 851fb9fe4659c4d123773d81aa8ef4988ef40be0 Mon Sep 17 00:00:00 2001
From: Michael Stenta <mike@mstenta.net>
Date: Tue, 27 Jun 2017 15:54:47 -0400
Subject: [PATCH] Move farm menu code from farm_admin to new farm_menu module.

---
 farm.info                                  |  1 +
 farm.install                               | 10 ++++--
 modules/farm/farm_admin/farm_admin.install | 41 ----------------------
 modules/farm/farm_admin/farm_admin.module  | 27 --------------
 modules/farm/farm_menu/farm_menu.info      |  4 +++
 modules/farm/farm_menu/farm_menu.install   | 30 ++++++++++++++++
 modules/farm/farm_menu/farm_menu.module    | 32 +++++++++++++++++
 7 files changed, 75 insertions(+), 70 deletions(-)
 delete mode 100644 modules/farm/farm_admin/farm_admin.install
 create mode 100644 modules/farm/farm_menu/farm_menu.info
 create mode 100644 modules/farm/farm_menu/farm_menu.install
 create mode 100644 modules/farm/farm_menu/farm_menu.module

diff --git a/farm.info b/farm.info
index ef60c0650..61e56a29b 100644
--- a/farm.info
+++ b/farm.info
@@ -47,6 +47,7 @@ dependencies[] = farm_fields
 dependencies[] = farm_help
 dependencies[] = farm_log
 dependencies[] = farm_map
+dependencies[] = farm_menu
 dependencies[] = farm_people
 dependencies[] = farm_quantity
 dependencies[] = farm_taxonomy
diff --git a/farm.install b/farm.install
index a5ed42172..3c88acbb6 100644
--- a/farm.install
+++ b/farm.install
@@ -536,10 +536,16 @@ function farm_update_7024(&$sandbox) {
 }
 
 /**
- * Install the new Farm Help, People, and UI modules.
+ * Install the new Farm Help, Menu, People, and UI modules.
  */
 function farm_update_7025(&$sandbox) {
-  _farm_update_enable_modules(array('farm_help', 'farm_people', 'farm_ui'));
+  $modules = array(
+    'farm_help',
+    'farm_menu',
+    'farm_people',
+    'farm_ui'
+  );
+  _farm_update_enable_modules($modules);
 }
 
 /**
diff --git a/modules/farm/farm_admin/farm_admin.install b/modules/farm/farm_admin/farm_admin.install
deleted file mode 100644
index fe3d3f3f7..000000000
--- a/modules/farm/farm_admin/farm_admin.install
+++ /dev/null
@@ -1,41 +0,0 @@
-<?php
-/**
- * @file
- * Farm admin install.
- */
-
-/**
- * Implements hook_enable().
- */
-function farm_admin_enable() {
-
-  // If Menu module is enabled, create the farm menu.
-  // @see farm_admin_modules_installed()
-  if (module_exists('menu')) {
-    farm_admin_menu_save();
-  }
-}
-
-/**
- * Implements hook_uninstall().
- */
-function farm_admin_uninstall() {
-
-  // Delete the farm menu.
-  if (module_exists('menu')) {
-    if ($farm_menu = menu_load('farm')) {
-      menu_delete($farm_menu);
-    }
-  }
-}
-
-/**
- * Create new farm menu.
- */
-function farm_admin_update_7000(&$sandbox) {
-
-  // If Menu module is enabled, create the farm menu.
-  if (module_exists('menu')) {
-    farm_admin_menu_save();
-  }
-}
diff --git a/modules/farm/farm_admin/farm_admin.module b/modules/farm/farm_admin/farm_admin.module
index 9a21316c6..f15c7032d 100644
--- a/modules/farm/farm_admin/farm_admin.module
+++ b/modules/farm/farm_admin/farm_admin.module
@@ -4,17 +4,6 @@
  * Code for the Farm Admin feature.
  */
 
-/**
- * Implements hook_modules_installed().
- */
-function farm_admin_modules_installed($modules) {
-
-  // If the menu module is installed, create the farm menu.
-  if (in_array('menu', $modules)) {
-    farm_admin_menu_save();
-  }
-}
-
 /**
  * Implements hook_permission().
  */
@@ -101,19 +90,3 @@ function farm_admin_dashboard() {
   // Return the output.
   return $output;
 }
-
-/**
- * Generate the farm menu.
- *
- * @see farm_admin_enable()
- * @see farm_admin_install_modules()
- */
-function farm_admin_menu_save() {
-  $t = get_t();
-  $menu = array(
-    'menu_name' => 'farm',
-    'title' => $t('Farm'),
-    'description' => $t('Farm management links'),
-  );
-  menu_save($menu);
-}
diff --git a/modules/farm/farm_menu/farm_menu.info b/modules/farm/farm_menu/farm_menu.info
new file mode 100644
index 000000000..6c0d81c50
--- /dev/null
+++ b/modules/farm/farm_menu/farm_menu.info
@@ -0,0 +1,4 @@
+name = Farm Menu
+description = Provides a menu for farm pages.
+core = 7.x
+package = farmOS
diff --git a/modules/farm/farm_menu/farm_menu.install b/modules/farm/farm_menu/farm_menu.install
new file mode 100644
index 000000000..3777b2774
--- /dev/null
+++ b/modules/farm/farm_menu/farm_menu.install
@@ -0,0 +1,30 @@
+<?php
+/**
+ * @file
+ * Farm menu install.
+ */
+
+/**
+ * Implements hook_enable().
+ */
+function farm_menu_enable() {
+
+  // If Menu module is enabled, create the farm menu.
+  // @see farm_menu_modules_installed()
+  if (module_exists('menu')) {
+    farm_menu_create();
+  }
+}
+
+/**
+ * Implements hook_uninstall().
+ */
+function farm_menu_uninstall() {
+
+  // Delete the farm menu.
+  if (module_exists('menu')) {
+    if ($farm_menu = menu_load('farm')) {
+      menu_delete($farm_menu);
+    }
+  }
+}
diff --git a/modules/farm/farm_menu/farm_menu.module b/modules/farm/farm_menu/farm_menu.module
new file mode 100644
index 000000000..1820d0021
--- /dev/null
+++ b/modules/farm/farm_menu/farm_menu.module
@@ -0,0 +1,32 @@
+<?php
+/**
+ * @file
+ * Farm menu module.
+ */
+
+/**
+ * Implements hook_modules_installed().
+ */
+function farm_menu_modules_installed($modules) {
+
+  // If the Menu module is installed, create the farm menu.
+  if (in_array('menu', $modules)) {
+    farm_menu_create();
+  }
+}
+
+/**
+ * Generate the farm menu.
+ *
+ * @see farm_menu_enable()
+ * @see farm_menu_install_modules()
+ */
+function farm_menu_create() {
+  $t = get_t();
+  $menu = array(
+    'menu_name' => 'farm',
+    'title' => $t('Farm'),
+    'description' => $t('Farm management links'),
+  );
+  menu_save($menu);
+}