3
0
Fork 0
mirror of https://github.com/farmOS/farmOS.git synced 2024-02-23 11:37:38 +01:00
Commit graph

84 commits

Author SHA1 Message Date
Michael Stenta 0067c85215 Rebuild routes when quick form config entities are saved/deleted. 2023-10-09 15:15:38 -04:00
Michael Stenta 96b6002f5d Quick form actions cause RouteNotFoundException: Route farm.quick.[id] does not exist. #727
Revert "Refactor quick form route building to a single route"

This reverts commit 3505e80124.
2023-10-09 15:15:37 -04:00
Michael Stenta de8a262685 Remove requiresEntity() method. 2023-10-06 14:11:11 -04:00
Paul Weidner 89be8e6359 Add test assertion for quick form help text 2023-10-06 14:11:10 -04:00
Michael Stenta 8ae1c6dd1f Automated tests of configurable quick forms. 2023-10-06 14:11:10 -04:00
Paul Weidner e987d9450c Configure quick form entities with correct quickId in getInstances() function 2023-10-06 14:11:10 -04:00
Paul Weidner 7506862308 Rename createInstance to getInstance for consistency with getInstances function 2023-10-06 14:11:10 -04:00
Paul Weidner 4fcc647115 Raise 404 if quick form does not exist 2023-10-06 14:11:10 -04:00
Paul Weidner f89e155f0a Load plugin definition to check requiresEntity 2023-10-06 14:11:10 -04:00
Paul Weidner 8a52fd3be6 Add cache metadata to quick form controller 2023-10-06 14:11:10 -04:00
Paul Weidner be973941aa Save default label, description and help text to quick form 2023-10-06 14:11:10 -04:00
Paul Weidner 18db434a68 Use standard entity permissions 2023-10-06 14:11:10 -04:00
Paul Weidner 3505e80124 Refactor quick form route building to a single route 2023-10-06 14:11:10 -04:00
Paul Weidner 8903ff44bc Refactor ConfigureQuickForm to use EntityForm 2023-10-06 14:11:10 -04:00
Michael Stenta fa6329f579 Generate menu task links (tabs) for quick forms and their configuration forms. 2023-10-06 14:11:10 -04:00
Michael Stenta 87fa34716d Build routes to configuration forms. 2023-10-06 14:11:10 -04:00
Michael Stenta 92c3543b87 Add a ConfigureQuickForm for building, validating, and submitting configuration forms. 2023-10-06 14:11:10 -04:00
Michael Stenta 44c443bda9 Add a permission for configuring quick forms. 2023-10-06 14:11:10 -04:00
Michael Stenta 554afce229 Add a requiresEntity boolean to quick form plugins to optionally prevent creating default instances. 2023-10-06 14:11:10 -04:00
Michael Stenta 9811f7c7f7 Exclude quick forms that are explicitly disabled. 2023-10-06 14:11:10 -04:00
Michael Stenta 898d2355f0 Introduce new getQuickId() and setQuickId() methods. Deprecate getId(). 2023-10-06 14:11:10 -04:00
Michael Stenta 11c6e5be7e Refactor QuickFormInstanceManager to return config entities. 2023-10-06 14:11:10 -04:00
Michael Stenta 6e34a09a9f Provide a ConfigurableQuickFormTrait that quick forms can use.
This uses ConfigurableTrait to add default getConfiguration(),
setConfiguration(), and defaultConfiguration() methods, and it
adds default buildConfigurationForm(), validateConfigurationForm(),
and submitConfigurationForm() methods.

The submitConfigurationForm() method does not yet save anything
automatically.
2023-10-06 14:11:10 -04:00
Michael Stenta 04e4a86b25 Provide a ConfigurableTrait with common boiler plate.
This will be replaced by a trait of the same name in Drupal core
via https://www.drupal.org/project/drupal/issues/2852463.
2023-10-06 14:11:10 -04:00
Michael Stenta 14365f6008 Provide a ConfigurableQuickFormInterface that quick forms can use to declare themselves configurable.
This extends from QuickFormInterface, as well as ConfigurableInterface
(which adds getConfiguration(), setConfiguration(), and defaultConfiguration())
and PluginFormInterface (which adds buildConfigurationForm(),
validateConfigurationForm(), and submitConfigurationForm()).
2023-10-06 14:11:10 -04:00
Michael Stenta bce6654428 Provide a configuration entity type for quick form instances. 2023-10-06 14:11:10 -04:00
Michael Stenta 78943d239d Provide a QuickFormInstanceManager service class with helper methods for instantiating quick form plugins. 2023-10-06 14:11:10 -04:00
Michael Stenta 3f559e77e9 Rename QuickFormManager to QuickFormPluginManager. 2023-10-06 14:11:10 -04:00
Michael Stenta 9109983cfe Fix test quick form field name. 2023-10-06 13:58:57 -04:00
Michael Stenta 2101da034a Fix typo in getQuickFormId() method name. 2023-10-06 13:58:57 -04:00
Michael Stenta cec5cc352a Fix camelCase of quick form plugin getLabel() method. 2023-10-06 13:58:57 -04:00
Michael Stenta 16eec9db45 Move quick form route builder method out of QuickFormManager to a new Routing/QuickFormRoutes class. 2023-10-06 13:58:57 -04:00
Michael Stenta 9c9acf5a95 Confirm that access is denied to individual quick forms without permission. 2023-10-06 13:58:57 -04:00
Michael Stenta bc11ac5e48 Target hook_help() logic to specific quick form route IDs.
Previously this matched any route starting with farm.quick., so
if a route was created like farm.quick.myform.configure it was
also getting help text applied.
2023-10-06 13:58:57 -04:00
Michael Stenta a1daf8300c Fix abstract getId() method visibility in QuickAssetTrait, QuickLogTrait, and QuickPrepopulateTrait.
These should match QuickFormInterface, which declares getID() as a public method.
2023-10-06 13:58:57 -04:00
Michael Stenta 05c7da18b4 Extend QuickFormInterface from FormInterface.
We already implement buildForm(), validateForm(), and submitForm().
The only method this adds is getFormId(). So we will also refactor
how getFormId() works in \Drupal\farm_quick\Form\QuickForm to get
it from plugin instances instead of generating it itself.
2023-10-06 13:58:57 -04:00
Michael Stenta 5fefeb3820 QuickFormInterface does not need to extend from PluginIntrospectionInterface.
Quick forms already extend from \Drupal\Component\Plugin\PluginBase,
which implements PluginIntrospectionInterface. There is no need for
QuickFormInterface to extend from it.
2023-10-06 13:58:57 -04:00
Paul Weidner 5ca5f1a3ab Fix phpcs error that use statements should be sorted alphabetically 2023-06-13 09:53:49 -07:00
Michael Stenta dab5415b95 Add QuickStringTrait::entityLabelsSummary() method for summarizing entity labels #675 2023-05-11 13:37:48 -04:00
Michael Stenta 8eaef1231b Abstract inline container structure into new QuickFormElementsTrait::buildInlineContainer() trait+method. 2023-04-01 14:00:38 -04:00
Michael Stenta 5ada077408 Move inline container style definition to farm_ui_theme. 2023-04-01 14:00:38 -04:00
Michael Stenta 78abcff89d Add a common CSS file for quick form styles, including an "inline" class for inline fields. 2023-04-01 14:00:38 -04:00
Michael Stenta b807c5602f Fix quick form toolbar menu links #657 2023-03-16 14:57:29 -04:00
Michael Stenta 7a9f8f4bbe Create a QuickFormTestBase class that other quick form tests can extend from #650 2023-03-11 11:13:59 -05:00
Michael Stenta c787d7e256 Remove default_measure configuration from quantity type definitions #612
This was originally added so that the Price quantity type could set its
default measure to "value" all the time. This was back when price
quantities were part of farmOS core. It was then moved to the
farm_ledger contrib module, and is being refactored such that it will no
longer need to make use of this default_measure configuration.
2022-12-02 14:02:24 -05:00
Michael Stenta 165547d94f Add asset/log dependencies to farm_quick_test.info.yml. 2022-11-22 16:20:40 -05:00
Michael Stenta 6c5f42b98f Use default quantity type in QuickQuantityTrait.
This removes the dependency on farm_quantity_standard.
2022-11-22 16:20:40 -05:00
Michael Stenta 5b06c00e1c Fix Constructor of class Drupal\farm_quick\Plugin\Derivative\QuickFormMenuLink has an unused parameter $base_plugin_id. 2022-09-13 10:23:48 -04:00
Michael Stenta 8b7f6fd28d Fix Call to deprecated function taxonomy_term_load_multiple_by_name() 2022-09-13 10:23:48 -04:00
Paul Weidner 7463f81f1d Implement BaseFormIdInterface and build a unique form ID from the id route parameter. 2022-06-27 11:33:25 -07:00