Commit Graph

7548 Commits

Author SHA1 Message Date
Michael Stenta 9e829fc374 Use @phpstan-ignore-next-line on getAggregateQuery() lines to fix "Missing explicit access check on entity query" errors.
This is a temporary workaround pending resolution of this upstream issue:

https://github.com/mglaman/phpstan-drupal/issues/474
2022-09-13 10:23:48 -04:00
Michael Stenta 79b3fb9ff8 Fix "Missing explicit access check on entity query" PHPStan errors. 2022-09-13 10:23:48 -04:00
Michael Stenta 1cd9df9fab Fix "Access to an undefined property" PHPStan errors. 2022-09-13 10:23:48 -04:00
Michael Stenta f7f97dd64d Use itamair/geophp instead of phayes/geophp because Geofield depends on it (and it is maintained). 2022-09-13 10:23:48 -04:00
Michael Stenta 2a9d057f09 Fix "Variable might not be defined" PHPStan errors. 2022-09-13 10:23:48 -04:00
Michael Stenta 6ac668d133 Add alterInfo() calls to fix "Plugin definitions cannot be altered" PHPStan errors. 2022-09-13 10:23:48 -04:00
Michael Stenta 63de8c406c Fix "return statement is missing" PHPStan errors. 2022-09-13 10:23:47 -04:00
Michael Stenta ff60b3164d Fix \Drupal calls should be avoided in classes, use dependency injection instead. 2022-09-13 10:12:45 -04:00
Michael Stenta ef2bc30feb Ignore PHPStan error: "Class Drupal\farm_l10n\Form\L10nSettingsForm extends @internal class Drupal\language\Form\NegotiationSelectedForm." 2022-09-13 08:16:35 -04:00
Michael Stenta b9ff7b07f7 Ignore PHPStan error: "Class Drupal\farm_kml\Encoder\Kml extends @internal class Drupal\serialization\Encoder\XmlEncoder." 2022-09-13 08:16:35 -04:00
Michael Stenta 809c224ca2 Ignore PHPStan error: Class Drupal\farm_api\Controller\FarmEntryPoint extends @internal class Drupal\jsonapi\Controller\EntryPoint.
We intentionally extend the core JSON:API controller, even though
it is marked @internal, and take responsibility for it working
correctly.
2022-09-13 08:15:50 -04:00
Michael Stenta d2a7d50029 Fix Interface Drupal\farm_map\LayerStyleLoaderInterface referenced with incorrect case: Drupal\farm_map\layerStyleLoaderInterface. 2022-09-12 19:46:38 -04:00
Michael Stenta 597e984fb4 Fix "always exists and is not falsy" PHPStan errors. 2022-09-12 19:46:27 -04:00
Michael Stenta bc92cb4714 Ignore "Unsafe usage of new static()" PHPStan errors.
See https://www.drupal.org/docs/develop/development-tools/phpstan/handling-unsafe-usage-of-new-static
2022-09-12 19:38:25 -04:00
Michael Stenta eedcc16115 Configure PHPStan via phpstan.neon.
See https://www.drupal.org/docs/develop/development-tools/phpstan/getting-started
2022-09-12 19:38:25 -04:00
Michael Stenta b0a008097c Document using PHPStan in local development environment. 2022-09-12 19:38:25 -04:00
Michael Stenta 059e058b6c Run PHPStan after Codesniffer in GitHub Actions test and delivery workflow. 2022-09-12 19:38:25 -04:00
Michael Stenta a0accbd38f Add PHPStan dependencies: phpstan/phpstan, phpstan/phpstan-deprecation-rules, phpstan/extension-installer, mglaman/phpstan-drupal. 2022-09-12 19:38:23 -04:00
Michael Stenta 6735d3228a Update Drupal core to 9.4.x #566 2022-09-12 09:09:22 -04:00
Michael Stenta b495cdb840 Prevent circular group membership #562 2022-08-29 19:06:35 -04:00
Michael Stenta ac8966b7ac Update farmOS-map to v2.0.5 to fix Uncaught (in promise) TypeError: o.getChangeEventType is not a function #551 2022-08-29 10:04:48 -04:00
Michael Stenta a4e8675b22 Fix Farm inventory view does not depend on farm_inventory module #559 2022-08-29 09:43:54 -04:00
Michael Stenta 948a873f59 Fix Incorrect translation placeholders for asset names #540 2022-08-29 09:36:32 -04:00
Michael Stenta a63e8a9683 Fix Map form element #required is not enforced #560 2022-08-29 09:14:49 -04:00
Michael Stenta b1cd960a4e Fix Uncaught (in promise) TypeError: instance.editAttached is undefined #550 2022-08-29 08:52:33 -04:00
Michael Stenta 5737d549a6 Issue #3305724 by pcambra, m.stenta, paul121: Allow map type and behaviors to be configurable in map blocks 2022-08-29 08:35:25 -04:00
Michael Stenta 6a035343d2 Mention that some behaviors require additional settings provided by modules in field description. 2022-08-29 08:11:58 -04:00
Michael Stenta c8440675f4 Only save map behavior array keys to config. 2022-08-29 08:11:47 -04:00
Paul Weidner 61decc4f39 Calculate dependencies for map block config. 2022-08-29 07:57:23 -04:00
Michael Stenta 837880963d Add CHANGELOG.md line for Issue #3305724. 2022-08-29 07:54:58 -04:00
Michael Stenta d09b163aa6 Allow map behaviors to be configurable in map blocks. 2022-08-29 07:54:58 -04:00
Michael Stenta a177c44866 Show map_type options in a dropdown select element. 2022-08-29 07:54:58 -04:00
Michael Stenta e841e57617 Implement blockSubmit() to save map type configuration value. 2022-08-29 07:54:58 -04:00
Michael Stenta 96c934df9c Call parent::buildConfigurationForm() to start the $form array. 2022-08-29 07:54:58 -04:00
Pedro Cambra 6e4878b650 Allow to configure the map type on the map block 2022-08-29 07:54:58 -04:00
Michael Stenta 5c74886d63 Issue #3306344 by paul121: Allow views exposed filters to be collapsed 2022-08-29 07:29:00 -04:00
Paul Weidner 49faab2979 Add CHANGELOG.md entry for Issue #3306344. 2022-08-28 19:13:23 -07:00
Paul Weidner 44087ecd98 Implement uninstall hook to remove collapsible_filter display extender. 2022-08-28 19:10:13 -07:00
Paul Weidner 78c36b4681 Add post_update hook to enable collapsible_filter on existing sites. 2022-08-26 14:35:13 -07:00
Paul Weidner f8ea3fe30f Enable collapsible filter on farm views that have many exposed filters. 2022-08-26 14:23:59 -07:00
Paul Weidner a3e27d34cc Re-export farm_inventory views config (no functional changes). 2022-08-26 14:22:21 -07:00
Paul Weidner f9eb9d6505 Enable the collapsible_filter display extender by default. 2022-08-26 14:21:39 -07:00
Paul Weidner 6d03d159ed Add views display extender to configure collapsible filter. 2022-08-26 14:21:21 -07:00
Paul Weidner cbd9875d66 Render farm entity views in collapsible details element. 2022-08-26 13:15:30 -07:00
Michael Stenta 8456962080 Add CHANGELOG.md line for Issue #3306227. 2022-08-26 11:30:35 -04:00
Michael Stenta 7d6cb34884 Issue #3306227: Dispatch events for asset presave, insert, update, delete 2022-08-26 09:28:55 -04:00
Michael Stenta 29106edda9 Re-export farm_asset and farm_log Views config (no functional changes). 2022-08-26 08:29:06 -04:00
Michael Stenta e23e390335 Improve API docs #557 2022-08-26 07:15:56 -04:00
Michael Stenta 5d6d889adf Organize unreleased CHANGELOG.md lines under "Added" and "Fixed" headings. 2022-08-26 07:14:26 -04:00
Michael Stenta be0ff3e118 Add CHANGELOG.md line for #557. 2022-08-26 07:14:26 -04:00