alexenko
/
ProSol.Messaging
1
1
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases 1 Wiki Activity

Fluent Provider #11

Merged
alexenko merged 5 commits from Fluents into main 2023-11-30 17:04:50 +01:00
Conversation 0 Commits 5 Files Changed 41 +715 -260
alexenko commented 2023-11-29 14:01:34 +01:00
Owner
Copy Link

Released at 4.0.0-rc.5.1

Released at 4.0.0-rc.5.1
alexenko added 1 commit 2023-11-29 14:01:35 +01:00
alexenko reviewed 2023-11-29 14:04:52 +01:00
alexenko left a comment
Author
Owner
Copy Link

please solve:

  • TODOs
  • NextDelegate all over the place.
please solve: - TODOs - NextDelegate all over the place.
src/Fluent/PublisherFluentExtensions.cs Outdated
@ -0,0 +10,4 @@
Func<TSource, TDest> converter)
{
// TODO: please remove reference to .Translating namespace.
var result = new SimpleTranslator<TSource, TDest>(converter);
alexenko commented 2023-11-29 14:02:54 +01:00
Author
Owner
Copy Link

please remove reference to .Translating namespace

please remove reference to .Translating namespace
alexenko marked this conversation as resolved
src/Fluent/PublisherFluentExtensions.cs Outdated
@ -0,0 +13,4 @@
var result = new SimpleTranslator<TSource, TDest>(converter);
// HACK: no idea what to do with unsubscribers.
var unsubscriber = publisher.Subscribe(result);
return result;
alexenko commented 2023-11-29 14:03:06 +01:00
Author
Owner
Copy Link

Any ideas?

Any ideas?
alexenko commented 2023-11-30 10:19:26 +01:00
Author
Owner
Copy Link

Yes. Ignore for now.

Yes. Ignore for now.
alexenko marked this conversation as resolved
src/Publishers/package.nuspec Outdated
@ -0,0 +24,4 @@
<file src="bin\Release\net8.0\Publishers.dll" target="lib\net8.0" />
<file src="bin\Release\net8.0\Translating.dll" target="lib\net8.0" />
<file src="bin\Release\net8.0\Subscriptions.dll" target="lib\net8.0" />
<file src="..\..\README.md" target="docs\" />
alexenko commented 2023-11-29 14:03:43 +01:00
Author
Owner
Copy Link

How the publishing going?

How the publishing going?
alexenko marked this conversation as resolved
alexenko added 1 commit 2023-11-30 12:13:00 +01:00
alexenko added 1 commit 2023-11-30 12:28:14 +01:00
alexenko added 1 commit 2023-11-30 12:42:57 +01:00
alexenko added 1 commit 2023-11-30 15:21:18 +01:00
alexenko reviewed 2023-11-30 15:36:57 +01:00
alexenko left a comment
Author
Owner
Copy Link

Looks like a merge. Lets finalize.

Looks like a merge. Lets finalize.
pack/package.nuspec
@ -0,0 +22,4 @@
<files>
<file src="bin\Release\net8.0\*.dll" target="lib\net8.0" />
<file src="..\README.md" target="docs\" />
<file src="..\docs\Subscriptions.md" target="docs\" />
alexenko commented 2023-11-30 15:34:49 +01:00
Author
Owner
Copy Link

Any chance to pack a Fluent.md docs?

Any chance to pack a Fluent.md docs?
alexenko marked this conversation as resolved
tests/Translating/MessageTranslatorTests.cs
@ -0,0 +19,4 @@
using var unsub = publisher
.Translate<string, int>(x => x.Length)
.Translate<int, bool>(x => x > 5)
.Subscribe(dataSubscriber);
alexenko commented 2023-11-30 15:36:34 +01:00
Author
Owner
Copy Link

cool

cool
alexenko marked this conversation as resolved
alexenko merged commit b89af9c74a into main 2023-11-30 17:04:50 +01:00
alexenko referenced this issue from a commit 2023-11-30 17:04:51 +01:00
Fluent Translators (#11)
alexenko deleted branch Fluents 2023-11-30 17:05:08 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: alexenko/ProSol.Messaging#11
No description provided.
Delete Branch "Fluents"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?