bigMouthCommie/storytime
Template
1
0
Fork 1
Code Issues 4 Pull requests Packages Projects Releases Wiki Activity

WIP: Create initial storytime script #3

Closed
judy wants to merge 1 commit from judy/storytime:storytime-script into main
pull from: judy/storytime:storytime-script
merge into: bigMouthCommie:main
Conversation 0 Commits 1 Files changed 1 +34 -43
judy commented 2024-04-12 20:14:27 +02:00
Collaborator
Copy link

🎁 Summary

Initial script to tie together storytime functionality. Takes feed url as required argument, outputs an mp3. (path to output mp3 can also be set to whatever output you want.)

✅ Quality Assurances

What steps have you taken to ensure quality and resilience in the code? Add and check off items you've completed to indicate thoroughness and confidence in your work. Delete non-applicable items.

  • Works on my machine
  • Documentation has been written (passing -h as command flag shows usage)
🎁 Summary --- Initial script to tie together storytime functionality. Takes feed url as required argument, outputs an mp3. (path to output mp3 can also be set to whatever output you want.) ✅ Quality Assurances --- _What steps have you taken to ensure quality and resilience in the code? Add and check off items you've completed to indicate thoroughness and confidence in your work. Delete non-applicable items._ - [x] Works on my machine - [x] Documentation has been written (passing -h as command flag shows usage)
judy added 2 commits 2024-04-12 20:14:28 +02:00
judy requested review from bigMouthCommie 2024-04-12 20:14:34 +02:00
judy self-assigned this 2024-04-12 20:14:36 +02:00
judy reviewed 2024-04-12 20:16:54 +02:00
bash/storytime.sh
@ -2,4 +3,3 @@
# Abort if any command fails.
set -e
# Check for presence of a command.
judy commented 2024-04-12 20:16:54 +02:00
Author
Collaborator
Copy link

Looks like storytime.sh had all of check-dependencies.sh copied into it. I removed it.

Looks like storytime.sh had all of check-dependencies.sh copied into it. I removed it.
judy reviewed 2024-04-12 20:20:14 +02:00
bash/storytime.sh
@ -24,0 +17,4 @@
output="output.mp3"
while getopts ":vo:h" opt; do
case ${opt} in
v) verbose="true" ;;
judy commented 2024-04-12 20:20:14 +02:00
Author
Collaborator
Copy link

FYI: Verbose flag doesn't currently do anything. I'd change the script to have zero output by default, and pass progress info to stderr if verbose is on. Later, if a TTY isn't detected (assuming output is being piped somewhere else), output can be piped downstream.

FYI: Verbose flag doesn't currently do anything. I'd change the script to have zero output by default, and pass progress info to stderr if verbose is on. Later, if a TTY isn't detected (assuming output is being piped somewhere else), output can be piped downstream.
bigMouthCommie closed this pull request 2024-04-13 03:09:54 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
bigMouthCommie
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
judy
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: bigMouthCommie/storytime#3
No description provided.
Delete branch "judy/storytime:storytime-script"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?