Add comments to Dockerfile about hacks

This commit is contained in:
Simon Li 2019-09-26 18:58:53 +01:00
parent c7cf086a76
commit ae8c952cf6
No known key found for this signature in database
GPG Key ID: F604A75EB0CBF584
1 changed files with 7 additions and 6 deletions

View File

@ -10,22 +10,23 @@ RUN apt-get update -y -q && \
tigervnc-standalone-server
RUN apt-get install -y -q python-pip
# https://github.com/novnc/noVNC/issues/1276
# Force an upgrade https://github.com/novnc/noVNC/issues/1276
RUN /usr/bin/pip install -U websockify==0.9.0
# pip doesn't rebuild rebind.so though so use the old version
RUN ln -s /usr/lib/websockify/rebind.so /usr/local/lib/
# Patch novnc to automatically connect
ADD websocket-path-ui-js.patch /usr/share/novnc/include
RUN cd /usr/share/novnc/include/ && \
patch -p0 < websocket-path-ui-js.patch
RUN ln -s /usr/lib/websockify/rebind.so /usr/local/lib/
USER jovyan
# RUN /opt/conda/bin/pip install jupyter-server-proxy
# Custom jupyter-server-proxy to load vnc.html instead of /
RUN /opt/conda/bin/pip install https://github.com/manics/jupyter-server-proxy/archive/indexpage.zip
ADD jupyter_notebook_config.py /home/jovyan/.jupyter/
# websockify --web /usr/share/novnc 5901 -- vncserver -verbose -xstartup startlxde -SecurityTypes None -geometry 1024x768 -fg :1
# Both these should work:
# http://localhost:5901/vnc.html?autoconnect=true
# http://127.0.0.1:8888/lxde/vnc.html?path=%2Flxde%2Fwebsockify&autoconnect=true
# http://localhost:5901/vnc.html
# http://127.0.0.1:8888/lxde