Fix some compiler warnings about unused parameters

This commit is contained in:
Filippo Gentile 2023-02-18 20:08:11 +01:00
parent 6323a87ff0
commit 9abb3b014c
12 changed files with 13 additions and 21 deletions

View File

@ -218,7 +218,7 @@ void LineGraphManager::onSceneDestroyed(QObject *obj)
unregisterScene(scene);
}
void LineGraphManager::onGraphChanged(int graphType_, db_id graphObjId, LineGraphScene *scene)
void LineGraphManager::onGraphChanged(int /*graphType_*/, db_id graphObjId, LineGraphScene *scene)
{
if(!m_followJobOnGraphChange || !scenes.contains(scene))
{

View File

@ -55,7 +55,7 @@ void LineGraphScene::renderContents(QPainter *painter, const QRectF &sceneRect)
}
void LineGraphScene::renderHeader(QPainter *painter, const QRectF &sceneRect,
Qt::Orientation orient, double scroll)
Qt::Orientation orient, double /*scroll*/)
{
if(orient == Qt::Horizontal)
BackgroundHelper::drawStationHeader(painter, this, sceneRect);

View File

@ -33,7 +33,7 @@ void StopCouplingModel::setStop(db_id stopId, RsOp op)
refreshData(true);
}
void StopCouplingModel::internalFetch(int first, int sortCol, int /*valRow*/, const QVariant& /*val*/)
void StopCouplingModel::internalFetch(int first, int /*sortCol*/, int /*valRow*/, const QVariant& /*val*/)
{
query q(mDb);

View File

@ -38,7 +38,7 @@ StopModel::StopModel(database &db, QObject *parent) :
connect(Session, &MeetingSession::stationNameChanged, this, &StopModel::onStationSegmentNameChanged);
}
QVariant StopModel::data(const QModelIndex &index, int role) const
QVariant StopModel::data(const QModelIndex &/*index*/, int /*role*/) const
{
return QVariant(); //Use setters and getters instead of data() and setData()
}

View File

@ -56,7 +56,7 @@ void ShiftGraphScene::renderContents(QPainter *painter, const QRectF &sceneRect)
}
void ShiftGraphScene::renderHeader(QPainter *painter, const QRectF &sceneRect,
Qt::Orientation orient, double scroll)
Qt::Orientation orient, double /*scroll*/)
{
if(orient == Qt::Horizontal)
drawHourHeader(painter, sceneRect);

View File

@ -161,12 +161,6 @@ QVariant RailwaySegmentsModel::data(const QModelIndex &idx, int role) const
return QVariant();
}
bool RailwaySegmentsModel::setData(const QModelIndex &idx, const QVariant &value, int role)
{
//TODO: edit here or always by the dialog?
return false;
}
Qt::ItemFlags RailwaySegmentsModel::flags(const QModelIndex &idx) const
{
if (!idx.isValid())

View File

@ -57,11 +57,6 @@ public:
// Basic functionality:
QVariant data(const QModelIndex &idx, int role = Qt::DisplayRole) const override;
// Editable:
bool setData(const QModelIndex &idx, const QVariant &value,
int role = Qt::EditRole) override;
Qt::ItemFlags flags(const QModelIndex& idx) const override;
// IPagedItemModel

View File

@ -431,7 +431,7 @@ void showTrackMsgBox(const StationSVGJobStops::Stop& stop, ssplib::StationPlan *
}
}
void StationSVGPlanDlg::onTrackClicked(qint64 trackId, const QString &name)
void StationSVGPlanDlg::onTrackClicked(qint64 trackId, const QString &/*name*/)
{
for(const StationSVGJobStops::Stop& stop : qAsConst(m_station->stops))
{
@ -443,7 +443,8 @@ void StationSVGPlanDlg::onTrackClicked(qint64 trackId, const QString &name)
}
}
void StationSVGPlanDlg::onTrackConnClicked(qint64 connId, qint64 trackId, qint64 gateId, int gateTrackPos, int trackSide)
void StationSVGPlanDlg::onTrackConnClicked(qint64 connId, qint64 /*trackId*/, qint64 /*gateId*/,
int /*gateTrackPos*/, int /*trackSide*/)
{
for(const StationSVGJobStops::Stop& stop : qAsConst(m_station->stops))
{

View File

@ -196,6 +196,7 @@ void FilterHeaderView::clearFilters()
void FilterHeaderView::setFilter(int column, const QString& value)
{
Q_UNUSED(value)
for(FilterHeaderLineEdit* filterLineEdit : qAsConst(filterWidgets))
{
if(filterLineEdit->getColumn() == column)

View File

@ -42,6 +42,7 @@ void BasicGraphHeader::paintEvent(QPaintEvent *e)
return; //Nothing to draw
//FIXME: consider QPaintEvent rect?
Q_UNUSED(e)
const double scaleFactor = mZoom / 100.0;

View File

@ -1,7 +1,7 @@
#include "taskprogressevent.h"
GenericTaskEvent::GenericTaskEvent(Type t, IQuittableTask *self) :
QEvent(t),
GenericTaskEvent::GenericTaskEvent(Type type_, IQuittableTask *self) :
QEvent(type_),
task(self)
{

View File

@ -10,7 +10,7 @@ class IQuittableTask;
class GenericTaskEvent : public QEvent
{
public:
GenericTaskEvent(QEvent::Type t, IQuittableTask *self);
GenericTaskEvent(QEvent::Type type_, IQuittableTask *self);
IQuittableTask *task = nullptr;
};