gfgit/claws-mail
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix a memory corruption bug in RSSyl's feed_item_copy()

Browse source
This commit is contained in:
Andrej Kacian 2019-04-30 23:03:03 +02:00
parent 4f3a94b969
commit 14b89d30c8
3 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/plugins/rssyl/libfeed/feeditem.c
View file

@ -344,7 +344,7 @@ FeedItem *feed_item_copy(FeedItem *item)
nitem->comments_url = g_strdup(item->comments_url);
nitem->parent_id = g_strdup(item->parent_id);
nitem->enclosure = g_memdup(item->enclosure, sizeof(FeedItemEnclosure));
nitem->enclosure = feed_item_enclosure_copy(item->enclosure);
nitem->date_published = item->date_published;
nitem->date_modified = item->date_modified;

9
src/plugins/rssyl/libfeed/feeditemenclosure.c
View file

@ -98,3 +98,12 @@ void feed_item_enclosure_set_size(FeedItemEnclosure *enclosure, gulong size)
enclosure->size = size;
}
FeedItemEnclosure *feed_item_enclosure_copy(FeedItemEnclosure *enclosure)
{
if (enclosure == NULL)
return NULL;
return feed_item_enclosure_new(enclosure->url, enclosure->type,
enclosure->size);
}

2
src/plugins/rssyl/libfeed/feeditemenclosure.h
View file

@ -40,4 +40,6 @@ void feed_item_enclosure_set_type(FeedItemEnclosure *enclosure, gchar *type);
gulong feed_item_enclosure_get_size(FeedItemEnclosure *enclosure);
void feed_item_enclosure_set_size(FeedItemEnclosure *enclosure, gulong size);
FeedItemEnclosure *feed_item_enclosure_copy(FeedItemEnclosure *enclosure);
#endif /* __FEEDITEMENCLOSURE_H */