Commit graph

1264 commits

Author SHA1 Message Date
Andrej Kacian 7087f6b973 Fix two missed return values in compose_write_to_file() from commit e9f610a4f.
Thanks to wwp for finding the issue!
2018-04-28 20:45:31 +02:00
Andrej Kacian b8db458023 Fix for e9f610a4f for the rare cases the privacy system has no error string ready. 2018-04-13 20:26:51 +02:00
Andrej Kacian 06cd7d5ff5 Rework and simplify how compose_queue() return values are handled
Also closes bug #3960 - Sends unencrypted emails when encryption fails
because we now return from compose_queue() with an error when
that happens, instead of ignoring it.
2018-04-13 20:09:36 +02:00
wwp 7e99816361 Fix broken templates attachments due to commit 814b087,
which clears template internals (including attachments list)
wherever template contains any field to apply (To/Subject/etc.)
and before attachments could be processed. Simply process
attachments before attachments list may be cleared by fields
processing. Ideally we should change quote_fmt_reset_vartable()
or its uses in compose.c at least.
2018-04-10 18:35:31 +02:00
Andrej Kacian ebd2fafbef Fix a dumb double-free on Windows.
Closes bug 3957: Claws-Mail 64bit crashes when saving a draft
2018-02-28 19:47:56 +01:00
Ricardo Mones 27c4b31bae Replace deprecated gtk_misc_set_alignment() in core 2018-02-20 19:08:45 +01:00
Andrej Kacian ab0270f13e Correctly set initial size for main and compose windows.
Use gtk_window_set_default_size() instead of
gtk_widget_set_size_request(), since in GTK3, the latter
sets minimum allowed size for a widget, and we're
interested in just setting initial size here. User
should be allowed to make the windows smaller.
2018-02-17 11:37:35 +01:00
Andrej Kacian 0463f92df1 Fix compose textview not using full window height. 2018-02-11 13:38:23 +01:00
Andrej Kacian 1d07c0f5db Limit external editor feature to UNIX OS with X11.
It uses GtkSocket, which is only available on X11
with GTK3.
2018-02-11 13:38:23 +01:00
wwp a99a6bc52c Update few occurrences to the new alertpanel() API (and by the way,
solve a leaking button_label strinc allocation).
2018-02-09 22:36:41 +01:00
Andrej Kacian 5ab9e6e799 Rework of alertpanel default button focus handling.
Instead of using "+" prefix with button labels and/or
the default_value parameter, we introduce "focus"
parameter, which will point to first, second or third
button.

Advantages:
- we got rid of the "+" prefix, which won't work with GTK3
  with GTK3
- instead of having two ways to indicate which button
  should have focus, which can be in conflict, and
  are not very straightforward, there is just one,
  arguably more intuitive
- some small memory leaks fixed along the way
  (using g_strconcat() directly as function argument)
2018-02-09 14:44:30 +01:00
Ralph Sennhauser 59309a6501 Drop ifdefs for old gtk+2
Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
2018-02-06 20:27:53 +01:00
Ricardo Mones 8363e45874 Move all colors into an array 2018-02-05 21:18:03 +01:00
Andrej Kacian b190f09ab3 Fix missing GError initialization in compose_draft(). 2017-12-20 10:46:01 +01:00
Andrej Kacian 9df59ba025 Add proper ifdefs around master_passphrase() calls. 2017-12-14 23:24:20 +01:00
Ricardo Mones 5b7108e97e Fix bug 3935: build from GIT master broken on arch linux
Completes 48f72c22f9 to allow building
with disabled LDAP support.
2017-12-12 18:27:32 +01:00
Andrej Kacian 48f72c22f9 Fix bug 3793: segfault when autocompletion asks for master passphrase
This is done by checking early if any ldap server is password-protected,
and asking for master passphrase when compose window appears.  If user
cancels the dialog (does not enter the passphrase), we temporarily
disable the password-protected LDAP servers, just for that particular
compose window. We reenable them in compose_destroy().
2017-12-10 18:13:28 +01:00
Ricardo Mones 9d25cc995d Fix CID 1420437 (OVERFLOW_BEFORE_WIDEN) 2017-10-30 11:00:17 +01:00
Andrej Kacian b97b0cead9 Use GIO API instead of g_stat() in compose_draft() on Windows. 2017-10-29 18:41:35 +01:00
Andrej Kacian 211cb04781 Use GIO API instead of g_stat() on Windows in compose_add_attachments() and get_file_size(). 2017-10-29 18:41:35 +01:00
Andrej Kacian 5407e4537c Use GIO API instead of g_stat() in compose_insert_file() on Windows. 2017-10-29 18:12:12 +01:00
Colin Leroy 9b17603ded CLI: Add a --insert option to --compose, allowing to insert files. 2017-09-15 15:45:46 +02:00
Paul 62686c8f6f fix bug 3852, 'delete header entry button doesn't restore colour' 2017-09-02 10:44:48 +01:00
Paul 9f24157d84 fix bug 3886, '"About to send mail to 2 recipients" warning when one of them is Reply-To' 2017-08-31 10:13:28 +01:00
Andrej Kacian 3266300edc Fix a memory leak in empty subject warning dialog in compose.c. 2017-07-28 19:50:29 +02:00
Andrej Kacian 14eb5b0094 Fix template parsing broken by commit 814b087. 2017-07-28 19:46:13 +02:00
Andrej Kacian fb0fb9d311 Fix a memory leak in compose_write_to_file(). 2017-07-12 11:14:13 +02:00
Andrej Kacian 814b087c91 Fix several memory leaks around template parsing.
FLEX-generated quote_fmt_scan_string() allocates a buffer
(and actually returns a pointer to it, although its prototype
in quote_fmt.h says its return value is void), which needs
to be cleaned up afterwards.
2017-07-11 18:37:54 +02:00
Ricardo Mones e00bcd4249 Check for NULL buttons also here
Thanks Andrej for the suggestion!
2017-07-11 10:06:20 +02:00
Ricardo Mones cd5ee29a81 Fix initialization of privacy buttons sensitivity 2017-07-11 09:53:42 +02:00
Andrej Kacian 7bf56c150c Add Sign/Encrypt toggle buttons to Compose toolbar. 2017-07-11 00:12:42 +02:00
Andrej Kacian 2872997c50 Fix two memory leaks around use of privacy_get_system_ids(). 2017-07-10 17:56:09 +02:00
Andrej Kacian d661fd7233 Only preserve existing Message-ID when reediting a draft.
This is a followup to commit e22cbed1f.
Closes Bug 3828 - "Re-edit" should not recycle the Message-ID header
2017-05-31 21:10:19 +02:00
Paul 6cc9389b81 add more utf8 listitem characters
patch by H. Merijn Brand
2017-05-22 17:56:06 +01:00
Paul 2db3b8b102 fix Resent-Date value 2017-05-21 19:12:51 +01:00
Paul 592315ae17 fix bug 3801, 'Broken auto wrapping' 2017-04-02 12:24:20 +01:00
Andrej Kacian 7c16b7e353 Make sure outgoing messages have a trailing newline.
This fixes a corner case where if the last line of
a message is a quote, its last character doesn't get
displayed when viewing the copy in outbox.
2017-03-30 21:12:52 +02:00
Andreas Bierfert e6db5f2b30 Fix bug #3796 format-security warnings in alertpanel_ use
This patch fixes format-security warnings in alertpanel_ use by passing
"%s" as string and the buffer as va argument if no other va arguments
are present.
2017-03-30 00:42:38 +02:00
wwp cce5b68054 Correct/update comment. 2017-03-19 19:42:04 +01:00
wwp 3595d6c625 Fix bug 3785: custom headers not stored in queued messages (and thus,
not sent).
2017-03-19 12:13:28 +01:00
Andrej Kacian bd8213fe3d Allow custom window title for the folder selection dialog.
Fixes bug #3582 - Select folder dialogue does not tell what is
selecting for.
2017-03-16 19:15:18 +01:00
Paul b83aa87688 fix disabling prefs_common.warn_sending_many_recipients_num by unchecking the 'show this msg again' checkbox in the dialogue 2017-03-01 13:13:24 +00:00
Ricardo Mones 0b164a349d Simplify hidden prefs for too many recipients 2017-02-27 23:59:19 +01:00
wwp 18403c8b8b Show attachments total size in compose window's relevant tab (only counts
attachments size, not encoding or body part, it is not the email
total size).
2017-01-21 12:58:50 +01:00
wwp 705f448caf Normalize rfc822 date handling by using decent buffer sizes everywhere (128,
which is way more than what RFC822 says: 37 max) and specific buffers.
2017-01-20 10:48:08 +01:00
wwp 9657f8bebc Fix bug 3762, 'redirect fails'
by removing an check added at 3.14.1.39-g989b3a3, thought I was hardening
sanity checks and I changed the logics, making it fail while in normal
situation. Removed few more extraneous checks.
2017-01-18 21:48:50 +01:00
wwp c0505b80f1 Fix bug 3251, 'A translated In-Reply-To header is sent translated'
by making sure we're always storing untranslated headers.
Optimize and sanitize a bit the code around it, too.
2017-01-17 13:41:52 +01:00
wwp 033bbdd7cd Fix Coverity CIDs #1398812, #1398813, #1398814.
Will convert compose_convert_header needs for fixed buffers later.
2017-01-16 18:29:15 +01:00
wwp 989b3a3f51 Fix bug 3571, 'recipient list lost and truncated'
by replacing lots of fixed-size buffers with dynamically
allocated ones.
Also enforce checks by adding or fixing few sanity tests,
fix returned value of some functions in some tricky cases.
2017-01-16 16:35:13 +01:00
wwp 498b61cc58 Prefer dynamically allocated buffers to fixed-size ones, use the same 2017-01-13 09:19:41 +01:00
wwp d1d7ad9aad Warn when sending to more than N recipients. This features obeys
to a couple of hidden prefs:
 warn_sending_many_recipients (TRUE/FALSE)
 warn_sending_many_recipients_num (1-1000)
2017-01-12 17:26:30 +01:00
wwp a7a4f21742 Fix a leak. 2017-01-07 00:46:20 +01:00
wwp 0372b283a8 Line-up arrays (w/ space chars only).
Fix missing array initializers.
2016-12-27 16:02:27 +01:00
wwp 66d2176e8b Silent up a compiler warning by making the ComposeCallAdvancedAction
enum a real integer-scope ([-1 .. n] instead of [0 .. n]), swallowing
the -1 value check.
2016-12-27 15:20:53 +01:00
wwp 571de7f509 Revert "Revert "Revert g9737584."" (but the fix) by reimplementing
the thing differently: don't mix printf() and C_() as it messes the
compiler up.
Factorize a bit format errors in compose.c.
Make some header names translatable following prefs in the
address keeper plugin.
2016-12-27 15:11:00 +01:00
wwp 69eaf525fa More translatable header names in UI strings. 2016-12-21 15:52:41 +01:00
Andrej Kacian 123563ca47 Moved compose_can_autosave() outside of #ifdef G_OS_UNIX. 2016-12-21 12:57:47 +01:00
wwp 4a92e36b32 Fix extra arguments to g_strdup_printf (thanks to coverity scan),
add quotes around header names in few dialogs.
2016-12-20 23:01:29 +01:00
wwp a38971609f Fix untranslatable concatenated strings (i.e. "Default "+"To:"),
normalize few uses of header names in UI.
2016-12-20 11:50:46 +01:00
Paul e3bb5c6ac8 fix black on black in From header 2016-12-16 10:21:31 +00:00
Andrej Kacian ea4011632f Honor autosave_encrypted preference when using external editor.
Patch by Ashish Gupta <ashmew2@gmail.com>.
2016-12-13 00:55:24 +01:00
wwp 382a3fed9d Add new actions to main window's toolbar: mark, unmark, lock, unlock,
mark (all) read, mark (all) unread.
Add new xpm icons for these actions (existing ones are small and made
for the message list) as well as for ignorethread and watchthread
actions.
Rename A_SENDL to A_SEND_LATER, we're not that lazy.
2016-12-12 15:30:24 +01:00
Paul 773ddbbae8 rename compose_guess_forward_account_from_msginfo() to compose_find_account() 2016-12-12 14:02:28 +00:00
Paul 3bbea866fa rename compose_entry_mark_default_to() to compose_entry_indicate() 2016-12-12 13:58:16 +00:00
wwp b3d90c51d0 Rename default_to_(bg)color hiddeng pref and variable to default_header_(bg)color. 2016-12-12 14:24:14 +01:00
Paul 70795ea5d1 more highlighted of automatically set header entries in Compose window
fix highlighting of multiple addresses set in account prefs
highlight From if not current account
2016-12-12 11:39:16 +00:00
Paul 3f46e81d2c don't remove the To when changing account 2016-12-12 10:17:59 +00:00
Paul f37bbdecf9 some more colouring based on folder prefs override 2016-12-11 17:44:32 +00:00
Paul 5f607a33a7 fix colouring of auto-filled headers 2016-12-11 10:04:30 +00:00
wwp d21adbda39 Make last colors configurable using hidden prefs: tags bg/fg colors in
message view, default-to header field in compose view, and quicksearch
active + error.
2016-12-09 17:42:46 +01:00
wwp 627f7110c9 Revert "Remove dead code, this changed signal doesn't exist and we've also".
This reverts commit fe0f832b37.
2016-12-09 16:26:21 +01:00
wwp fe0f832b37 Remove dead code, this changed signal doesn't exist and we've also
probably removed parts of the highlight-active-account field feature
a while ago.
2016-12-09 16:21:29 +01:00
Andrej Kacian 08916bffe4 Fix more compile warnings for Windows in socket.c. 2016-11-24 21:03:34 +01:00
Paul e7206c0db7 don't ignore auto-account selection when forwarding on IMAP and NNTP accounts
patch by Blatinox
2016-11-22 09:52:06 +00:00
Andrej Kacian 0fec6a07b6 Improve plural handling of a file insert string.
Fixes bug #3711.
2016-10-10 20:29:47 +02:00
Andrej Kacian a48bc28223 Removed a superfluous debug_print() call. 2016-10-02 19:04:57 +02:00
Andrej Kacian 8eb1faa9d4 Remove useless code from e22cbed.
References header was already being honored in drafts.
2016-10-02 00:11:56 +02:00
Andrej Kacian e22cbed1fc Do not add Message-ID for draft, unless it already has one.
We now add a Message-ID header only when queuing a message,
and we honor existing Message-ID and References headers in
drafts, if there are any.
2016-10-01 23:41:19 +02:00
Andrej Kacian 8d93e8c8cd Make Message-ID string generation less confusing.
Instead of having to prepare one part, then second
part in advance and pass them to generate_msgid()
which does its own voodoo with them, we now just pass
a pointer to PrefsAccount to
prefs_account_generate_msgid(), and it does all of it
on its own, returning pointer to a newly allocated
string.
2016-10-01 16:22:44 +02:00
Paul e070e40476 add hidden pref 'reqrite_first_from'
'0' or '1'. This works around a limitation of some servers with
'overly-liberal parsers'. When this is turned on and the Content-
Transfer-Encoding is set to 8bit or 7bit, in a message body starting
with 'From ' the 'From ' will become '=46rom ' and the
Content-Transfer-Encoding will be changed to Quoted-Printable. When it
is turned off no such modification will be made but it is very likely
that an MTA will convert the 'From ' to '>From '. See RFC 4155 for
further details. Default value is '1', turned on.
2016-09-26 10:59:43 +01:00
Andrej Kacian 04456e3b73 Make filesel API more consistent.
One of the functions, filesel_select_multiple_files_open(),
was missing the path parameter.
2016-08-28 20:11:03 +02:00
Ricardo Mones a22303ce00 Fix bug #3515: Ctrl-Shift-X opens multiple external editors
This a known GTK+ bug (passing keypresses of disabled menus) or
a mising feature (not providing a way to disable also keypresses).

See https://bugzilla.gnome.org/show_bug.cgi?id=656158
2016-08-24 12:14:28 +02:00
Ricardo Mones 3a89a270fc Fix bug #2975: Implement setting -0000 timezone to hide sender localtime
This adds a new hidden preference, namely 'hide_timezone', that
sets the timezone of date fields sent over the network to the
unknown timezone value as specified in RFC 5322 §3.3.

Default value is false (i.e., send available timezone information).
2016-08-22 19:02:47 +02:00
Ricardo Mones adf00727b0 Fix some debug messages and update headers 2016-07-29 00:59:11 +02:00
Paul 2011344224 fix bug 2518, ' "Reply-All" message from NNTP-account does not contain CC'ed correspondents' 2016-07-04 15:58:06 +01:00
Paul cdb37a1570 include Reply-To value when using 'reply to all' 2016-07-04 12:21:29 +01:00
Andrej Kacian 14b55b5122 Make procmime_mimeinfo_free_all() zero the passed pointer.
The function's argument type changes from MimeInfo* to MimeInfo**,
so that we can zero out the pointer.

This closes bug #3610, reported by Hanno Boeck.
2016-02-08 18:28:08 +01:00
Paul 9a84275f94 automatically use external editor on fwd-as-attachment if option is set 2016-01-29 13:33:25 +00:00
Andrej Kacian d0c7241757 Remove the outer scrollbar from header area.
This means the sender address line, with account
selector is always visible.
2016-01-28 20:13:45 +01:00
Andrej Kacian bfb18150ef Make procmsg_msginfo_free() zero out pointers to freed memory.
The function's argument type changes from MsgInfo* to MsgInfo**,
so that we can zero out the pointer.

This closes bug #3598, reported by Hanno Boeck.
2016-01-23 16:45:02 +01:00
Paul 6eb02a5598 fix bug 2358, '"Disposition-Notification-To:" should default to same value as "From:' 2015-12-28 19:12:33 +00:00
Paul 225ab1ccaf call 'new' address book 'alternate' address book 2015-12-07 10:40:25 +00:00
Ricardo Mones 388820da80 Adjust menus for external embedded editor 2015-11-24 11:41:32 +01:00
Ricardo Mones a5bd5e1504 Bug #2355: don't send while external editor is open 2015-11-24 10:26:18 +01:00
Ricardo Mones 8b99c246a1 Fix bug #2355: Embedding external editor through GtkSocket
Original patch by David Schneider, updated by Darko Koruga,
Also added emacs command as suggested by Marcel van der Boom.

Many thanks to all of them! :-)
2015-11-23 20:07:24 +01:00
Paul 5a62dd7ed4 more sanitizing of translatable strings 2015-11-15 12:59:23 +00:00
Paul 129afc04be remove the internally used plus symbol from the translatable strings 2015-11-14 10:36:49 +00:00
Colin Leroy ea54e7760f Fix unchecked return value 2015-10-08 19:13:17 +02:00
Ricardo Mones 98b12b276f Remove line breaks from g_warning() 2015-10-01 22:05:12 +02:00
Ricardo Mones 5ef1df1e1b Fix bug 2458 “Option to force header type to pre-defined-only”
As suggested by the comments in the report this  adds a new
hidden preference namely 'type_any_header', which controls
the editable status of the compose header entries.

For RELEASE_NOTES: the option is set to FALSE by default, so it
changes current default behaviour.
2015-08-09 11:33:42 +02:00
Andrej Kacian 3b14f47606 Fixed handling of drag&drop onto compose text area on Windows.
Fixes bug #3475.
2015-07-25 14:02:33 +02:00
Andrej Kacian 0158a5105c Make right-click behavior more intuitive in compose attachment list. 2015-07-09 12:31:22 +02:00
Ricardo Mones f3d84861e4 Fix build with hardened compiler flags
Error was:
compose.c: In function 'compose_write_to_file':
compose.c:5782:5: error: format not a string literal and no format
arguments [-Werror=format-security]
     alertpanel_error(msg);
     ^
cc1: some warnings being treated as errors
Makefile:1430: recipe for target 'compose.o' failed
make[6]: *** [compose.o] Error 1
2015-07-09 03:17:16 +02:00
Andrej Kacian a36b173660 Get rid of last remaining "struct stat" variables.
GStatBuf is used instead.
2015-06-29 11:44:13 +02:00
Andrej Kacian eb9beace00 Handle an unlikely fopen failure in compose_write_to_file() 2015-06-25 17:58:50 +02:00
Andrej Kacian a7c0255395 Encrypt message just before writing it to queue dir.
This fixes bug #2965.
As a side effect, if "Save sent encrypted messages as clear text" is
enabled, a copy will be saved to outbox when queuing, not when sending.
2015-06-25 13:01:58 +02:00
Andrej Kacian f061b67c93 Use 'GStatBuf' instead of 'struct stat' type where possible. 2015-06-05 13:33:32 +02:00
Ricardo Mones 6fc7c18a81 Switch core from strerror to g_strerror 2015-05-18 22:42:37 +02:00
Andrej Kacian 9cf5b73b47 Compose window: Fix bug #3421 - Recipients list doesn't scroll when moving with arrow keys. 2015-04-22 18:31:46 +02:00
Paul b6a112c69c Mac-Cyrillic menu updates. patch by Anton Butanaev 2015-01-26 05:03:29 +00:00
Paul 72dbf64f39 add support for x-mac-cyrillic encoding.
patch by Anton Butanaev.
2015-01-19 09:21:52 +00:00
Colin Leroy 2fc36b1cd4 Better fix for bug #3349 (almost all the needed code was there :-) 2014-12-19 16:23:00 +01:00
Ricardo Mones ff2f663ebc Improve feedback to user when bug #3349 2014-12-17 17:08:15 +01:00
Paul 9f4528e13e when cancelling a msg written with an external editor, get rid of the draft copy. thanks to Darko Koruga. 2014-12-09 10:46:49 +00:00
Andrej Kacian e19ba17f94 Compose window: Change Subject mnemonic from 's' to 'u', since 's' is already used by Spelling menu. 2014-12-09 10:14:40 +01:00
Andrej Kacian fcd8492f73 Compose window: sender address line gets its own label with a mnemonic, similar to Subject line. 2014-12-08 23:08:29 +01:00
Andrej Kacian e746281f5f Compose window: activating the GtkEntry with sender address activates the account selection combobox. Closes bug #3345, reported by Barry Warsaw. 2014-12-07 22:33:26 +01:00
Andrej Kacian a2068001ee Use GLib's implementation of Base64 instead of our own. 2014-11-15 19:59:29 +01:00
Paul 8c7418e621 add Reply-To to template config 2014-09-03 11:49:17 +01:00
Andrej Kacian 18d334146b Fix b976c1d by actually having a mnemonic char in the Subject label, so alt+s works. 2014-06-22 02:09:12 +02:00
Andrej Kacian 8e65767973 Added comments explaining the use of gtk_container_set_focus_chain(), for future generations. 2014-06-18 21:10:51 +02:00
Andrej Kacian 7975defae6 In compose window, prevent account selection combobox to get focus when navigating widgets using arrow keys. Closes bug #3216. 2014-06-18 21:03:54 +02:00
Andrej Kacian 3fc9e21801 Revert "Make Up key bring focus to Subject line, if the cursor is on the first line of body textview." 2014-06-18 13:13:36 +02:00
Colin Leroy 04314da118 Drop old unsupported GTK+ conditionals too 2014-06-10 11:18:48 +02:00
Colin Leroy 767368e898 More Coverity fixes 2014-06-05 21:29:31 +02:00
Ricardo Mones 0fff967430 Fix “File (null) doesn't exist” error dialog
When attaching a non-existing file via --attach
2014-05-29 01:18:59 +02:00
Colin Leroy 78965aa3b7 Add a per-account preference to allow automatically accepting unknown
and changed SSL certificates, if they're valid (that is, if the root CA
is trusted by the distro).
2014-05-28 21:18:34 +02:00
Colin Leroy 7c1bb13b90 Fix the race fix, now preventing the compose window to be closed. 2014-05-28 20:23:33 +02:00
Colin Leroy 5e1e3a0cb3 Better place to remove the draft callback, where we hold the mutex 2014-05-23 11:37:26 +02:00
Colin Leroy f19a85fc67 Remove draft_timeout_tag too before destroying 2014-05-23 11:29:16 +02:00
Colin Leroy a873d8f791 Better solution than a global function call, use our hook infrastructure
(with minor modifications for moving)
2014-05-22 22:46:07 +02:00
Colin Leroy 6086f18b85 Fix bug #2447, "Compose window crashes if moving a folder that is being replied to". Also constify compose_get_compose_list() 2014-05-22 22:11:07 +02:00
Colin Leroy 0dbb415b36 Fix Undo after wrapping a paragraph, which undid every line wrap one by one, and make it atomic. 2014-05-22 20:57:01 +02:00
Colin Leroy eba3ff6f6f Fix bug #2179, "Improve quotation wrapping support": Make manual wrapping also wrap quotes. 2014-05-22 15:40:24 +02:00
Colin Leroy ab2c7af982 Don't go up in subject if we're selecting 2014-05-14 15:55:42 +02:00
Andrej Kacian 668e757b05 Use the GtkPaned's position value to store compose_notebook_height, since setting this position is what we're using it for now. Since GtkPaned doesn't have any "resize done" signal available, we have to do it in the notebook's "size-allocate" callback. 2014-05-12 19:03:19 +02:00
Andrej Kacian a5a0678195 Make Up key bring focus to Subject line, if the cursor is on the first line of body textview. 2014-05-12 18:39:29 +02:00
Andrej Kacian b976c1dc26 Add a mnemonic to compose window's Subject line, allowing alt+s to bring focus there. 2014-05-12 18:36:43 +02:00
Andrej Kacian f7b5879924 Do not allow the compose window's slider between headers and body to hide widgets on either side. 2014-05-11 21:39:51 +02:00
Colin Leroy 5ff93b4877 Fix typo 2014-05-02 10:03:18 +02:00
Colin Leroy 46a3424081 Fix g_timeout usage 2014-05-02 09:54:52 +02:00
Colin Leroy 8880d1a999 Fix bug #2398, "Race when closing compose during drafting"
Thanks to Michael Schwendt for spotting the problem.
2014-04-30 22:48:13 +02:00
Colin Leroy 1e30bfc631 Fix most of the leaks referenced in bug #3155 2014-04-28 12:28:42 +02:00
Colin Leroy 55f26ba283 Change the blueness in Drafts folders to saving drafts as New. It makes
the folder noticed too, but the user can mark the draft as read if he
desires.
2014-04-25 12:24:54 +02:00
Colin Leroy d6156962e2 Fix bug #3120, "Error - file is empty" when redirecting a mail with
an empty part: ask for confirmation when attaching an empty file,
apart in batch mode where no confirmation is asked.
2014-03-25 09:06:14 +01:00
Paul 6469d5311a don't reply to self when doing reply to all 2014-03-20 08:46:38 +00:00
Paul e9b16bfa80 combine xmailer/xnewsreader header options into one, using generic term "user agent" 2014-02-05 09:09:20 +00:00
Paul 0b253d9527 implement RFE bug 3053, 'Can't add "replace signature" to the toolbar' 2014-02-03 14:03:17 +00:00
Paul 84ef4ef55f add option 'Generate X-Newsreader header' for NNTP accounts and complete the 'Generate X-Mailer header' option 2014-02-03 13:16:00 +00:00
Colin Leroy 02b5ac9ed2 Add preference to allow disabling automatic drafting of encrypted
messages.
2013-12-20 11:53:18 +01:00