gfgit/claws-mail
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
9634 commits 7 branches 0 tags 60 MiB
Commit graph

7808 commits

Author SHA1 Message Date
Ricardo Mones
b453ee32de Remove more line breaks from g_warning() 2016-07-29 20:21:05 +02:00
Ricardo Mones
adf00727b0 Fix some debug messages and update headers 2016-07-29 00:59:11 +02:00
Andrej Kacian
ce7c6f57c6 Only enable "New Book" context menu entry for internal addressbook. 
It was confusing to have it active on e.g. LDAP server interface,
when it really only adds a new XML addressbook.

Also, do not enable the "New" button when right-clicking the XML
addressbook interface line, as the button doesn't do anything
useful for interfaces.
 2016-07-28 23:02:04 +02:00
Andrej Kacian
b848e66f91 Fix sensitivity of "Delete book" menu entries in addressbook. 
Now it's possible to delete a read-only address datasource
via popup menu.
 2016-07-28 22:54:31 +02:00
Ricardo Mones
5164fae34b Remove also unused struct member 2016-07-28 13:55:09 +02:00
Andrej Kacian
8959d16e49 Remove the (now unused) master_passphrase_change plugin function. 2016-07-28 13:12:03 +02:00
Andrej Kacian
ca90fcd9d2 Do not run config update routine on first run. 
The newly created configuration is already up to date.
 2016-07-28 11:38:32 +02:00
Paul
6dba6cdee2 Improve label 2016-07-27 22:05:20 +01:00
Ricardo Mones
9e4a3265d7 Handle configuration versions from the future 2016-07-27 16:46:22 +02:00
Andrej Kacian
4d766fb1d2 Embarrassing typo fix in rssyl_subscribe(). 2016-07-23 23:02:55 +02:00
Andrej Kacian
d0f52e970e Added working_directory parameter to execute_command_line() 
It gets passed as a first argument to g_spawn_sync/async.
Mostly NULL, since that's what was passed until now, but
bsfilter plugin on Windows needs to change to installation
directory (startup_dir).
 2016-07-23 22:41:04 +02:00
Andrej Kacian
e66778e76d Updated plugins' claws.def files for win32 build. 2016-07-23 21:40:02 +02:00
Paul
ce6fea08ce replace another: "pixel(s)" -> "pixels" 2016-07-23 15:20:20 +01:00
Paul
1d75fbdbf9 another one (see last commit) 2016-07-23 15:17:30 +01:00
Paul
79d0dc212a standardise singlular/plural mix on labels 2016-07-23 14:57:07 +01:00
Ricardo Mones
f6769c0ac6 Use current style of preferences for time fields 2016-07-23 13:09:49 +02:00
Ricardo Mones
60b6b8ef14 Make label more readable 2016-07-23 12:13:50 +02:00
Ricardo Mones
72a45f97e6 Update copyright headers for previous commit 2016-07-23 03:00:00 +02:00
Ricardo Mones
bc779dcb02 Fix bug #2176: autochk_interval granularity is low 
This also fixes Debian bug “Please increase mail auto check period.”
See: https://bugs.debian.org/712758

Former bug wanted sub-minute granularity and latter the opposite: just
check a few times a day, so this allows user to specify also hours and
seconds in addition to existing minutes to address both requests.

Checking range was from 1 minute to 1 hour 40 minutes and now is
extended to a range from 10 seconds to 100 hours minus one second.

Default for new configurations is preserved (10 minutes).

Configuration version is raised to 2 for migrating existing values
from minutes to seconds.
 2016-07-23 02:59:21 +02:00
Andrej Kacian
00f51a67e4 Remove last outside gtk_cmclist_freeze/thaw for summaryview&folderview ctrees. 
More code maintenance to isolate summaryview and folderview
widgets' internals behind an API.
 2016-07-22 20:50:25 +02:00
Paul
5f96d48923 remove unnecessary 'Encoding' frame 2016-07-22 18:08:00 +01:00
Paul
ab032e23e8 Remove unneeded 'Other' from View/Go to/Other folder... 2016-07-22 17:56:20 +01:00
Ricardo Mones
ef0eeb2d41 Reorganise send options a bit 
Also remove '(Recommended)' from selector, as that's already
mentioned in the tooltip.
 2016-07-22 14:14:37 +02:00
Andrej Kacian
dbad2967a2 Further improve API isolation of folderview. 
This commit gets rid of all outside access to "opened" and
"selected" struct members, and lot of outside access to
"ctree" member.

Additional work still needed. :)
 2016-07-21 22:32:37 +02:00
Andrej Kacian
96ca00e6bc Use folderview_grab_focus() outside of folderview.c. 2016-07-21 12:12:40 +02:00
Andrej Kacian
4306c9eaa2 Use folderview_freeze/thaw() functions outside of folderview.c. 
These are modeled after summary_freeze/thaw().
 2016-07-21 12:02:30 +02:00
Andrej Kacian
574ec56dde Make exit_claws() use folderview API and not reach inside _FolderView struct. 2016-07-21 11:54:36 +02:00
Andrej Kacian
3ed994a5e6 Remove unused GtkWidget* argument in stock_pix* functions. 
stock_pixmap_widget()
stock_pixmap_widget_with_overlay()
stock_pixbuf_gdk()
 2016-07-20 23:48:10 +02:00
Ricardo Mones
bbae17b7df Restore also size of toolbar arrows 
Thanks Paul for pointing those out!
 2016-07-20 19:01:33 +02:00
Ricardo Mones
6b72b03125 Restore size of toolbar trash button 
Default is 24x24 for toolbar buttons but this was unintentionally
shrinked more than a decade ago.
 2016-07-20 12:16:19 +02:00
Ricardo Mones
fbba86572f Fix warning about what directory cannot be open 2016-07-20 09:13:59 +02:00
Andrej Kacian
6274ab07d2 Fix up previous commit. 
Move the update_fonts check earlier, before the last_*font
pointers get modified.
 2016-07-19 11:48:17 +02:00
Andrej Kacian
28fe219b16 Do not repopulate folderview after account prefs save. 
The only reason to repopulate is if user's chosen fonts
change, and that cannot happen in account prefs.
 2016-07-19 11:09:22 +02:00
Andrej Kacian
6bc99f87ae Remove APOP and RPOP also from account prefs. 
This fixes up previous commit, 358e811.
 2016-07-18 21:23:52 +02:00
Andrej Kacian
358e811283 Remove obsolete A_APOP and A_RPOP account protocols. 
CLAWS_CONFIG_VERSION bumped to 1.
 2016-07-15 17:00:26 +02:00
Andrej Kacian
3b5b4f75dd Added config versioning. 
This allows us to change meaning of existing preferences,
without losing or mangling user data. Controlled by a common
pref "config_version", which is checked on startup after
reading all configuration. If this version is lower than
what is defined in CLAWS_CONFIG_VERSION, an upgrade is done
incrementally, from one version to the next and to the next,
so that all affected preferences are adjusted.
 2016-07-15 17:00:26 +02:00
Ricardo Mones
74b625c53e Update lists of authors 2016-07-14 11:59:22 +02:00
Ricardo Mones
4bee63af35 Fix bug #3573: Out of bounds read in macro LBREAK_IF_REQUIRED 
Thanks Hanno Boeck for the patch!
 2016-07-14 11:53:59 +02:00
Andrej Kacian
5e02bd982a When generating a PGP keypair, only ask for passphrase with gpg1. 
Also erase all copies of an entered passphrase from memory
when done. Closes bug #3658.
 2016-07-13 21:50:52 +02:00
Andrej Kacian
e454dd8d56 Simplify handling of gpg_ask_create_key pref. 2016-07-12 00:13:21 +02:00
Andrej Kacian
88d81f3035 Fix filesel dialog with filter for Win32. 
g_utf8_to_utf16() always stops on first null byte,
so we have to construct the "filter\0filter\0\0"
string for GetOpenFileName() manually.
 2016-07-11 23:53:34 +02:00
Andrej Kacian
cca1d5d3d1 Added --batch option to manual gpg executable calls. 
This, together with --no-tty, is to make these calls
really non-interactive, and helps against the calls
hanging on Windows occasionally.
 2016-07-10 14:57:16 +02:00
Andrej Kacian
38a69f674e Made exporting GPG key to keyserver work on Windows. 2016-07-10 14:55:48 +02:00
Andrej Kacian
6a20b48b44 Updated claws.def file for win32 build of notification plugin. 2016-07-07 18:24:41 +02:00
Ricardo Mones
cda0657547 Add forgotten block delimiters 
Thanks Paul for noticing!
 2016-07-04 18:45:53 +02:00
Paul
2011344224 fix bug 2518, ' "Reply-All" message from NNTP-account does not contain CC'ed correspondents' 2016-07-04 15:58:06 +01:00
Paul
cdb37a1570 include Reply-To value when using 'reply to all' 2016-07-04 12:21:29 +01:00
Paul
92c1a195b5 make 'next_on_delete' hidden pref apply after trashing or moving a msg in addition to deleting a msg 
fixes bug #3600.
document this hidden pref also
 2016-07-04 11:02:58 +01:00
Ricardo Mones
b2651d9e36 Warn on unsuccessful gpgme_set_engine_info calls 2016-07-04 11:00:35 +02:00
Paul
fd6e3082a8 modify 61f7c3c5e to catch another hardcoded gpg call 2016-07-04 09:25:46 +01:00
wwp
6295af1f95 notification plug-in: skip SMTP-only accounts when building the 
'Get mail from account' menu.
 2016-07-03 10:40:32 +02:00
Pawel Pekala
a5fb6aac0a Revert "Place dialogs on center of main window." 
This reverts commit cb67730a26.
 2016-07-02 20:12:02 +02:00
Pawel Pekala
cb67730a26 Place dialogs on center of main window. Most window managers place 
these dialogs in some weird positions making interacting with
them unwieldy. Windows is biggest offender here putting things
around left top corner of the screen.
 2016-07-02 18:05:14 +02:00
wwp
bc2c1d1d88 Add 'Get mail from account..' to notification plugin's trayicon menu. 2016-06-30 12:01:54 +02:00
Charles Lehner
9854220303 Allocate quoted-printable output buffer on heap 2016-06-27 13:52:57 -04:00
Charles Lehner
18292e3bbd Handle ical lines longer than 256 bytes 2016-06-27 10:29:18 -04:00
Charles Lehner
8c8e1a90e7 Indent html in blockquotes 2016-06-24 23:26:29 -04:00
Charles Lehner
145bcd5c60 Line break after <dd> 2016-06-24 17:36:27 -04:00
Ricardo Mones
804af9b079 Fix bug #3652 “warning: ordered comparison of pointer…” 2016-06-16 16:28:54 +02:00
Pawel Pekala
aafdc441c2 Implement focused widget saving between iconify/deiconify events in 
trayicon notification. Without this focus is lost on deiconify and this
can be painful to keyboard users. This is similar to my old work on
trayicon plugin I've done in the past.
 2016-06-09 20:59:37 +02:00
Ricardo Mones
4bb9ba0e83 Use Unicode, don't restrict ourselves to ASCII 2016-06-02 11:17:49 +02:00
Charles Lehner
1805e09547 Indicate list items in html 2016-06-02 00:21:55 -04:00
Andrej Kacian
3b6d06fd7a Fixed calculation of timing.h timer for Windows. 2016-05-30 13:01:22 +02:00
Andrej Kacian
31a9c52a28 Fix --select CLI option on Windows when selecting a particular message. 2016-05-28 19:54:51 +02:00
Andrej Kacian
54ce0e858a Use PBKDF2 to derive encryption key for passwords. 
...instead of my previous hash-then-xor nonsense.
 2016-05-24 18:30:44 +02:00
Paul
8ceef647fc fix crash introduced in c7e1e0bbdf 2016-05-24 14:20:52 +01:00
Andrej Kacian
f7b5405def Moved getting random bytes into a separate get_random_bytes() function. 2016-05-20 12:30:57 +02:00
Andrej Kacian
a451a77a45 Remove imap_use_trash account preference. 
Disabling this preference made deleting messages behave
incorrectly - they were marked for deletion regardless
of whether "delete" or "move to trash" was used, and
these actions were not executed immediately, regardless
of "immediate_execution" common preference.
 2016-05-18 17:20:13 +02:00
Paul
c7e1e0bbdf remove matcherrc.pre_names migration. 10 years later, we'll assume everyone has been migrated 2016-05-16 17:02:53 +01:00
Andrej Kacian
c4ebc9dacb Improve plural handling for "Delete message" dialog. 2016-05-06 19:43:16 +02:00
Andrej Kacian
c4a67908ff Made manual GPG key import work on Windows. 2016-05-03 09:28:10 +02:00
Andrej Kacian
61f7c3c5e7 Ask GpgME for path to gpg executable for manual key import. 2016-05-03 09:28:10 +02:00
Ricardo Mones
37794f6a74 Fix frequently ocurring typos :) 2016-05-01 16:56:18 +02:00
Ricardo Mones
437f56ed66 Fix some typos in perl plugin's manpage 2016-05-01 16:51:10 +02:00
Andrej Kacian
758a6b1256 Fix behavior in selecting PGP MIME signature on Windows. 
With old argument order, gpgme_op_verify() returned "empty signature"
error on Windows, for reasons unknown.
 2016-04-28 12:01:10 +02:00
Andrej Kacian
fc35f5b0e9 Use correct dir separator for "Scanning folder ..." in statusbar. 2016-04-26 10:21:22 +02:00
Andrej Kacian
e895ed1467 More fixes for the Windows native file choosers. 
Filter string should be terminated with two nuls.
Save dialog did not show for message parts which have no
attachment name.
 2016-04-22 20:04:02 +02:00
Andrej Kacian
61383c66ea Disallow folder names ending with a space on Windows. 
Closes bug #2781.
 2016-04-22 13:31:41 +02:00
Andrej Kacian
f324ae742a Make Windows native file/dir choosers work with non-ASCII characters. 
Also, make the save chooser supply the correct attachment
file name by default, just like the GTK+ one does.
 2016-04-22 10:05:57 +02:00
Andrej Kacian
3f96e4596d Use native file and folder selection dialogs on Windows. 
This is done by compiling in src/gtk/w32_filesel.c instead of
filesel.c on Windows. The Makefile.am logic mirrors the one from
src/common/.
 2016-04-16 21:30:19 +02:00
Andrej Kacian
e630ef9df0 Show duration of PBKDF2 computation in debug output. 2016-04-11 18:30:18 +02:00
Andrej Kacian
1da0623169 Make double-click open edit dialog also for addressbook datasources. 
For example, LDAP servers.
 2016-04-10 00:57:15 +02:00
Andrej Kacian
c3345bcdef Prevent an unlikely crash during RSSyl feed properties save. 
This is just to shut Coverity up, I don't think it could
ever crash this way.
 2016-04-09 18:06:26 +02:00
Andrej Kacian
8d59235e93 Addressbook now uses password store for LDAP passwords. 2016-04-09 18:03:01 +02:00
Andrej Kacian
39a8fb83ee Remove password from passwordstore when deleting a RSSyl feed. 2016-04-09 15:43:02 +02:00
Andrej Kacian
c093e11acb Update passwordstore if RSSyl feed's URL gets changed. 2016-04-09 15:28:06 +02:00
Andrej Kacian
605671c5d1 Fix crash on deleting password from passwordstore. 2016-04-09 15:21:13 +02:00
Andrej Kacian
1f8a15286c Remove obsolete comment in RSSyl's OPML import. 2016-04-09 12:01:54 +02:00
Andrej Kacian
7c87afdcbc Fix parsing logic in RSSyl OPML import. 
Possibly closes bug #3623.
 2016-04-09 10:57:48 +02:00
Andrej Kacian
5b146e9eaa Close PRNG source after reading our PBKDF2 salt from it. 2016-04-08 14:50:45 +02:00
Andrej Kacian
ffd418aaa7 Use PBKDF2 with HMAC-SHA1 for master passphrase in clawsrc. 
The 64 bytes long key derivation is stored in 'master_passphrase'
pref, together with number of rounds used in its computation.

Introducing also two new common prefs:
master_passphrase_salt - holds a randomly generated 64 bytes
  for use as salt with PBKDF2. Base64-encoded.
master_passphrase_pbkdf2_rounds - number of rounds (or
  iterations) for next passphrase key derivation

The latter can be tweaked by user in case they want to use more
or less rounds, e.g. if they're running on weaker hardware and
KD with default number of rounds takes too long.
 2016-04-08 10:05:37 +02:00
Andrej Kacian
e63f8db4c7 Added PBKDF2 implementation, copied from OpenBSD. 2016-04-08 10:05:37 +02:00
Andrej Kacian
b998857198 Update plugins' claws.def filess for Windows build. 2016-04-06 14:53:57 +02:00
Andrej Kacian
75dba924fd Remove unneeded plugin_master_passphrase_change(). 2016-04-06 14:53:37 +02:00
Holger Berndt
3404740af6 Python plugin: Add set_header_list() function for ComposeWindow objects 2016-04-05 21:16:04 +02:00
Andrej Kacian
497cfad48d RSSyl: zero out password variables after migration to password store 2016-04-02 17:07:35 +02:00
Andrej Kacian
08ed4047b2 Make RSSyl plugin use the password store. 2016-04-02 17:01:44 +02:00
Andrej Kacian
7789c3acba Move RSSyl plugin name to a macro. 2016-04-02 17:01:44 +02:00
Ricardo Mones
a1bb5a0004 Fix some odd debug outputs 2016-04-02 15:41:04 +02:00
wwp
0a55c9ba37 Make use of GNUTLS_CFLAGS to compile. 2016-04-01 13:49:26 +02:00