Andrej Kacian
c02b6cb1d9
Do not try to expand a childless folderview row on right arrow keypress.
2015-10-21 11:33:04 +02:00
Andrej Kacian
22b147d793
Slightly more complete fix for the keyboard selection in summaryview.
...
Now it also handles PageUp/Down properly, although it's not pretty.
2015-10-20 23:08:00 +02:00
Paul
9e163b4bbc
implement RFE 3545, 'Support to view encrypted (password protected) PDF'
2015-10-20 13:33:33 +01:00
Paul
a98e7f2de2
define tags dir where all the others are
2015-10-19 17:15:53 +01:00
Andrej Kacian
4b812fcb03
Add a forgotten RSSyl: prefix to log_print message from previous commit.
2015-10-19 16:55:16 +02:00
Andrej Kacian
aeb5b6ad61
RSSyl: Accept feeds with no title. Closes bug #3480 .
2015-10-19 16:53:32 +02:00
Andrej Kacian
966533831c
In folderview, Enter key opens the selected folder immediately.
...
...instead of expanding it to see its subfolders.
Closes bug #3541 .
2015-10-19 09:52:05 +02:00
Andrej Kacian
ce08ae91d0
Fix Shift+arrowkeys selection behavior in summaryview.
...
This fixes bugs #1959 , #2490 (unselected lines still
appearing as selected), as well as #3513 .
2015-10-18 02:46:40 +02:00
Paul
c014711110
fix erroneous debug text, debug output (and style)
2015-10-15 07:28:47 +01:00
Paul
a04d186bb8
fix format warnings and some OpenBSD specific fixes
...
Patch by Daniel Jakots.
2015-10-14 18:14:17 +01:00
Paul
7c605b01f4
remove vanity labelling
2015-10-14 18:10:43 +01:00
Paul
e3265d1d26
fix menu item reference
2015-10-14 18:10:13 +01:00
Paul
7a36263d6b
fix a format warning, thanks to Daniel Jakots
2015-10-12 19:25:20 +01:00
Paul
9cd558c535
fix building on OpenBSD, thanks to Daniel Jakots
2015-10-12 19:20:01 +01:00
Paul
48d8a4066d
add (currently?) hidden pref for choosing to go to older/newer msg on delete
2015-10-12 18:56:06 +01:00
Paul
76f1303d66
update i18n
...
updates from: David Vachulka, Thomas Bellmann, Flammie Pirinen,
Genghis Khan, Páder Rezső, Luigi Votta, Marcel Pol, Frederico Goncalves
Guimaraes, Slavko, Andreas Rönnquist, Mark Chang
Re-addded newly maintained translations: it, zh_TW
Dropped unmaintained translations: id_ID, pl
2015-10-11 08:56:10 +01:00
Andrej Kacian
78c851a541
Updated plugins' symbol list files for Windows build.
2015-10-11 02:11:48 +02:00
Michael Rasmussen
5bc11591f1
Fix buffer overrun
2015-10-09 19:06:57 +02:00
Colin Leroy
72f85216a0
Fix missing check
2015-10-08 19:23:15 +02:00
Colin Leroy
84f1556050
Fix missing check
2015-10-08 19:22:06 +02:00
Colin Leroy
8b44c9d2c4
Fix resource leak
2015-10-08 19:18:53 +02:00
Colin Leroy
6fd294c50f
Fix null pointer dereferences and missing return checks
2015-10-08 19:16:52 +02:00
Colin Leroy
ea54e7760f
Fix unchecked return value
2015-10-08 19:13:17 +02:00
Colin Leroy
542c66f3f8
Fix null pointer dereference
2015-10-08 19:08:42 +02:00
Colin Leroy
47d362fb39
Fix possibly not null-terminated string
2015-10-08 19:08:23 +02:00
Colin Leroy
0bc73a08fc
Fix possibly non-null-terminated string
2015-10-08 19:03:00 +02:00
Colin Leroy
9af27fcb9c
Fix TOCTOU (time-to-check, time-to-use) race
2015-10-08 18:59:49 +02:00
Colin Leroy
ae5935f8ea
Fix possible overrun
2015-10-08 18:58:54 +02:00
Colin Leroy
accc3f6a7b
Fix wrong variable in for loop
2015-10-08 18:49:45 +02:00
Colin Leroy
9dbc2cbc46
Remove unused field
2015-10-08 18:47:24 +02:00
Colin Leroy
6fcc0e06c5
Fix theoretical off-by-one (which should never happen)
2015-10-08 18:39:33 +02:00
Colin Leroy
985a56cfaf
Fix off-by-one.
2015-10-08 18:34:00 +02:00
Ricardo Mones
e98adf35bc
Fix bug #3263 ‘Wrong timezone while using date_fmt function’
...
In addition of %z for timezone offset, the strftime allows also a %Z
specifier for timezone name and also some modifiers and field width.
All these specifier are detected now and ignored, appending the timezone
on the message. Otherwise they would be passed to the strftime call as
is, which uses the local timezone, wrong most of the time.
2015-10-05 11:47:11 +02:00
Christian Hesse
904dc0783c
msg is not const
...
Signed-off-by: Christian Hesse <mail@eworm.de>
2015-10-03 23:34:15 +02:00
Paul
66d1996ab0
move 'delete thread' to Message menu, fix it's name (trash thread) and add a real delete thread item
2015-10-03 11:05:06 +01:00
Paul
d3d6ac6eff
fix bug 3531, 'a/z hotkeys crash Claws immediately after startup'
2015-10-02 17:37:51 +01:00
Paul
3c64fb648d
remove dead GeoLocation plugin
2015-10-02 08:56:00 +01:00
Ricardo Mones
76b854fd5e
Fix bug #3524 ‘vCard does not decode all quoted-printable values’
...
Support vCard 2.1 variants with UTF-8 charset and/or encoding type
parameters, which were deprecated in vCard 3.0, but are currently
being used in some smartphone contact list exporters.
2015-10-01 22:08:35 +02:00
Ricardo Mones
8780b1f666
Fix bug #3516 ‘vCard icon misplaced’
...
The icon was too big for the tree. Surrounding whitespace has been
removed to fit at least as better as the others used on the AddressBook.
2015-10-01 22:07:49 +02:00
Ricardo Mones
e6aa883794
Fix bug #3526 ‘autoconfiguration: get more detailed error message’
...
Based on original patch by Christian Hesse (thanks!).
2015-10-01 22:06:15 +02:00
Ricardo Mones
98b12b276f
Remove line breaks from g_warning()
2015-10-01 22:05:12 +02:00
Paul
307fff3eba
make 'date' (not thread date) the default sort when clicking column header to switch to date sort
2015-10-01 15:53:33 +01:00
Ricardo Mones
f20d6e2a1b
Archiver: remove unnecessary allocations
2015-09-29 19:15:20 +02:00
Christian Hesse
2c54352ae2
Fix bug #3527 ‘autoconfiguration: move button below server type’
2015-09-29 19:13:15 +02:00
Ricardo Mones
d463671387
Do not translate g_warning() strings
...
They aren't for end user error reporting.
Also, remove needless line breaks inside.
2015-09-22 19:55:14 +02:00
Ricardo Mones
2c781ca221
Libravatar: remove hooks on failed init
2015-09-22 14:57:17 +02:00
Andrej Kacian
f54e21beba
Fix several memory leaks in RSSyl.
...
Patch by Darko Koruga.
2015-09-21 22:46:41 +02:00
Andrej Kacian
baa33ee12b
Remove unneeded Windows-specific code path in Notification plugin's trayicon popup menu callback.
2015-09-20 22:18:21 +02:00
Paul
30ac527285
modify label to give more clarity
2015-09-11 09:26:31 +01:00
Paul
f57d5ced55
modify label to give more clarity
2015-09-11 09:10:57 +01:00
Paul
02c24e9925
add UI for default sort key and type
2015-09-11 09:09:39 +01:00
Andrej Kacian
073b3b6e5c
Make IPv6 work on Windows, for connections not handled by libetpan.
2015-09-10 21:12:31 +02:00
Paul
9524293504
add prefs for default folder sort and direction, no ui yet
2015-09-09 16:54:57 +01:00
Christian Hesse
1207b105a4
Hidden preference to limit PGP autocompletion
...
Some keys have a lot of UIDs, resulting in a huge dropdown list. This
allows to limit PGP autocompletion to use the first n UID/address of a
key only.
2015-09-08 00:32:03 +02:00
Paul
71b8625f5d
when replying to our own msg, select the account that sent it
2015-09-04 18:09:19 +01:00
Andrej Kacian
9654c62175
Make Left and Right keys collapse and expand item under cursor if appropriate.
...
Left key also moves cursor to parent item, if current item is
already collapsed.
2015-09-01 10:28:18 +02:00
Andrej Kacian
97e8253eb3
Make Home and End keys work in folderview pane.
2015-09-01 03:00:39 +02:00
Andrej Kacian
8bc08f388d
Add a PrefsWindow callback for apply button, and use it for common preferences to save them to disk.
...
Fixes bug #3467 for "click Apply, then click Cancel" scenario.
2015-08-28 11:40:11 +02:00
Andrej Kacian
4cf741e58e
Use PrefsWindow's close_cb callback to save common prefs to disk, if OK or Apply button was pressed.
...
Fixes bug #3467 .
2015-08-28 11:39:49 +02:00
Andrej Kacian
f3593ce1b2
Added dialog_response member to PrefsWindow.
2015-08-28 11:38:05 +02:00
Andrej Kacian
f0cc04183e
Pass PrefsWindow pointer instead of GtkWindow to prefswindow's open and close callbacks.
2015-08-28 11:38:05 +02:00
Andrej Kacian
05a137be88
Moved struct and enum declarations from prefswindow.c to .h.
2015-08-28 11:38:05 +02:00
Christian Hesse
4721a112b0
Auto-configuration: set port only when not default
2015-08-28 11:24:44 +02:00
Paul
4f85809426
let's not suggest possible, not necessarily correct, solutions in debug output
2015-08-27 09:47:19 +01:00
Paul
e39993c0ed
add option to specify location of GnuPG executable
...
This allows the user to choose to use gpg rather than be forced to use
gpg2
2015-08-27 09:37:04 +01:00
Ricardo Mones
e111f1299d
Also fix #3209 on initial wizard
...
And remove unused variables while at it.
From original patches thanks to Christian Hesse!
2015-08-27 09:48:39 +02:00
Paul
6267b9b8a6
use the PACK_CHECK_BUTTON macro in prefs_gtk.h
2015-08-27 08:42:26 +01:00
Ricardo Mones
30afef9bb6
Fix cut-and-paste error
2015-08-27 07:54:09 +02:00
Ricardo Mones
9f60522740
Fix bug #3342 ‘"Automatically accept unknown valid SSL certificates" is unfortunate wording’
2015-08-26 13:21:09 +02:00
Ricardo Mones
87b3e7c74a
Fix bug #3209 ‘autoconfig does not use full email address as username’
...
If a provider supports Auto-Configuring it's likely to be using the
full email address as user ID, not the local machine $USER.
2015-08-26 11:05:15 +02:00
Charles Lehner
2ff4e385f8
Always check for GnuTLS ( fix #3507 )
2015-08-21 12:49:45 -04:00
Paul
fbf45e2aaf
do sgpgme_init() after prefs_gpg_init() because prefs are used in sgpgme_init()
2015-08-21 12:05:59 +01:00
Michael Rasmussen
f8f7de3c14
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
2015-08-20 20:23:14 +02:00
Michael Rasmussen
fefb4204bf
Reduce size of error message
2015-08-20 20:22:46 +02:00
Andrej Kacian
8f4236e282
Use getaddrinfo() instead of gethostbyname() in socket.c.
...
Closes bug #3253 , as we're trying all resolved addresses.
This should also make IPv6 work on Windows, bug #3495 .
2015-08-20 08:28:22 +02:00
Michael Rasmussen
1b32cc6794
Fix possible crash when gpg is upgraded to gpg-v21
2015-08-20 01:26:33 +02:00
Ricardo Mones
70782f3f2c
Libravatar: fix typo in label
2015-08-18 17:40:33 +02:00
Andrej Kacian
206f559c6f
Fix crash on double notification popup.
...
Patch by Richard Hughes. Closes bug #3496 .
2015-08-17 20:45:38 +02:00
Andrej Kacian
31806c2352
Improve how message body is quoted for reply/forward/etc.
...
Insert body_start and body_end text marks around quotable
message body, and quote that if user has not selected any text
to quote for their reply.
Closes bug #3483 .
2015-08-13 20:28:38 +02:00
Andrej Kacian
bf373b8226
Provide an up to date version of g_base64_decode() for older GLib.
...
Patch by Jean Diraison, closes bug #3473 .
2015-08-13 20:24:48 +02:00
Holger Berndt
b20b2b3508
Python plugin: Add Folder to MessageInfo objects
2015-08-12 20:14:17 +02:00
Colin Leroy
c1172c548a
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
2015-08-11 14:45:08 +02:00
Colin Leroy
f04aaa4cb1
Save temporary file in mime temporary directory when using right-click/Open image instead of saving in current working directory.
...
Also, save in home directory if attach_save_dir is not set.
2015-08-11 14:43:23 +02:00
Colin Leroy
229e17d5b7
Fix string leaks
2015-08-10 20:58:32 +02:00
Ricardo Mones
5ef1df1e1b
Fix bug 2458 “Option to force header type to pre-defined-only”
...
As suggested by the comments in the report this adds a new
hidden preference namely 'type_any_header', which controls
the editable status of the compose header entries.
For RELEASE_NOTES: the option is set to FALSE by default, so it
changes current default behaviour.
2015-08-09 11:33:42 +02:00
Colin Leroy
b4582cad28
Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws
2015-08-04 12:34:37 +02:00
Colin Leroy
9693e93d08
Fix bug #3352 , "found_in_addressbook matches entries from GPG keyring"
...
Only include GPG keyring in autocompletion when we're not completing
on a specific addressbook.
2015-08-04 11:01:04 +02:00
Andrej Kacian
200a466aad
Do not build libfeed if RSSyl plugin is disabled.
...
Closes bug #1544 , fix based on patch by Jean Diraison.
2015-08-04 10:08:49 +02:00
Andrej Kacian
4256dfbdc8
Remove broken reimplementation of a few Glib file functions.
...
This fixes bug #3454 , and probably a few more.
2015-08-03 23:28:07 +02:00
wwp
8d1abd7c17
Oops, added back one line, swallowed by 3.12.0-36, fixing address completion
...
again.
2015-07-31 07:18:09 +02:00
wwp
5eeace716a
Better fix for 3.12.0-35, thanks to Michael Rasmussen.
2015-07-31 00:17:10 +02:00
wwp
cf35c41153
Fix crash in address completion when matching group name.
2015-07-30 10:13:06 +02:00
Paul
b499a35e93
fix spacing around dictionary prefs
2015-07-30 08:47:23 +01:00
Paul
a6f69f305b
fix msg selection after delete/trash
2015-07-29 12:24:06 +01:00
Andrej Kacian
7171f9ebc5
Correct handling of RFC3339 format with second fraction.
...
Patch by Darko Koruga.
2015-07-28 01:11:41 +02:00
Andrej Kacian
b05f232613
Fix drag&drop attaching files with % in filename.
...
Closes bug #2115 .
2015-07-28 01:11:11 +02:00
Charles Lehner
e8fd963967
Remove use of G_SOURCE_REMOVE (convenience typedef)
...
Support GLib < 2.32
2015-07-27 15:11:24 -04:00
Andrej Kacian
3b14f47606
Fixed handling of drag&drop onto compose text area on Windows.
...
Fixes bug #3475 .
2015-07-25 14:02:33 +02:00
Paul
f0b7352b38
fix crasher when using descending sort and deleting a msg
2015-07-24 17:47:39 +01:00
Paul
3a0460c255
remove useless check
2015-07-24 15:17:40 +01:00
Paul
0cbcaf7e74
after deleting/trashing msg, select next msg depending on sort order
2015-07-22 09:50:18 +01:00
Charles Lehner
8be3195502
managesieve: read literals in chunks, not line-by-line
...
This adds a way to read data chunks with a known length from a Session, rather
than until a newline or terminator string is reached. It is used to let Sieve
scripts be loaded faster.
2015-07-21 21:34:16 -04:00
Charles Lehner
510d72d37d
managesieve: count script length in bytes, not characters
2015-07-21 21:16:02 -04:00
Charles Lehner
a5fcd7b5d7
managesieve: fix memory leak
2015-07-21 21:09:28 -04:00
Andrej Kacian
bd4e7f8520
Fix a small (copy&paste ?) typo in time zone parsing.
2015-07-21 14:33:48 +02:00
Charles Lehner
69d2e1d0e9
managesieve: ensure space above Refresh button
2015-07-20 22:42:16 -04:00
Charles Lehner
38ea0d67f5
managesieve: close windows when unloading
...
fixes crash on plugin unload
2015-07-20 22:31:01 -04:00
Charles Lehner
897a5ed724
managesieve: fix list header tooltip
2015-07-20 16:13:21 -04:00
Andrej Kacian
aab231b16f
Fix building on GLib older than 2.25.
2015-07-20 19:57:05 +02:00
Paul
06ba5f471b
add missing NL, sorry Marcel
2015-07-20 10:20:42 +01:00
Charles Lehner
3bedb72424
Fix typo in email address
2015-07-19 11:17:39 -04:00
Paul
de24d5dab1
update translators info
2015-07-19 11:26:52 +01:00
Paul
0f59e75fd3
remove translations that have been unmaintained for 3 releases
2015-07-19 11:07:28 +01:00
Paul
818e1ca6a6
add Charles to list of team members
2015-07-19 10:42:31 +01:00
Paul
bf1ab46a18
update translators list
2015-07-19 10:39:36 +01:00
Charles Lehner
de58cd700b
managesieve: prevent session list corruption
...
This fixes a crash on plugin unload with a connected session
2015-07-18 21:58:03 -04:00
Charles Lehner
7e1943d6b8
managesieve: Localize Rename button. Fix bug 3469
...
not breaking string freeze because the string is already translated and in use
2015-07-17 11:13:46 -04:00
Charles Lehner
cf7df0a057
managesieve: add back dialog hint
...
This makes the manager window appear floating in tiling window managers
This reverts commit e2d116a25f
.
2015-07-17 11:13:16 -04:00
Charles Lehner
cc334ab9de
managesieve: show warnings received when setting active script
2015-07-17 10:10:54 -04:00
Charles Lehner
c00d3332dd
managesieve: handle putting/checking empty scripts
2015-07-17 09:24:11 -04:00
Colin Leroy
a4e905df97
Fix missing null pointer check
2015-07-17 08:51:36 +02:00
Charles Lehner
53c39d90eb
managesieve: add newly created scripts to manager window list
2015-07-17 01:21:06 -04:00
Charles Lehner
7af42c87bc
managesieve: if new script name is in use, open existing script
...
This is better than opening a blank script which will overwrite the existing
one when it is saved
2015-07-17 01:21:05 -04:00
Charles Lehner
ec59ae0c2e
managesieve: let refresh button always be sensitive
...
When the session is disconnected, refresh can be clicked to try to reconnect.
This partially reverts commit 7c2dd3d976
.
2015-07-17 01:15:13 -04:00
Charles Lehner
f6bce6ab85
managesieve: remove unused function sieve_session_add_script
2015-07-17 00:00:53 -04:00
Charles Lehner
81acf6b893
managesieve: don't reset status while appending text
2015-07-16 23:51:00 -04:00
Charles Lehner
367d6a780e
managesieve: discard manager window's callbacks when it closes
2015-07-16 23:29:51 -04:00
Charles Lehner
dde1c4531b
managesieve: consolidate popping send queue
...
- send a queued command when the ready state is entered
- always free a command when it is done
2015-07-16 23:29:51 -04:00
Charles Lehner
ee78106024
managesieve: fix connecting with TLS not available
2015-07-16 23:29:51 -04:00
Charles Lehner
dc1d2b4ed5
managesieve: allow script loading to be interrupted
...
Prevent use after free when an editor window is closed while loading
Uses string "Loading..." which is already translated
2015-07-16 23:28:37 -04:00
Charles Lehner
32924ce7e8
managesieve: fix command aborting and discarding
...
- Add "aborted" callback argument to indicate command is cancelled
- Add helper function for issuing command callbacks
2015-07-16 23:24:32 -04:00
Charles Lehner
99738a91f6
managesieve: Fix string memory leaks
2015-07-16 22:27:20 -04:00
Charles Lehner
cf75891c80
managesieve: handle lines starting with "OK"
...
Count octets instead of waiting for OK
2015-07-16 18:22:05 -04:00
Paul
8e72324cbc
revert the revert
...
because, as Charles pointed out, this string is already present in
compose.c, therefore, technically, it's not a new string
2015-07-16 18:46:49 +01:00
Charles Lehner
7d58732990
Remove extravagant debug message
2015-07-16 08:39:47 -04:00
Paul
4e7ed5bd38
revert without breaking stuff
...
(fix for last commit)
2015-07-16 12:55:24 +01:00
Paul
65f1e6e443
revert, it's string-freeze right now
2015-07-16 12:53:23 +01:00
Andrej Kacian
988ae8b83f
Fix address autocompletion popup not displaying on Plasma5.
...
Closes bug #3466 .
2015-07-16 13:36:26 +02:00
Charles Lehner
e2d116a25f
managesieve: remove dialog hint
2015-07-15 22:24:15 -04:00
Charles Lehner
7c2dd3d976
ManageSieve: fix manager window button spacing
...
- Remove unused vbox
- Move refresh button to bottom, since it is semantically different
from the other action buttons
2015-07-15 22:19:39 -04:00
Charles Lehner
2328d40cf2
ManageSieve: remove Activate button
...
A filter can be activated by selecting its radio button in the list,
so the activate button is not needed.
Bug #3469 progress
2015-07-15 22:19:38 -04:00
Charles Lehner
455254fe24
ManageSieve: save manager window size (bug #2923 )
2015-07-15 22:19:38 -04:00
Charles Lehner
ae7bea75db
ManageSieve: use stock refresh button (bug #2923 progress)
2015-07-15 22:19:37 -04:00
Charles Lehner
bf369b87a2
Mark string for translation which is already translated
2015-07-15 16:59:08 -04:00
Paul
eee39d758f
fix bug 2435, ' Infinite loop+crash when refreshing folders from dovecot mbox based mailbox'
...
Patch by Oliver Schneider
2015-07-15 19:23:05 +01:00
Michael Rasmussen
463abe4eff
Added FreeBSD patch, see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=167460 . Fixes claws-mail bug #3457
2015-07-14 20:57:00 +02:00
Andrej Kacian
52551ae80d
Fix two more issues with modal dialog focus on Windows.
...
Date format information dialog in /Display/Summaries.
Icon chooser dialog in /Toolbars/*.
2015-07-10 11:18:04 +02:00
Andrej Kacian
005c378d7b
Fix Escape key closing color dialogs in /Display/Color common prefs.
2015-07-10 10:44:13 +02:00
Andrej Kacian
bd1465de2b
Fix folder selection dialog modality and focus on Windows.
...
Again, first set transient_for, then modal.
2015-07-09 21:58:25 +02:00
Andrej Kacian
a3ee5bae26
Use g_win32_getlocale() in manual availability detection on Windows.
2015-07-09 12:38:50 +02:00
Andrej Kacian
0158a5105c
Make right-click behavior more intuitive in compose attachment list.
2015-07-09 12:31:22 +02:00
Paul
c9593c34c3
remove unneeded and crash-causing g_free()
2015-07-09 07:12:55 +01:00
Paul
650714d6de
don't offer an empty string for translation
2015-07-09 07:12:24 +01:00
Ricardo Mones
f3d84861e4
Fix build with hardened compiler flags
...
Error was:
compose.c: In function 'compose_write_to_file':
compose.c:5782:5: error: format not a string literal and no format
arguments [-Werror=format-security]
alertpanel_error(msg);
^
cc1: some warnings being treated as errors
Makefile:1430: recipe for target 'compose.o' failed
make[6]: *** [compose.o] Error 1
2015-07-09 03:17:16 +02:00
Andrej Kacian
951a0fe24c
Fix filtering action configuration dialog modality on Windows.
...
First set transient_for, then show dialog, then set modal,
just like other dialogs.
2015-07-08 17:39:52 +02:00
Paul
d094dae124
make 'mark all as read' dialogue button style match that in folderview
2015-07-08 05:12:55 +01:00
Paul
ba83c690aa
fix dialogue question when recursively marking all as read
2015-07-08 05:11:43 +01:00
Andrej Kacian
ffd3698338
RSSyl: add a missing symbol to claws.def for Windows build.
2015-07-07 21:47:52 +02:00
Andrej Kacian
704598e1e4
Fix another win32 specific syntax error.
2015-07-07 21:31:19 +02:00
Andrej Kacian
90d8c2dc5a
Avoid some unnecessary foldertree redraws.
...
In particular, there were some redraws before moving a folder
and before moving to a next unread message in different folder.
This slowed these actions perceptibly on Windows.
2015-07-07 18:45:55 +02:00
Andrej Kacian
33fd5d6227
Use accessor for common preferences in all plugins.
2015-07-07 18:44:34 +02:00
Andrej Kacian
13198cd180
Fix a Win32-specific syntax error.
2015-07-01 21:47:57 +02:00
Andrej Kacian
226efcbfa4
Fix a logic error introduced in previous commit.
2015-07-01 21:30:50 +02:00
Andrej Kacian
567b040b6b
Disallow folder names to begin or end with a dot on Windows.
...
I fixed the most obvious locations - MH, RSSyl, mbox. There
may be more.
2015-07-01 20:37:00 +02:00
Andrej Kacian
95c770f2fd
Reenable transient windows for win32. Fixes bug #2866 .
...
This effectively reverts older commit ed483d5f
.
2015-07-01 19:00:02 +02:00
Andrej Kacian
e184b18f57
Managesieve: Fix parsing config string on Windows
...
Windows sscanf() does not understand the %ms format yet, so we
have to do the allocation of target buffer ourselves before
calling sscanf(), and copy the host string to config->host.
Also fix some off-by-one bugs in other sscanf() parameters - the
field width format modifier does not include trailing NUL byte,
which is added.
2015-07-01 18:45:36 +02:00
Andrej Kacian
198db03ee8
Managesieve: use accessor for common preferences
...
Fixes crash on Windows when opening the script editor window.
2015-07-01 12:25:32 +02:00
Andrej Kacian
4b955c34ba
Do not use GStatBuf with non-Glib *stat() functions.
...
Also fix up on forgotten stat() to g_stat().
2015-06-30 23:38:31 +02:00
Andrej Kacian
23a3e906b2
RSSyl: Variable typo fix in Windows-specific code.
2015-06-30 22:29:48 +02:00
Andrej Kacian
7c5efcb9a5
Updated plugins' claws.def files as needed for Windows build.
2015-06-30 22:29:48 +02:00
Paul
f8bac1960b
make filtering action 'mark_as_unread' set the unread flag AND remove the new flag
2015-06-30 17:49:17 +01:00
Andrej Kacian
a36b173660
Get rid of last remaining "struct stat" variables.
...
GStatBuf is used instead.
2015-06-29 11:44:13 +02:00
Andrej Kacian
0faddd1e85
Use g_dir_open() and friends instead of opendir() and friends.
...
This makes more things work on Windows, since Mingw
opendir() is kind of flakey, and breaks e.g. vcalendar or rssyl
being able to read contents of their folders.
I only left opendir() in archive plugin, since it is only found
in unused part of code (excluded by #ifdef _TEST, which is never
true for claws-mail compilations).
2015-06-29 11:35:13 +02:00
Holger Berndt
4e67def9e4
GData plugin: Make it possible to compile with libgdata 0.17.1
...
This version of libgdata does not yet support cold start, but
has the advantage that it's already released. For an acceptable
user experience, it's still required to have a more recent
libgdata version.
2015-06-28 10:00:30 +02:00
Ricardo Mones
016e2b0482
Libravatar: clean cache button
2015-06-28 09:54:04 +02:00
Ricardo Mones
6aa8971eda
Libravatar: cache usage info label
2015-06-28 09:53:19 +02:00
Andrej Kacian
eb9beace00
Handle an unlikely fopen failure in compose_write_to_file()
2015-06-25 17:58:50 +02:00
Andrej Kacian
3117fda50f
Do not use MsgInfo's plaintext_file for message file.
...
It is no longer needed, as we no longer write unencrypted
version of an encrypted message anywhere.
Keep the struct member for now, since att_remover plugin is
still (mis)using it.
2015-06-25 14:00:31 +02:00
Andrej Kacian
53784ce943
Revert "Remove plaintext_file member of struct MsgInfo."
...
This reverts commit 4e7e4f922c
.
Looks like plaintext_file has been misappropriated by
att_remover plugin, and it can't be trivially changed.
2015-06-25 13:58:21 +02:00
Andrej Kacian
4e7e4f922c
Remove plaintext_file member of struct MsgInfo.
...
It is no longer needed, as we no longer write unencrypted
version of an encrypted message anywhere.
2015-06-25 13:02:05 +02:00
Andrej Kacian
a7c0255395
Encrypt message just before writing it to queue dir.
...
This fixes bug #2965 .
As a side effect, if "Save sent encrypted messages as clear text" is
enabled, a copy will be saved to outbox when queuing, not when sending.
2015-06-25 13:01:58 +02:00
Christian Hesse
3dc44ceb67
Libravatar: this is rootdir, not subdir
2015-06-24 10:34:45 +02:00
Andreas Rönnquist
747e95c91c
Set focus row to top item if marking a message above previous
2015-06-24 02:05:20 +02:00
Ricardo Mones
89d3142e63
AttachWarner: fix copyright and g_warning string
2015-06-24 01:54:09 +02:00
Ricardo Mones
736a83b799
AddressKeeper: fix copyright and g_warning strings
2015-06-24 01:53:12 +02:00
Ricardo Mones
ea9009a97c
Libravatar: fix g_warning strings
2015-06-24 01:50:16 +02:00
Ricardo Mones
a98ae440dc
Libravatar: fix copyright headers
...
As quickly noted by Paul an Andrej, Hiroyuki had nothing
to do with plugin system. Thanks! ;-)
2015-06-23 10:29:34 +02:00
Ricardo Mones
7fca97dcd1
Fix bug #3438 ‘Filter to add address to Addressbook duplicates address in Name field’
...
Also included some cleanup:
• Remove unused function strlen_with_check
• Remove unused macro STRLEN_WITH_CHECK
• Update copyright header
2015-06-23 10:11:13 +02:00
Ricardo Mones
cb87edf171
Libravatar: refactor and fix leak on corner case
...
• Move cache initialization to its own file
• Fix leaked cache_dir path when initialization failed
2015-06-23 10:07:59 +02:00
Ricardo Mones
601733aa30
Update year for incoming release
2015-06-23 09:35:04 +02:00
Andrej Kacian
2d947971db
Fix a mistake in previous commit.
2015-06-23 07:49:42 +02:00
Andrej Kacian
5bfb2198f3
Allow 'Z' as time zone in procheader_scan_date_string()
...
Function should now be completely RFC3339 compliant.
2015-06-22 22:19:07 +02:00
Andrej Kacian
4ce8639200
Removed an unneeded ifdef in my_tmpfile().
2015-06-22 21:19:58 +02:00
Andrej Kacian
514d0e3172
Use g_mkstemp() instead of mkstemp().
...
Also, removed our implementation of mkstemp() for Windows. Glib
has us covered.
2015-06-22 21:16:14 +02:00
Ricardo Mones
8aa14edcbf
Fix bug #1901 ‘More descriptive error msgs when attempting to delete a folder’
...
Original patch by Paweł Pękala; added additional info on some
g_warning calls and removed trailing '\n' as they're already
appended by glib's default handler.
2015-06-22 12:19:51 +02:00
Christian Hesse
63f3f4f846
Finish 439a5cffca
...
Remove unused code relating to old unsupported version of libarchive.
2015-06-21 02:48:23 +02:00
Christian Hesse
d1f8f167a5
Remove useless rule
2015-06-21 02:48:23 +02:00
Christian Hesse
ab18e2097f
Do not redefine MIN and MAX
...
This includes util.h, which includes glib.h, which includes gmacros.h,
which defines MIN and MAX.
2015-06-21 02:48:23 +02:00
Christian Hesse
0ccf2f026b
Remove unused variables
2015-06-21 02:48:22 +02:00
Christian Hesse
7abcba6de2
Fix type in yacc file
2015-06-21 02:48:22 +02:00
Andrej Kacian
8ae2860c54
Allow TLS connections to LDAP on Windows.
...
The comment no longer applies, TLS seems to work fine for LDAP
connections on Windows. Closes bug #2827 - Feature request: Add
TLS/SSL support for LDAP server access
2015-06-20 23:03:50 +02:00
Andrej Kacian
72a9c0b46a
Do not free LDAP error string on Windows.
...
Fixes bug #2816 - LDAP addressbook search crashes Claws Mail.
2015-06-20 22:38:53 +02:00
Paul
6044d9dcb1
fix error on load: 'undefined symbol: response_is_ok'
...
happened for me with gcc5.
Patch by Charles Lehner.
2015-06-19 19:12:57 +01:00
Andrej Kacian
8549b2a6cb
The "mark_as_spam" filtering action does not move message.
...
The alternative was to rename the action to
"mark_as_spam_and_move_to_spam_folder".
2015-06-19 17:33:49 +02:00
Andrej Kacian
c483d06ee3
Various small fix ups needed for mingw-w64 build.
2015-06-18 23:58:51 +02:00
Andrej Kacian
e7d7deb012
RSSyl: Use our CA certificate bundle on Windows.
...
Libcurl seems to want a CA cert bundle for any https connection,
even if verification is disabled. On Windows, there is no default
bundle or directory libcurl knows about, so we give it our own,
pointed to by claws_ssl_get_cert_file().
2015-06-18 23:53:08 +02:00
Andrej Kacian
42f80d30ef
RSSyl: If given, set CURLOPT_CAINFO regardless of libcurl version.
2015-06-18 23:53:08 +02:00
Ricardo Mones
ab24ae5d50
Remove unchecked realloc which is unnecessary
2015-06-18 02:15:12 +02:00
Ricardo Mones
a8e2db54e2
Fix leak on failing realloc
2015-06-18 02:13:28 +02:00
Holger Berndt
aadb7d5405
GData plugin: Support cold-start
...
Store refresh token, and try to authorize Google access with it on
startup. Interactive authorization is now only the fallback if refreshing
cannot be done or was not successful.
Fixes bug #3432 but requires yet unreleased libgdata, see
https://bugzilla.gnome.org/show_bug.cgi?id=750746
2015-06-18 00:33:48 +02:00
Andrej Kacian
bee73785e5
RSSyl: Allow giving custom CA cert file to libfeed
2015-06-17 13:47:01 +02:00
Andrej Kacian
a48d94d8f0
RSSyl: Free GError from memory where necessary.
2015-06-16 23:04:24 +02:00
Andrej Kacian
cb7105cb92
RSSyl: Use g_mkstemp() instead of mkstemp()
2015-06-16 22:55:20 +02:00
Andrej Kacian
d510ecf8b8
RSSyl: Got rid of opendir/readdir/closedir in favour of Glib functions.
2015-06-16 22:52:47 +02:00
Ricardo Mones
3c6940a955
Remove unnecessary “Use this” for changing theme
...
Use the standard preferences button “Apply” instead.
2015-06-16 12:50:36 +02:00
Holger Berndt
aaa86dbd5c
GData plugin: Remove now obsolete password pref
2015-06-14 14:46:22 +02:00
Holger Berndt
c69ab3b4cd
GData plugin: Switch from ClientLogin to OAuth2
...
Google has recently removed ClientLogin support.
The switch to OAuth2 fixes bug #3432 and makes the plugin work
again, but with a degraded user experience. The authorization
needs to be redone on every program start. Improving that is
pending on https://bugzilla.gnome.org/show_bug.cgi?id=750746
2015-06-14 14:46:22 +02:00
Holger Berndt
63e39e3b8c
GData plugin: Change debug output order during plugin load
2015-06-14 14:46:22 +02:00
Holger Berndt
7d3b4a6e71
GData plugin: Drop support for libgdata < 0.9
2015-06-14 14:46:22 +02:00
Andrej Kacian
0043e1ee2e
Fancy: updated list of exports from core claws-mail for win32 build.
2015-06-14 13:34:37 +02:00
Colin Leroy
fbd6608f0e
Fix english (I think)
2015-06-10 11:51:05 +02:00
Ricardo Mones
20f7a3d674
Add missing page weights on some plugins
2015-06-09 09:44:16 +02:00
Ricardo Mones
43f6bcc91f
Libravatar: use accessor for common preferences
...
Fixes crash on Windows when loading preferences page.
Original patch thanks to Ticho:
http://git.claws-mail.org/?p=claws-win32-installer.git;a=commitdiff;h=956cf9f8
2015-06-09 09:43:35 +02:00
Andrej Kacian
298a94adf8
Add a missing include to make commit f061b67
work on Win32.
2015-06-06 18:24:49 +02:00
Ricardo Mones
8d39c742f6
Fix low probability resource leak
2015-06-06 13:52:23 +02:00
Ricardo Mones
bd68b59f01
And other format warning less
...
• imap.c:4832:8: warning: format ‘%d’ expects argument of type ‘int’,
but argument 9 has type ‘time_t’ [-Wformat=]
2015-06-06 03:09:31 +02:00
Ricardo Mones
3227621a74
Fix a couple of format warnings
...
• utils.c:5569:3: warning: format '%d' expects argument of type 'int',
but argument 4 has type 'size_t' [-Wformat=]
• utils.c:5569:3: warning: format '%d' expects argument of type 'int',
but argument 5 has type 'gsize' [-Wformat=]
2015-06-06 02:54:36 +02:00
Andrej Kacian
f061b67c93
Use 'GStatBuf' instead of 'struct stat' type where possible.
2015-06-05 13:33:32 +02:00
Andrej Kacian
1114a38f38
RSSyl: Reworked item comparing logic, partly based on bug #3429 .
2015-06-04 09:16:10 +02:00
Andrej Kacian
1dc9b3ed94
Pass --export-* flags correctly to the linker, depending on platform.
2015-06-03 19:59:06 +02:00
Andrej Kacian
1b89980855
Use pkg-config to detect Expat library.
2015-05-30 23:32:17 +02:00
Andrej Kacian
545ff0cc02
RSSyl: Use procheader_date_parse() for RFC3339 date strings.
...
This allows us to remove the parseISO8601Date() function, and
therefore use of strptime(), which does not exist on all platforms.
2015-05-30 19:46:48 +02:00
Andrej Kacian
3b6cfef6e3
Rewrote parsing of RFC3339 datetime strings.
...
This rewrite supports all allowed separators between date
and time: both uppercase and lowercase 'T', as well as space.
Only thing not yet supported is 'Z' instead of time zone offset,
I will hopefully add that later.
2015-05-30 19:46:48 +02:00
Andrej Kacian
87adea61fd
RSSyl: Updated list of symbols needed from claws-mail core.
...
Needed for building for Windows.
2015-05-30 18:33:19 +02:00
Andrej Kacian
8469cc0131
RSSyl: struct dirent doesn't have d_type member on Windows.
2015-05-30 18:32:35 +02:00
Andrej Kacian
4dbb2b5d93
RSSyl: Remove unnecessary use of link() in rssyl_add_msgs().
2015-05-30 18:31:26 +02:00
Andrej Kacian
d674287961
Fix typo in variable name in Windows g_open() implementation.
2015-05-30 17:36:34 +02:00
Ricardo Mones
fed3e19ea5
Fix bug #1941 ‘recursive "mark read all"’
...
Based on the original patch from Robert David which unfortunately
didn't marked as read the folder currently open on summary view.
2015-05-28 21:33:05 +02:00
Paul
c3112d8424
fix last commit
...
my fault, not a problem with the patch
2015-05-28 08:56:19 +01:00
Paul
084d8dcadc
Fix LDAP access using TLS protocol
...
Patch by Darko Koruga.
2015-05-28 08:43:20 +01:00
Andrej Kacian
a52401526d
RSSyl: Fix compilation on OS X.
...
The enums declared in libfeed's parser*.h files sneaked through
to object built from old_feeds.c file, due to parser.h include.
For some reason, this bothers OS X compiler.
Since these enums were only used in their respective parser*.c file,
I just moved them there.
2015-05-27 22:58:27 +02:00
Andrej Kacian
e0aa60ca7a
RSSyl: Leave unread flag on new items regardless of silent_update setting.
...
Closes bug #2601
2015-05-21 23:34:25 +02:00
Ricardo Mones
f3d3586ed9
Almost switch plugins from strerror to g_strerror
...
Refusing to modify spamassassin's libspamc.c code to avoid
diverging (more) from original ASF code. It's a pity they
don't provide a shared library for this, or at least for the
message_read/message_filter functions used by the plugin :)
2015-05-18 22:42:44 +02:00
Ricardo Mones
6fc7c18a81
Switch core from strerror to g_strerror
2015-05-18 22:42:37 +02:00
Andrej Kacian
64e5421bb2
RSSyl: Strip leading and trailing whitespace from XML tag contents.
2015-05-17 19:13:17 +02:00
Ricardo Mones
46c8c40814
Update summary view status after "Find all"
...
In search messages dialog (Edit/Search folder...) pressing "Find all"
left the summary view status empty regardless of the result.
The status of the resulting selection when matching messages are found
is displayed now. If no message is matched it remains empty as before.
2015-05-16 12:21:07 +02:00
Andrej Kacian
455d234394
RSSyl: use procheader_date_parse() instead of parseRFC822Date().
2015-05-07 00:33:49 +02:00
Ricardo Mones
3d05195eb6
Fix GLib-GObject-CRITICAL message when printing
...
Message was: “g_object_ref: assertion 'G_IS_OBJECT (object)' failed”
2015-05-04 03:07:50 +02:00
Ricardo Mones
6d45e57eb7
Fix bug #2981 and other two implicit...
...
...declaration warnings I probably introduced in previous commits:
• notification_prefs.c:1285:2: warning: implicit declaration of function
'filesel_select_file_open' [-Wimplicit-function-declaration]
• rssyl_prefs.c:110:2: warning: implicit declaration of function
'filesel_select_file_open' [-Wimplicit-function-declaration]
• icalderivedproperty.c:374:4: warning: implicit declaration of function
'icalproperty_add_parameters' [-Wimplicit-function-declaration]
;-)
2015-04-29 20:28:29 +02:00
Ricardo Mones
43930e40fc
Fix 'make dist' for Managesieve plugin
...
make[5]: Entering directory '/home/mones/hydra/claws-dev/src/plugins/managesieve'
make[5]: *** No rule to make target 'sieve_plugin.h', needed by 'distdir'. Stop.
2015-04-25 20:26:36 +02:00