* src/prefs_customheader.c
I prefer removing then freeing rather than the contrary
(even if it doesn't change anything ;-)
* src/prefs_account.c
Fix bug #933 (Crash re-entering the custom headers list
dialog in accounts prefs)
The problem happened when cancelling the Account
Preferences' dialogs - in which case we didn't do
anything to the PrefsAccount * struct. In case of applying,
the old ac_prefs was replaced with the tmp_ac_prefs we were
working with in this dialog. The problem is that
prefs_customheader.c, working on this tmp_ac_prefs, always
changes the ->customhdr_list pointer, even when cancelled.
So in case of cancelling the prefs_account dialog, we still
have to update ->customhdr_list in the real account.
* src/summary_search.c
* .cvsignore
Bugfix: stop button was sticky when searching in an empty folder.
Applied curly brackets code style to the whole file (summary_search.c).
More files to ignore.
* src/message_search.c
* src/summary_search.c
changed default button when search bumps at file/folder
beginning or end, for convenience (thanks to Colin).
* src/plugins/pgpcore/plugin.c
* src/plugins/pgpcore/select-keys.c
* src/plugins/pgpcore/select-keys.h
* src/plugins/pgpcore/sgpgme.c
* src/plugins/pgpcore/sgpgme.h
* src/plugins/pgpinline/pgpinline.c
* src/plugins/pgpinline/plugin.c
* src/plugins/pgpmime/pgpmime.c
* src/plugins/pgpmime/plugin.c
Factorize and generalize a bit
Drop S/MIME signature verification from PGP/MIME
(adding it as another, more complete plugin)
* src/compose.c
Fix crash on Reply with no From:
Show signature and conversion error on queuing
(but not sending)
* src/mainwindow.c
* src/summaryview.c
* src/summaryview.h
Factorize threading code and make sure msginfo
is not null when it comes from a GtkCTreeRow's
data
* src/gtk/gtkaspell.c
Check for necessary things
* src/gtk/gtksctree.c
* src/gtk/gtksctree.h
Reset anchor if necessary when removing node
* src/gtk/gtkutils.c
* src/gtk/gtkutils.h
Add a gtkut_get_link_btn() function that
creates a button which acts like an URI
* src/prefs_themes.c
* src/gtk/about.c
Use this function (factorizes codes)
* src/common/defs.h
* src/gtk/pluginwindow.c
Add a "Get more..." in the plugins window
* src/procheader.c
Make sure the date is UTF8 valid, or try to make it
so. IncrediMail is really IncrediStupid.
* src/compose.c
Fix possible conversions.
* src/summaryview.c
I think I killed the twilight zone bug!
summary_select_node() flushes GTK events in order
to be able to center the view. But this also
flushes keypresses like Ctrl-Alt-U, so this can
call summary_show from summary_select_node (itself
called from summary_show, etc.). And the summaryview
has to be unlocked in this function. So just locking
while processing GTK events, and bailing if locked,
should fix it.
Fixes bug #927 (SIGSEGV during Update Summary)
* src/matcher.c
Fix search in QP-encoded bodies
Fix utf-8 searches in bodies encoded in the
locale's encoding
* src/common/quoted-printable.c
* src/common/quoted-printable.h
Add a decode function that doesn't overwrite
the original pointer
* src/summaryview.c
* src/gtk/description_window.c
fix display of From/To column title when in appropriate folders (queue/sent/drafts)
and headers are translated; adjust description windows' width to fit their
contents. Patches by Pawel Pekala <c0rn@o2.pl>.
* src/common/utils.c
revert patch, (postponing a fix), at 2.0.0cvs120
as it breaks more URIs than it fixes.
Allow '-' to be a terminating character in a URI
* src/addressbook.c
allow sorting by name/email/remarks, ensure that right-pane's contents
matches the left-pane selection (cleared when appropriate).
Patch by Pawel Pekala <c0rn@o2.pl>.
* src/summaryview.c
Set cursor to watch for execution (fixes lack
of watch-cursor when dnd'ing hundreds of mails)
* src/gtk/filesel.c
Check that mime type is 'image/*' before updating
the preview (maybe fix crashes on Solaris+gtk2.8.4 ?)
* src/mainwindow.c
* src/mainwindow.h
* src/prefs_msg_colors.c
* src/summaryview.c
* src/summaryview.h
* src/gtk/colorlabel.c
* src/gtk/colorlabel.h
Add a color label menu in the main menubar
Add (fixed) accels Ctrl-{0-7} to change the color
They have to be fixed because the menu's dynamic,
the items are complex widgets, hence we can't use
a GtkItemFactory.
* src/compose.c
rollback few lines from my previous commit (those lines come from
a pending patch, accidentally commited, even if neutral as they are
commented out).
* src/procmsg.h
* src/procmsg.c
* src/folder.c
Fix POSTPROCESSING hook
Patch by H. Merijn Brand
* src/procmime.c
* src/procmime.h
Parse Content-Location
* src/toolbar.c
* src/messageview.c
* src/messageview.h
Don't crash when a top-level MessageView has
been closed on us. Same problematic than
yesterday's quicksearch issue.
* src/gtk/quicksearch.c
Fix a bitchy race we didn't think about when we
added quicksearch cancellation:
If the search is not on cached fields, for example
body_part matchcase "stuff"
the matcher code has to get the whole message. If
we're on IMAP, that can be slow, and in order to
be non-blocking, the IMAP code idle loop processes
gtk events too. So it is possible to cancel a
quicksearch while the matcher is getting the mail's
body. After matcher got its body, it will start to
iterate over the matcher list that the Quicksearch's
clear_search_cb() just freed via prepare_matcher().
SIGSEGV ensues.
The fix consists of guarding the matcherlist_match()
call with a boolean 'matching'. If we reset the
quicksearch while matching is TRUE, we don't free
the matcherlist anymore like we did, but we set
another new flag, deferred_free, to TRUE. Then,
in quicksearch_match(), just after returning from
matcherlist_match() and unsetting the matching flag,
we check the deferred_free flag and do the
prepare_matcher() (which does the matcherlist_free)
for real, so we free the matcherlist once it's not
used anymore.
As all of this runs via the glib main loop, we
luckily don't need a mutex.
* src/summaryview.c
Also, show progress while searching.
* src/prefs_matcher.c
give a little more width to the combos
* src/prefs_display_header.c
* src/textview.c
translate headers if prefs_common.trans_hdr
is TRUE
Patches by Pawel Pekala
* src/plugins/clamav/clamav_plugin.c
* src/plugins/dillo_viewer/dillo_viewer.c
* src/plugins/pgpcore/plugin.c
* src/plugins/pgpinline/plugin.c
* src/plugins/pgpmime/plugin.c
* src/plugins/spamassassin/spamassassin.c
update/add to descriptions
* src/plugins/spamassassin/spamassassin_gtk.c
fixes to the english, remove superfluous
tooltips, clean up a little
* src/summaryview.c
Revert 2.0.0cvs84 which reverted 1.9.6cvs23 which
messed up shift-selection because is slows down
moving around summaryview. thanks -users
* src/addressadd.c
* src/foldersel.c
* src/prefs_common.c
* src/prefs_common.h
remember some more windows' sizes (add to addressbook and
select folder).
* src/news.c
* src/news_gtk.c
when unsubscribing a newsgroup, remove the
folder and msgs in .sylpheed-claws/newscache
Patch by Pawel Pekala <c0rn@gazeta.pl>
* src/prefs_common.c
* src/prefs_common.h
* src/prefs_msg_colors.c
* src/summaryview.c
* src/summaryview.h
* src/gtk/colorlabel.c
* src/gtk/colorlabel.h
colors in messages list are now customizable. Color values and names can
be changed in "Configuration/Preferences/Display/Colors/Color labels".
Thanks to Paul and Colin for their help with this longstanding patch!
* manual/plugins.xml
* src/plugins/spamassassin/README
updated SpamAssassin plugin docs to reflect new functional additions
(also fix/update/documents few technical stuff more, see the README).
* src/plugins/spamassassin/spamassassin.c
Fix segfault (g_file_set_contents fails for some
reason and err==0x2f. Can't find out why with
valgrind, using working function :-)
* src/plugins/spamassassin/spamassassin.c
fixed spamc invocation: use a tricky temporary mini shell wrapper
'cause it seems that calling `spamc ... < inputfile` with
g_spawn_(a)sync simply.. erm doesn't work :-).
* src/toolbar.c
* src/toolbar.h
simplify the adding of spam/ham button to the messageview toolbar
(it gets more clear now that the same button will be "Mark as spam"
or "Mark as ham" according to the current message status,
thanks to Colin).
* src/messageview.c
* src/procmsg.c
* src/procmsg.h
* src/summaryview.c
* src/plugins/spamassassin/spamassassin.c
* src/plugins/spamassassin/spamassassin.h
make learner callbacks return a status (0 for ok),
handle it in main code to avoid setting flags when learning failed,
don't learn on TCP if offline in spamassassin,
thanks to Colin.
* src/plugins/spamassassin/spamassassin.c
* src/plugins/spamassassin/spamassassin.h
* src/plugins/spamassassin/spamassassin_gtk.c
made processing of emails w/ sa-plugin an option (default is TRUE),
fixed Engrish some tooltips, capitalization of some debug messages
and warnings. The spamassassin plugin now provides two separate
services: process emails upon incorporation and spamd training.
Both services (un)register independently but use some common
plugin settings (transport settings, spam storage location).
* src/plugins/spamassassin/spamassassin.c
* src/plugins/spamassassin/spamassassin.h
* src/plugins/spamassassin/spamassassin_gtk.c
- added the ability to learn a remote spamassassin server (spamd),
using spamc.
- added the spamassassin option 'username', that applies to all
spamassassin operations (filtering, learning, local or remote).
The default username is the current unix user (if left blank
from gtk prefs or config file).
- commented out some unused code (notebook widget), removed unused
layout (hbox1).
- make more widgets sensitive to the transport type.
* src/procmsg.c
* src/summaryview.c
* src/summaryview.h
* src/plugins/spamassassin/spamassassin.c
* src/plugins/spamassassin/spamassassin.h
* src/plugins/spamassassin/spamassassin_gtk.c
Unregister learner when spamassassin is either
disabled or over tcp
* src/compose.c
* src/compose.h
* src/filtering.c
hide compose window when sending message in batch mode
(filtering: forward and redirect). Also fixed a wrong
value returned when sending failed, neutral anyway.
(Colin, me)
* src/compose.c
fix a crash when redirecting (for instance) when compose window's
toolbar contents has been customized (when some buttons have been
removed in fact).
* src/summary_search.c
enhancements to the summary search:
- add the ability to stop the running search
(upon ESC-key press, new Stop button or when Clear button is pressed)
- don't search if no criteria (From/To/Subject/Body) is set
- ensure that a busy mouse pointer is always shown when searching,
show it even a bit earlier
* src/messageview.c
* src/prefs_common.c
* src/prefs_common.h
* src/prefs_message.c
Add pref to display HTML-only mails with plugin,
if possible (defaulting to FALSE of course).
* src/mimeview.c
* src/mimeview.h
Let MimeViewers know which MimeView they
depend of.
* src/summaryview.c
Swap From/To columns in Sent/Queue/Drafts
folders
* src/etpan/imap-thread.c
Use mailstream_low_tls_open() for STARTTLS
instead of mailstream_low_ssl_open()
** REQUIRES libetpan 0.42cvs3 **
* src/compose.c
* src/compose.h
* src/message_search.c
* src/message_search.h
* src/textview.c
* src/gtk/gtkutils.c
* src/gtk/gtkutils.h
added the ability to Find text in the compose window (and a bit
of code factorization).
