The internal representation was buggy anyway, converting
to and from GdkColor improperly, changing slightly RGB values.
I guess nobody ever noticed slight hue changes.
GdkColor is still used when setting widget colors with (also
deprecated) GtkStyle, and when using other deprecated
functions, which will eventually be replaced.
* Fix right-click replying to messages in summaryview
* Fix corner-case when selected and opened messages are different,
and one of them is to a mailing-list.
When re-editing a message, let's preserve its flags (color labels, etc)
and tags. Can be especially useful for those who use such things on queued
messages, and find themselves re-editing messages afterwards but before
actually sending them.
1434187, 1434189, 1434192, 1434193, 1434195, 1434196, 1434198, 1434200, 1434202, 1434203
And few more. Change few silent returns into debug ones (cm_return_if_fail).
Also closes bug #3960 - Sends unencrypted emails when encryption fails
because we now return from compose_queue() with an error when
that happens, instead of ignoring it.
which clears template internals (including attachments list)
wherever template contains any field to apply (To/Subject/etc.)
and before attachments could be processed. Simply process
attachments before attachments list may be cleared by fields
processing. Ideally we should change quote_fmt_reset_vartable()
or its uses in compose.c at least.
Use gtk_window_set_default_size() instead of
gtk_widget_set_size_request(), since in GTK3, the latter
sets minimum allowed size for a widget, and we're
interested in just setting initial size here. User
should be allowed to make the windows smaller.
Instead of using "+" prefix with button labels and/or
the default_value parameter, we introduce "focus"
parameter, which will point to first, second or third
button.
Advantages:
- we got rid of the "+" prefix, which won't work with GTK3
with GTK3
- instead of having two ways to indicate which button
should have focus, which can be in conflict, and
are not very straightforward, there is just one,
arguably more intuitive
- some small memory leaks fixed along the way
(using g_strconcat() directly as function argument)
