gfgit/claws-mail
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity
13145 commits 7 branches 0 tags 60 MiB
Commit graph

137 commits

Author SHA1 Message Date
Jonathan Boeing f5080c0fc5 Add pkgconfig support for gpgme and libgpg-error 2022-10-15 15:35:24 -07:00
Ricardo Mones 39aff56f3f Honor GTK project name¹, except some files… 
…where it refers to previous name of the project.

¹ https://mail.gnome.org/archives/gtk-devel-list/2019-February/msg00000.html
 2022-03-18 20:18:35 +01:00
paul 817071429e fix a bunch of buttons in dark corners. add some images to others 2022-01-24 15:41:29 +00:00
Jonathan Boeing e700a32e8f Fix build error with -Werror=format-security 2021-10-29 11:09:32 -07:00
Jonathan Boeing 617596d534 fix bug 4517, 'Thread safety issues in signature checking code' 
Move from using raw pthreads to GLib tasks for safety and convenience.
Also includes some extra fixes for leaked gpgme keys and contexts.
 2021-10-29 08:36:13 -07:00
wwp cf88ebed5b Fix pgpcore build. 2021-09-28 18:43:51 +02:00
wwp b78a997e2c Fix CID 1492251: resource leaks. 2021-09-28 17:41:16 +02:00
Jonathan Boeing d5e5f0ce0c Fix memory leak 2021-09-25 19:41:34 -07:00
wwp ed74a4678f Normalize g_warning's: no capitalization, no trailing punctuation or newline-char. 
Fix few messages (simply wrong, or typos).
 2021-09-03 17:09:32 +02:00
paul 1d37ede952 replace deprecated GtkStock 2019-11-20 17:14:54 +00:00
Andrej Kacian cab9f7c7a3 Fix a memory leak in sgpgme_sigstat_info_short() 2019-05-04 16:43:28 +02:00
Andrej Kacian 3166cdab19 Fix a compiler warning 2019-02-08 20:49:41 +01:00
Colin Leroy b7e7385fa2 Rename claws_io to file-utils, and move file-related functions 
from utils.c to file-utils.c
 2018-10-16 19:02:31 +02:00
Colin Leroy 0cfddd54ce Wrap file I/O to claws_* to benefit from custom locking when 
available. Gains about 33% on I/O bound tasks.
 2018-10-16 19:01:44 +02:00
Andrej Kacian 5ab9e6e799 Rework of alertpanel default button focus handling. 
Instead of using "+" prefix with button labels and/or
the default_value parameter, we introduce "focus"
parameter, which will point to first, second or third
button.

Advantages:
- we got rid of the "+" prefix, which won't work with GTK3
  with GTK3
- instead of having two ways to indicate which button
  should have focus, which can be in conflict, and
  are not very straightforward, there is just one,
  arguably more intuitive
- some small memory leaks fixed along the way
  (using g_strconcat() directly as function argument)
 2018-02-09 14:44:30 +01:00
Andrej Kacian 9f1c5fef1a Show full key/signature fingerprints. 
Closes bug 3910 - Displaying of problematic short key IDs for GPG messages
 2017-11-09 00:31:27 +01:00
Andrej Kacian 3bce048151 Use separate account configuration for OpenPGP and for S/MIME. 
This is useful for users who switch between privacy systems.
Based on patch by Thomas Orgis.
Closes bug Bug 3834 - [PATCH] separate account prefs for
S/MIME to be able to specify keys for both PGP and S/MIME
 2017-09-23 20:43:03 +02:00
Andrej Kacian 5fb879d20a Fix use of uninitialized value in sgpgme_has_secret_key(). 
Fixes commit 11980bc7a.
 2017-07-12 09:47:45 +02:00
Andrej Kacian 11980bc7a3 Fix a few memory leaks when enumerating keys with GpgME. 
Also replaced uses of deprecated gpgme_key_release()
with gpgme_key_unref().
 2017-07-11 21:09:24 +02:00
Andrej Kacian 99f7057395 Correct the use of pthread_create() in several places. 
The second argument should be a pointer to pthread_attr_t,
not a numeric constant. Joinable detachstate is also the
default, we don't need to explicitly set it. Lastly, use
"NULL" for null pthread_attr_t pointer, not "0" (this is
just a cosmetic/consistency thing, but still).
 2017-07-07 12:49:22 +02:00
Andrej Kacian 21d4407617 Added debug output for failure cases in sgpgme_data_release_and_get_mem() 2017-03-08 12:07:51 +01:00
Ricardo Mones adf00727b0 Fix some debug messages and update headers 2016-07-29 00:59:11 +02:00
Andrej Kacian 5e02bd982a When generating a PGP keypair, only ask for passphrase with gpg1. 
Also erase all copies of an entered passphrase from memory
when done. Closes bug #3658.
 2016-07-13 21:50:52 +02:00
Andrej Kacian e454dd8d56 Simplify handling of gpg_ask_create_key pref. 2016-07-12 00:13:21 +02:00
Andrej Kacian 38a69f674e Made exporting GPG key to keyserver work on Windows. 2016-07-10 14:55:48 +02:00
Ricardo Mones cda0657547 Add forgotten block delimiters 
Thanks Paul for noticing!
 2016-07-04 18:45:53 +02:00
Ricardo Mones b2651d9e36 Warn on unsuccessful gpgme_set_engine_info calls 2016-07-04 11:00:35 +02:00
Paul fd6e3082a8 modify 61f7c3c5e to catch another hardcoded gpg call 2016-07-04 09:25:46 +01:00
Andrej Kacian 1cd1e06213 Better fix for crash after broken pgp keyring update. 
This should fix the crash without interfering with
signature checking when public key is missing.
 2015-12-15 00:07:35 +01:00
Ricardo Mones b189d777f1 Cosmetic: use always g_getenv instead of getenv 2015-12-09 12:20:57 +01:00
Paul 3a8df4ede9 reinistate 1b32cc6794 but with an addition check, eliminating the unwanted behaviour 2015-11-17 18:12:36 +00:00
Paul 5a62dd7ed4 more sanitizing of translatable strings 2015-11-15 12:59:23 +00:00
Colin Leroy 49d9491bae More null pointer dereference fixes 2015-11-13 10:49:25 +01:00
Paul 22a0f60092 revert 1b32cc6794 
it was a regression, and causes 'end of file' message on checking sig
of a key not in the keyring, whereas without it you get the 'Key KEYID
not avilable...' message instead. If there is a fix, that was not it.
 2015-11-01 15:52:58 +00:00
Ricardo Mones 98b12b276f Remove line breaks from g_warning() 2015-10-01 22:05:12 +02:00
Ricardo Mones d463671387 Do not translate g_warning() strings 
They aren't for end user error reporting.
Also, remove needless line breaks inside.
 2015-09-22 19:55:14 +02:00
Paul 4f85809426 let's not suggest possible, not necessarily correct, solutions in debug output 2015-08-27 09:47:19 +01:00
Paul e39993c0ed add option to specify location of GnuPG executable 
This allows the user to choose to use gpg rather than be forced to use
gpg2
 2015-08-27 09:37:04 +01:00
Michael Rasmussen fefb4204bf Reduce size of error message 2015-08-20 20:22:46 +02:00
Michael Rasmussen 1b32cc6794 Fix possible crash when gpg is upgraded to gpg-v21 2015-08-20 01:26:33 +02:00
Ricardo Mones a8e2db54e2 Fix leak on failing realloc 2015-06-18 02:13:28 +02:00
Ricardo Mones f3d3586ed9 Almost switch plugins from strerror to g_strerror 
Refusing to modify spamassassin's libspamc.c code to avoid
diverging (more) from original ASF code. It's a pity they
don't provide a shared library for this, or at least for the
message_read/message_filter functions used by the plugin :)
 2015-05-18 22:42:44 +02:00
Paul 64f523e4ab better implementation of 420e834997. thanks to Ticho for the push. 2014-10-31 09:23:24 +00:00
Paul 420e834997 implement RFE 3314, 'user can't see validity of gpg signatures' [SIC] 
also a little reformatting of similar strings
 2014-10-30 18:21:13 +00:00
Colin Leroy d1d1180b1b Fix missing fclose(), thanks to Kevin Day 2014-08-01 17:15:26 +02:00
Paul 7229dd2c72 tidy up after last commit 2014-08-01 07:05:31 +01:00
Paul ee35990fd9 implement RFE 3238, 'GPG Mime Plugin exports contents to a tmpfile unnecessarily' 
The function gpgme_data_new_from_filepart() accepts a file stream with an offset.
This information is already available via the mimeinfo variable.
Instead of creating a new, temporary, file that contains some of the gpgme data, just use the original file as is.
This saves resources especially on flash disks that have a limited number of writes.

Patch by Kevin Day <thekevinday@gmail.com>
 2014-08-01 06:50:50 +01:00
Paul 678ea51e82 indicate revoked UIDs 2014-06-26 05:38:22 +01:00
Paul f146a82069 show owner trust in full info 2014-06-26 05:19:11 +01:00
Paul fe89b3a7fb fix erroneous 'untrusted' msg based on validity not trust 2014-06-24 11:39:04 +01:00