Commit graph

8146 commits

Author SHA1 Message Date
Ricardo Mones
f6c690e3c9 Fix bug #3819 “Duplicate definition of global pygtk symbols”
Patch by Hanno Boeck (thanks! :)
2017-05-05 00:20:39 +02:00
Andrej Kacian
c8f81c2007 Use g_strndup() instead of strndup() for better portability.
Fix by Abhay S. Kushwaha.
2017-04-28 13:38:54 +02:00
Ricardo Mones
c6663d2c41 Initialize variable (CID 1405467) 2017-04-28 00:31:17 +02:00
Andrej Kacian
0556ba2def Fix crash in sieve manager window when no account has sieve enabled.
The GtkComboBox gets destroyed in such case, but the 'Refresh'
button handler didn't check for that.
2017-04-24 18:59:10 +02:00
Andrej Kacian
0a83c86dca A fix for a fix in ea866a633. 2017-04-24 07:42:27 +02:00
Ricardo Mones
3ca5da1a13 Unify summaryview icon sizes
There was variety of sizes for the summaryview icons, which have been
moved to a common 12x12 size while keeping the same appearance for
internal theme. This change will allow SVG themes to generate equally
sized icons for summaryview.
2017-04-24 01:51:48 +02:00
Andrej Kacian
ea866a6331 Fix build for webkitgtk versions between 1.5.1 and 1.9.3. 2017-04-23 20:16:58 +02:00
Andrej Kacian
f40de0b8b5 Remove vertical padding from rows in folder selection dialog treeview. 2017-04-23 10:33:19 +02:00
Andrej Kacian
1f15cacbbd Fix building against older webkitgtk versions. 2017-04-22 13:04:57 +02:00
Andrej Kacian
eb0e68e67a Fix get_serverport() in ssl_manager.c to better handle bad filenames. 2017-04-22 10:34:30 +02:00
Andrej Kacian
ab84747295 Fancy: simplify open-or-not decision to x,y matching or not
Fixes bug #3814:  end of mouse drag or text selection erroneously
activates links
2017-04-22 01:15:30 +02:00
Andrej Kacian
fd6bb2ab3c Fancy: correctly handle when text selection event ends on a link
Fixes bug #3813 - "mouse up" activates link even if "mouse down"
occurred outside the link / cannot copy link text

...with a small caveat where this is not implemented for
webkitgtk version  earlier than 1.5.1, because I couldn't find
relevant old enough API documentation.
2017-04-22 01:04:10 +02:00
Andrej Kacian
9bc2a70b66 Remove an unused function - cleanup after 680a2ee67. 2017-04-21 18:02:38 +02:00
Andrej Kacian
680a2ee675 Rewrite ssl_manager cert filename parsing to allow for ipv6 addresses. 2017-04-21 17:57:04 +02:00
Ricardo Mones
da97dac531 Fix use after free 2017-04-18 12:13:33 +02:00
Andrej Kacian
91fad9fcba Promote warn_sending_many_recipients_num from hidden to regular pref. 2017-04-16 11:53:55 +02:00
Andrej Kacian
7c4f81fda6 Fix 'add_to_addressbook' filtering action to correctly add the name. 2017-04-15 19:43:03 +02:00
Michael Rasmussen
73d4891078 Fix bug #3808: Replace icaltime_from_timet with icaltime_from_timet_with_zone 2017-04-14 12:47:41 +02:00
Andrej Kacian
dbec2c7256 Assume direct TLS if SMTP autoconfig finds port 465.
Technically, this is incorrect:
A direct TLS-only SMTP service is against the standards,
and a "_submission._tcp" SRV record should have a port
that has a plaintext+STARTTLS service listening
(RFC 6186, section 3.1).

Port 465 shouldn't even be used for mail submission of
any kind, according to IANA:
(https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml?search=465)

However, everyone ignores that, and port 465 is routinely
used for TLS-only SMTP service, and therefore it is safe to
assume direct TLS instead of STARTTLS.
2017-04-13 09:06:30 +02:00
Andrej Kacian
8e40e71a28 Fix a memory leak around password field in editldap.c. 2017-04-12 17:36:07 +02:00
Andrej Kacian
6c2eb37a0c Add "Show password" checkbox next to LDAP server password field. 2017-04-11 18:10:14 +02:00
Andrej Kacian
dd3dd86abd Add "Show password" checkbox next to password fields in account prefs. 2017-04-11 17:55:46 +02:00
Andrej Kacian
9eb1c969c8 Fix GUI not updating after deleting a tag.
Fixes bug #3744 - Crash upon deleting tags.
2017-04-09 18:31:52 +02:00
wwp
1d4d909086 Fix missing new printer_btn.xpm in make dist archive. 2017-04-05 08:24:48 +02:00
Ricardo Mones
38baadfcf8 Adjust yet another addressbook icon 2017-04-04 00:34:47 +02:00
Ricardo Mones
37d7c5ac53 Adjust addressbook's tree icons
They were too big for the row height and overflowed into the next.
2017-04-04 00:28:51 +02:00
wwp
2736853ffb Fix copy/paste error, thanks to Coverity (#1403767). 2017-04-03 18:12:10 +02:00
wwp
ffa6936f5f Fix missing include for new pixmap file. 2017-04-03 12:41:20 +02:00
wwp
eb81399b76 Add new print button to pdf view. 2017-04-03 12:30:04 +02:00
wwp
c015b47f04 Add new print button to pdf view. 2017-04-03 12:27:05 +02:00
Paul
592315ae17 fix bug 3801, 'Broken auto wrapping' 2017-04-02 12:24:20 +01:00
Paul
6aecd1768d old/new version display 2017-04-02 10:08:38 +01:00
Ricardo Mones
799158990f Really fix bug #3784: Very similar strings in src/gtk/about.c 2017-03-31 20:06:19 +02:00
Ricardo Mones
a8a52797f3 Add missing library to output of --version-full 2017-03-31 20:05:25 +02:00
Andrej Kacian
7c16b7e353 Make sure outgoing messages have a trailing newline.
This fixes a corner case where if the last line of
a message is a quote, its last character doesn't get
displayed when viewing the copy in outbox.
2017-03-30 21:12:52 +02:00
Paul
95ca86061e default selection on entering a folder: make first new|unread|marked message sort-order aware 2017-03-30 08:07:28 +01:00
Andrej Kacian
7cdd09339e Revert "Fix an off-by-one error in textview's quote unfolding."
This reverts commit 8819febec5.
I refuse to be driven to madness by our textview's colorization.
2017-03-30 01:56:48 +02:00
Andrej Kacian
531de2f6b8 Revert "Fix the other off-by-one bug in textview quoting."
This reverts commit 1acb353987.
I refuse to be driven to madness by our textview's colorization.
2017-03-30 01:55:59 +02:00
Andrej Kacian
1acb353987 Fix the other off-by-one bug in textview quoting.
There were two complementary off-by-one bugs, each masking
the other one. Commit 8819fe fixed the first one, thus
unmasking this one.

This should also fix the disgusting bug #3797:
"Unfold quoting renders quotes completely confusing".
2017-03-30 01:04:22 +02:00
Andreas Bierfert
e6db5f2b30 Fix bug #3796 format-security warnings in alertpanel_ use
This patch fixes format-security warnings in alertpanel_ use by passing
"%s" as string and the buffer as va argument if no other va arguments
are present.
2017-03-30 00:42:38 +02:00
Andrej Kacian
8819febec5 Fix an off-by-one error in textview's quote unfolding. 2017-03-27 21:03:23 +02:00
Paul
fb4c4d0ebf update German translator 2017-03-26 09:58:40 +01:00
Ricardo Mones
768c234ad2 Update list of TLDs for release 2017-03-26 00:56:06 +01:00
Andrej Kacian
edc59d5b4b Make summary_show() open-when-selected behavior more consistent.
Fall back to "on folder open" setting when deciding whether
or not to also open the selected message.
2017-03-24 14:04:13 +01:00
Andrej Kacian
76b8816837 Fix timezone handling in procheader_date_parse() on Windows.
This fixes logic error introduced in 029174b.
2017-03-24 11:13:15 +01:00
Andrej Kacian
029174b069 Fix crash on e-mails with invalid date on Windows.
This fixes crashing on dates with out of range numbers,
e.g. "Sun, 19 Mar 2017 27:41:31 +0600".
2017-03-20 19:52:11 +01:00
Michael Rasmussen
9fb2bb2b59 Update copyright year 2017-03-19 23:06:58 +01:00
wwp
cce5b68054 Correct/update comment. 2017-03-19 19:42:04 +01:00
wwp
3595d6c625 Fix bug 3785: custom headers not stored in queued messages (and thus,
not sent).
2017-03-19 12:13:28 +01:00
Ricardo Mones
b99f30096d Fix bug #3784: Very similar strings in src/gtk/about.c
And remove also some \n from translatable strings.
2017-03-19 00:25:43 +01:00