Commit graph

8146 commits

Author SHA1 Message Date
Andrej Kacian
8baab85304 Add more granular options on when to open a selected message.
There are now several checkboxes in Display/Summaries page.
The checkbox in folder open selection dialog has been removed,
since that checkbox is among the new ones.

The option "always_show_message_when_selected" is now boolean,
instead of a tri-state.

This commit also removes function summary_display_by_msgnum(),
and its functionality was moved to summary_select_by_msgnum(), which
has a new boolean argument to control whether or not to display the
selected message.
2017-03-18 22:00:12 +01:00
Michael Rasmussen
81b66ecc88 Use fix bug #3787 for specifying format as well 2017-03-18 20:58:33 +01:00
Michael Rasmussen
3096aa1d94 Fix bug #3787. Create tooltip i helper function 2017-03-18 20:43:47 +01:00
Paul
f0fbc524ae improve label text 2017-03-18 12:21:14 +00:00
Andrej Kacian
b06be7caf1 Show context of foldersel dialog in a label, instead of in a title.
This is a follow-up commit to bd8213.
2017-03-18 12:41:41 +01:00
wwp
3f01dc8712 Fix typos, fixes bug 3786: typo in src/mimeview.c. 2017-03-18 00:21:50 +01:00
Andrej Kacian
bd8213fe3d Allow custom window title for the folder selection dialog.
Fixes bug #3582 - Select folder dialogue does not tell what is
selecting for.
2017-03-16 19:15:18 +01:00
Andrej Kacian
e420063586 Added summary_get_selection_count() function. 2017-03-16 18:37:30 +01:00
Andrej Kacian
3fd978a7dd Initialize icaltimetype variables in Vcalendar's feed_fetch().
Also print out debug output if an event has no start or end,
as it can help determine why a malformed event file shows
weird times or duration.
2017-03-13 19:03:25 +01:00
Andrej Kacian
69ed24f94f Remove obsolete files icaltime_as_local.[ch]. 2017-03-13 18:18:57 +01:00
Andrej Kacian
21d4407617 Added debug output for failure cases in sgpgme_data_release_and_get_mem() 2017-03-08 12:07:51 +01:00
Ricardo Mones
e4f6b0b306 Declare and use only when needed 2017-03-04 12:46:21 +01:00
Andrej Kacian
8d14c43a29 webkitglobals.h exists since 1.3.10, not 1.3.13.
Patch by Olaf Hering <olaf at aepfle.de>
2017-03-04 00:45:18 +01:00
Andrej Kacian
9327286516 Add support for date-only variant of ISO8601 timestamp format.
Fixes bug #3777 - Weird news dates for some RSS feeds
2017-03-04 00:12:29 +01:00
Ricardo Mones
a8cbb1bbd9 Remove unused variable
prefs_actions.c:594:12: warning: unused variable ‘action_nb’
2017-03-02 16:36:33 +01:00
wwp
a8e50abd15 Reduce translators' work by merging almost-duplicated strings
(reported by Pader Rezso).
2017-03-01 16:52:34 +01:00
Paul
b83aa87688 fix disabling prefs_common.warn_sending_many_recipients_num by unchecking the 'show this msg again' checkbox in the dialogue 2017-03-01 13:13:24 +00:00
Ricardo Mones
affc68a9b8 Make 'Save all...' report more accurate
Thanks Woody for nitpicking.
2017-03-01 10:45:49 +01:00
Paul
b68be74a31 bump copyright year 2017-03-01 08:02:03 +00:00
Ricardo Mones
0b164a349d Simplify hidden prefs for too many recipients 2017-02-27 23:59:19 +01:00
wwp
68274612f4 Fix bug #3775, wrong plural form string. 2017-02-27 13:36:58 +01:00
Olivier Brunel
e3b7197f8b Fix memory leak
Signed-off-by: Olivier Brunel <jjk@jjacky.com>
2017-02-25 22:51:18 +01:00
Ricardo Mones
300f811f3b Remove duplicated code and include 2017-02-25 13:14:35 +01:00
Andrej Kacian
a0cd163714 Replace verbosity boolean flag with a bitfield of flags.
Currently, there are two - whether or not to show error dialogs
and whether or not to show a feed rename dialog after subscribing.

We use same enum typedef for subscribing and fetching/updating
for consistency, the second flag only has effect in rssyl_subscribe().
2017-02-25 11:43:26 +01:00
Andrej Kacian
ae3a830bd1 Remove rssyl_feed_subscribe_new(), it was redundant.
rssyl_subscribe() is almost identical, so it is used instead.
Some minor usability issues that arise from this change will
be fixed in next commit(s).
2017-02-25 11:32:52 +01:00
Ricardo Mones
91af1a4bee Fix bug #3741: Deleting an account doesn't delete imapcache
Based on initial patch by Paul and in exchange of a reviewed
patch for 3582 ;-)
2017-02-24 23:54:27 +01:00
Andrej Kacian
cc3882f360 Remove internal libytnef and require an external one instead. 2017-02-24 20:49:40 +01:00
Ricardo Mones
bbeb55d2ed Do not hardcode resolv.conf location 2017-02-16 22:57:37 +01:00
Paul
8f2c1491f8 use xdg-open as default mime_open_command 2017-02-16 13:49:00 +00:00
Ricardo Mones
d6dfb9960c Fix 'Apply' when changing scaling options only 2017-02-16 00:40:46 +01:00
Ricardo Mones
5d95cf07a8 Remove spurious comment 2017-02-14 01:00:56 +01:00
Ricardo Mones
14a997dea0 Migrate icon filename stored in toolbar XML files
Thanks Paul for the hint.
Completes commit 50bd87f2e1.
2017-02-14 00:58:59 +01:00
wwp
4f33789a0c Fix impossible action duplication: don't check for duplicate action name
when saving/duplicating (we're not doing this elsewhere and I don't see
the point in doing it here).
2017-02-13 18:55:28 +01:00
Paul
947c2b6e3c add Bcc to default headers in drop-down 2017-02-13 15:20:53 +00:00
Ricardo Mones
50bd87f2e1 Fix pixmap name to reflect what it really does
Will break your themes, nothing a mv cannot fix ;-)
2017-02-11 16:47:50 +01:00
wwp
579f91dc8b Fix wrong return value type. 2017-02-08 23:33:38 +01:00
Ricardo Mones
147fa58416 Set same size as its companions (new and unread) 2017-02-08 20:22:14 +01:00
Ricardo Mones
6011240801 Fix included header
Error message was:
stock_pixmap.c:26:26: fatal error: librsvg/rsvg.h: No such file or directory

Thanks Paul for reporting!
2017-02-07 21:07:16 +01:00
Ricardo Mones
1ef7efbc70 User interface for SVG preferences 2017-02-07 20:02:58 +01:00
Ricardo Mones
89eb1e67c5 Add SVG icon scaling/rendering preferences
• 'enable_alpha_svg' to use alpha channel when rendering
• 'enable_pixmap_scaling' to bypass SVG's own natural size
• 'pixmap_scaling_auto' to compute a PPI or use a user defined value
• 'pixmap_scaling_ppi' to set a user defined value for PPI
2017-02-07 20:02:58 +01:00
Ricardo Mones
427ba2698e Render SVG scaled to default icon size
Default icon sizes are parsed from icon data, which is suboptimal
since these sizes can be known at compile time.
2017-02-07 20:02:58 +01:00
Ricardo Mones
db434c2b05 Load SVG files the deprecated way 2017-02-07 20:02:58 +01:00
Ricardo Mones
cdf48fc3e9 Configure SVG library
• New feature flag HAVE_SVG, enabled by default if dependencies
  are available (librsvg-2.0 >= 2.36.0).
• New item in About window's Features tab for librSVG.
2017-02-07 20:02:58 +01:00
Ricardo Mones
56ec09cbfa A bit more room for alertpanel messages
And same room for all of them. The current sizes were so small that
a somewhat large list of failed-to-load plugins appeared truncated
in the warning message.
2017-02-06 14:28:15 +01:00
Paul
2a90c1d2f0 remove unused variable 2017-02-05 08:46:24 +00:00
Paul
32ac23cdd5 no tranlslation needed here 2017-02-05 08:38:57 +00:00
Michael Rasmussen
1950c0973e Fix build when using alternate addressbook 2017-02-05 01:13:03 +01:00
Andrej Kacian
2bf719fcbf Make --disable-dillo-plugin actually do something. 2017-02-04 19:08:51 +01:00
Andrej Kacian
e010e3551e Unify display of event times in vCalendar's mimeviewer on Windows and Unix.
We now use g_date_time_format() on both. Also, display
timezone abbreviation (%Z) instead of offset (%z) in the
strings.
2017-02-04 17:35:20 +01:00
Andrej Kacian
38131c96c1 Handle timezones correctly in vCalendar.
We convert DTSTART and DTEND to UTC as soon as possible,
using the VTIMEZONE info. The convert_to_utc() function
should be able to handle several timezone definitions and
events using those several different timezones in one ical
file, picking the correct one for converting each event.
2017-02-04 17:33:07 +01:00
Andrej Kacian
9200a68743 Use PLUGIN_NAME macro instead of "vCalendar" string literal internally. 2017-02-04 14:18:03 +01:00
Ricardo Mones
4eab156958 Oops! forgot one themeable icon in pdf_viewer
Completes commit 89d34855ea.
2017-02-04 12:55:21 +01:00
Andrej Kacian
11cadab162 Make a relative signature_path relative to home directory.
This applies only if corresponding signature_type is SIG_FILE.
2017-02-03 19:03:19 +01:00
Andrej Kacian
2016b17dad Moved found_in_addressbook() from plugins to core.
Four identical copies of the same functions removed
from four plugins and put into addr_compl.[ch].
2017-02-03 17:48:02 +01:00
Ricardo Mones
02a57d6786 Make all headers abide by config and features 2017-02-03 12:56:31 +01:00
wwp
1e068dbfc2 Re-introducing the Dillo plugin. Tested against Dillo 3.0.4.1/3.0.5. 2017-02-02 18:06:27 +01:00
Ricardo Mones
2e9cc8cca6 Remove obsolete font prefs 2017-01-31 20:02:51 +01:00
Ricardo Mones
8e02f3f3c6 Generalise theme extension handling 2017-01-31 12:21:45 +01:00
Paul
8925ab226b vCalendar plugin: use external libical
closes bug #3764
patch by flo.xfce@gmx-topmail.de
2017-01-27 15:56:47 +00:00
Paul
53f3cf1c25 sensitise trayicon's 'get mail' and 'exit'
patch by Olivier Brunel
2017-01-27 15:40:27 +00:00
Paul
6715c6b58e add shadow to rule list (like everywhere else)
patch by Olivier Brunel
2017-01-27 15:37:06 +00:00
Paul
deb42e32ff when renaming folder, only update summaryview folder name if the current folder is being renamed
patch by Olivier Brunel
2017-01-27 15:32:11 +00:00
wwp
ce16e266f5 Fix typos and a wrong switch expression (coverity CID #1399549). 2017-01-24 07:41:39 +01:00
Ricardo Mones
9c26d835ef Better error handling and feedback for save all attachments 2017-01-23 23:48:18 +01:00
wwp
3a84a64d03 No need to test what g_malloc returns, as if it fails, it stops the
program.
2017-01-21 23:51:31 +01:00
wwp
20ad778b08 Always show a notice dialog after delete-dupes, even if nothing has
been deleted. Make a better notice when it's about marking as delete
(for later deletion when execute is done). Always say we're deleting
dupes, in status bar.
Fix toolbar item sensibility even though if it's not perfect since
the whole button dropdown menu can't be accessed if current folder
can't be searched for dupes.
2017-01-21 15:12:43 +01:00
wwp
18403c8b8b Show attachments total size in compose window's relevant tab (only counts
attachments size, not encoding or body part, it is not the email
total size).
2017-01-21 12:58:50 +01:00
wwp
a1b7175d0b Main window's toolbar delete dupes button is now a dropdown, allowing
both duplication in selected folder and in all folders. Clicking the
button still raises the deletion in selected (current) folder.
2017-01-20 23:18:56 +01:00
wwp
c082dff510 Update func name in g_warning message (_full() may matter since
this _func() function is also called directly).
2017-01-20 18:02:09 +01:00
wwp
705f448caf Normalize rfc822 date handling by using decent buffer sizes everywhere (128,
which is way more than what RFC822 says: 37 max) and specific buffers.
2017-01-20 10:48:08 +01:00
wwp
db6a1558f9 More work on default pixmaps theme, few details in corners to get
icons look nicer on dark and light backgrounds.
2017-01-19 16:39:28 +01:00
wwp
f806a49d36 Add "Delete duplicates" (delete duplicated messages in current folder) to
the main window's toolbar, including a brand new (not so shining) icon.
2017-01-19 14:49:06 +01:00
wwp
9fc2c3acb3 Fix a memory leak. 2017-01-19 14:26:06 +01:00
wwp
e5d028a1f5 Make few edit fields wider in matcher dialog, better suit their
use (addressbook name, command-line, etc.).
2017-01-18 21:55:02 +01:00
wwp
9657f8bebc Fix bug 3762, 'redirect fails'
by removing an check added at 3.14.1.39-g989b3a3, thought I was hardening
sanity checks and I changed the logics, making it fail while in normal
situation. Removed few more extraneous checks.
2017-01-18 21:48:50 +01:00
wwp
ff51eec7ab Improvements and fixes in the folder search: prevent changes in
criterias while the search is performing (disable appropriate widgets).
Better disabling/enabling of widgets when changing search modes or
state.
Discard current cached search when switching from/to advanced
search or changing the case sensitivity or changing the matching
any/all mode.
2017-01-17 22:44:30 +01:00
wwp
c0505b80f1 Fix bug 3251, 'A translated In-Reply-To header is sent translated'
by making sure we're always storing untranslated headers.
Optimize and sanitize a bit the code around it, too.
2017-01-17 13:41:52 +01:00
Ricardo Mones
11840607c9 Better English (thanks Paul for reference) 2017-01-17 11:09:45 +01:00
Ricardo Mones
518c0b205e Update quicksearch info to cope with rfe 2260…
…until it's really fixable, if ever.
2017-01-17 00:59:27 +01:00
wwp
033bbdd7cd Fix Coverity CIDs #1398812, #1398813, #1398814.
Will convert compose_convert_header needs for fixed buffers later.
2017-01-16 18:29:15 +01:00
wwp
989b3a3f51 Fix bug 3571, 'recipient list lost and truncated'
by replacing lots of fixed-size buffers with dynamically
allocated ones.
Also enforce checks by adding or fixing few sanity tests,
fix returned value of some functions in some tricky cases.
2017-01-16 16:35:13 +01:00
wwp
18227b9fc9 Fix g4850949 (use correct API calls). 2017-01-16 12:57:36 +01:00
wwp
4850949dad Fix yet another average leak in matcher.c when parsing headers (valgrind). 2017-01-16 11:54:24 +01:00
Paul
93c6983e1c fix bug 3734, 'undefined symbol error with flex-2.6.2'
Patch by Ashish Gupta
2017-01-16 10:30:17 +00:00
wwp
2fbcc0fcef Fix another (not so big but still common) leak, thanks to valgrind. 2017-01-16 11:03:35 +01:00
wwp
c5b631cdb8 Fix big leaks (thanks to valgrind) in filtering/matching by headers,
saved (lots of) megabytes here.
2017-01-16 10:33:05 +01:00
wwp
bcb8cb4e9d Revert part of 3.14.1-128-g498b61c, fixing Coverity CID #1398594.
Instead of really fixing the wrong call to g_strdup_printf, I prefer
not touching libical code, we'll see later what to do w/ it.
2017-01-14 08:34:57 +01:00
wwp
498b61cc58 Prefer dynamically allocated buffers to fixed-size ones, use the same 2017-01-13 09:19:41 +01:00
wwp
a875f48b7d Don't dump more than 100 char in g_warnings about missing HTML tags errors
while parsing, unless --debug mode is set.
2017-01-13 08:46:13 +01:00
wwp
b9dd4fb837 Revert ga0fbaac (3.14.1-88) as it gets things worse in folder search,
waiting for a proper fix.
2017-01-13 08:45:16 +01:00
wwp
d1d7ad9aad Warn when sending to more than N recipients. This features obeys
to a couple of hidden prefs:
 warn_sending_many_recipients (TRUE/FALSE)
 warn_sending_many_recipients_num (1-1000)
2017-01-12 17:26:30 +01:00
wwp
1ee234f75c Add context missing info to few system call errors (mostly:
file operations).
2017-01-12 16:31:10 +01:00
wwp
77e2223bbb Remove dead code, fixing Coverity CID #1398568. 2017-01-12 10:06:22 +01:00
wwp
91300009f4 Rework logics, remove dead code. Solves Coverity CID #1220297. 2017-01-11 23:19:22 +01:00
wwp
dad5b3e32a Kill dead code, fixing Coverity CID #1220511. 2017-01-11 22:41:28 +01:00
wwp
8ae6e56758 Remove accidentally added xpm file. 2017-01-11 16:38:31 +01:00
wwp
34fd77ccef Add deallocation call. 2017-01-11 16:35:05 +01:00
wwp
de7bb00b0c Quit function if no connection instead of assigning variable that
will be overwriten right after.
Fixes Coverity CID #1372370.
2017-01-11 16:09:08 +01:00
wwp
f986aa1d86 Rework icon antialiasing to look OK on dark and light themes. 2017-01-11 11:03:56 +01:00
wwp
2b41515a33 POPPLER_ACTION_MOVIE was not introduced w/ Poppler 0.14.0, but in
a version so old that even my grandma was using it (0.3.0 in fact).
2017-01-11 01:56:22 +01:00