gfgit/claws-mail
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
10018 commits 7 branches 0 tags 60 MiB
Commit graph

8146 commits

Author SHA1 Message Date
wwp
34fb7f005f Rework icon antialiasing to look OK on dark and light themes. 2017-01-11 01:31:05 +01:00
wwp
b15774d193 Don't #undefine UNIX_PATH_MAX, move #define's up. 2017-01-10 16:19:29 +01:00
wwp
72625ef0e7 Be more clear about what 108 means here towards the Unix socket 
path value lenght: rely on UNIX_PATH_MAX and fallback to its common
value '108' in not defined in un.h (caution, on other systems, it could
be 104, etc. down to 92).
 2017-01-10 15:58:05 +01:00
wwp
32955775f6 Fail if attempting to create a UNIX socket w/ path len >108c. 
Add few checks more for socket operations, and reduce few duplicate
initializations.
Saves us warnings and sikves Civerity #1372360.
 2017-01-10 14:51:09 +01:00
wwp
619164ab29 Fix Coverity CIDs: 1220259 1364687 (and discarded 1220496) and added more checks for returned 
values.
 2017-01-10 10:10:05 +01:00
wwp
16b5db8d3a Fix Coverity CIDs: 1220274 and 1220377. 2017-01-10 09:59:52 +01:00
wwp
37b65a4db7 Real fix for Coverity 1372362. 2017-01-10 09:36:31 +01:00
wwp
0b238a22d6 Don't behave as if avail_d was not hardcoded, it is hardcoded 
to 7, and do it properly.
Saves us a warning and solves Coverity #1372366.
 2017-01-10 09:31:34 +01:00
wwp
e3cd98f9f3 Better fix for Coverity #1220388, use effective indexes and boundaries. 2017-01-10 09:26:08 +01:00
Paul
d18fa86729 fix typo 2017-01-09 11:37:25 +00:00
wwp
87b362fc33 Fixes Coverity CIDs: 1220388 1372362 1220222 1358399 1223756 1223757 1220305 1220269 1220243 1396991. 2017-01-09 11:37:18 +01:00
Ricardo Mones
be36f031fa Attachwarner: fix leaked string 2017-01-09 00:37:04 +01:00
wwp
a7a4f21742 Fix a leak. 2017-01-07 00:46:20 +01:00
wwp
d6deeaa61c Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws 2017-01-05 18:39:21 +01:00
wwp
be32eb07b7 Rework antialiasing a bit around toolbar and logo icons, in order 
to better fit dark background themes (but still be fine w/ light ones).
 2017-01-05 18:36:43 +01:00
wwp
cdbf2c37c3 Revert parts of 3.14.1-91 (the summary_select_node_no_mard_read func), obviously it's 
been accidentally included in that commit and the origin of this modification is still
undetermined.
 2017-01-05 10:56:46 +01:00
wwp
471d243cf7 Fix wrong function definition, declare it before using it, and make it 
static.
 2017-01-05 10:21:50 +01:00
wwp
9a20d31a23 Fix wrong libarchive version check. 2017-01-04 17:16:09 +01:00
wwp
3a66d2e101 Make the FOO vanish. 2017-01-04 11:32:19 +01:00
wwp
c7af8ad4b2 Fix marking all as (un)read recursively when the confirmation 
dialogue is enabled and the user clicks No: confirmation dialog
was taken into account just for the current folder, subtree was
marked anyway, and this only under certain conditions that I'd
prefer not to list here becau<woosh>
 2017-01-04 11:14:15 +01:00
wwp
d287120c94 Rename a misnamed function, remove debug statements. 2017-01-04 09:13:05 +01:00
wwp
8cc21bf46a Fix missing array initializers and line everything up. 2017-01-03 23:36:33 +01:00
wwp
2b85c3daaa Fix missing array initializers and line everything up. 2017-01-03 23:12:02 +01:00
wwp
eaa8a3ebd8 Really align array (using whitespaces). 2017-01-03 22:31:13 +01:00
wwp
91c5187539 Cosmetic changes: align arrays, remove debug statements. 2017-01-03 22:20:59 +01:00
wwp
cdb10d81eb Archiver plugin update and review: 
- updated to support some of the compression formats up to libarchive 3.2.2,
- detect libarchive 2.8+ using pkgconfig,
- use alertpanel API instead of creating gtk dialogs from scratch (with missing
- dialog title, and no clue about what is displayed),
- configure script now makes use of libarchive pkgconfig,
- fixed wrong use of cached page struct info, we do now rely on data set in widgets
  to get source folder and target archive filename and sync the page struct info w/ it
  when needed,
- renamed gzip/zip to gzip,
- reworked the way archive formats and compression formats lists are displayed (not translatable anymore).
- reformat code a bit.
 2017-01-03 19:14:10 +01:00
Holger Berndt
abf4b98214 GData plugin: Require libgdata at least 0.17.2 
Version 0.17.2 is required for auth token save/restore accross restarts.
Without this functionality, the plugin has such bad usability, it's not
worth maintaining. This also fixes the previous compile-error when only
0.17.1 was present.
 2017-01-03 11:20:11 +01:00
wwp
a0fbaacf17 Fix 'search folder' not working in some cases (it needs a 'clear' click to 
work or to manually clear search fields).
Fix provided by Paul, the be(a)st.
 2016-12-29 13:42:46 +01:00
Paul
38af4d7654 make Go to/[Next|Prev] sort order aware 2016-12-28 12:55:04 +00:00
wwp
b2b913e310 Fix compiler warnings when we test enum-based variables for impossible 
<0 values.
 2016-12-27 18:06:11 +01:00
wwp
f69f1588a9 Factorize toolbar reset code, and don't compute array sizes using 
unsafe calculations.
 2016-12-27 18:04:42 +01:00
wwp
30a1c0875f Fix enum boundaries we check in func_selection_changed (when 
changing the internal function assigned to a toolbar item).
Just a theoretical issue here apparently, or we would have had
problems since ages.
 2016-12-27 18:02:55 +01:00
wwp
878b6d7a20 More places where printf() and C_() have to be separated. 2016-12-27 17:58:47 +01:00
wwp
0372b283a8 Line-up arrays (w/ space chars only). 
Fix missing array initializers.
 2016-12-27 16:02:27 +01:00
wwp
66d2176e8b Silent up a compiler warning by making the ComposeCallAdvancedAction 
enum a real integer-scope ([-1 .. n] instead of [0 .. n]), swallowing
the -1 value check.
 2016-12-27 15:20:53 +01:00
wwp
571de7f509 Revert "Revert "Revert g9737584."" (but the fix) by reimplementing 
the thing differently: don't mix printf() and C_() as it messes the
compiler up.
Factorize a bit format errors in compose.c.
Make some header names translatable following prefs in the
address keeper plugin.
 2016-12-27 15:11:00 +01:00
wwp
6b68aee40d Fix a leak. 2016-12-27 13:12:22 +01:00
Ricardo Mones
ec9e88d3df Revert "Revert g9737584." and fix it ;) 
This reverts commit 834ee304 which was reverting a previous
commit which broke build because of an extra comma. This
reverts the revert and removes the comma.
 2016-12-27 13:08:00 +01:00
wwp
834ee30437 Revert g9737584. 2016-12-27 12:57:37 +01:00
wwp
9737584876 Add translation context helper text where some %s' are used and 
their meaning is not obvious.
 2016-12-27 12:16:56 +01:00
wwp
dbdfae6969 Capitalize header names (as everywhere else). 2016-12-21 16:01:36 +01:00
wwp
69eaf525fa More translatable header names in UI strings. 2016-12-21 15:52:41 +01:00
Ricardo Mones
b281fcac67 Remove unnecessary commas 
They were added by mistake in f455e02c.
 2016-12-21 15:17:02 +01:00
Andrej Kacian
e31ee60178 Stop left/right keypresses from propagating further in foldersel. 
This amends commit 5305715.
 2016-12-21 13:21:03 +01:00
Andrej Kacian
123563ca47 Moved compose_can_autosave() outside of #ifdef G_OS_UNIX. 2016-12-21 12:57:47 +01:00
wwp
596d44ce3c Fix wrong string split and list of arguments. 2016-12-21 10:08:13 +01:00
Andrej Kacian
cf9cab50cb Removed an unneeded trailing '\' from Windows' START_TIMING. 
Well spotted by Pierre Fortin.
 2016-12-20 23:31:16 +01:00
wwp
4a92e36b32 Fix extra arguments to g_strdup_printf (thanks to coverity scan), 
add quotes around header names in few dialogs.
 2016-12-20 23:01:29 +01:00
wwp
a38971609f Fix untranslatable concatenated strings (i.e. "Default "+"To:"), 
normalize few uses of header names in UI.
 2016-12-20 11:50:46 +01:00
Andrej Kacian
53057151de Use left/right keys to collapse/expand rows in foldersel dialog. 
Further keypress will move the cursor to parent
or first child, respectively.
 2016-12-19 21:30:45 +01:00
Andrej Kacian
5a66116ee9 Allow toplevel folders to be copied. 
They are created as regular folders in target mailbox.
 2016-12-19 20:51:21 +01:00
Andrej Kacian
22d94ce01f Do not strip plus sign when drag&drop attaching files. 
Closes bug #3742.
 2016-12-18 22:34:44 +01:00
Paul
e3bb5c6ac8 fix black on black in From header 2016-12-16 10:21:31 +00:00
wwp
77a2981141 Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws 2016-12-16 09:16:15 +01:00
wwp
19430d77d5 Silent up coverity scan. 2016-12-16 09:15:45 +01:00
Ricardo Mones
abc9d9cd40 Fix initialization of two pixmaps 2016-12-15 19:57:27 +01:00
wwp
b4d895b8b8 Fix possibly broken toolbar_compose.xml by migrating A_SENDL actions names 
to A_SEND_LATER. An attempt to rewrite the whole toolbar .xml file was done
when only a part of it was read, leading to toolbar elements loss; the
rewrite of migrated toolbar configs is now done a posteriori.
Also, the renaming/migration magics swallowed the existing one
for A_SYL_ACTIONS.
 2016-12-14 11:06:18 +01:00
wwp
a34523c618 Merge branch 'master' of ssh+git://git.claws-mail.org/home/git/claws 2016-12-13 08:57:52 +01:00
wwp
884055d3bd Internal API change: split read/unread marking features from functions used 
to mark as read/all read using a parameter.
 2016-12-13 08:56:27 +01:00
Andrej Kacian
1a505326d0 Also update authors.h for commit ea40116. 2016-12-13 01:01:23 +01:00
Andrej Kacian
ea4011632f Honor autosave_encrypted preference when using external editor. 
Patch by Ashish Gupta <ashmew2@gmail.com>.
 2016-12-13 00:55:24 +01:00
wwp
4b9f6e2b63 Fix table order. 2016-12-12 19:41:56 +01:00
wwp
9c47b608f7 Fix missing items in summaryview's menu declarations. 2016-12-12 19:28:06 +01:00
Paul
1340b93c5b make list a bit more manageable and remove duplicated items 2016-12-12 17:03:23 +00:00
wwp
a8aa3fc220 Fix wrong call to missing *_unread func (we use the *_read() func 
w/ FALSE as parameter for that).
Add missing new xpm files to Makefile.am.
 2016-12-12 17:36:05 +01:00
wwp
382a3fed9d Add new actions to main window's toolbar: mark, unmark, lock, unlock, 
mark (all) read, mark (all) unread.
Add new xpm icons for these actions (existing ones are small and made
for the message list) as well as for ignorethread and watchthread
actions.
Rename A_SENDL to A_SEND_LATER, we're not that lazy.
 2016-12-12 15:30:24 +01:00
wwp
b7df74e8f5 Add new mark-all-unread (and recursively when relevant) action to folder 
context menu, message list and main window menu.
 2016-12-12 15:17:15 +01:00
Paul
773ddbbae8 rename compose_guess_forward_account_from_msginfo() to compose_find_account() 2016-12-12 14:02:28 +00:00
Paul
3bbea866fa rename compose_entry_mark_default_to() to compose_entry_indicate() 2016-12-12 13:58:16 +00:00
wwp
b3d90c51d0 Rename default_to_(bg)color hiddeng pref and variable to default_header_(bg)color. 2016-12-12 14:24:14 +01:00
wwp
c0c22eb997 Fix format, no tabs to align everywhere (at last!). 2016-12-12 14:17:43 +01:00
wwp
7d84a8a996 Remove extra entries, not yet in git. 2016-12-12 14:14:37 +01:00
wwp
f455e02c81 Fix missing initializers (last field in data struct), 
reworked table to a human readable format.
 2016-12-12 14:10:04 +01:00
Paul
70795ea5d1 more highlighted of automatically set header entries in Compose window 
fix highlighting of multiple addresses set in account prefs
highlight From if not current account
 2016-12-12 11:39:16 +00:00
Paul
3f46e81d2c don't remove the To when changing account 2016-12-12 10:17:59 +00:00
Paul
f37bbdecf9 some more colouring based on folder prefs override 2016-12-11 17:44:32 +00:00
Paul
5f607a33a7 fix colouring of auto-filled headers 2016-12-11 10:04:30 +00:00
Ricardo Mones
9123296406 Fix bug #3574: Template addressing 
Remove artificial limitations to values of email addresses on templates:
these strings are already parsed and split when the template is applied
in compose window.
 2016-12-10 13:32:41 +01:00
wwp
d21adbda39 Make last colors configurable using hidden prefs: tags bg/fg colors in 
message view, default-to header field in compose view, and quicksearch
active + error.
 2016-12-09 17:42:46 +01:00
wwp
627f7110c9 Revert "Remove dead code, this changed signal doesn't exist and we've also". 
This reverts commit fe0f832b37.
 2016-12-09 16:26:21 +01:00
wwp
fe0f832b37 Remove dead code, this changed signal doesn't exist and we've also 
probably removed parts of the highlight-active-account field feature
a while ago.
 2016-12-09 16:21:29 +01:00
Ricardo Mones
7794350956 Update authors lists 2016-12-06 13:17:06 +01:00
Ricardo Mones
828fdc64ec Fix Debian bug #846170: incorrect IMAP UID handling 
Patch by Darac Marjal <darac@darac.org.uk>
 2016-12-06 13:07:32 +01:00
Andrej Kacian
bac0338c95 Enable icons of stock GTK buttons on Windows. 2016-12-02 12:48:30 +01:00
Andrej Kacian
681532e4c5 Fix closing of description window using WM controls. 
Closes bug #3740.
 2016-11-29 19:23:14 +01:00
Paul
25bab9dcc9 on first run, use --alternate-config-dir (if set) on prefs migration 
prevents useless creation of ~/.claws-mail directory
 2016-11-28 12:50:32 +00:00
Andrej Kacian
08916bffe4 Fix more compile warnings for Windows in socket.c. 2016-11-24 21:03:34 +01:00
Andrej Kacian
504dd92adc Removed unused w32_get_uid_equiv() function. 2016-11-24 21:03:34 +01:00
Andrej Kacian
0d330cb779 Fix two unused variable warnings in ssl.c for Windows build. 2016-11-24 20:05:58 +01:00
Paul
4d7461d727 make go to next/previous sort order aware 2016-11-23 14:06:21 +00:00
Paul
e7206c0db7 don't ignore auto-account selection when forwarding on IMAP and NNTP accounts 
patch by Blatinox
 2016-11-22 09:52:06 +00:00
Paul
dc84b54f83 obey 'always_show_msg' on "no more [...] msgs. go to next folder?" 2016-11-21 08:47:52 +00:00
Paul
c95de2bcb0 fix 'Go to' moving off current, unopened msg, and dialogue to go next folder 
T
 2016-11-17 19:19:08 +00:00
Paul
81d0b58adc fix text selection when double-clicking quoted text and 'collapse quoted text on double click' is turned off 
Patch by Andrej
 2016-11-17 09:46:31 +00:00
Paul
caa00289e8 amendment to last commit, to avoid interfering with Shift+[Up|Down] 2016-11-16 17:01:08 +00:00
Paul
a7c6921d57 make up/down key navigation obey 'always_show_msg' 2016-11-16 16:30:15 +00:00
Paul
860ccbc87f fix some menu sensitivity issues 2016-11-16 08:47:03 +00:00
Andrej Kacian
afe0203a64 Use summary_select_node() more, to get more consistent behaviour. 2016-11-14 18:37:04 +01:00
Andrej Kacian
ad839919d8 Improve scrolling in summary_key_pressed(). 2016-11-12 23:05:42 +01:00
Andrej Kacian
4006b1258c Allow sending empty messages in Session (just \r\n). 2016-11-12 20:04:44 +01:00
Andrej Kacian
75fcc188b6 Add open_selected_on_folder_open to common prefs. 
This option overrides always_show_message_when_selected
option when selecting initial message during folder open.

This is useful so that the message's unread flag doesn't
get unset before user had the chance of noticing it, or
that an overly large message doesn't get automatically
selected if user doesn't want it (e.g. IMAP over a slow
connection).
 2016-11-11 17:31:09 +01:00
Andrej Kacian
7322c825c7 Honor display_msg == 0 in PostponedSelectData struct. 2016-11-11 17:31:09 +01:00
wwp
36d5d93bf5 Get rid of this \t char. 2016-11-07 18:25:42 +01:00
Ricardo Mones
f8de086672 Fix space after comma 2016-11-06 18:12:40 +01:00
Paul
42c355d266 fix string. thanks to Pierre Fortin. 2016-11-06 12:35:47 +00:00
Ricardo Mones
8201993d01 Update list of TLDs for release 2016-11-06 11:19:39 +01:00
Paul
6ca72685e7 missing from g8bd6066 2016-11-05 11:46:05 +00:00
Andrej Kacian
aaa7ab7d3e Minimize scrolling in gtkut_ctree_node_move_if_on_the_edge(). 
Instead of scrolling to get the target row to the middle of
the viewport (offset 0.5), scroll to offsets 0.2 or 0.8 if
the target row is above or below current viewport,
respectively. This makes it consistent with scrolling when
the target row is only partially visible.
 2016-11-05 12:18:53 +01:00
Andrej Kacian
2193529a58 Only scroll summaryview to the middle when necessary. 2016-11-05 12:00:33 +01:00
Andrej Kacian
94030d1aa5 Do not process folder marks when just refreshing summaryview. 2016-11-05 11:09:59 +01:00
Paul
8bd6066d2b more fixes for Go To actions not obeying 'always_show_msg' option 2016-11-05 10:02:18 +00:00
Andrej Kacian
512b1eba01 Added missing symbol to vcalendar's claws.def. 2016-11-04 12:16:19 +01:00
Ricardo Mones
f755acc92b Update license stanza 2016-10-27 15:32:59 +02:00
Ricardo Mones
89d34855ea Make pdf_viewer icons themeable 2016-10-26 23:39:23 +02:00
Paul
8352f9b6a0 removed unnecessary do_refresh flag from summary_select_node() 2016-10-26 15:34:08 +01:00
Paul
f9b68fc09c in the UI replace 'POP3' with 'POP' and 'IMAP4' with 'IMAP' 2016-10-25 12:21:07 +01:00
Paul
59e8c1a1e7 and another 'SSL' to 'SSL/TLS' 2016-10-25 11:31:49 +01:00
Paul
a87b48979b more 'SSL' to 'SSL/TLS' 2016-10-25 11:15:39 +01:00
Paul
484ab8c24f more 'SSL' to 'SSL/TLS' 2016-10-25 11:15:02 +01:00
Paul
112b21df10 rename SSL to SSL/TLS 
Using just 'TLS' is ambiguous. Sometimes it refers to encrypted
connection with TLSv1.0/1.1/1.2, sometimes it refers to STARTTLS
command. So be more specific about what is what.

Patch by Christian Hesse, with some modifications
 2016-10-25 10:36:35 +01:00
Paul
5f01319281 make /View/Go to/... respect the always_show_msg option, and refactor a bit 2016-10-25 10:13:53 +01:00
wwp
dd8c448efa While we're at it, fix typos like prefered occurences in variable names. 2016-10-22 14:56:58 +02:00
Ricardo Mones
8db8d39549 Fix typo (thanks lintian.d.o!) 2016-10-22 12:57:49 +02:00
Ricardo Mones
53ea6f806c Fix resource leak and missing return 2016-10-18 00:13:24 +02:00
Ricardo Mones
e62c01edd0 Libravatar: refactor image retrieval 
And use a synchronous thread for fetching, in preparation
of a future asynchronous fetching. Thanks Andrej for the
ideas.
 2016-10-17 14:09:25 +02:00
Andrej Kacian
b96378117a Fix typo from commit 63e19c6. 2016-10-11 14:16:05 +02:00
Andrej Kacian
341d01e835 Fix wrong argument order in Windows file choosers. 2016-10-11 13:04:36 +02:00
Andrej Kacian
63e19c6c8e Change mention of "mydomain.com" to "example.org". 
Fixes bug #3712.
 2016-10-10 20:32:09 +02:00
Andrej Kacian
0fec6a07b6 Improve plural handling of a file insert string. 
Fixes bug #3711.
 2016-10-10 20:29:47 +02:00
Ricardo Mones
73ba30d10a Fix bug #3705: active account Mail Address corrupted… 
…when address in Message-ID is used
 2016-10-05 09:51:31 +02:00
Ricardo Mones
12ab4c172e Fix a couple of typos 2016-10-04 15:29:57 +02:00
Ricardo Mones
9470e632a1 Fix #3014: The icon for folder drafts with hide… 
…read messages is the same as when not hidden

Fix disables hiding thread/messages options in draft folders,
hence hrm mode icons are not required for them. Values already
set for these options in draft folders are also ignored.

Many thanks to Andrej and Paul for their feedback on this one.
 2016-10-03 15:54:01 +02:00
Andrej Kacian
a48bc28223 Removed a superfluous debug_print() call. 2016-10-02 19:04:57 +02:00
Andrej Kacian
8eb1faa9d4 Remove useless code from e22cbed. 
References header was already being honored in drafts.
 2016-10-02 00:11:56 +02:00
Andrej Kacian
e22cbed1fc Do not add Message-ID for draft, unless it already has one. 
We now add a Message-ID header only when queuing a message,
and we honor existing Message-ID and References headers in
drafts, if there are any.
 2016-10-01 23:41:19 +02:00
Paul
3835a3a627 fix pixmap 
fixes "initialization from incompatible pointer type" warning
 2016-10-01 20:28:39 +01:00
Andrej Kacian
41064e4416 Fix some harmless compiler warnings. 
Some variables in notification_popup.c were peeking
out of their ifdefs, and I forgot to remove an
unused variable in vcal_meeting_gtk.c in my commit
8d93e8c.
 2016-10-01 17:55:10 +02:00
Andrej Kacian
8d93e8c8cd Make Message-ID string generation less confusing. 
Instead of having to prepare one part, then second
part in advance and pass them to generate_msgid()
which does its own voodoo with them, we now just pass
a pointer to PrefsAccount to
prefs_account_generate_msgid(), and it does all of it
on its own, returning pointer to a newly allocated
string.
 2016-10-01 16:22:44 +02:00
Holger Berndt
437668c7f0 Notification plugin: Port from libindicate to unity/messaging menu 
This is a slightly modified version of the patch from Sebastien Noel,
fixes bug #2665
 2016-09-29 22:21:02 +02:00
Holger Berndt
8dc0092094 GData plugin: Refresh auth token periodically 
Fixes bug #3638
 2016-09-29 18:37:16 +02:00
Holger Berndt
86e01da0f3 GData plugin: Make global data static 2016-09-29 18:37:16 +02:00
Ricardo Mones
878fcaeb00 Use a spinbutton for port number also in clamd 
Default value is now 0 instead of an empty string.
 2016-09-29 00:23:20 +02:00
Ricardo Mones
af113911d3 Use hours/minutes UI for vcalendar alert time 2016-09-29 00:12:37 +02:00
Holger Berndt
3ffc699a99 GData plugin: Unify indent accross file 2016-09-28 12:57:52 +02:00
Paul
e070e40476 add hidden pref 'reqrite_first_from' 
'0' or '1'. This works around a limitation of some servers with
'overly-liberal parsers'. When this is turned on and the Content-
Transfer-Encoding is set to 8bit or 7bit, in a message body starting
with 'From ' the 'From ' will become '=46rom ' and the
Content-Transfer-Encoding will be changed to Quoted-Printable. When it
is turned off no such modification will be made but it is very likely
that an MTA will convert the 'From ' to '>From '. See RFC 4155 for
further details. Default value is '1', turned on.
 2016-09-26 10:59:43 +01:00
Andrej Kacian
244b9cae9f Change home directory fallback to "C:\Claws-mail" on Windows. 
It is unlikely ever to be used, since CSIDL_APPDATA special
folder is guaranteed to be defined, but still...
 2016-09-25 16:22:16 +02:00
Andrej Kacian
94fb81e086 Fix absolute path detection in mh_create_tree() on Windows. 2016-09-25 00:19:50 +02:00
Ricardo Mones
20ece29edf Enable keeping old items by default 
Be more conservative towards feed data to avoid unwanted and
unrecoverable loss of items.

Users which don't want to store old items can easily disable
this in feed preferences and also remove obsolete items with
the “Trim” button.
 2016-09-23 09:33:10 +02:00
wwp
0ebf0a02f8 Use Delete button instead of Remove (tooltips and other places already 
talk about deletion) in prefs dialogs. Reassign some keyboard hotkeys
accordingly, 'e' for Delete.
 2016-09-23 09:26:47 +02:00
wwp
0f33f4bbfa Normalize Webcal name capitalization everywhere (instead of WebCal, webCal, 
webcal). Rephrase a bit a confirmation dialog to talk about subscription
instead of folder.
 2016-09-23 09:25:14 +02:00
Andrej Kacian
3a5f7d5d11 Better handle NULL path arguments in w32_filesel.c 
Fixes bug #3697.
 2016-09-22 14:05:12 +02:00
Ricardo Mones
2eea744e65 Remove unused function 2016-09-20 19:27:26 +02:00
Ricardo Mones
41fd672bfd Do not abuse macro for debugging 2016-09-20 19:25:41 +02:00
Andrej Kacian
a05eeae0e7 Fix using client TLS certificates for GnuTLS 3.0 and up. 
3.0 introduced new API for setting client certificates,
gnutls_certificate_set_retrieve_function2().

This fixes bug #3684.
 2016-09-18 10:46:58 +02:00
Andrej Kacian
479b9dc255 Remove an unused, mistyped ifdef in imap.c. 2016-09-17 23:46:21 +02:00
Ricardo Mones
a7e2030786 Remove useless workaround 
The problem is still happening with it, see bug #3511
 2016-09-16 19:54:10 +02:00
Ricardo Mones
dd8aee82fd Remove (obsolete) FSF address from welcome mail 2016-09-14 20:30:49 +02:00
Andrej Kacian
d113e2d96b Removed unused macro from prefs.c. 2016-09-14 09:55:28 +02:00
Andrej Kacian
a2a3d29ce7 Yet more vcalendar varargs functions fixed for issue described in d20742e. 2016-09-13 11:53:17 +02:00
Andrej Kacian
c0dc565cf9 More fixes for vcalendar crash on 64-bit arch. 
Same issue as in commit d20742e, different place.
This should be the last one, though.
 2016-09-13 11:45:22 +02:00
Ricardo Mones
a62bfbb3d2 Fix another two strangely sized buttons 2016-09-13 10:19:21 +02:00
Ricardo Mones
93354c8ef6 Fix potential segfault 
Syslog message was:
[5473572.496127] claws-mail[24080]: segfault at 22 ip
 00000000005704ce sp 00007ffdf1dfcea0 error 4 in
 claws-mail[400000+34a000]

$ addr2line -e /…/claws-mail 00000000005704ce
/…/src/textview.c:837

More details on: http://stackoverflow.com/questions/2179403
 2016-09-12 17:23:18 +02:00
Ricardo Mones
00ba843d39 Adjust to our toolbar button size of 24x24 2016-09-12 12:22:49 +02:00
Andrej Kacian
008fce789f Fix an impossible crash to shut Coverity up. 2016-09-11 10:15:41 +02:00
Andrej Kacian
afc83c6030 Fix a memory leak in rssyl_update_comments(). 2016-09-10 20:19:16 +02:00
Andrej Kacian
42b0938292 A fix for commit b274c72. 
Whatever FeedItem's ->data is pointing to is being
freed in feed_item_free() already.
 2016-09-10 09:28:04 +02:00
Andrej Kacian
6061cc33f7 Fix a memory leak when setting summaryview and folderview fonts. 2016-09-10 01:32:47 +02:00
Andrej Kacian
720b9a5429 Fixed two memory leaks when creating folderitems. 
The Folderitem's "node" member is set to a new empty
GNode in folder_item_new(), but is later set to
another newly allocated GNode.

This commit removes the extra allocation in one case
(folder_new()), and gets rid of the original GNode
in another case, where avoiding the second allocation
is impossible without completely rewriting the recursive
folderitem appending in folder_get_from_xml().
 2016-09-10 01:13:30 +02:00
Andrej Kacian
b274c72a2b Fix memory leak when freeing RSSyl's FeedItem struct. 2016-09-10 00:07:01 +02:00
Andrej Kacian
fbb619d6ae Fix memory leak in password store reading. 2016-09-09 23:43:51 +02:00
Andrej Kacian
e6ae9fa25d Fix a memory leak in folder_register_class(). 2016-09-09 23:11:52 +02:00
Ricardo Mones
51481e41cb Fix potential out-of-bounds read 2016-09-09 21:27:35 +02:00
Ricardo Mones
831b8da1eb Do not reuse pixmaps for theme icons 
Otherwise theme authors may have a hard time finding why an
icon is not themed despite having provided replacements for
all existing xpm files.
 2016-09-07 14:08:55 +02:00
Ricardo Mones
a79bdb6a07 Remove another unused pixmap 2016-09-06 00:53:24 +02:00
Ricardo Mones
02744e99fb Remove unused pixmap 
Not used in theme and it wasn't a Claws Mail icon but other
ancient thingy… :)
 2016-09-05 09:27:11 +02:00
Ricardo Mones
ed7e898a2a Normalise theme icon names which were different 2016-09-05 09:21:40 +02:00
Ricardo Mones
6809ce7893 Remove unused declaration 2016-09-03 01:20:17 +02:00
Ricardo Mones
001f97e114 Add warning icon to warning message 
Refactor warning creation code into a single function.
 2016-09-03 01:18:56 +02:00
Andrej Kacian
b130471c60 Be more strict about minimum DH prime size for TLS connections. 
Since GnuTLS 3.1.7, this minimum size is dictated by the
priority string, and current (GnuTLS 3.3.0) "safe-enough"
value is 1008 bits. We set this minimum size explicitly
for older GnuTLS versions.

Users who are affected by this (their servers use DH prime
smaller than 1008 bits can override this by using priority
string starting with the keyword "LEGACY". This keyword
only works with GnuTLS 3.3.0 or newer, however.
 2016-09-02 11:22:50 +02:00
Paul
49e55fb574 fix make dist 2016-09-02 08:21:42 +01:00
wwp
1b450742d6 Templates: add a way to attach a file, 'attach_output' or 'A', file whose absolute path+filename 
is the output of a command-line (it s a mix of 'attach' and 'program'). The first line of the
command-line output is taken into account, trailing newline being stripped down.
Like 'attach', if the filename is not found or not accessible, CM will raise an error. Like
'program', if the command-line fails, no error raises but the standard output of CM shows it.
 2016-09-02 00:40:27 +02:00
Ricardo Mones
db2ee150ef Fix bug #2918: Notification Popup icon is hardcoded 
Also fixes last part of bug #3437 by removing the call to deprecated
function gdk_pixbuf_new_from_inline and not using a raw pixmap.
 2016-09-01 19:40:31 +02:00
Ricardo Mones
fcfeb30db6 Add 64x64 icon version to stock pixmaps 
Icon data purloined from last patch of #3437 by Christian Hesse.
 2016-09-01 19:39:46 +02:00
Ricardo Mones
465eabaf3a Forgot to adjust default window size 2016-09-01 12:20:02 +02:00
Ricardo Mones
8ea71837e7 Improve icon legend appearance a bit 
Remove extra space and replace scrolled window with a frame.
 2016-08-31 20:48:13 +02:00
Colin Leroy
6110e7055f Fix a few Coverity issues 2016-08-31 17:11:24 +02:00
Colin Leroy
b794c279c9 Remove useless code 2016-08-31 16:47:50 +02:00
Colin Leroy
9730a98ed2 Remove useless code 2016-08-31 16:44:40 +02:00
Paul
371bbb58ad use file name for WebCal subscription folder name 
also remove the string length limit, which broke saving folder
properties
 2016-08-31 12:37:03 +01:00
Ricardo Mones
673374af23 Better alignment for icon legend columns 
Reverts most of c0abccd31d.
 2016-08-31 13:17:25 +02:00
Paul
af477843ca fix make dist 2016-08-30 16:07:05 +01:00
Paul
c0abccd31d place icons in 2 columns 2016-08-30 15:54:25 +01:00
Paul
84ef5517bc remove icons that will never be displayed 2016-08-30 12:37:11 +01:00
Paul
9aeea1ac93 fix capitalisation 2016-08-30 11:54:42 +01:00
Paul
6771436760 add 'noselect' and 'subs-only' folder icons 2016-08-30 11:26:45 +01:00
Paul
27290077c0 fix non-resizeable Icon Legend dialogue 2016-08-30 11:22:12 +01:00
Paul
999c327103 implement the 4-state icons for 'noselect' folders 2016-08-30 11:01:59 +01:00
Andrej Kacian
2032c913a7 Fix NULL pointer dereference in LDAP lookup code. 
Fixes bug #3027.
 2016-08-30 10:03:06 +02:00
Andrej Kacian
986e6f7c5f Fix crash on Windows when doing a LDAP search. 2016-08-28 22:42:10 +02:00
Andrej Kacian
04456e3b73 Make filesel API more consistent. 
One of the functions, filesel_select_multiple_files_open(),
was missing the path parameter.
 2016-08-28 20:11:03 +02:00