From 33749786e4c962fddbd08ccfa15796e3bf0849ed Mon Sep 17 00:00:00 2001
From: Christopher Baines <mail@cbaines.net>
Date: Sat, 15 Feb 2020 19:54:42 +0000
Subject: [PATCH] Add verbose output to the query-build-servers script

---
 guix-data-service/builds.scm                  | 60 ++++++++++++-------
 .../guix-data-service-query-build-servers.in  |  8 ++-
 2 files changed, 45 insertions(+), 23 deletions(-)

diff --git a/guix-data-service/builds.scm b/guix-data-service/builds.scm
index 4fbc105..f66c0b3 100644
--- a/guix-data-service/builds.scm
+++ b/guix-data-service/builds.scm
@@ -114,19 +114,25 @@ initial connection on which HTTP requests are sent."
                (_
                 (loop tail (+ 1 processed) result)))))))))) ;keep going
 
-(define (query-build-servers conn build-server-ids revision-commits)
-  (while #t
-    (let ((build-servers (select-build-servers conn)))
-      (for-each
-       (match-lambda
-         ((id url lookup-all-derivations?)
-          (when (or (or (not build-servers)
-                        (not build-server-ids))
-                    (member id build-server-ids))
-            (when lookup-all-derivations?
-              (simple-format #t "\nQuerying ~A\n" url)
-              (query-build-server conn id url revision-commits)))))
-       build-servers))))
+(define verbose-output?
+  (make-parameter #f))
+
+(define* (query-build-servers conn build-server-ids revision-commits
+                              #:key verbose?)
+  (parameterize
+      ((verbose-output? verbose?))
+    (while #t
+      (let ((build-servers (select-build-servers conn)))
+        (for-each
+         (match-lambda
+           ((id url lookup-all-derivations?)
+            (when (or (or (not build-servers)
+                          (not build-server-ids))
+                      (member id build-server-ids))
+              (when lookup-all-derivations?
+                (simple-format #t "\nQuerying ~A\n" url)
+                (query-build-server conn id url revision-commits)))))
+         build-servers)))))
 
 (define (query-build-server conn id url revision-commits)
   (simple-format #t "\nFetching pending builds\n")
@@ -213,19 +219,26 @@ initial connection on which HTTP requests are sent."
   (fetch-builds-by-output
    url
    derivation-outputs
-   (lambda (data)
+   (lambda (data output)
      (if data
-         (let ((build-id
-                (ensure-build-exists conn
-                                     build-server-id
-                                     (assoc-ref data "derivation"))))
+         (let* ((derivation
+                 (assoc-ref data "derivation"))
+                (build-id
+                 (ensure-build-exists conn
+                                      build-server-id
+                                      derivation)))
            (insert-build-statuses-from-data
             conn
             build-server-id
             build-id
             (assoc-ref data "build"))
-           (display "-"))
-         (display ".")))))
+           (if (verbose-output?)
+               (simple-format #t "found build for: ~A (~A)\n"
+                              output derivation)
+               (display "-")))
+         (if (verbose-output?)
+             (simple-format #t "no build found:  ~A\n" output)
+             (display "."))))))
 
 (define (process-derivations conn build-server-id url revision-commits)
   (define derivations
@@ -336,7 +349,12 @@ initial connection on which HTTP requests are sent."
            (bytevector->string response-body
                                "utf-8")))
          (else
-          #f)))))
+          #f))
+        (string-append
+         "/gnu/store"
+         (string-drop
+          (uri-path (request-uri request))
+          (string-length "/output"))))))
    '()
    (map (lambda (output-file-name)
           (build-request
diff --git a/scripts/guix-data-service-query-build-servers.in b/scripts/guix-data-service-query-build-servers.in
index e04329a..8f96bed 100644
--- a/scripts/guix-data-service-query-build-servers.in
+++ b/scripts/guix-data-service-query-build-servers.in
@@ -35,7 +35,10 @@
                    (cons (string->number arg)
                          (or (assoc-ref result 'build-server-ids)
                              '()))
-                   (alist-delete 'build-server-ids result))))))
+                   (alist-delete 'build-server-ids result))))
+        (option '("verbose") #f #f
+                (lambda (opt name _ result)
+                  (alist-cons 'verbose #t result)))))
 
 (define %default-options
   ;; Alist of default option values
@@ -61,4 +64,5 @@
    (lambda (conn)
      (query-build-servers conn
                           (assq-ref opts 'build-server-ids)
-                          (assq-ref opts 'revision-commits)))))
+                          (assq-ref opts 'revision-commits)
+                          #:verbose? (assq-ref opts 'verbose)))))