guix
/
data-service
mirror of git://git.savannah.gnu.org/guix/data-service.git
2
0
Fork 0
Code Issues Releases Wiki Activity

Improve the revision builds page 

Allow specifying how many results to show, and say how many results are being
shown.
This commit is contained in:
Christopher Baines 2020-07-03 20:33:16 +01:00
parent 69d3c83986
commit 4b1dc76f18
2 changed files with 23 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
guix-data-service/web/revision/controller.scm
View File

@ -282,12 +282,18 @@
(('GET "revision" commit-hash "builds")
(if (guix-commit-exists? conn commit-hash)
(let ((parsed-query-parameters
(parse-query-parameters
request
`((build_status ,parse-build-status #:multi-value)
(build_server ,(parse-build-server conn) #:multi-value)
(system ,parse-system #:default "x86_64-linux")
(target ,parse-target #:default "")))))
(guard-against-mutually-exclusive-query-parameters
(parse-query-parameters
request
`((build_status ,parse-build-status #:multi-value)
(build_server ,(parse-build-server conn) #:multi-value)
(system ,parse-system #:default "x86_64-linux")
(target ,parse-target #:default "")
(limit_results ,parse-result-limit
#:no-default-when (all_results)
#:default 50)
(all_results ,parse-checkbox-value)))
'((limit_results all_results)))))
(render-revision-builds mime-types
conn
@ -1057,7 +1063,9 @@
'build_server)
#:revision-commit commit-hash
#:system system
#:target target))))))
#:target target
#:limit (assq-ref query-parameters
'limit_results)))))))
(define* (render-revision-lint-warnings mime-types
conn

8
guix-data-service/web/revision/html.scm
View File

@ -1908,6 +1908,13 @@ figure {
#:allow-selecting-multiple-options #f
#:help-text "Only include derivations that are build for this system."
#:font-family "monospace")
,(form-horizontal-control
"Limit results" query-parameters
#:help-text "The maximum number of results to return.")
,(form-horizontal-control
"All results" query-parameters
#:type "checkbox"
#:help-text "Return all results")
(div (@ (class "form-group form-group-lg"))
(div (@ (class "col-sm-offset-2 col-sm-10"))
(button (@ (type "submit")
@ -1915,6 +1922,7 @@ figure {
"Update results")))))))
(div
(@ (class "row"))
(p "Showing " ,(length builds) " results")
(div
(@ (class "col-sm-12"))
(table