guix
/
guix-cuirass
mirror of git://git.savannah.gnu.org/guix/guix-cuirass.git
2
0
Fork 0
Code Issues Releases Wiki Activity

http: Handle wrong build number. 

The request "/build/1234)" causes a select query on the whole Builds table,
because failed "string->number" conversion is not handled.

* src/cuirass/http.scm (url-handler): Handle erroneous id -> number conversion
on "/build/id" route.
This commit is contained in:
Mathieu Othacehe 2020-08-02 15:50:59 +02:00
parent 153b49c952
commit 769682924c
No known key found for this signature in database
GPG Key ID: 8354763531769CA6
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/cuirass/http.scm
View File

@ -354,10 +354,11 @@ Hydra format."
(respond-json (object->json-string
(list->vector (db-get-specifications)))))
(('GET "build" id)
(let ((hydra-build (handle-build-request
(if (string-suffix? ".drv" id)
(string-append (%store-prefix) "/" id)
(string->number id)))))
(let* ((build (if (string-suffix? ".drv" id)
(string-append (%store-prefix) "/" id)
(string->number id)))
(hydra-build (and build
(handle-build-request build))))
(if hydra-build
(respond-json (object->json-string hydra-build))
(respond-build-not-found id))))