From d3d1f384a4622b48650219f309adfdd27a8e8099 Mon Sep 17 00:00:00 2001
From: Mathieu Othacehe <othacehe@gnu.org>
Date: Thu, 8 Apr 2021 15:42:07 +0200
Subject: [PATCH] Fix display glitches.

* src/cuirass/templates.scm (specifications-table): Fix glitches.
* src/static/css/cuirass.css (job-val): New section.
* doc/cuirass.texi: Update it.
---
 doc/cuirass.texi           |  5 +++--
 src/cuirass/templates.scm  | 23 ++++++++++++-----------
 src/static/css/cuirass.css |  4 ++++
 3 files changed, 19 insertions(+), 13 deletions(-)

diff --git a/doc/cuirass.texi b/doc/cuirass.texi
index f313626..c12ce71 100644
--- a/doc/cuirass.texi
+++ b/doc/cuirass.texi
@@ -1117,8 +1117,9 @@ This integer field references the evaluation identifier from the
 @code{Evaluations} table, indicating to which evaluation this job
 belongs.
 
-@item derivation
-This text field holds the absolute name of the job derivation file.
+@item builds
+This integer field references the build id from the @code{Builds}
+table, corresponding to this job.
 
 @item system
 This text field holds the system name of the derivation.
diff --git a/src/cuirass/templates.scm b/src/cuirass/templates.scm
index b96e874..c5aeeec 100644
--- a/src/cuirass/templates.scm
+++ b/src/cuirass/templates.scm
@@ -331,14 +331,13 @@ $('.job-toggle').click(function() {
                                 (specification-name spec))))
                           (if summary
                               `((div
-                                 (@ (class "badge badge-success job-per")
+                                 (@ (class "badge badge-success job-per mr-3")
                                     (title "Percentage succeeded"))
                                  ,(format #f "~1,2f%"
                                           (assq-ref summary #:percentage)))
                                 " "
                                 (div
-                                 (@ (class "job-val")
-                                    (style "display:none"))
+                                 (@ (class "job-val"))
                                  (div
                                   (@ (class "badge badge-success")
                                      (title "Succeeded"))
@@ -353,16 +352,18 @@ $('.job-toggle').click(function() {
                                   ,(assq-ref summary #:scheduled))))
                               '())))
                      (td
-                      ,(let ((eval (and=> (spec-summary
+                      ,@(let ((eval (and=> (spec-summary
                                            (specification-name spec))
                                           (cut assq-ref <> #:evaluation))))
-                         `(a (@ (href "/eval/" ,eval
-                                      "/dashboard"))
-                             (div
-                              (@ (class "oi oi-monitor d-inline-block ml-2")
-                                 (title "Dashboard")
-                                 (aria-hidden "true"))
-                              "")))
+                          (if eval
+                              `((a (@ (href "/eval/" ,eval
+                                             "/dashboard"))
+                                    (div
+                                     (@ (class "oi oi-monitor d-inline-block ml-2")
+                                        (title "Dashboard")
+                                        (aria-hidden "true"))
+                                     "")))
+                              '()))
                       (div
                        (@ (class "dropdown d-inline-block ml-2"))
                        (a (@ (class "oi oi-menu dropdown-toggle no-dropdown-arrow")
diff --git a/src/static/css/cuirass.css b/src/static/css/cuirass.css
index ccab72a..9967e11 100644
--- a/src/static/css/cuirass.css
+++ b/src/static/css/cuirass.css
@@ -92,3 +92,7 @@ div.tooltip {
     max-width: 1000px;
     height: 30px;
 }
+
+.job-val {
+    display: none;
+}