guix/guix
3
5
Fork 0
mirror of git://git.savannah.gnu.org/guix.git synced 2023-12-14 03:33:07 +01:00
Code Issues Releases Wiki Activity

services: zabbix-server: Do not write database password to the store.

Browse source 
* gnu/services/monitoring.scm (zabbix-front-end-config): Read the secret file
from zabbix.conf.php at runtime instead of embedding the contents.
This commit is contained in:
Marius Bakke 2022-01-26 09:28:46 +01:00
parent 440ad14128
commit 078f5bfae7
No known key found for this signature in database
GPG key ID: A2A06DF2A33A54FA
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
gnu/services/monitoring.scm
View file

@ -577,7 +577,7 @@ $DB['SERVER'] = '" db-host "';
$DB['PORT'] = '" (number->string db-port) "'; $DB['PORT'] = '" (number->string db-port) "';
$DB['DATABASE'] = '" db-name "'; $DB['DATABASE'] = '" db-name "';
$DB['USER'] = '" db-user "'; $DB['USER'] = '" db-user "';
$DB['PASSWORD'] = '" (let ((file (location-file %location)) $DB['PASSWORD'] = " (let ((file (location-file %location))
(line (location-line %location)) (line (location-line %location))
(column (location-column %location))) (column (location-column %location)))
(if (string-null? db-password) (if (string-null? db-password)
@ -592,15 +592,14 @@ $DB['PASSWORD'] = '" (let ((file (location-file %location))
(condition (condition
(&error-location (&error-location
(location %location))))) (location %location)))))
(string-trim-both (string-append "trim(file_get_contents('"
(with-input-from-file db-secret-file db-secret-file "'));\n"))
read-string)))
(begin (begin
(display-hint (format #f (G_ "~a:~a:~a: ~a: (display-hint (format #f (G_ "~a:~a:~a: ~a:
Consider using @code{db-secret-file} instead of @code{db-password} for better Consider using @code{db-secret-file} instead of @code{db-password} for better
security.") file line column 'zabbix-front-end-configuration)) security.") file line column 'zabbix-front-end-configuration))
db-password))) "'; db-password)))
"
// Schema name. Used for IBM DB2 and PostgreSQL. // Schema name. Used for IBM DB2 and PostgreSQL.
$DB['SCHEMA'] = ''; $DB['SCHEMA'] = '';