Author: NRK <nrk@disroot.org>
Date: Fri Mar 18 17:03:34 2022 +0600
base64_digits: reduce scope, implicit zero, +1 size
the array is not accessed outside of base64dec() so it makes sense to
limit it's scope to the related function. the static-storage duration of
the array is kept intact.
this also removes unnecessary explicit zeroing from the start and end of
the array. anything that wasn't explicitly zero-ed will now be
implicitly zero-ed instead.
the validity of the new array can be easily confirmed via running this
trivial loop:
for (int i = 0; i < 255; ++i)
assert(base64_digits[i] == base64_digits_old[i]);
lastly, as pointed out by Roberto, the array needs to have 256 elements
in order to able access it as any unsigned char as an index; the
previous array had 255.
however, this array will only be accessed at indexes which are
isprint() || '=' (see `base64dec_getc()`), so reducing the size of the
array to the highest printable ascii char (127 AFAIK) + 1 might also be
a valid strategy.
Author: NRK <nrk@disroot.org>
Date: Fri Mar 18 16:20:54 2022 +0600
avoid potential UB when using isprint()
all the ctype.h functions' argument must be representable as an unsigned
char or as EOF, otherwise the behavior is undefined.
Author: robert <robertrussell.72001@gmail.com>
Date: Sat Jan 8 11:40:34 2022 -0800
Fix mousereport
This patch replaces the previous one I sent.
The following changes are made in this patch:
- Fix tracking of pressed buttons. Previously, pressing two buttons and
then releasing one would make st think no buttons are pressed, which
in particular broke MODE_MOUSEMOTION.
- Always send the lowest-numbered pressed button on motion events; when
no button is pressed for a motion event in MODE_MOUSEMANY, then send
a release. This matches the behaviour of xterm. (Previously, st sent
the most recently pressed button in the motion report.)
- Remove UB (?) access to potentially inactive struct member
e->xbutton.button of XEvent union.
- Fix (unlikely) possibility of overflow for large button numbers.
The one discrepancy I found between st and xterm is that xterm sometimes
encodes buttons with large numbers (>5) strangely. E.g., xterm reports
presses of buttons 8 and 9 as releases, whereas st properly (?) encodes
them as presses.
Author: jamin <acdimalev@gmail.com>
Date: Wed Dec 29 09:07:17 2021 -0800
Fix overtyping wide characters.
Overtyping the first half of a wide character with the
second half of a wide character results in display garbage.
This is because the trailing dummy is not cleaned up.
i.e. ATTR_WIDE, ATTR_WDUMMY, ATTR_WDUMMY
Here is a short script for demonstrating the behavior:
#!/bin/sh
alias printf=/usr/bin/printf
printf こんにちは！; sleep 2
printf '\x1b[5D'; sleep 2
printf へ; sleep 2
printf ' '; sleep 2
echo
8e310303903792c010d03c046ba75f8b18f7d3a7
Add support for OSC color sequences
273db5ceaf392e68c2faf8f7dec14ea2e25e980d
follow-up fix for OSC color sequences, return
Otherwise the message "erresc: unknown str" is printed.
a0467c802d4f86ed162486e3453dd61181423902
Fix null pointer access in strhandle
According to the spec the argument is optional for 104, so p can be
NULL as can be tested with printf '\x1b]104\x07'. This is a regression
of 8e31030.
'\t' is for cursor movement, no point of workarounds to be able to copy
it. Anyway in alt screens like less and vim they are represented as ' '.
Not as useful as I thought while implementing.
Accomadated gp.state in gp.mode. This also fixes a bug introduced in the
text wrapping fix in the second last commit. gp.mode = GLYPH_SET might
have overwritten GLYPH_T* in gp.mode.
fix possible rare crash when Xutf8TextPropertyToTextList fails
from the XmbTextListToTextProperty(3) man page:
"If insufficient memory is available for the new value string, the functions
return XNoMemory. If the current locale is not supported, the functions return
XLocaleNotSupported. In both of these error cases, the functions do not set
text_prop_return."
Reported by Steffen Nurpmeso <steffen@sdaoden.eu>, thanks!
fix a problem that the standard streams are unexpectedly closed
In the current implementation, the slave PTY (assigned to the variable
`s') is always closed after duplicating it to file descriptors of
standard streams (0, 1, and 2). However, when the allocated slave PTY
`s' is already one of 0, 1, or 2, this causes unexpected closing of a
standard stream. The same problem occurs when the file descriptor of
the master PTY (the variable `m') is one of 0, 1, or 2.
In this patch, the original master PTY (m) is closed before it would
be overwritten by duplicated slave PTYs. The original slave PTY (s)
is closed only when it is not one of the stanrad streams.
1) Fixed bug introduced in last commit in tdeletechar and tinsertchar
2) No need to use size_t in tscrollup, can mess up subtractions
3) Removed terasechar
1) Implement regionselected (much more optimal for tclearregion than
calling selected in a loop)
2) Removed redundant (escpecially after 1) tfullclear
3) tresetcursor only needed to be called once in treset
4) Removed necessity of LIMIT and SWAP in tclearregion by fixing the
places from where it was called (tscrollup, tscrolldown and new
terasechar)
5) Fixed bugs in CSI 'J', case 1 handling, tdeletechar and tinsertblank
(Add reminder to send bugfix to upstream)
Ashish Kumar Yadav