Commit graph

20 commits

Author SHA1 Message Date
Andrea Blankenstijn d8f56e0e5f Delete OpaqueStruct and use directly fancy pointers now that I know
how to set the deleter correctly.
2021-08-26 18:59:52 +02:00
Andrea Blankenstijn a19d2ea6bd - mark as const every single read only variable.
- mark as const every pointer that can be const.
- in implementation mark const args passed by value that are meant to be read-only.
- wrap in a lambda complex initializations of (const) values.
- argument passing:
  - pass by value arguments of cheap-to-copy types or meant to be copied
    anyway.
  - pass by (const) reference args not meant to outlive called
    function scope and not cheap-to-copy.
  - pass (const) pointers to (const) args when null is a valid option
    and pointed data aren't expected to outlive function scope.
  - use string_view for non-owned strings (not meant to outlive function
    scope).
  - use span for collection types like vector and arrays.
  - fancy pointers passing:
    - pass by value if a reference will be held:
    - pass by const reference if a reference _may_ be hell.
    - when no references are meant to be held:
        - dereference the pointer to pass the pointed data by reference
          if null is not an option.
        - pass the underlying raw pointer if null is an option.
… and random subtle changes and fixes here and there that I forgot to mention.
2021-08-22 00:57:55 +02:00
Andrea Blankenstijn 76d319fb69 trash commit, style, small api changes (ref vs ptr) and who knows 2021-08-19 15:00:44 +02:00
Andrea Blankenstijn 3458ca123b pass by value vs by ref thing 2021-08-14 16:37:42 +02:00
Andrea Blankenstijn b11d574d9c constructor style refactor 2021-08-14 11:53:51 +02:00
Andrea Blankenstijn f0e89f837b Simplify exceptions 2021-08-13 22:01:14 +02:00
Andrea Blankenstijn 5cb15abe11 code formatting. 2021-08-12 16:10:49 +02:00
Andrea Blankenstijn 43dd6ab820 use raw ptr instead of fancy one when no references are kept after function
exit.
2021-08-12 15:55:47 +02:00
Andrea Blankenstijn c7bea043c2 rethink C opaque struct encapsulation 2021-08-11 15:58:04 +02:00
Andrea Blankenstijn 79f83abe3b smart ptr and a bit of doc 2021-08-10 23:48:19 +02:00
Andrea Blankenstijn e71a16208b noexcept correctness intent 2021-08-08 16:04:33 +02:00
Andrea Blankenstijn 4f82826bbc constness 2021-08-08 14:30:56 +02:00
Andrea Blankenstijn cab6fa0cf4 wip general code improvement 2021-08-07 20:11:28 +02:00
Andrea Blankenstijn 13bdb970c0 config clang-tidy linter and fix code based on linting err/warn 2021-07-30 21:37:14 +02:00
Andrea Blankenstijn 3b6e900a22 format code with custom clang-format style 2021-07-29 16:06:03 +02:00
Andrea Blankenstijn 55fbd59c36 half workaround to fix corner glitch in draw_rect and minor changes 2021-07-26 23:48:04 +02:00
Andrea Blankenstijn 369e1c1f1b 'fix' input widget size and set back dbg outline to vp boundaries 2021-07-24 22:07:28 +02:00
Andrea Blankenstijn 4b87af7bc4 various changes and fixes 2021-07-23 20:08:52 +02:00
Andrea Blankenstijn 30c4205dab some fixes and working sdl wrapper 2021-07-19 23:50:50 +02:00
Andrea Blankenstijn dd3ff9358a big hierarchy refactor, some little changes, add Font class 2021-07-18 18:26:12 +02:00
Renamed from src/sdl/renderer.cpp (Browse further)