joborun-pkg/jobcore
joborun-pkg/jobcore
Template
2
1
Fork 0
Code Issues Pull requests Projects Releases Activity

Update runit-service-scripts/PKGBUILD #2

Closed
Evhorizon wants to merge 1 commit from (deleted):main into main
pull from: (deleted):main
merge into: joborun-pkg:main
Conversation 7 Commits 1 Files changed 1 +1 -1
Evhorizon commented 2023-12-16 16:24:26 +01:00
First-time contributor
Copy link
No description provided.
Evhorizon added 1 commit 2023-12-16 16:24:26 +01:00
Evhorizon commented 2023-12-29 20:41:42 +01:00
Author
First-time contributor
Copy link

Same as commit in /repos

Same as commit in /repos
Evhorizon closed this pull request 2023-12-29 20:41:42 +01:00
joborun commented 2024-01-02 11:03:21 +01:00
Owner
Copy link

I haven't been able to get notification up for pull requests here, so they remain unnoticed.
I can't see the specific change asked for, was it to switch the log conf from 0755 to 0750 ?
Is it because openvpn demands this as more secure?

I haven't been able to get notification up for pull requests here, so they remain unnoticed. I can't see the specific change asked for, was it to switch the log conf from 0755 to 0750 ? Is it because openvpn demands this as more secure?
joborun commented 2024-01-02 11:52:34 +01:00
Owner
Copy link

OK got it, before we upload the change we will make a new repository for the runit scripts themselves so they can be edited on a one-by-one basis (the contents of the current tarball)

OK got it, before we upload the change we will make a new repository for the runit scripts themselves so they can be edited on a one-by-one basis (the contents of the current tarball)
Evhorizon commented 2024-01-02 11:52:49 +01:00
Author
First-time contributor
Copy link

Hi, thanks for asking, I have closed the PR because I agreed with you, there's no need to open a request uploading a tarball:) you should only change upstream the permission of /log/run to 755 because otherwise that file won't be able to create the log folder in the /var/log directory. Indeed, if you look at the artix PGKBUILD, it installs the file with -Dm755.

Hi, thanks for asking, I have closed the PR because I agreed with you, there's no need to open a request uploading a tarball:) you should only change upstream the permission of /log/run to 755 because otherwise that file won't be able to create the log folder in the /var/log directory. Indeed, if you look at the artix PGKBUILD, it installs the file with -Dm755.
Evhorizon commented 2024-01-02 12:02:37 +01:00
Author
First-time contributor
Copy link

Forgot to say that in your runit service script tarball that file seems to have 644 permission on my side.

Forgot to say that in your runit service script tarball that file seems to have 644 permission on my side.
joborun commented 2024-01-02 12:53:07 +01:00
Owner
Copy link

Thank you, check swap-runit service added, the permissions to run also made it not work, now it does. runit uses a bash environment and expects all run scripts to be executable for it to "run" them.
the openvpn/log/run and swap-runit/run were read only files

https://git.disroot.org/joborun/runit-service-scripts/src/branch/main/usr/lib/runit/sv

Now you can make individual changes to all files on the scripts

Thank you, check swap-runit service added, the permissions to run also made it not work, now it does. runit uses a bash environment and expects all run scripts to be executable for it to "run" them. the openvpn/log/run and swap-runit/run were read only files https://git.disroot.org/joborun/runit-service-scripts/src/branch/main/usr/lib/runit/sv Now you can make individual changes to all files on the scripts
Evhorizon commented 2024-01-02 13:26:04 +01:00
Author
First-time contributor
Copy link

Thanks so much to you, this change is great, now contributing to the services is much easier!') btw I have just shared my own 66 OpenVPN service on the Obarun gitlab (obcommunity), I would be happy if Eric moves it to observice, even because seeing a 66 service on obcommunity is kind of weird.

Thanks so much to you, this change is great, now contributing to the services is much easier!') btw I have just shared my own 66 OpenVPN service on the Obarun gitlab (obcommunity), I would be happy if Eric moves it to observice, even because seeing a 66 service on obcommunity is kind of weird.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference: joborun-pkg/jobcore#2
No description provided.
Delete branch "(deleted):main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?