35 lines
1.1 KiB
Diff
35 lines
1.1 KiB
Diff
From 5e0496260b7d3f9c9fcf2b1c4899e4dbcc20ff03 Mon Sep 17 00:00:00 2001
|
|
From: Ivan Shapovalov <intelfx@intelfx.name>
|
|
Date: Wed, 13 Mar 2024 04:27:31 +0100
|
|
Subject: [PATCH] make_aligned_titles: pass the correct buffer length
|
|
|
|
The third parameter to wcstombs() is the length of the output buffer
|
|
(first parameter) in bytes. Take the correct sizeof() here.
|
|
|
|
This is not a problem in practice, but prevents _FORTIFY_SOURCE=3 from
|
|
detecting a possible output buffer overflow (as the source buffer is
|
|
bigger than the destination).
|
|
|
|
Fixes #104.
|
|
|
|
Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
|
|
---
|
|
src/pacman/package.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/src/pacman/package.c b/src/pacman/package.c
|
|
index b832663c0..95d0c4c4c 100644
|
|
--- a/src/pacman/package.c
|
|
+++ b/src/pacman/package.c
|
|
@@ -140,7 +140,7 @@ static void make_aligned_titles(void)
|
|
size_t padlen = maxcol - wcol[i];
|
|
wmemset(wbuf[i] + wlen[i], L' ', padlen);
|
|
wmemcpy(wbuf[i] + wlen[i] + padlen, title_suffix, ARRAYSIZE(title_suffix));
|
|
- wcstombs(titles[i], wbuf[i], sizeof(wbuf[i]));
|
|
+ wcstombs(titles[i], wbuf[i], sizeof(titles[i]));
|
|
}
|
|
}
|
|
|
|
--
|
|
GitLab
|
|
|