kpriv/freebsd-ports
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

games/megaglest: Unbreak on F10+ with an unsavory solution

Browse source 
Megaglest cannot be built under c++11 standard from the latest clang.
It catches a narrowing error.  The real solution is to fix the c++
code (it wasn't the only problem, but the first to trigger an error over
a warning).  The c++11 standard is required for wx, so it can't be
unspecified.  It turns out that gcc48 will not catch the error that clang
does so the temporary fix is to require gcc48 for all FreeBSD releases.
This may work for gcc49 as well, but it's likely that gcc5 will also
catch the bug and break.

So the unsavory short-term solution is to require GCC to build megaglest,
but the long term fix is either patch the code or hopefully update to
new version when upstream fixes the bug (then USE_GCC can be removed).

Reported by:	amdmi3
This commit is contained in:
John Marino 2015-04-12 08:32:01 +00:00
parent bb1b699cc3
commit 33e3be5231
Notes: svn2git 2021-03-31 03:12:20 +00:00 
svn path=/head/; revision=383843
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
games/megaglest/Makefile
View file

@ -3,7 +3,7 @@
PORTNAME= megaglest
PORTVERSION= 3.9.0.4
PORTREVISION= 5
PORTREVISION= 6
CATEGORIES= games
MASTER_SITES= SF/${PORTNAME}/${PORTNAME}_3.9.0/
DISTNAME= ${PORTNAME}-source-${PORTVERSION}
@ -23,7 +23,11 @@ RUN_DEPENDS= ${DATADIR}/tutorials/2_basic_tutorial/2_basic_tutorial.xml:${PORTSD
SUB_FILES= pkg-message
USES= cmake compiler:c++11-lib display:build dos2unix lua openal:al,alut pkgconfig tar:xz
# Clang catches a c++11 violation that older GCC misses, so until the
# code is fixed, remove USES+=compiler:c++11-lib and set USE_GCC=yes
USES= cmake display:build dos2unix lua openal:al,alut pkgconfig \
tar:xz
USE_GCC= yes
USE_GL= glew gl glu
USE_SDL= yes
USE_WX= 3.0