Mk/Uses/go.mk: Drop PLIST_SUB for GO_PKGNAME

GO_PKGNAME defaults to ${PORTNAME}.  As a result it is often too
general and can produce bad results with make makeplist.  For
example, in mail/aerc it produces bogus entries like

man/man5/%%GO_PKGNAME%%-sendmail.5.gz

since GO_PKGNAME=aerc there.

Having it in PLIST_SUB was only useful for Go libraries which we
no longer support.  Only 2 ports use it currently but do not really
need to and are easily fixed.

Approved by:	dg@syrec.org (maintainer)
Differential Revision:	https://reviews.freebsd.org/D21114

Mk/Uses/go.mk

@@ -100,7 +100,6 @@ BUILD_DEPENDS+=	${GO_CMD}:${GO_PORT}
 .if ${go_ARGS:Mrun}
 RUN_DEPENDS+=	${GO_CMD}:${GO_PORT}
 .endif
-PLIST_SUB+=	GO_PKGNAME=${GO_PKGNAME}
 
 _USES_POST+=	go
 .endif # !defined(_INCLUDE_USES_GO_MK)

databases/go-carbon/pkg-plist

@@ -1,6 +1,6 @@
-bin/%%GO_PKGNAME%%
-@sample %%ETCDIR%%/%%GO_PKGNAME%%.conf.sample
+bin/go-carbon
+@sample %%ETCDIR%%/go-carbon.conf.sample
 @sample %%ETCDIR%%/storage-aggregation.conf.sample
 @sample %%ETCDIR%%/storage-schemas.conf.sample
-@dir(carbon,carbon,0750) /var/db/%%GO_PKGNAME%%
-@dir(carbon,carbon,0750) /var/log/%%GO_PKGNAME%%
+@dir(carbon,carbon,0750) /var/db/go-carbon
+@dir(carbon,carbon,0750) /var/log/go-carbon

security/ct-submit/Makefile

@@ -18,4 +18,6 @@ GH_ACCOUNT= grahamedgecombe
 GH_PROJECT= ct-submit
 GH_TAGNAME= 7bb2541
 
+PLIST_FILES=	bin/ct-submit
+
 .include <bsd.port.mk>

security/ct-submit/pkg-plist

@@ -1 +0,0 @@
-bin/%%GO_PKGNAME%%