generate a bunch of,
   cannot make pipe for process substitution: File exists
errors.

The problem lies with colliding pipe names.

The code in sh_mktmpname() in lib/sh/tmpfile.c uses a combination of things like
the current time, the PID, and an incrementing counter. Since the child PIDs
tend to be sequential (barring kern.randompid=1), there are collisions.

Fix this problem without rewriting upstream code by defining USE_MKTEMP=1 to
use the mktemp(3) code of bash.

FreeBSD's mktemp() is not nearly as bad as the bash default and isn't
brain-damaged like some platforms (which is likely why the bash code tries to
do it's own thing). In FreeBSD, "mktemp(3)" it uses arc4random to pick one of
62 symbols for each "X".

Submitted by:   Henric Jungheim <software@henric.org>
This commit is contained in:
Emanuel Haupt 2015-07-09 05:47:32 +00:00
parent 458ee3bf95
commit 72451773c8
Notes: svn2git 2021-03-31 03:12:20 +00:00
svn path=/head/; revision=391614

View file

@ -4,7 +4,7 @@
PORTNAME= bash
PATCHLEVEL= 39
PORTVERSION= 4.3.${PATCHLEVEL:S/^0//g}
PORTREVISION?= 0
PORTREVISION?= 1
CATEGORIES= shells
MASTER_SITES= GNU/${PORTNAME}
DISTNAME= ${PORTNAME}-${PORTVERSION:R}
@ -54,6 +54,8 @@ CONFIGURE_ARGS+= --without-bash-malloc \
--disable-rpath \
--enable-disabled-builtins
CFLAGS+= -DUSE_MKTEMP=1
.if empty(PKGNAMESUFFIX)
CONFLICTS+= bash-static-[0-9]*
.else