This patch comes from the ht://Dig maintainers, and fixes a possible

security vulnerability. Quoting from their e-mail announcement:

	There is a security vulnerability in all versions of
	htsearch between 3.1.0b2 and 3.1.5 . . . The hole can
	allow a remote user to pick a file on your system for
	the config file that the UID running the webserver
	can read.

With a default ports install the httpd user should be nobody, which
makes the vulnerability small.
This commit is contained in:
Doug Barton 2001-09-25 07:08:47 +00:00
parent 31b84c6823
commit b2b3b4bb73
Notes: svn2git 2021-03-31 03:12:20 +00:00
svn path=/head/; revision=48179

View file

@ -0,0 +1,24 @@
--- htsearch/htsearch.cc.Dist Thu Feb 24 18:29:11 2000
+++ htsearch/htsearch.cc Mon Sep 24 23:57:28 2001
@@ -77,9 +77,18 @@
switch (c)
{
case 'c':
- configFile = optarg;
- override_config=1;
- break;
+ // The default is obviously to do this securely
+ // but if people want to shoot themselves in the foot...
+#ifndef ALLOW_INSECURE_CGI_CONFIG
+ if (!getenv("REQUEST_METHOD"))
+ {
+#endif
+ configFile = optarg;
+ override_config=1;
+#ifndef ALLOW_INSECURE_CGI_CONFIG
+ }
+#endif
+ break;
case 'v':
debug++;
break;