net/rabbitmq: update to 3.11.7 & switch to OTP25

- while here, pet with portfmt and portclippy

net/rabbitmq/Makefile

@@ -1,5 +1,5 @@
 PORTNAME=	rabbitmq
-DISTVERSION=	3.10.13
+DISTVERSION=	3.11.7
 CATEGORIES=	net
 MASTER_SITES=	https://github.com/rabbitmq/rabbitmq-server/releases/download/v${PORTVERSION}/
 DISTNAME=	${PORTNAME}-server-${PORTVERSION}
@@ -11,18 +11,35 @@ WWW=		https://www.rabbitmq.com/
 LICENSE=	MPL20
 LICENSE_FILE=	${WRKSRC}/LICENSE-MPL-RabbitMQ
 
-BUILD_DEPENDS=	erlang-runtime${ERLANG_VER}>=${ERLANG_VER}.2:lang/erlang-runtime${ERLANG_VER} \
+BUILD_DEPENDS=	erlang-runtime${_ERLANG_VER}>=${_ERLANG_VER}.2:lang/erlang-runtime${_ERLANG_VER} \
 		elixir>=1.13.4:lang/elixir \
 		${PYTHON_PKGNAMEPREFIX}simplejson>=2.0:devel/py-simplejson@${PY_FLAVOR} \
 		xmlto:textproc/xmlto \
 		zip:archivers/zip \
 		rsync:net/rsync
-RUN_DEPENDS=	erlang-runtime${ERLANG_VER}>=${ERLANG_VER}.2:lang/erlang-runtime${ERLANG_VER}
+RUN_DEPENDS=	erlang-runtime${_ERLANG_VER}>=${_ERLANG_VER}:lang/erlang-runtime${_ERLANG_VER}
 
 USES=		cpe gmake shebangfix tar:xz
+CPE_VENDOR=	pivotal_software
 USE_LOCALE=	en_US.UTF-8
 USE_RC_SUBR=	rabbitmq
+SHEBANG_FILES=	deps/rabbitmq_management/bin/rabbitmqadmin
+MAKE_ARGS+=	PYTHON=${PYTHON_CMD}
+MAKE_ENV+=	PATH="${LOCALBASE}/lib/${_ERLANG_LIB}/bin:${PATH}" \
+		RMQ_LIBDIR="${PREFIX}/lib" \
+		MANDIR="${PREFIX}/man" \
+		DESTDIR="${STAGEDIR}"
+MAKE_JOBS_UNSAFE=	yes
+ALL_TARGET=	install
+
+REINPLACE_ARGS=	-i ""
 NO_ARCH=	yes
+SUB_LIST+=	_ERLANG_LIB=${_ERLANG_LIB}
+
+USERS=		rabbitmq
+GROUPS=		rabbitmq
+
+PLIST_SUB=	VERSION=${PORTVERSION}
 
 OPTIONS_DEFINE=	ADMIN
 OPTIONS_SUB=	yes
@@ -31,36 +48,15 @@ ADMIN_DESC=	Install rabbitmqadmin script
 ADMIN_USES=	python
 ADMIN_USES_OFF=	python:build
 
-ALL_TARGET=	install
-
-USERS=		rabbitmq
-GROUPS=		rabbitmq
-
-SUB_LIST+=	ERLANG_LIB=${ERLANG_LIB}
-
-PLIST_SUB=	VERSION=${PORTVERSION}
-
-CPE_VENDOR=	pivotal_software
-
-REINPLACE_ARGS=	-i ""
-SHEBANG_FILES=	deps/rabbitmq_management/bin/rabbitmqadmin
-MAKE_ARGS+=	PYTHON=${PYTHON_CMD}
-MAKE_ENV+=	PATH="${LOCALBASE}/lib/${ERLANG_LIB}/bin:${PATH}" \
-		RMQ_LIBDIR="${PREFIX}/lib" \
-		MANDIR="${PREFIX}/man" \
-		DESTDIR="${STAGEDIR}"
-
-MAKE_JOBS_UNSAFE=	yes
-
-ERLANG_VER=	24
-ERLANG_LIB=	erlang${ERLANG_VER}
+_ERLANG_VER=	25
+_ERLANG_LIB=	erlang${_ERLANG_VER}
 
 .include <bsd.port.options.mk>
 
 post-patch:
 	# ensure our OTP is always preferred over other installed versions
 	@${REINPLACE_CMD} -e 's|LOCALBASE|${LOCALBASE}|' \
-		-e 's|ERLANG_LIB|${ERLANG_LIB}|' \
+		-e 's|ERLANG_LIB|${_ERLANG_LIB}|' \
 		${WRKSRC}/deps/rabbit/scripts/rabbitmq-defaults
 	# ensure docs match heir(7) paths
 	@${REINPLACE_CMD} -i '' \

net/rabbitmq/distinfo

@@ -1,3 +1,3 @@
-TIMESTAMP = 1671203440
-SHA256 (rabbitmq-server-3.10.13.tar.xz) = d9810e5d5552c910fc47dda4836b7b42a70b7751cc4669b4204d577783c3f3b0
-SIZE (rabbitmq-server-3.10.13.tar.xz) = 3648572
+TIMESTAMP = 1674652861
+SHA256 (rabbitmq-server-3.11.7.tar.xz) = 9b53bf93fc3d58b491a4a003a3bf4353ebdfe33e3597a9df269230a58d5d1a00
+SIZE (rabbitmq-server-3.11.7.tar.xz) = 3732104