a symbol matches multiple clauses the last one takes precedence. If the
catch-all is last it captures everything. In the case of Qt5 libraries
this caused all symbols to have a Qt_5 label while some should have
Qt_5_PRIVATE_API. This only affects lld because GNU ld always gives the
catch-all lowest priority.
Older versions of Qt5Webengine exported some memory allocation symbols from
the bundled Chromium. Version 5.9 stopped exporting these [1] but the
symbols were kept as weak wrappers for the standard allocation functions to
maintain binary compatibility. [2][3] The problem is that the call to the
standard function in these weak wrappers is only resolved to the standard
function if there's a call to this standard function in other parts of
Qt5Webengine, because only then is there a non-weak symbol that takes
precedence over the weak one. If there's no such non-weak symbol the call
in the weak wrapper resolves to the weak wrapper itself creating an infinite
call loop that overflows the stack and causes a crash. Some of the
allocation functions are variants of C++ new and delete and it probably
depends on the compiler whether these variants are used in other parts of
Qt5Webengine.
Remove the weak wrappers (make them Linux specific). This isn't binary
compatible but we are already breaking that with the changes to the symbol
versions.
[1] 5c2cbfccf9
[2] 2ed5054e3a
[3] 009f5ebb4b
Bump all ports that depend on Qt5.
PR: 234070
Exp-run by: antoine
Approved by: kde (adridg)
Ports that build out of source now simply can use "USES=cmake"
instead of "USES=cmake:outsource". Ports that fail to build
out of source now need to specify "USES=cmake:insource".
I tried to only set insource where explictely needed.
PR: 232038
Exp-run by: antoine
defined via Mk/bsd.default-versions.mk which has moved from GCC 7.4 t
GCC 8.2 under most circumstances.
This includes ports
- with USE_GCC=yes or USE_GCC=any,
- with USES=fortran,
- using Mk/bsd.octave.mk which in turn features USES=fortran, and
- with USES=compiler specifying openmp, nestedfct, c11, c++0x, c++11-lang,
c++11-lib, c++14-lang, c++17-lang, or gcc-c++11-lib
plus, as a double check, everything INDEX-11 showed depending on lang/gcc7.
PR: 231590
While here, chase some KDE4 ports and functionality, these are scheduled for
removal on 2018-12-31. Change the default option/flavor to QT5 where applicable
or use alternative toolkits like GTK.
Submitted by: tcberner
Reviewed by: adridg, jhale, rene, tcberner
Approved by: portmgr (implicit, flavor hook)
Differential Revision: https://reviews.freebsd.org/D17741
From now on, ports that depend on Qt4 will have to set
USES= qt:4
USE_QT= foo bar
ports depending on Qt5 will use
USES= qt:5
USE_QT= foo bar
PR: 229225
Exp-run by: antoine
Reviewed by: mat
Approved by: portmgr (antoine)
Differential Revision: →https://reviews.freebsd.org/D15540
* Convert to slaveport, as they are very similar
* Switch to cmake in archviers/quazip
Reviewed by: rakuco
Approved by: rakuco (mentor)
Differential Revision: https://reviews.freebsd.org/D7909
[The previous commit r22303 skipped archives/quazip]
* archivers/quazip
Regenerate the qztest.pro patch for archivers/quazip
* archivers/quazip-qt5
Drop the coinstallability patch as it is now part of the release
Add upstreamed patch by rakuco@ to fix linking
Reviewed by: rakuco
Approved by: rakuco (mentor)
Differential Revision: https://reviews.freebsd.org/D7726
> I was wondering if you were willing to push archivers/quazip onto kde@
Of course, assign the maintanership to kde@, please. :)
Approved by: nivit (previous maintainer), rakuco (mentor)
testquagzipfile.cpp: In member function 'void TestQuaGzipFile::read()':
testquagzipfile.cpp:11: error: 'gzFile_s' was not declared in this scope
testquagzipfile.cpp:11: error: expected primary-expression before '=' token
testquagzipfile.cpp:12: error: expected primary-expression before ',' token
testquagzipfile.cpp:13: error: expected primary-expression before ')' token
testquagzipfile.cpp: In member function 'void TestQuaGzipFile::write()':
testquagzipfile.cpp:35: error: 'gzFile_s' was not declared in this scope
testquagzipfile.cpp:35: error: expected primary-expression before '=' token
testquagzipfile.cpp:38: error: expected primary-expression before ',' token
testquagzipfile.cpp:39: error: expected primary-expression before ')' token
Reported by: pkg-fallout
