the variable $unique_list was created with identical content, its value was
only set within the implicit sub-shell (2nd command in a pipe) and lost on
exit from the while loop.
Reported by: Jakub Laach
Torsten has accepted the challenge of whipping portmaster back into
shape. In addition to changing MAINTAINER, he's starting with fixing
both non-default options by providing their necessary RUN_DEPENDS.
PR: 207075
I've been ordered by portmgr to remove DEPRECATION designation because
others have indicated they believe people should not be so directly
informed of its poor state. Despite the fact that there was no expiration
date set and that functionality was not affected in any way (leaving now
informed people free to use this unmaintained port), it was considered a
disruptive change.
Let the record show that I strongly object to this decision and that I
firmly believe that portmaster is a port that *must* have a competent
maintainer that can *develop* it. It should *not* be allowed to be
unmaintained and still maintain a presence in FreeBSD documentation.
The portmaster script hasn't had an official maintainer in 9 months and 2
years before that it was only patched in reaction to changes in the ports
framework. There are many unclaimed PRs in the bugzilla database, many
known bugs, and several areas where portmaster no longer aligns with how
ports work today. The problem isn't simply getting a maintainer; that
person has to be a ports framework expert and it appears that the people
with these qualifications don't want anything to do with this port.
Moreover, there are better options available. All FreeBSD platforms
support ports-mgmt/poudriere (although some many struggle under the load)
and the most common amd64 and i386 platform users have the additional
option of ports-mgmt/synth which is user-friendly, lightweight, and aimed
at users of portmaster, portupgrade, and even poudriere.
Unless something drastic regarding portmaster occurs, it's nearing its
natural EOL, so it's users should evaluate alternatives and try to
migrate off of it.
Using this new scheme allows only setting the _tag_ or _commit hash_ in
GH_TAGNAME and not having to know the hash for a tag. This scheme will
download a tarball that has a different checksum than before due to a changed
directory name for extraction.
The following MASTER_SITES are provided to retain the old checksum and
directory structure (that require GH_COMMIT):
GH -> GHL
GITHUB -> GITHUB_LEGACY
Differential Revision: https://reviews.freebsd.org/D748
Submitted by: amdmi3
Reviewed by: mat, swills, antoine, bdrewery
With hat: portmgr
Changes:
* Speedup --list-origins with pkg
* Use proper /usr/local/etc/portmaster.rc path in portmaster.8
* Fix running from deleted dirs.
* Fix losing control of building run-depends of staged ports
(thus breaking -g and counts). [1]
PR: 189398 [1]
Changes:
* Fix --check-port-dbdir support after ports r321785 changed
to /var/db/ports/category_port (OPTIONS_NAME) instead of
UNIQUENAME [1]
Reported by: many
- Rename distfile and fix checksum errors. These errors
were due to renaming the upstream account, which changed
which directory the distfile untarred in.
- Shuffle MASTER_SITES so that FreeBSD.org and other more
reliable mirrors come before github
This fixes a regression with non-pkgng usage that would invoke
the bootstrapper when upgrading ports. My testing did not
cover systems with the bootstrapper that did not use pkgng, so
this was missed.
The impact of this was just a hung build during deinstall.
Reported by: mandree
Pointyhat to: bdrewery
- Add extra mirror
- Remove PKGNGPATCH option
Changes:
- The pkgng patch has been fully integrated upstream with its
history copied from the pkgng repo over to portmaster's repo
- Add extra messages before/after killing background processes so
that 'Terminated' messages look less unexpected
- Fix running from / trying to build the entire tree
- pkgng: Fix -s not respecting the automatic flag
- Fix "Argument list too long" errors
- Add PM_SU_CMD documentation to the sample config file [1]
- Fix -o not showing the specified origin [pkgng patch bug]
Submitted by: Oleg Pudeyev <oleg@bsdpower.com> [1]
this port confusing bsd.pkgng.mk into thinking
that WITH_PKGNG is defined and pkg(8) shoul be
used to register.
Pointyhat to: bdrewery
Feature safe: yes
- Add PKGNG option to apply pkgng support patch. This will
be fully integrated upstream in the next version. This
functionality is only enabled when WITH_PKGNG is defined
in make.conf (or a recent CURRENT by default, see
UPDATING 20121010). Due to the compat OPTION handling,
defining WITH_PKGNG will also apply the patch by default.
The pkgng patch is contributed by avilla@
Feature safe: yes
- Take maintainership
- Convert to new options framework
- Use USE_GITHUB for fetching
- Add DISTNAME to avoid conflict with existing distfile as
the checksum of the distfile has changed now that it is
no longer modified for release.
- Remove use of bsd.port.pre.mk
Minor improvements:
===================
* Improve messages for processing of dependent ports when -r
* If there is an installed version, always print that message, not just
when we're in the parent
* Optimize determination of $new_port:
- When first set, let it be global
- Use a function to incorporate/optimize the various tests from the
2 different places that it was being set
* Use a more robust method of determining portdir from $PWD. This also
works for bare 'portmaster' with no arguments now, if you're in a port
directory.
* Various additional code cleanups
Bug fix:
========
Do read_distinfos() in the background for multiport() too, oops
Minor fixes/improvements
========================
* Turns out there are a non-zero number of distinfo files that have SIZE
listed first, so in the code that parses them for the data to put into
/var/db/pkg/$port/distfiles, handle this situation gracefully.
* If we trap while working on a child port do not remove that child from
the PM_NEEDS_UPDATE list so that when it gets printed in the parent
that child is still on the list.
* Use the count of total ports as $num_of_deps for -Faf
* For -av, add num_{roots|trunks|branches|leaves} values to the headers
* In multiport(), decrement the number of ports to work on and print a -v
message if we have already seen a port in the worklist as a dependency
of another port in the list.
* Many other minor code cleanups
Performance enhancement
=======================
* In read_distinfos*() use while read instead of grep. Avoids the fork
and reduces the total time for building the list(s) of distfiles by 25%
