* More verbose option description and reason for NO_CDROM
* Add dependency on compat9x for the shared lib (binaries are static)
* Update the pkg-descr text
PR: 213590
Submitted by: matthew@reztek.cz (maintainer)
Drop unused PROJECTHOST variable
Convert to USES=localbase
Mark DEPRECATED; EXPIRATION_DATE to follow once the dependency from
consumer ports is removed. There isn't much point keeping this
around if the backend servers are no longer functioning. They were
in a zombie state for years as it was.
- Use github instead of fedora mirror to ensure we detect any future
releases.
- NOTE: it appears the www.musicdns.org website is no longer functioning
and this port may need to be depreciated if no other service is available
PR: 212790
Submitted by: tcberner
Approved by: jhale (maintainer timeout: 13 weeks)
It appears that the static resample library should not have been part
of the distribution tarball. It's presence causes libresample.a not to
be built and to be used instead. It was detected by DF's ar programs
which reported it as malformed. Fix the distribution issue by removing
the pre-existing library and force it to be rebuilt.
Approved by: just-fix-it
Modern GCC doesn't accept empty Wl arguments. Solves:
c++: error: unrecognized command line option '-Wl'
I confirmed the patch modification doesn't break the build on FreeBSD 10.3.
Approved by: just-fix-it
- update to 0.7.10
- remove dependency upon magic: it is not used since 0.7.8
Changelog:
0.7.10 - 12.10.2016 (Hollow)
Bug Fixes:
[issue 97] - Missing import
[issue 105] - Fix the rendering of default constructed id3.TagHeader
Fixed Tag.frameiter
$ sayonara
[...]
Database created successfully
QSqlDatabase: QSQLITE driver not loaded
QSqlDatabase: available drivers:
Error: DatabaseConnector database cannot be opened!
Error: Driver not loaded
Error: Driver not loaded
Error: Could not open Database
Warning: Database not existent. Creating database
**** All settings initialized ****
Error: Cannot initialize settings
-- Checking for module 'libmtp'
-- Package libmtp was not found in the pkg-config search path.
Perhaps you should add the directory containing `libmtp.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libmtp', required by 'virtual:world', not found
Reported by: pkg-fallout
While here:
Add a few dependencies to satisfy stage-qa
Convert to USES=localbase
Complete conversion to options helpers
PR: 214497
Submitted by: Jochen Neumeister <joneum@bsdproject.de>
Approved by: maintainer timeout
- Add LICENSE (BSL)
- Add CPE data
- Remove STATIC option and always install the shared library;
no reason not to.
- Remove GCC option and use USES=compiler framework
- Add FULL_DEBUG option to address CVE-2016-7420 and add a warning if trying
to use it. It will allow the asserts to be enabled which could be a
security risk. The standard DEBUG option is now safe to use.
- Add SIMD option for i386 and amd64 - requires a recent clang or gcc
- Don't install the cryptest binary; it is really only used for regression
testing, so only build it for the TEST_TARGET. It is useless without the
data files anyways.
- Take maintainership
- Bump PORTREVISON on dependent ports due to shared library bump
PR: 215015
Reported by: <fcsk.aim@gmail.com>
MFH: 2016Q4
Security: eab68cff-bc0c-11e6-b2ca-001b3856973b
This allows the port to be built with the upcoming FFMPEG 3.x series while
still maintaining compatibility with FFMPEG 2.x that is currently in the ports
tree.
I don't think PORTREVISION needs to be bumped here, as both the old and new
calls exist in FFMPEG 2.x, and when FFMPEG 3 lands there will be a PORTREVISION
bump anyway.
PR: 214184
Submitted by: Matthey Rezny <matthew@reztek.cz>
`make stage-qa' was complaining about a lot of missing dependencies:
- Amarok actually links against MySQL, so we need USES=mysql, not
USES=mysql:embedded.
- Add USE_KDE=soprano and USE_GL=gl.
- Add several missing X11 dependencies that were being pulled indirectly.
- The IPOD option causes the iPod plugin to link against a few other libraries
via libgpod-1.0.pc, so add them.
- The MP3TUNES option needs either libgcrypt or OpenSSL; explicitly disable
libgcrypt and add USES=ssl as required.
- Fix a capitalization typo in MP3TUNES_CMAKE_OFF that was preventing the
MP3Tunes code from being properly disabled in CMake.
Based on an initial patch sent by Matthey Rezny <matthew@reztek.cz>.
PR: 214184
MFH: 2016Q4
The only reason to use post-stage is because the port needs to do
"things" at a later time, like some plist manipulation.
While there, fold post-install in do-install targets when they are
defined.
PR: 214780
Submitted by: mat
Exp-run by: antoine
Sponsored by: Absolight
Braces are not shell metacharacters, and they do not need to be quoted.
By the time find parses its arguments and dicovers them, the quoting
will have been removed by the shell anyway.
Sponsored by: Absolight
Additions
Swedish translation (Ake Engelbrektson)
CJK Encoding for Encoding Conversion Function (XIE Dongping)
Spanish translation (Jose Vidal)
Changes
Improved Amazon tag source album matching
Czech translation (Pavel Fric)
Fixes
#280 Turn off auto-saving "Enter description here" desciption for covert art
Parsing tracks in Discogs if only a single artist (Frank Sachsenheim)
Support for latest mutagen (Bruno Bergot)
- Instead of excluding the specific packages added to DISTFILES (but only for
FreeBSD 9+), exclude all files with a '.nupkg' extension.
- Move the nuget-extract command to be before post-extract, to allow the port's
post-extract command to move packages around
audio/libgpod-sharp: add port for mono bindings for libgpod
- audio/libgpod: [2]
- USE_GNOME: add missing dependency
- Remove mono files from pkg-plist (now in audio/libgpod-sharp)
- Allow relevant variables to be overridden
- Fix MONO options
- Patch source to allow building with modern mono
- Avoid post-install target for slave ports.
devel/monodevelop: update to 4.6.2.7
- Update nuget package Fantomas to 2.4.0 (latest at time of monodevelop's
release).
- Downgrade nuget package FSharp.Compiler.CodeDom (per paket's specification)
- LICENSE: Add license of LGPL21
- LICENSE_FILE: Add license file from source
- PORTSCOUT: Avoid checking alpha releases (aka x.y.0.z releases)
games/openra: simplify post-extract [3]
- USES=mono:nuget allow overridding of NUGET_PACKAGEDIR
- Set NUGET_PACKAGEDIR to correct location, fix patching accordingly
lang/fsharp: update to 4.6.2.7
ChangeLog:
- Fix#639: Problems with F# scripts on Mono
- Fix FSharp.Compiler.Tools targets for .NET Core usage
- Fix FSharp.Compiler.Tools package dependencies
lang/mono: update to 4.6.2.7
Mono 4.6.2 is the 1st service release to the 4.6 series.
Changes:
- LICENSE: Add license of MIT
- LICENSE_FILE: Add license file from source
- PORTSCOUT: Avoid checking alpha releases (aka x.y.0.z releases)
Bug fixes:
- #44708 - "TrustFailure (The authentication or decryption has failed.) ...
Invalid certificate received from server." with "Error code: 0x5"
or "Error code: 0xffffffff800b010f" when attempting to access
HTTPS servers on ports other than 443
- #39832 - SIGSEGV when running roslyn
multimedia/banshee: bump port revision.
- Update missing port dependencies
- Convert to use option helpers
- OPTIONS: Add APPLEDEV (missing dependency added)
- LICENSE: Add MIT license
- LICENSE_FILE: Add license file from source
- PORTSCOUT: Skip alpha release (2.9.1)
x11-toolkits/gnome-sharp20: fix port dependencies
- Add missing dependencies
- Convert post-patch to shebangfix
- LICENSE: add LGPL21 license
- LICENSE_FILE: use license file from source
- MKAE_JOBS_UNSAFE: remove, does appear to work
x11-toolkits/gtk-sharp20: update to 2.12.42.
PR: 214680 [2]
PR: 214681
Suggested by: jbeich [1]
Submitted by: jbeich [3]
Approved by: avilla (maintainer; timeout) [2]
- Update PORTVERSION and distinfo checksum (1.2.0)
- Remove unneeded patches
- Update pkg-message according to changes
- Improved OSS support
- Support for snd_uaudio(4) /dev/umidi* interfaces. /dev/umidi1.0 maps to rmidi/1 in sndio, /dev/umidi1.1 to rmidi/1.1
- The configure script has support for DragonFly
- More detailed changes: https://pkg.tobik.me/sndio-1.2.0-changes.txt
PR: 214210
Submitted by: Tobias Kortkamp <t@tobik.me> (maintainer)
Approved by: feld (mentor)
- Switch to USES=localbase
- Add LICENSE: GPLv2+ for VBA code, LGPL21 for bundled libresample code and
NONE for playgsf code, as no license is specified neither for it nor for
code it's based on (http://www.caitsith2.com/gsf/)
PR: 214653
Submitted by: amdmi3
Reported by: jbeich
* This allows us to get rid of both manually specified targets.
* As no PLIST_SUBS are used, also OPTIONS_SUB can be dropped.
* Further, do not use QT_BINDIR and install the manpage to man/ intead of share/man.
PR: 214621
Approved by: rakuco (mentor), takefu (maintainer)
lang/gcc which have moved from GCC 4.8.5 to GCC 4.9.4 (at least under some
circumstances such as versions of FreeBSD or platforms).
In particular that is ports with USE_GCC=yes, USE_GCC=any, or one of
gcc-c++11-lib, openmp, nestedfct, c++11-lib as well as c++14-lang,
c++11-lang, c++0x, c11 requested via USES=compiler.
- Fixed virtual server stops responding to clients
- TSDNS server now also listens on ipv6 when available
- TSDNS server Documentation updated
PR: 214641
Submitted by: Ultima1252@gmail.com (maintainer)
Rename a few options based on what they do vs. what libraries they use and use
standard descriptions where possible. Namely, CHROMAPRINT -> ACOUSTID,
ID3LIB -> MP3, MP4V2 -> MP4.
Add a few missing dependencies reported by stage-qa.
Cosmetic changes to make the Makefile a little more readable.
$ portlint
FATAL: Makefile: [18]: EXPIRATION_DATE (2016-11-31) is either not in YYYY-MM-DD format or it is not a valid date.
Reported by: dvl (via freshports)
- This includes several changes that were already made by local patches
- Changes since release:
- Fix taglib detection
- Fix build with ffmpeg 3.x
- Fix build with gcc 6
- Add dependency on desktop-file-utils to satisfy stage-qa
- Bump PORTREVISION
PR: 214183 [1]
Submitted by: jbeich [1]
- Convert to option helpers
- Convert to COPYTREE_SHARE, CONFLICTS_INSTALL
- Turn goemon font into an actual option
- Use TDIR/TCONFIG variables more
Tested by: mtree -k sha256 -cp <before> | mtree -p <after> # is silent
PR: 197126, 213285 (based on)
Submitted by: Radim Kolar <hsn@sendmail.cz>, Michael Beer <beerml@sigma6audio.de>
LV2 is an open standard for audio plugins, used by hundreds of plugins
and other projects. At its core, LV2 is a simple stable interface,
accompanied by extensions which add functionality to support the needs
of increasingly powerful audio software.
http://lv2plug.in/
%%QT_BINDIR%% and %%QT_LIBDIR%% represent the relative location of the
Qt binaries and libraries respectively -- they are only 'bin' and 'lib'
by chance, and should not be used that way.
Approved by: portmgr (blanket), rakuco (mentor)
Virtual OSS is an audio mixing application that multiplexes and demultiplexes
a single OSS device into multiple customizable OSS compatible devices using
character devices in userspace. These devices can be used to record played
back audio and mix the individual channels in multiple ways. Virtual OSS
also supports playback and recording through bluetooth audio devices.
Submitted by: Hans Petter Selasky
- Add xcb to USE_XORG, required by bin/pacat
- Add iconv to USES, required by bin/pacat
- Add ssl to USES and correct OPENSSL_CFLAGS and OPENSSL_LIBS
- Replace --disable-systemd with correct --disable-systemd-* configure arguments
- Move ALSA and JACK to AUDIO options group
- Move BASH and ZSH to COMPLETIONS options group
- Add DATABASE single option to be able to select supported database
- Add SIMPLE (database support) to default options
- Silence mkdir
- Replace files/patch-src_daemon_default.pa.in with sed patch
- Adapt pkg-plist
Changes: https://www.freedesktop.org/wiki/Software/PulseAudio/Notes/9.0/
ABI: https://abi-laboratory.pro/tracker/timeline/pulseaudio/
PR: 210548
Submitted by: lightside@gmx.com
Approved by: maintainer timeout (4 months)
So, replace them with OPTIONS_SLAVE, OPTIONS_EXCLUDE, OPTIONS_DEFAULT,
where appropriate.
The ghostscript ports are doing something nasty that is certainly wrong,
but I don't want to try to understand it.
Sponsored by: Absolight
See "Maintainer Reset" in
https://www.freebsd.org/portmgr/policies_contributors.html. makc's last commit
was in March 31st (r412218), and his ports have been timing out since at least
July (r418155).
I also emailed him 2 weeks ago and have received no response so far.
Mk/Uses/linux.mk changes:
- Add support for architecture neutral (noarch) distfiles.
- Add support for 64-bit only ports: set IGNORE on i386 and don't install
32-bit compat libraries on amd64.
Submitted by: Piotr Kubaj <pkubaj@anongoth.pl>
Differential Revision: https://reviews.freebsd.org/D7886
A lot of KDE Ports share MASTERSITES, LICENSE and so one, as they are
released as a bundle upstream, however, there was not really a clean
way to share this information.
Using these new categories, we can simplify the Makefiles for the diverse
KDE ports.
At the moment we support the virtual category
* kde-kde4
In the future, this will be extended to
* kde-frameworks
* kde-plasma
* kde-applications
PR: 213406
Differential Revision: https://reviews.freebsd.org/D7645
Exp-run by : antoine
Reviewed by: mat, rakuco
Approved by: portmgr (mat), rakuco (mentor)
This fixes the scanner.pl program, which would otherwise produce this
error in the log files:
Slim::Schema::Storage::throw_exception (122) Error: DBI Exception:
DBD::SQLite::db do failed: SQL logic error or missing database
cannot ATTACH database within transaction [for Statement "ATTACH
'/var/db/logitechmediaserver/cache/persist.db' AS persistentdb"]
More details about this problem:
http://forums.slimdevices.com/showthread.php?106257-FreeBSD-port&p=864545
Approved by: mark@tranquillussoftware.co.uk (maintainer), adamw (mentor)
Differential Revision: https://reviews.freebsd.org/D8255
Because GitHub releases (tarballs) are not fetched with correct modification
time, set TIMESTAMP to 1475314642 which corresponds to commit 57ef482 tagged
as this release.
Reported by: portscout
maintained the XMMS plugin doesn't work past this version. Rather than
removing the still working XMMS plugin in this version, decouple the slave
port from master port and leave it at this version. This allows for the CLI
player to be updated independently.
- Add NLS option and therefore bump PORTREVISION
- The CLI player is not needed as a run-dependency
- Update WWW
- Add license
maintained the XMMS plugin doesn't work past this version. Rather than
removing the still working XMMS plugin in this version, decouple the slave
port from master port and leave it at this version. This allows for the CLI
player to be updated independently.
- Add NLS option
- Add LICENSE
- Update to 0.0.93
- Update WWW
- Relocate to github
- Explicitly list Qt core components in dependencies
Because GitHub releases (tarballs) are not fetched with correct modification
time, set TIMESTAMP to 1475427605 which corresponds to commit 7f9ae7c tagged
as this release.
Reported by: portscout
USES=localbase:ldflags can be used to set LDFLAGS. Normally LDFLAGS
appears too early on the command line causing some ports to link with
their own libraries in LOCALBASE (if installed) instead of WRKSRC.
Also make use of _USES_POST so -L${LOCALBASE}/lib is added as late as
possible after anything a port Makefile might set. Use _USES_POST
instead of .include in libedit.mk and libarchive.mk so things like
'USES=libedit localbase:ldflags' work correctly.
Fix some issues with LIBS in some ports.
Switch ports that don't support LIBS to localbase:ldflags.
PR: 212987
Exp-run by: antoine
Approved by: portmgr (antoine)
Add some examples if requested.
Add some test programs if requested.
N.B. PR is actually against comms/libcodec2 which is a duplicate port.
PR: ports/210186
Submitted by: takefu@
- Clean up the Makefile.
- Follow some upstream recommendations (--with-data-packaging=archive,
--disable-renaming, -DICU_NO_USER_DATA_OVERRIDE).
- Patch makefiles to install static libraries with INSTALL_DATA so they
aren't stripped.
- Patch config/mh-bsd-gcc to sync with config/mh-linux-gcc.
- Fix endianness detection in ICU. The code wanted to use BYTE_ORDER
defined in machine/endian.h, but this isn't visible because ICU is
compiled with _XOPEN_SOURCE. Patch the code to use _BYTE_ORDER instead.
- Compile ICU with C++11 compiler to enable move constructors.
- Patch ICU to fix a problem with atomics in the case of a C++11 compiler
without C++11 header <atomic> (like Clang on FreeBSD 9).
- Bump all ports that depend on it due to library version change.
- Add USES=compiler:c++0x to some ports that pick up -std=c++0x from ICU
pkgconfig files.
- Add USES=compiler:c++11-lib to graphics/libcdr01 because it also needs
a C++11 runtime library now. Add this to all ports that depend on it
so their executables load the right libstdc++.so on FreeBSD 9.
PR: 205120
Exp-run by: antoine
Approved by: portmgr (antoine)
which allows you to use the Espeak speech synthesizer with Asterisk.
This module invokes the Espeak TTS engine locally, and uses it to
render text to speech.
WWW: https://zaf.github.io/Asterisk-eSpeak/
despite that their repository has been moved to GitHub: new distfile lacks
pre-generated autotools-related bits and does not bootstrap correctly, and
I'm not in the mood to fight with autotools right now
- Remove no longer accurate explanation of why we cannot enable -Werror yet:
while this particular problem with Clang is no longer an issue, there are
still lots of compiler warnings left
- If a port has another upstream, remove GOOGLE_CODE
- If a port only has GOOGLE_CODE mark it BROKEN
Some ports have a local mirror configured but for security reasons, it
is not considered upstream.
Sponsored by: Absolight
Clang 3.9.0 has a new warning about undefined template variables, which
is triggered by including cryptopp headers in the spotify blob
downloader:
In file included from /wrkdirs/usr/ports/audio/clementine-player/work/Clementine-1.3.1/src/internet/spotify/spotifyblobdownloader.cpp:43:
/usr/local/include/cryptopp/pkcspad.h:74:53: error: instantiation of variable 'CryptoPP::PKCS_DigestDecoration<CryptoPP::SHA512>::decoration' required here, but no definition is available [-Werror,-Wundefined-var-template]
return HashIdentifier(PKCS_DigestDecoration<H>::decoration, PKCS_DigestDecoration<H>::length);
^
This warning could be silenced by hacking on cryptopp, but just suppress
it for now.
Approved by: sbruno (maintainer)
PR: 212343
MFH: 2016Q3
Detailed maintainer log:
- fixed a problem where virtual servers refuse to start due to invalid flags
or order
- fixed a crash in fix crash on servergroupautodelperm /
servergroupautoaddperm
- "Error opening file: No such file or directory" message now includes
filename
- Fixed server crash when ipv6 client connects while using MariaDB (or
MySQL) server
- Database plugins are now checked more thoroughly at server startup
- To fix the problem with MariaDB, the server needs to alter columns in the
client and bindings table. For large databases, this can take a while. It
is recommended that all ts3servers that use the same database, are stopped
and then one new ts3server is started first which does the update. After
this, the other instances can be started too.
PR: 212531
Submitted by: Ultima1252@gmail.com (maintainer)
hide actual commands executed and only show short summary line (like
"CC foo.c"). CMake and ninja enable this by default, some autotools
using ports do as well. This is unacceptable because we need complete
build logs at any time, so we now switch to verbose build logs
unconditionally. Note that this change deliberately affects ALL
builds and not only package builds on cluster, because we need to
be sure that user experiencing failure can always provide informative
build log regardless of settings and without rerunning the build.
Change summary:
- Always do verbose builds for cmake, ninja and GNU configure (the
latter includes check if --disable-silent-rules is actually supported
by the configure script; there are isolated cases when it's not true)
- Remove CMAKE_VERBOSE, NINJA_VERBOSE and
CONFIGURE_ARGS=--disable-silent-rules from all ports which set them
for this is no longer needed
- Revert hacks for --disable-silent-rules support priorly committed
to biology/ncbi-blast+ and net-p2p/mldonkey - no longer needed as well
Submitted by: amdmi3
Reviewed by: mat
Exp-run by: antoine
Approved by: portmgr (mat, antoine)
Differential Revision: D7534
*_DEPENDS. Helper variables derived from the loop variable aren't
expanded causing *_DEPENDS to be incorrect.
- Bump all ports with more than one value in USE_LINUX.
PR: 211645
Reported by: jkim
- add a SNDIO option that enables building of the audio/sndio output
module
- replace CPPFLAGS/LDFLAGS with USES=localbase
- use INSTALL_TARGET=install-strip to strip libraries
- bump PORTREVISION due to packaging change
PR: 212406
Submitted by: Tobias Kortkamp
Mk/Uses/linux.mk.
- Replace USE_LINUX=yes with USES+=linux and USE_LINUX=(.*) with
USES+=linux:\1 in all ports.
- Replace USE_LINUX_APPS with USE_LINUX in all ports.
- Use INSTALL_SCRIPT instead of INSTALL_PROGRAM to install scripts in some
ports.
- When USE_LINUX_RPM is defined, simplify the way DISTFILES and EXTRACT_ONLY
are defined.
- Remove BRANDELF_DIRS and BRANDELF_FILES handling. In the very rare cases
that it is still necessary ports can run ${BRANDELF} from post-patch.
- Remove AUTOMATIC_PLIST handling. Only one port used it.
- Fix Linux MASTER_SITES.
- Replace OVERRIDE_LINUX_BASE_PORT and OVERRIDE_LINUX_NONBASE_PORTS with
default versions framework.
- bsd.port.mk:
- Move Linux related bits to Uses/linux.mk, except USE_LINUX_PREFIX.
- Put USE_LINUX_PREFIX handling after USES processing.
- Define DOCSDIR, DATADIR, etc. after handling USE_LINUX_PREFIX so it can
give these variables a different default value.
- When a package needs to run Linux ldconfig check before installation if
Linux support is enabled.
- emulators/linux_base-*:
- Use USES=linux and remove duplication.
- Remove files/lp. FreeBSD or CUPS lp(1) should work.
- Remove files/yp.conf. No longer seems to be used.
- Remove pkg-deinstall and move pkg-install into pkg-plist.
- Update pkg-descr and pkg-message.
- Fix handling of ldconfig cache in pkg-plist.
- devel/fb-adb: Use a Linux shell to run a Linux script but patch the script
to use FreeBSD mkdir so mkdir -p $path creates $path and not
/compat/linux/$path.
PR: 211645
Exp-run by: antoine
Approved by: portmgr (antoine)
* migrate to the pd-miXedSon maintenance codebase due to breaking fork upstream: see https://github.com/electrickery/pd-miXedSon for details
* a test patch has been added to the [sampstoms~] object
* the [teeth~] object has been converted from an abstraction to an external
- While here, add LICENSE, silence MKDIR, fix whitespace
PR: 212208
Submitted by: brittlehaus@gmail.com (maintainer)
- This adds support for building with the sndio audio output (audio/sndio).
PR: 211664
Submitted by: Tobias Kortkamp <t@tobik.me>
Approved by: mva (maintainer timeout)
Plasma5 ports
At the moment KDE ports use bsd.kde4.mk to handle their dependencies. When
working on the ports for KDE Frameworks and Plasma5 it seemed to be more
reasonable to create a new kde.mk instead of adding an bsd.kde5.mk.
The kde.mk in this review is a stripped down version of the one we are using in
the KDE Test repositories plasma5 branch [1] to only contain the parts relevant
to the current KDE4 ports in the portstree [2].
Changes to the KDE Ports needed by this:
Replace USE_KDE4 by USE_KDE [3]
Add USES=kde:4 [4]
[1] http://src.mouf.net/area51/view/branches/plasma5/KDE/Mk/Uses/kde.mk
[2] The version in the plasma5 branch also handles frameworks/plasma5 and
handles MASTER_SITES via a KDE_DIST variable similar to bsd.qt.mk for Qt
Ports -- I chose to leave this out for now, as the diff is already large
enough.
[3] I chose USE_KDE instead of USE_KDE4, USE_KDE5, USE_KDEX as the version we
want is already specified as argument to kde:<arg>
[4] For KDE Frameworks and Plasma5 ports this would be kde:5
PR: 210667
Approved by: portmgr, mat (mentor), rakuco (mentor)
Reviewed by: mat, rakuco
Differential Revision: https://reviews.freebsd.org/D6961