Commit graph

823 commits

Author SHA1 Message Date
Mark Linimon
34d3330d94 Add a column for last-date stamp and clean up the formatting a bit. 2006-07-05 23:17:53 +00:00
Vasil Dimov
ed290037f5 Escape characters (like +) that may appear in ports' names and
break sed -E regular expressions
2006-07-05 08:31:49 +00:00
Renato Botelho
0bc560fc74 When automatic commit log is generated, change @ to " at " on submitter email
to prevent spam
2006-07-04 23:12:10 +00:00
Mark Linimon
c693c172bc Handle the case where the size of INDEX is zero (e.g. during new builds). 2006-06-28 22:46:18 +00:00
Mark Linimon
e4e1eb4a82 Fix edit-o. 2006-06-28 04:27:43 +00:00
Mark Linimon
a2947a3c30 Creates an HTML file with tables for each architecture which summarize the
number of packages built vs. packages that failed, along with some other
related information.
2006-06-27 05:31:32 +00:00
Mark Linimon
ef2b06d533 - Remove false positives for 'makefile' (and possibly a few others).
- Remove obsolete explanations which are no longer seen, for speed:
   ELF, MOTIF, MOTIFLIB, X_manpage, awk, bison, ffs_conflict, forbidden,
   getopt, getopt.h, imake, lc_r, malloc.h, pod2man, sed, stl, soundcard.h,
   texinfo, union_wait, values.h

 - Add more cases to: arch, bad_c++, compiler_error, depend_object,
   install_error, linker_error, mtree, perl5

These changes reduce many dozens of false positives; add a few dozen
true positives; and for certain directories, improve the speed about 10%
(a few drop by 15%).

It turns out that the performance issues are mainly due to the multiple
greps.  If performance is an issue we need to go back to the moderately-
unreadable, everything-on-one-line paradigm.  Before that happens, I would
like to experiment with some refactoring, so that the patterns are built up
in the shell line-by-line, so you could still be able to read it.

Tested on:	pointyhat
Hat:		portmgr
2006-06-24 19:51:53 +00:00
Erwin Lansing
7fbbcb4402 MFP4:
Actually use ${SCP_DEST_TMP} to fix the case where
        SCP_DEST_TMP != /tmp/
2006-06-22 18:52:57 +00:00
Erwin Lansing
c090c55e39 MFP4:
When copying INDEX to the server, copy it first to a staging area and
first then to the real location. The copying can take long enough for
users to get a truncated file when downloading during the upload.
2006-06-19 15:44:16 +00:00
Renato Botelho
3cf8cfc8cd - Change addport script to do the job locally instead connect to freefall every
time to add a new module. If you want to still use old way, just use
  "-M freefall.FreeBSD.org" option
- Take addport maintainership
- When modulesupdate fail, ask user to retry
- Change modulesupdate to work fine with addport

Approved by:	will (maintainer)
2006-05-16 15:44:29 +00:00
Vasil Dimov
12dda3240e Add support for specifying ports to be removed as directories on the
filesystem (either absolute or relative) in addition to `category/port'.

PR:		ports/96649
Submitted by:	Cheng-Lung Sung <clsung@freebsd.org>
Reworked by:	vd
2006-05-02 11:31:54 +00:00
Vasil Dimov
8529c41f37 Improve dependency check:
When removing category/port - look if other ports' Makefiles contain
`/port' rather than `category/port', since the later misses things
like `${.CURDIR}/../port'
2006-05-02 09:16:10 +00:00
Vasil Dimov
b2a9550574 Add support for removing multiple ports which depend on each other 2006-04-17 08:08:37 +00:00
Kris Kennaway
38bfaf4774 Explicitly mount the NFS images ro, instead of relying on the server to
export it ro.  This saves thrashing the server if we accidentally try to
rm -rf a NFS mount (e.g. because a chroot cleanup failed).
2006-04-16 02:29:36 +00:00
Kris Kennaway
30e2a90b43 Don't bother archiving the ports tree, we don't use it for anything so it
just takes up time.
2006-04-16 02:27:27 +00:00
Vasil Dimov
dffa807775 Quote ${1} so we don't get ``[: =: unexpected operator'' if the script
is started without arguments.
2006-04-12 05:23:04 +00:00
Vasil Dimov
ffc261a29e Add the script I use to remove ports so everyone
can benefit (or suffer :-) from it.
2006-04-10 05:54:50 +00:00
Kris Kennaway
6da61e3ed2 Mount linprocfs on amd64 for the convenience of jdk builds. 2006-04-03 04:43:56 +00:00
Kris Kennaway
072a81b38f The squid rc.d script no longer has the .sh suffix 2006-04-03 04:42:42 +00:00
Kris Kennaway
36780b5bd1 Do not preserve the previous package sets in bak/. This is taking up
too much space on pointyhat, and it's also very slow.
2006-04-03 04:41:59 +00:00
Kris Kennaway
7d1ca938be Clean up linprocfs on amd64 as well. 2006-04-03 04:41:14 +00:00
Kris Kennaway
721c2900a5 jdk is buildable on amd64, so we need to also mount linprocfs there. 2006-04-03 04:40:39 +00:00
Kris Kennaway
6b9fc3cfd1 This script preserves packages that will be removed by the restricted.sh
script, i.e. so they can be moved back into place before start the next
incremental build so they won't be needlessly rebuilt every time (jdk, I'm
looking at you).  It is a bit of a hack since it relies on assumptions
about the structure of that shell script, but for now it's the best we
can do.
2006-04-03 04:40:10 +00:00
Kris Kennaway
fc0b01f665 Temporarily back out the pre.log change, it doesn't work properly.
Approved by:    portmgr (implicit)
2006-03-13 03:05:51 +00:00
Kris Kennaway
0a3523a185 Mount the md image async here too
Approved by:    portmgr (implicit)
2006-03-13 03:04:37 +00:00
Kris Kennaway
7a39c45c24 Add some more directories temporarily until these ports can be made to
clean themselves up properly.

Approved by:	portmgr (implicit)
2006-03-13 03:04:07 +00:00
Kris Kennaway
6d04ba603f Add a mechanism for reporting client machine error conditions back to the
server.  Error conditions are flagged by other processes by creating
a named dotfile in ${scratchdir}.  If these files are found, report the
error status instead of the number of running jobs.  Currently report "ERR"
for all error conditions; I will probably change this to a per-condition
message.

Currently only "squid not running" and "disk space low" conditions are
reported.
2006-02-15 07:48:53 +00:00
Kris Kennaway
744179e319 Trim some unused cruft
If the package copy fails, bail out immediately instead of later on when
we try to pkg_add it.  Also trap signals and bail out.

Both conditions will cause a retry of the package build.
2006-02-15 07:45:53 +00:00
Kris Kennaway
56aabd9e31 Save the output of portbuild run on the client to a temporary log file.
If portbuild bailed out unexpectedly, mail the log to ${mailto}.

Add some XXX comments about improving robustness of this script.

Sleep for 2 minutes before retrying builds, to avoid spamming ${mailto}
with a high rate of failure logs.  In future we might be smarter about
attempting to automatically correct common failure modes.
2006-02-15 07:44:47 +00:00
Kris Kennaway
d270e5ec99 Add some sanity checking of the build environment:
* Test whether squid is running.  If not, try to kick off
  the rc script in the background in case it can be restarted
  cleanly.

* Test for at least 100MB of free space on the scratch partition.

If either condition fails, set an exception flag and bail out.  This
will be reported back to the server via reportload.
2006-02-15 07:42:30 +00:00
Kris Kennaway
bb3de95c29 * Don't try to pkg_delete packages that are not installed (the usual
cause is because it was specified in the list twice)

* Don't panic when the list of packages to delete becomes empty

* When unexpected filesystem changes are detected, bail immediately
  instead of proceeding and hiding the error in the middle of
  the log
2006-02-15 07:39:48 +00:00
Kris Kennaway
4787e51b8b Add support for 6-exp builds (FreeBSD 6.x is our new reference platform) 2006-02-15 07:34:02 +00:00
Kris Kennaway
17394c78b7 * Switch back to using pkg_delete -f; we are not yet ready to deal
with all the errors from broken pkg_delete scripts

* As threatened in previous commit, move the pristine mtree spec
  generation to phase 1, and avoid having to delete and re-add the
  FETCH_DEPENDS.  We still have to keep them installed until after
  'make extract' though
2006-02-13 20:47:04 +00:00
Kris Kennaway
89b70a6115 * In kill_procs(), pass in the directory and mountpoint as separate
arguments (cosmetic)

* Detect if a chroot was used to run a jailed build, and first attempt
  to gracefully shut it down by killing everything within using pgrep(1)
  This has a much higher chance of succeeding that relying on fstat to
  identify processes that might interfere with our attempts to clean up
  mountpoints, which is fragile (libkvm-dependent), and inherently
  unreliable at best.
2006-02-11 10:05:01 +00:00
Kris Kennaway
50a3a73c61 Support for building ports in a jail instead of a chroot. If use_jail=1
in portbuild.conf (or per-machine .conf), then construct a 127.0.0.0/8
IP address based on the build directory ID (i.e. unique for each
build instance).  This is bound to the lo0 interface for the duration
of the 'phase 2' build.

We cannot build 'phase 1' in a jail since 'make fetch' doesn't always
work through a proxy (e.g. squid sometimes mangles files fetched through
FTP, I think by performing CR/LF translation in FTP ASCII mode).

Pass in the HTTP_PROXY variable to the jail, if set.  This allows FTP/HTTP
access from within the jail if the proxy is suitably configured (some ports
legitimately need to fetch additional files during the build, e.g. if they
have a BUILD_DEPENDS=...:configure target that needs to fetch additional
distfiles).

Not all ports can be built in jails (most notably the linux_base ports
since they want to mount/umount linprocfs), so we will need to come up
with a way to deal with this.

Some ports require SYSV IPC, so security.jail.sysvipc_allowed=1 might be
required.  Some other ports attempt to perform DNS lookups, ping, or
outbound TCP connections during the build.

When it works, this provides better compartmentalization of package builds,
e.g. easier termination of builds without the possibility of daemonized
processes staying active; no possibility of accidental interference
between jails, etc.  It also allows for admin monitoring using jls(1).
2006-02-11 10:01:37 +00:00
Kris Kennaway
624d76fbca * Use ${mailto} portbuild.conf variable instead of hard-coded list [1]
* Remove old logs and possible compressed logs before attempting the build

Requested by:   lofi [1]
Submitted by:   linimon [1]
No more accidental portbuild spam:      kris and krion [1]
2006-02-11 09:49:53 +00:00
Kris Kennaway
4094b5762c Use ${mailto} portbuild.conf variable instead of hard-coded list
Requested by:	lofi
Submitted by:	linimon
No more accidental portbuild spam:	kris and krion
2006-02-11 09:48:53 +00:00
Kris Kennaway
b8d81fba50 Checkpoint a major round of changes:
* Only keep distfiles if the port passes 'make fetch', so we don't
  accidentally keep files with invalid checksums

* Use cleanup() instead of directly exiting in some error conditions

* When cleanup() is called indicating an unexpected error (possibly
  leaving the filesystem in an inconsistent state), mark the chroot
  as dirty so it will not be reused by another build

* Remove packages in dependency order instead of with pkg_delete -f in
  possibly incorrect order.  This paves the way for focusing on errors
  generated by pkg_delete (e.g. @dirrm that should be @dirrmtry) in the
  future. [1]

* Detect when packages were left behind because they were still in use
  by other packages, indicating an incorrect or incomplete port
  dependency list

* Partial support for ccache builds (not yet complete)

* Support non-standard LOCALBASE/X11BASE settings

* Delete FETCH_DEPENDS after the 'make fetch' stage.  We have to add
  them again before 'make extract' since, due to a lack of a 'fetch
  cookie', 'make extract' actually *always* runs 'make fetch' again,
  even when distfiles have already been fetched.  We need to delete
  them in order to:

* Record an mtree spec of the 'pristine' filesystem state, for later
  comparison.
  # XXX Perhaps this can be done in stage 1 before the
  # 'make fetch', removing the need to delete-and-readd.

* Also record an mtree spec of the filesystem state prior to the
  build phase.  Compare this to the state of the filesystem
  immediately before running the install phase, to detect files
  that were inappropriately installed during the build phase.
  Doing so is a fatal error.

* Prior to installing, try to run a 'regression-test' port makefile
  target, if it exists.  This allows ports to hook their internal
  regression suites into the package build.  This needs further
  infrastructure support, e.g. a default NOP target in bsd.port.mk.
  For now this is run with 'make -k', so regression failures will
  not yet actually cause package build failures.

* Separate the 'make install' from 'make package' phases rather than
  let the latter implicitly do the install.

* After the newly packaged port has been deleted, compare the state
  of the filesystem to the state before 'make install'.

* After removing BUILD and RUN dependencies, compare the filesystem
  state to the pristine state before the start of the build.  This
  also detects package dependencies that did not clean themselves up
  properly when deinstalling.  It also detects dependencies that were
  'missing' from the port INDEX: these were not pkg_added into place,
  so the package build had to compile them from scratch (a big waste
  of time and effort), so this is now also a fatal error.

PR:		ports/85746 (inspired by) [1]
Submitted by:	Boris B. Samorodov <bsam@ipt.ru> [1]
2006-02-11 09:38:18 +00:00
Kris Kennaway
84c66c52a2 Flip from noclean to clean 2006-02-03 20:13:23 +00:00
Kris Kennaway
35fb7ca9ce Don't bother chowning the client /var/portbuild/, it just takes too long
and this doesn't happen in practise unless you screwed up manually.
2006-02-03 20:10:34 +00:00
Kris Kennaway
e0db90a164 Use clean-chroot with clean=2 to remove the chroot instead of duplicating
some of the code
2006-02-03 20:09:35 +00:00
Kris Kennaway
e3e716a021 Flip "noclean" to "clean" 2006-02-03 20:08:56 +00:00
Kris Kennaway
b762d9e066 Instead of passing in a "noclean" boolean, pass in a "clean" level:
0 = don't clean chroot
  1 = sanitize commonly-modified directories
  2 = remove entire chroot
2006-02-03 20:08:18 +00:00
Kris Kennaway
a65bd63641 Also look for chroots that are marked 'dirty' (previous build left chroot
in unclean state) and run clean-chroot on them to remove them.
2006-02-03 20:07:13 +00:00
Kris Kennaway
a9f9b51a89 Don't try to remove the lock file now that we use lockf to manage it
Noticed by:	 linimon
2006-02-03 20:06:04 +00:00
Mark Linimon
f7200095a8 Fix bogus comments. No code change. 2006-02-02 00:40:37 +00:00
Kris Kennaway
e242e2904e Correctly set SRCBASE; the version inherited from buildenv is wrong for
the client chroots.
2006-01-27 22:42:00 +00:00
Kris Kennaway
d59fe16ef4 Don't try to rsync docs, we no longer need to distribute them 2006-01-27 22:40:51 +00:00
Kris Kennaway
2c15d2d1d6 Update the list of quickports 2006-01-27 22:40:33 +00:00
Edwin Groothuis
faaea2b718 Warn if there are duplicate MD5/SHA256/SIZE statements for a single file 2006-01-24 21:53:51 +00:00
Edwin Groothuis
295732eff2 Small tool to check the necessary lines in the distinfo files, based
on the contents of the distinfo files.

#
# Small tool to find distinfo with missing MD5/SHA256/SIZE statements,
# based on the assumption that if there is one of the MD5/SHA256/SIZE
# statements, then there should be all of them (except for SIZE
# when MD5/SHA256 is set to IGNORE).
#
# Usage: distinfochecker [-v] [-d directory]
# -v    - verbose (print)
# -d    - use directory instead of /usr/ports
#
2006-01-24 07:30:07 +00:00
Kris Kennaway
b3f6037efa Support 7.x INDEX builds
Add a few more local configuration variables
Minor cleanups
2006-01-22 20:45:11 +00:00
Kris Kennaway
f708dd4383 Don't bother mounting doc tree, it's not needed by any ports
Use LOCALBASE/X11BASE values from buildenv

xorg uses the stock BSD.x11-4.dist now.
2006-01-22 04:56:37 +00:00
Kris Kennaway
560f97f20b Remove -nodoccvs option, it turns out mounting the doc tree is not
required by any ports
2006-01-22 04:55:28 +00:00
Kris Kennaway
d715faf967 Also clean up linprocfs mounts 2006-01-22 04:55:03 +00:00
Kris Kennaway
c4f994d99b Pull in buildenv for LOCALBASE/X11BASE locations
Don't bother cleaning up doc mounts, they are not needed.
2006-01-22 04:54:49 +00:00
Kris Kennaway
b713f62e3b Use LOCALBASE and X11BASE from buildenv 2006-01-22 04:54:24 +00:00
Kris Kennaway
9b356bb99d Allow for the possibility of overriding LOCALBASE and X11BASE 2006-01-22 04:53:59 +00:00
Kris Kennaway
15ac5c6724 Exit with the correct error code when a make target fails
PR:             ports/64930
Submitted by:   Damir Kiramov <damirycha@damirycha.net.ru>
2006-01-15 04:18:14 +00:00
Kris Kennaway
c7d2049938 Back out last commit, it was the wrong file 2006-01-15 04:17:48 +00:00
Kris Kennaway
f83ac9920c Exit with the correct error code when a make target fails
PR:		ports/64930
Submitted by:	Damir Kiramov <damirycha@damirycha.net.ru>
2006-01-15 02:35:47 +00:00
Daichi GOTO
e1ad7a3739 Add portsvar.sh schell script into Tools/scripts.
portsvar.sh
  - print out variable defined through bsd.port.mk

example:
   % portsvar.sh PORTSDIR OSVERSION
   PORTSDIR = /usr/ports
   OSVERSION = 600034
   % portsvar.sh -e "PORTS[^_]"
   PORTSDIR = /usr/ports
   PORTSSUPFILE = /usr/share/examples/cvsup/ports-supfile
   % portsvar.sh USE_RUBY=yes RUBY_VER RUBY_ARCH
   RUBY_VER = 1.8
   RUBY_ARCH = i386-freebsd6
   % portsvar.sh -w ruby RUBY_VER RUBY_ARCH
   RUBY_VER = 1.8
   RUBY_ARCH = i386-freebsd6
   % portsvar.sh -w kde -e KDE_
   KDE_MAINTAINER = will@FreeBSD.org
   KDE_ORIGVER = ${KDE_VERSION}
   KDE_PREFIX = ${LOCALBASE}
   KDE_VERSION = 3.5.0
   MASTER_SITE_KDE_kde = ${kmaster:S@%SUBDIR%/@@g}
   % portsvar.sh -a
   list all variables through bsd.port.mk
   % portsvar.sh -a -w kde
   list all variables through bsd.port.mk including kde

portsvar.sh is easy tool to check out the variables used in
/usr/ports/Mk/bsd.*.mk.
2006-01-11 07:06:51 +00:00
Kris Kennaway
4a1dd67a59 This script may be run on a client machine to force it to flush its squid
cache.  This is useful if the client is holding a bad or stale cached
copy of a package that is causing problems for package builds.
2005-12-11 04:41:38 +00:00
Kris Kennaway
dc26cbf0be Bump the file size limit to 300MB now that openoffice distfiles exceed
256MB.  Clarify a comment.
2005-12-11 04:40:27 +00:00
Kris Kennaway
4e0a14315c Shuffle the order of a cd 2005-12-11 04:36:47 +00:00
Kris Kennaway
57164dfa7a Remove 0-sized entries to avoid misbehaviour 2005-12-11 04:36:23 +00:00
Kris Kennaway
2f084309ba Don't use a lockfile, the script will be called with lockf -t0 instead to
avoid problems with stale lockfiles after a reboot.
2005-12-11 04:35:44 +00:00
Kris Kennaway
1ace35e972 Don't use a lockfile, the script will be called with lockf -t0 instead
to avoid problems with stale lockfiles after reboots.
2005-12-11 04:35:04 +00:00
Kris Kennaway
ba996790a4 Update the list of quickports 2005-12-11 04:34:20 +00:00
Kris Kennaway
d06e2470ca Don't set -nocopy when -norsync is set, otherwise the setupnode script
doesn't completely prep the client.
2005-12-11 04:33:55 +00:00
Kris Kennaway
29d910959f Don't use a lock file, the script will be called with lockf -t 0 instead.
This avoids problems from stale lockfiles after reboots.
2005-12-11 04:32:29 +00:00
Kris Kennaway
70ca5470b7 Mount the md image async since this gives much better performance 2005-12-11 04:31:08 +00:00
Edwin Groothuis
3d8bb0ca76 Utility: A tool to identify similar pkg-descr files
The ports tree contains many tools with almost-similar names
	and no helpful pkg-descr difference. The goal of pkg-descr
	would be to aid the user in his choice of port version.
	Ergo, similar pkg-descr files are bad.

PR:		ports/89432
Submitted by:	Jonathan <afarsec@012.net.il>
2005-11-26 01:15:20 +00:00
Kris Kennaway
391855dc68 Remove, don't comment out, unused variables 2005-10-11 04:02:49 +00:00
Kris Kennaway
f03134ec0a Remove unused variables. Don't bother protecting against negative
queue lengths since that doesn't arise.
2005-10-11 04:02:05 +00:00
Kris Kennaway
29028363d7 Update lockf to lockf -k in example usage 2005-10-11 03:56:42 +00:00
Kris Kennaway
bd58a06a02 Update the lockf command to add -k in example usage 2005-10-11 03:56:20 +00:00
Kris Kennaway
94cda32b84 When -norsync is set, don't bother to run md5 over the bindist.tar
and copy it to the client.  This has two benefits:

1) Avoids spamming the master with dozens of md5 processes when
   dosetupnode is spawned for all client machines at ocne

2) Avoids silly copy attempts on disconnected nodes for which the file
   is copied to itself
2005-10-11 03:55:27 +00:00
Kris Kennaway
ac6980959a Change lockf to lockf -k in a commented-out command, just in case it's
ever uncommented.
2005-10-11 03:53:39 +00:00
Kris Kennaway
b63664dd37 Add support for use_md_swap 2005-10-11 03:53:02 +00:00
Kris Kennaway
0faac9ad5f Add support for use_md_swap. When this variable is set in a
portbuild.conf, builds will each be done in a separate swap-backed md.
This dramatically improves build performance since

* Every transaction is not written to disk, so disk bandwidth is not
  a bottleneck

* Multiple builds do not contend with each other for the same set of
  filesystem locks and other per-device resources

The size of the md devices is controlled by the md_size variable.  '2g'
seems to be a good size.

Currently we mdconfig -u each device after each port build, since
otherwise dirty blocks accumulate and the md eventually uses a full
amount of backing store (2g in the above example).  This is a problem
if there is unsufficient swap backing to accomodate them all.

XXX This should be made configurable to avoid the performance penalty on
systems that do have enough swap backing
2005-10-11 03:52:37 +00:00
Kris Kennaway
f873829934 No need to hold the queue lock while polling client load 2005-10-11 03:48:11 +00:00
Kris Kennaway
86a1e3f264 * Use lockf -k instead of lockf. If there is ever contention from >1
process, you must use -k or lockf can give out two locks at once
2005-10-11 03:47:33 +00:00
Kris Kennaway
da7e71facd * Add support for use_md_swap 2005-10-11 03:45:49 +00:00
Kris Kennaway
e93c55ca9b * Unmount linprocfs around pkg_adding dependencies, to try and work
around silly failures in some ports when it is present

* Add a footer to completed builds that is recognised by pdispatch to
  retry truncated builds

* If ALWAYS_KEEP_DISTFILES is not present in the environment or port
  makefile, then clean up DISTDIR after the build finishes, to prevent
  collection of distfiles for this port.

* Finish flipping the switch on -noplistcheck - this is activated by
  passing in the NOPLISTCHECK environment variable instead of
  using PLISTCHECK in the opposite case
2005-10-11 03:40:57 +00:00
Kris Kennaway
917dfa95ab * Finish flipping the switch on -noplistcheck - this is activated by
passing in the NOPLISTCHECK environment variable instead of
  using PLISTCHECK in the opposite case

* Remove the unused -nodummy function

* Pass in ALWAYS_KEEP_DISTFILES when -distfiles is set
2005-10-11 03:37:57 +00:00
Kris Kennaway
353d47ddd9 * Remove support for the unused -nodummy function
* Finish flipping the switch on -noplistcheck - this is activated by
  passing in the NOPLISTCHECK environment variable instead of
  using PLISTCHECK in the opposite case

* Always pull in the distfiles from the client if they exist (needed
  for forthcoming ports tree changes to satisfy GPL license requirements)

* If the build did not complete "cleanly", e.g. it was interrupted by a
  network outage or client machine panic, then retry it until it succeeds
  instead of just leaving a dirty truncated log
2005-10-11 03:36:50 +00:00
Kris Kennaway
1a15382c52 * Remove unused -nodummy argument
* Finish flipping the switch on -noplistcheck; set NOPLISTCHECK instead
  of PLISTCHECK in the opposite case

* Clean up the distfiles/ directory when starting build, so it is not
  contaminated by old distfiles

* Remove commented-out code to don't back up old distfiles/ directory,
  it's just too big to do this.
2005-10-11 03:31:41 +00:00
Kris Kennaway
85ae134a79 Silence some possible errors from chflags -R 2005-10-11 03:27:36 +00:00
Kris Kennaway
ddd72ac387 Silence possible errors from some recursive commands 2005-10-11 03:27:19 +00:00
Renato Botelho
2a6ad7961f - Add a new option -L, it works like -l but uses pkg-descr to create
commit message.

Approved by:	will (maintainer)
2005-10-04 16:26:37 +00:00
Kris Kennaway
310ce3b0a4 Remove some hardcoded values to hopefully stop random users from shooting
their feet off in public.

Suggested by:	adamw
2005-09-08 17:57:37 +00:00
Pav Lucistnik
6d4f3ffef5 - Handle different INDEX filename on 5.X and above
PR:		ports/85281
Submitted by:	Vasil Dimov <vd@datamax.bg>
2005-09-04 23:11:15 +00:00
Kris Kennaway
0280b07725 Check for extra files on !i386 also 2005-07-24 20:38:06 +00:00
Kris Kennaway
5faf427bee Support FreeBSD 7.x 2005-07-24 20:37:31 +00:00
Kris Kennaway
ea1d96a8a9 Drop the removed openoffice 1.0 ports from the quickports list 2005-07-24 20:37:20 +00:00
Kris Kennaway
a42f81135d Correct typo 2005-07-24 20:35:07 +00:00
Joe Marcus Clarke
898c84cdf7 Add prototypes for all the subroutines which fixes compilation with
Perl 5.8.7.

Reported by:	mezz
2005-07-10 22:18:55 +00:00
Volker Stolz
ac482a872e Fix typos
Approved by: sobomax
2005-04-18 14:03:05 +00:00
Volker Stolz
c53968b206 As discussed on the cvs-ports-list, make 'addport' print a warning if the directory
name contains upper-case characters as it makes finding a port harder.

PR:		ports/79679
Approved by:	will, portmgr(krion)
2005-04-12 11:03:49 +00:00
Anton Berezin
bbd85008bd Add a splitpatch.pl utility, a small script to convert multi-file
patches to several appropriately named single-file patches.

Requested by:	flz
2005-04-12 10:56:08 +00:00
Florent Thoumie
75dd621ca0 - Add bump_revision.pl, a small script to bump the PORTREVISION variable
of ports which are depending on a port with a changed shared lib version.

Edwin dedicates this script to his son Dirk, born few days ago :)
Congrats (again) !

PR:		ports/63915
Submitted by:	edwin
2005-04-12 09:22:59 +00:00
Florent Thoumie
a9c04539e5 - Replace pkg-comment with COMMENT to reflect latest (*sigh*) changes
in the ports framework.

PR:		ports/62767
Submitted by:	Igor Pokrovsky <tiamat@comset.net>
Approved by:	maintainer timeout (> 8 months)
2005-04-11 22:21:41 +00:00
Kris Kennaway
aa820a71ce Use WRKDIRPREFIX instead of hardcoded value.
Clean up after we're done.
2005-04-11 22:08:14 +00:00
Kris Kennaway
d23d4aaa34 Change rsync -l to -L for the tarballs/ directory (so that dangling
symlinks are not created on the target) and rsync the entire
directory so that extra files are deleted.
2005-04-03 04:37:09 +00:00
Kris Kennaway
9ebdc14d1d Build packages with WRKDIRPREFIX=/work (which does not exist by
default) instead of /tmp, since some packages incorrectly search this
build path at runtime to try to load things.

Requested by:	nectar
2005-04-02 20:20:21 +00:00
Kris Kennaway
3bb948c483 Increase the nc poll timeout to better deal with network latencies. 2005-04-02 20:19:03 +00:00
Kris Kennaway
da08048084 Flip over the -plistcheck switch to -noplistcheck since we now want to
make it the default behaviour.
2005-04-02 20:18:28 +00:00
Kris Kennaway
37d3297837 Update the list of files and directories to filter from the plist checking. 2005-04-02 20:17:47 +00:00
Volker Stolz
3ddc5c643b Checkout Templates from CVS as well since ports with GNU_CONFIGURE will
need them when building from 'addport -a -t'.

Approved by: will
2005-03-20 17:32:52 +00:00
Kirill Ponomarev
c0c72653c1 Put $FreeBSD$ for ident(1)'ing. 2005-03-13 08:49:38 +00:00
Kirill Ponomarev
4bfcaa5b4c Hopefully last try to fix readmes build.
Submitted by:	Christopher Kelley <bsd at kelleycows.com>
Pointyhat to:	krion
2005-03-11 21:25:16 +00:00
Kirill Ponomarev
6049ef2e65 Fix problems with quoting if PORTSTOP is specified. 2005-03-09 23:57:29 +00:00
Kirill Ponomarev
bd07e61e5b * Add info files to TMPPLIST, only if INFO is specified. [1]
* Fix PATH problems during README.html generation if "make
  -DPORTSTOP readmes" is defined. [2]

* Add support for early rcNG startup scripts. [3]

* Remove duplicate USE_XLIB handling. [4]

* Add check for USE_PYTHON_(BUILD|RUN), and include bsd.python.mk if
  both are specified. [5]

* Use PRE-INSTALL target for SUB_FILES and SUB_LIST. [6]

* Introduce bsd.gstreamer.mk and utilize new macros:
  USE_GSTREAMER/WANT_GSTREAMER. [7]

PR:		ports/77634 [1], ports/77592 [2], ports/77385 [3],
		ports/77557 [4], ports/77344 [5], ports/77211 [6],
		ports/77838 [7]
Submitted by:	krion [1] [2], Florent Thoumie <flz@xbsd.org> [3] [6],
		pav [4], lofi [5], ahze [7]
2005-02-28 21:09:05 +00:00
Kris Kennaway
54af5f8cd3 * Instead of using umount -f to unmount things, first use fstat to
look for processes holding open references within the FS and kill
them, then use regular umount.  This is necessary now that devfs
cannot be force-unmounted, and has the benefit that processes can't
hang around holding references to files between port builds.

* Preliminary work to support using ccache to accelerate builds.
2005-02-12 03:41:39 +00:00
Kris Kennaway
5afe4a4daa Only try to chown the portbuild directory if we are a disconnected client
(i.e. it is not mounted by nfs)
2005-02-12 03:39:16 +00:00
Kris Kennaway
9e2b178527 Instead of using umount -f to unmount things, first use fstat to look for
processes holding open references within the FS and kill them, then use
regular umount.  This is necessary now that devfs cannot be force-unmounted,
and has the benefit that processes can't hang around holding references to
files between port builds.
2005-02-12 03:38:37 +00:00
Kris Kennaway
ccb8be3838 * Instead of using umount -f to unmount things, first use fstat to
look for processes holding open references within the FS and kill
them, then use regular umount.  This is necessary now that devfs
cannot be force-unmounted, and has the benefit that processes can't
hang around holding references to files between port builds.

* Reduce possibility for error by testing for presence of executable
ldconfig inside the chroot before attempting to run it (e.g. it may not
be there if the chroot was not completely initialized)
2005-02-12 03:38:08 +00:00
Kris Kennaway
4e40e823b4 Update the plist checking to look for a subset of files and weed out some
false positives.
2005-02-12 03:34:21 +00:00
Kris Kennaway
3038d3579a Document the check-latest-link and tindex scripts 2005-01-24 07:22:38 +00:00
Kris Kennaway
4649cc8071 Add the script I use to look for duplicate LATEST_LINK entries and to
send nag-mails to the responsible maintainers.
2005-01-24 07:20:01 +00:00
Kris Kennaway
738cf264d0 This is the script I use to build indexes for all supported ports branches,
which are copied to www.freebsd.org for use by 'make fetchindex', as well
as the source of build failure reports on ports@FreeBSD.org when it is
broken.
2005-01-24 07:18:33 +00:00
Kirill Ponomarev
043f5658ce Remove traling spaces. 2005-01-09 10:21:17 +00:00
Kris Kennaway
8466626037 Always set up the bindist-${hostname}.tar file since it's usually small.
This should probably be changed to only update it if it changes.

Approved by:    portmgr (self)
2005-01-06 23:11:51 +00:00
Kris Kennaway
7e26c3751b Unset the __MAKE_CONF variable after setting up buildenv, because we
want to use the default value in the build chroot.

Approved by:    portmgr (self)
2005-01-06 23:10:53 +00:00
Kris Kennaway
db37071d1d Allow machines to use an alternate address for polling for job load (e.g.
if the machine is behind a NAT and is not directly addressable, we can
use a localhost port forward to contact it)

Approved by:    portmgr (self)
2005-01-06 23:09:31 +00:00
Kris Kennaway
0715403560 * Include portbuild.conf before portbuild.${hostname} to reset the default
value of variables

* Allow krion to drink from the email firehose

Approved by:    portmgr (self)
2005-01-06 23:07:50 +00:00
Kris Kennaway
dbfcfd10a4 * The mlist file now only has one field per line.
* Correctly calculate job concurrency in pass two as well

* In pass two run dosetupnode -rsync to avoid wasting time.

Approved by:    portmgr (self)
2005-01-06 23:06:41 +00:00
Kris Kennaway
d123521192 krion wants to drink from the pointyhat email firehose as well.
XXX This should be a portbuild.conf tunable

Approved by:    portmgr (self)
2005-01-06 23:05:27 +00:00
Kris Kennaway
db2150f0f7 Now that I have so many remote build machines, don't force trying to
fetch from ftp-master and pointyhat; they'll just get timeouts.
Instead, each machine is expected to set up their own MASTER_SITE_*
variables in etc/make.conf via a bindist-${hostname}.tar file.

Approved by:	portmgr (self)
2005-01-06 23:04:20 +00:00
Kris Kennaway
23bd58ef86 * Support the -norsync argument to only remove the existing build chroots
on a disconnected client, without running the time-consuming rsyncs.
  This is useful when a build is interrupted and needs to be restarted.

* After we have cleaned up the machine, reset the queue counter by using
  pollmachine -queue.  This has a race condition if other builds are being
  dispatched to the machine (e.g. builds on another branch):

  getmachine can claim a directory and increment the counter, then the
  machine is polled and finds e.g. 0 chroots in use, and resets the
  counter to 0, then claim-chroot is run and the build dispatched, with
  the counter now off-by-one.  This could be fixed by running
  claim-chroot with the .lock held, but this turns out to be too
  time-consuming.  A two-level lock approach might also fix this
  efficiently.
2004-12-28 05:50:37 +00:00
Kris Kennaway
01e42e5b2d * It does in fact make sense to specify -incremental and -noindex at the
same time, assuming that the admin has already built the INDEX and
  INDEX.old in advance.

* Adapt to new method of calculating build concurrency, by summing the
  value of ${maxjobs} listed in every portbuild.${machine}

* Support 5-exp builds
2004-12-28 05:45:30 +00:00
Kris Kennaway
0ebddec26a Fix the Xvfb code to run Xvfb before the build phase if detected
(i.e. if the package lists a dependency on the relevant package in the
PACKAGE_BUILDING case).  This allows packages that require an
available DISPLAY to again build (with some forthcoming fixes to
existing ports).

Improve the reporting of detected filesystem anomalies (extra files
left behind after deinstallation, changes to and removal of
pre-existing files)
2004-12-28 05:43:40 +00:00
Kris Kennaway
5ca3821cf5 Overhaul of the job scheduler. The new scheduler runs builds
synchronously instead of probabilistically scheduling jobs, which
means that the job load on a machine never exceeds a desired
threshold, and we can preferentially use faster machines when they are
available.  This has a dramatic effect on package build throughput,
although I don't yet have precise measurements of the performance
improvements.

Specifically, the changes are:

* Introduce the new variable maxjobs in portbuild.  This replaces the
build scheduling weights previously listed in the mlist file, which
now changes format to list the build machines only, ranked in order of
preference for job dispatches (i.e. faster machines first).

* The ${arch}/queue directory is used to list machines available for
jobs (file content is the number of jobs currently running on the
machine).  Changes to files in this directory are serialized using
lockf on the .lock file.

* Claim a machine with the getmachine script, with the .lock held.
This picks the machine with the fewestnumber of jobs running, which is
listed highest in the mlist file in case of multiple machines with
equal load.  The job counter is incremented, and the file removed if
the counter reaches ${maxjobs} for that machine.  If all machines are
busy, sleep for 15 seconds and retry.

* After we have claimed a machine, we run claim-chroot on it to claim
an empty chroot, as before.  If the claim fails, release the job from
the queue with the releasemachine script and retry after a 15 second
wait.

* When the build is finished, decrement the job counter with the
releasemachine script, with .lock held.

* The checkmachines script now exists only to poll the load averages
for admin convenience (every 2 minutes), and to ping for unreachable
machines.  When a machine cannot be reached, remove the entry in the
queue directory to stop further job dispatches to it.  This needs more
work to deal with reinitialization of machines after they become
available again.
2004-12-28 05:40:51 +00:00
Kris Kennaway
e47e305126 Overhaul of the job scheduler. The new scheduler runs builds
synchronously instead of probabilistically scheduling jobs, which
means that the job load on a machine never exceeds a desired
threshold, and we can preferentially use faster machines when they are
available.  This has a dramatic effect on package build throughput,
although I don't yet have precise measurements of the performance
improvements.

Specifically, the changes are:

* Introduce the new variable maxjobs in portbuild.  This replaces the
build scheduling weights previously listed in the mlist file, which
now changes format to list the build machines only, ranked in order of
preference for job dispatches (i.e. faster machines first).

* The ${arch}/queue directory is used to list machines available for
jobs (file content is the number of jobs currently running on the
machine).  Changes to files in this directory are serialized using
lockf on the .lock file.

* Claim a machine with the getmachine script, with the .lock held.
This picks the machine with the fewestnumber of jobs running, which is
listed highest in the mlist file in case of multiple machines with
equal load.  The job counter is incremented, and the file removed if
the counter reaches ${maxjobs} for that machine.  If all machines are
busy, sleep for 15 seconds and retry.

* After we have claimed a machine, we run claim-chroot on it to claim
an empty chroot, as before.  If the claim fails, release the job from
the queue with the releasemachine script and retry after a 15 second
wait.

* When the build is finished, decrement the job counter with the
releasemachine script, with .lock held.

* The checkmachines script now exists only to poll the load averages
for admin convenience (every 2 minutes), and to ping for unreachable
machines.  When a machine cannot be reached, remove the entry in the
queue directory to stop further job dispatches to it.  This needs more
work to deal with reinitialization of machines after they become
available again.

Additional changes to this file:

* Exit if passed a null package name, to avoid badness later on

* Send a nag-mail if pkg-plist errors are detected in the build
2004-12-28 05:40:15 +00:00
Kris Kennaway
b6626b754a * Catch up to change in formatting of 'extra files' section in logs
* Other minor changes
2004-12-28 04:31:29 +00:00
Kris Kennaway
a8da2d9253 /rescue/mount_linprocfs isn't functional when called by
/rescue/mount -t linprocfs, so assume that the i386 build hosts have
statically-built copies of the necessary binaries in /sbin, until this is
fixed.

Create /usr/X11R6 inside the chroot so that mtree has something to do, since
this directory is otherwise orphaned.
2004-12-28 04:30:11 +00:00
Kris Kennaway
df2f620935 Support 5-exp builds 2004-12-28 04:28:38 +00:00
Kris Kennaway
b1f044aa85 Use X_WINDOW_SYSTEM for 4.x builds too. 2004-12-10 06:33:04 +00:00
Kris Kennaway
b46b393082 Belatedly catch up to XFREE86_VERSION -> X_WINDOW_SYSTEM change; apply
the BSD.x11.dist if set to xfree86-3, otherwise use BSD.x11-4.dist.
2004-12-10 06:31:43 +00:00
Mark Linimon
aa1f54d2fe The explanations of each build error no longer live on bento, they live
on pointyhat.
2004-12-09 04:14:51 +00:00
Kris Kennaway
6686d9ac33 Construct permanent links to the error logs here too.
Submitted by:	linimon
Reminded by:	marcus
2004-12-05 00:18:05 +00:00
Kris Kennaway
f977b82737 Copy the statically-linked binaries from /rescue on the host, instead
of needing to also include the dynamic libraries that were confusing
some ports.  We still need libc.so.[56] for killall to work, though :(
2004-12-05 00:17:18 +00:00
Kris Kennaway
009e9c0f01 Be silent about attempts to unmount filesystems from within the chroot 2004-12-05 00:15:53 +00:00
Kris Kennaway
85fd51a02c Clean up the symlink in ${pb}/${arch}/${branch}/latest/${dir} when we find
a port that should not be listed here
2004-11-25 00:08:31 +00:00
Kris Kennaway
4b1cca1ab3 If sudo_cmd is set, assume we need to chown the files we created on
the client to the client_user so they can later write to them
2004-11-25 00:07:24 +00:00
Kris Kennaway
e5e059c3d8 Rework the -incremental support slightly; this should now be robust enough
to use.
2004-11-25 00:06:02 +00:00
Kris Kennaway
7b38de7527 Catch up to the changed format of the logs.
List the extra/removed/changed files separately, and colour-code the
serious errors (files left behind outside of /usr/local and /usr/X11R^;
files removed that were installed by another port, and files with changed
permissions or ownership)
2004-11-25 00:04:48 +00:00
Kris Kennaway
33afdf33e9 * Recursively list all files detected as having been left behind after
the port deinstall; mtree does not recurse into subdirectories it does
  not know about
* Break out the 'files incorrectly removed' and 'files incorrectly changed'
  into their own sections
2004-11-25 00:02:38 +00:00
Kirill Ponomarev
ae1ec8f3dc * Fix INDEX build if MAINTAINER is not defined. [1]
* Remove USE_QT2 since it's obsolete now. [2]

* Clarify comments about ARCH. [3]

* Speedup 'make readmes'.  Add a perl script "Tools/make_readmes"
  and modify bsd.port.subdir.mk to avoid recursing into individual
  port directories to create README.html. [4]

* Fix 'make search' to allow case insensitive search on 5-x/6-x. [5]

* Add the possibility to search the ports by category. [6]

* Remove tk42 and tcl76 from virtual categories since they're
  obsolete. [7]

* Introduce new variable - DISTVERSION, vendor version of the
  distribution, that can be set instead of PORTVERSION and is
  automatically converted in a conforming PORTVERSION. [8]

* Use --suffix instead of -b option for patch(1) to make it
  compatible with BSD patch(1) [9]

* Fix {WANT,WITH}_MYSQL_VER behavior, to deal with conflicting
  versions. [10]

PR:		ports/68895 [1], ports/69486 [2], ports/68539 [3],
		ports/70018 [4], ports/68896 [5], ports/73299 [6],
		ports/73570 [7], ports/67171 [8], ports/72182 [9]
Submitted by:	linimon [1][3], arved [2][7], cperciva [4],
		Matthew Seaman <m.seaman@infracaninophile.co.uk> [5],
		Radek Kozlowski <radek@raadradd.com> [6],
		eik [8], Andreas Hauser <andy-freebsd@splashground.de> [9],
		clement [10]
2004-11-19 13:45:07 +00:00
Dima Dorfman
77414b4220 Newline should go after the terminating punctuation (fix typo).
Approved by:	will
2004-11-07 04:09:39 +00:00
Kris Kennaway
e18fa3d926 Fix a couple of bugs in the extraction of this from dopackages, and
flatten the setupnode() function into the main body since it's only
called from one place.
2004-10-25 04:36:03 +00:00
Kris Kennaway
9acc2f0954 Redefine the -norestr option to mean 'don't build the list of
restricted ports' instead of 'don't build any restricted ports' since
the former is useful when we're not intending to publish the results
of a build, but the latter is not.

Move the build preprocessing (directory setup, old build rotation,
etc) out from under -nobuild, so that we can set up a new build using
that option.
2004-10-25 04:34:26 +00:00
Kris Kennaway
f233e968d9 If the symlink under latest/ exists, then use that to find the most recent
error log for the port, instead of assuming it exists in the current
build.
2004-10-25 04:31:14 +00:00
Kris Kennaway
c379808409 We now also do 6.x builds in the '6' branch. 2004-10-25 04:29:36 +00:00
Kris Kennaway
fb5e730f91 Use the absolute path to nc(1) to deal with it not being in the PATH.
Remove useless sleep(1).
2004-10-25 04:29:06 +00:00
Kris Kennaway
e12c61e3af Clean up the 'latest error log' symlink when the build is successful. 2004-10-25 04:28:07 +00:00
Kris Kennaway
0472be83f9 When a port build fails, create a symlink to the error log under
${arch}/${branch}/latest/${portdir}.  We will use this in the
processfail script, so that the "new package build errors" webpages do
not have out-of-date links but instead link to the most recent copy of
the build error.
2004-10-25 04:27:02 +00:00
Maxim Sobolev
4570e0b23c Strip out date/time from +++/--- headers in generated patchfiles, so that they
don't generate extra hunk each time patchfile is updated.
2004-10-14 14:39:44 +00:00
Kris Kennaway
db2201b8f6 Support ${client_user} and ${sudo_cmd} for running commands as root on
machines where we first connect to a non-root user and then increase
privileges.

Approved by:	portmgr (self)
2004-09-26 22:37:22 +00:00
Kris Kennaway
0147d90a3b * Break out setupnode into the dosetupnode script so it may be called
manually

* Support 6.x builds

Approved by:    portmgr (self)
2004-09-26 22:09:59 +00:00
Kris Kennaway
148e0d36af Break out the setupnode function of dopackages into a separate script so
that it may be called by hand.

Support new portbuild.conf variables

    client_user = user to connect to on the client (not necessarily
                  root).  This user must have write permission to the
                  /var/portbuild tree if disconnected=1 (i.e. we're
                  going to run rsync).
    rsync_gzip  = set to "-z" to enable compression on low-bandwidth
                  disconnected clients.

Approved by:    portmgr (self)
2004-09-26 22:09:09 +00:00
Kris Kennaway
cb3b4b98c7 * Bail out if we can't claim a chroot directory in the client (e.g. if
ssh times out)

* Support new portbuild.conf settings:

    client_user = user to connect to on the client (not necessarily root)

    sudo_cmd = If ssh'ing to a non-root user, run this command to gain
               root privs (set to empty string for client_user=root,
               or sudo for !root).  Cannot require interactivity, of
               course.

Approved by:    portmgr (self)
2004-09-26 22:04:57 +00:00
Kris Kennaway
82cb4888a4 Refuse to "clean" / if something goes wrong upstream and we are passed
the wrong path

Approved by:    portmgr (self)
2004-09-26 21:59:48 +00:00
Kris Kennaway
15d5c4a51f Pull in portbuild.$(hostname) for per-client customization
Approved by:    portmgr (self)
2004-09-26 21:59:09 +00:00
Kris Kennaway
49c4b887b4 Support 6.x builds
Approved by:	portmgr (self)
2004-09-26 21:57:27 +00:00
Kris Kennaway
ba970af6a2 * Support 6.x builds
* Default 4.x to XFree86 4.x, 5.x and above to x.org
* Don't pick up local customizations from OPTIONS

Approved by:	portmgr (self)
2004-09-26 21:56:39 +00:00
Joe Marcus Clarke
a2543a3dd2 Use a consistent PATH in both portbuild and dopackages. 2004-08-27 18:28:44 +00:00
Kirill Ponomarev
8f11239294 Avoid possible GNATS timeouts by using query-pr.real direclty. 2004-07-28 07:17:29 +00:00
Kris Kennaway
62b5c51fcb Clean up the specified chroot (umount filesystems, and scrub the
directories likely to contain changed files).
2004-07-14 10:45:26 +00:00
Kris Kennaway
2bec66d639 Atomically claim an unused chroot directory. The previous algorithm
was not atomic and could have ended up with two port builds trying to use
the same chroot.  Report the claimed directory back to the caller.
2004-07-14 10:44:36 +00:00
Kris Kennaway
f8194e5412 Bump up the cleanup timeout to directories that have been in use for
>48 hours, to cope with monster ports like openoffice and atlas.
2004-07-14 10:42:40 +00:00
Kris Kennaway
faec39b50e Back out the attempt to list the error type in the failure summary;
because this file is a chronological history of port builds that have
failed, the files listed may not be present in the current set of
error logs, and we currently have no easy way to find the most recent
failure log to use instead.
2004-07-14 10:41:03 +00:00
Kris Kennaway
b8ce56aee3 Generate permanent URLs in the error reports. The directories like
i386-5-latest that are linked to from the index.html are symlinks to
dated directories (e.5.`date`), so the URLs in the error reports will
expire with the start of the next build when the symlink is repointed.
This change makes the URLs in the error reports use the realpath of
the target file, so they do not expire.
2004-07-14 10:37:48 +00:00
Kris Kennaway
0d973156a7 * Add support for ${TRYBROKEN}.
* Clients no longer have ssh access to the master, so we need to
  push/pull everything on the client from here.  This means we need to
  know where the build took place so we can go in and get the files
  after it finishes.  Introduce the claim-chroot script which
  atomically claims a free chroot directory on the host and returns
  the name.  This directory is later populated by the portbuild script
  if it does not already contain an extracted bindist.

* Use the per-node portbuild.$(hostname) config file to decide where
  in the filesystem to claim the chroot on the build host.

* If a port failed unexpectedly (i.e. is not marked BROKEN), or if
  something strange happened when trying to pull in build results from
  a client, then send me email (XXX should be configurable).

* Clean up after the build finishes and we have everything we need, by
  dispatching the clean-chroot script on the client.
2004-07-14 10:33:19 +00:00
Kris Kennaway
a09ab19235 * Add a cleanup() function and use it so that we archive the ${WRKDIR}
if requested (".keep" file in the port directory), no matter where
  we fail.

* Add package dependencies before the corresponding build stage
  (e.g. FETCH_DEPENDS before 'make fetch'), and remove them again
  afterwards.  This allows us to catch ports that list their
  dependencies too early/late.

* No need to check for set[ug]id files here, the security-check target
  in bsd.port.mk does it for us.

* Exclude some more directories and files from showing up in the mtree
  before/after comparison, to trim down the false-positive in the
  pkg-plist check.

* Other minor changes
2004-07-14 10:19:12 +00:00
Kris Kennaway
57198c9845 * Remove the quickports stuff, it didn't (ever?) work as designed and
it's done properly^Wbetter in makeparallel

* Script accepts new arguments:

 -nodoccvs: skip cvs update of the doc tree

 -trybroken: try to build BROKEN ports (off by default because the
  i386 cluster is fast enough now that when doing incremental builds we
  were spending most of the time rebuilding things we know are probably
  going to fail anyway.  Conversely, the other clusters are slow enough
  that we also usually don't want to waste time on BROKEN ports).

 -incremental: compare the interesting fields of the new INDEX with
  the previous one, remove packages and log files for the old ports that
  have changed, and rebuild the rest.  This substantially cuts down on
  build times since we don't rebuild ports that we know have not
  changed.  XXX checkpoint of work-in-progress, not yet working as
  committed.

* When setting up the nodes, read in per-node config files
  ("portbuild.$(hostname)") before dispatching the setupnode script on
  each node.  For disconnected nodes (which don't mount the master via
  NFS), we also rsync the interesting files required by the builds
  (ports/src/doc trees, bindist tarballs, scripts) into place on the
  client.  They will be mounted locally via nullfs in the build chroots.

* Break out the restricted.sh generation into a makerestr script so it
  can be called manually as needed.

* Remove the -nocvsup argument which has been unused for a long time.

* For now, don't prune the list of failed ports with prunefail,
  since when -trybroken is not specified, every BROKEN port ends up in
  the duds file (so the build is skipped), and as a result we would
  prune almost everything from the list of failed ports.  XXX
  prunefailure should be run conditionally on -trybroken, or I should
  find a way to prune in both cases.

* Don't run index in the background, it was thrashing against makeduds
  and not saving any time by doing it concurrently.

* Build with 'make quickports all' to kick off the quickports builds
  earlier.

* Delete restricted and/or cdrom distfiles *after* post-processing the
  distfiles, otherwise the script doesn't remove any of them since
  they're not in the expected place.

* Miscellaneous other minor changes and cleanups
2004-07-14 10:09:58 +00:00
Kris Kennaway
0ba3e2d4d2 Parse the slightly-different format of the build logs. 2004-07-14 09:27:26 +00:00
Kris Kennaway
c17d1fc995 Parse the slightly-different format of the build logs. 2004-07-14 09:18:48 +00:00
Kris Kennaway
b0f3d5ad1e * Accept another argument, the value of the disconnected variable that
tells us whether the node has NFS access to the master.

* Also copy the bindist-$(hostname).tar file to allow local
customization of the build chroots (e.g. resolv.conf and make.conf
files for disconnected systems)

* For disconnected hosts, we don't copy the bindist files from the
master, but just set up the local directories and let the server rsync
them into place later.  Also set up dangling symlinks to the bindist
files in the build area, which will be filled in by the server too (in
the NFS case it makes sense to cache the bindist files locally to
avoid extra NFS traffic, but here we know the file is local so a
symlink is fine)

* Remove an apparently spurious 'killall fetch' that snuck in for what
were probably transient reasons.

* Forcibly clean up old chroot directories since we are preparing to
start another build and don't want old (possibly orphaned) builds to
skew the job scheduling or use up resources.
2004-07-14 09:17:30 +00:00
Kris Kennaway
3f0d616dec Allow local customization of the node using the portbuild.$(hostname) file. 2004-07-14 09:07:53 +00:00
Kris Kennaway
8da8b35951 Send me mail when a previously-broken port builds successfully.
XXX Should not be a hard-coded address
2004-07-14 09:06:42 +00:00
Kris Kennaway
cee8b20e99 * Initial support for disconnected nodes (not on same LAN as build
host), specified by disconnected=1 in portbuild.$(hostname) file.
These do not mount via NFS, so we need to maintain a local copy of
things needed by the build (like the ports/src/doc trees) on the build
host, which are mounted into the chroot by read-only nullfs.  These
local files are maintained in the dopackages script via rsync.

* Download packages via http instead of NFS.  Allow fetching via a
local http proxy (http_proxy variable in per-node
portbuild.$(hostname) file).  Caching package dependencies saves about
85% of package fetches and similar reduction in package fetch traffic
by byte count.

* Support a per-node tarball (bindist-$(hostname).tar) to customize
the build chroots.  This is used for things like local resolv.conf and
make.conf files on disconnected nodes.

* Make sure we don't use a chroot until it is finished extracting.

* Don't set '.' in PATH; this is bad practise, and fortunately nothing
seems to rely on it.

* Only try to build broken packages if requested

* Try harder to unmount leftover linprocfs mounts in the chroot, by copying
  in the 5.x mount binary and supporting libraries from the host system.
  The 5.x mount is able to unmount by FSID in situations where the 4.x umount
  becomes confused.

* Don't clean up when we are signalled, that is done by the build
master from outside.

* Suppress some code relating to jail builds, which are not yet ready
for use.

* Don't push results of the build back to the master; the master now
pulls them from the client when the build completes.  Clients no
longer need ssh access into the master; this is good for security as
well as significantly reducing the load on the master since it is not
thrashed by dozens of sshd processes.
2004-07-14 09:05:32 +00:00
Kris Kennaway
fb42c8eacf Hack around the sparc64 64-bit time_t test in 'installworld' since
we're installing (into a temporary staging area) on a non-sparc64
machine that does not have 64-bit time_t.
2004-07-14 08:48:42 +00:00
Kris Kennaway
5facf6ab37 * Break out the 'parallel' target from /usr/ports/Makefile. One
advantage is that here we know the value of PKGSUFFIX (.tgz/.tbz) for
  the build via buildenv.

* Add a list of 'quickports', which are ports with long dependency chains
  that we should kick off straight away to try and avoid bottlenecks later
  on when most of the cluster idles waiting for one or two ports to build.

  Ideally we'd build dependencies of these ports exclusively first and only
  build other ports when we run out (i.e. a build slot becomes free), but I
  couldn't work out how to do this.  As a compromise, we now do
  'make -k -j<#> quickports all' which doesn't give quite as high a
  priority to the quickports (i.e. we also build other ports from the
  beginning while there are quickport dependencies still to build), but is
  better than nothing.

* Pass in the FETCH/EXTRACT/PATCH/BUILD/RUN_DEPENDS separately via env
  variables when dispatching a job.  This allows us to add and remove
  the dependencies at the corresponding build stage to catch ports
  with dependencies listed too early/late.
2004-07-14 08:47:03 +00:00
Kris Kennaway
d0a6a41e42 Set INDEX_JOBS to control index build concurrency 2004-07-14 08:36:48 +00:00
Kris Kennaway
a90c52dabe Drop the ignorelist concurrency back to 1 because I'm occasionally seeing
overlapping I/O.  Something similar to how parallel index builds are now
done will need to be done here too.
2004-07-14 08:34:25 +00:00
Kris Kennaway
592c704625 * If we time out connecting to a machine, give it a weight of 999 to make
sure we don't try and schedule jobs on it even if all other machines are
  busy
* Remove sleep in outer loop, this isn't needed or worthwhile now that there
  are so many machines being monitored
2004-07-14 08:30:34 +00:00
Kris Kennaway
71b501c979 Chase bento to pointyhat 2004-07-14 08:28:35 +00:00
Kris Kennaway
3a7c8c1833 * Be even more explicit about partial ports trees being unsupported
for INDEX builds [1]

* Remove the parallel target from Makefile; this is heavily tied to
  the package build cluster and can be better done in the makeparallel
  script (commit to follow) [2]

* Extend the format of INDEX to separately list the
  EXTRACT/PATCH/FETCH_DEPENDS instead of lumping them all in together
  with BUILD_DEPENDS.  The three new fields are appended to the end of
  the record in that order. [2]

* Change BROKEN to IGNORE in BROKEN_WITH_MYSQL failure code [3]

* Support non-default PREFIX for perl 5.00503 [5]

* Use pkg_info -I instead of ls when searching for conflicts [6]

* Allow local customization of the port subdirectories by including
  ${.CURDIR}/Makefile.local in bsd.subdir.mk if it exists [7]

* Fix 'make search' when ${PORTSDIR} is a symlink to a directory name
  containing extended regexp metacharacters [8]

Submitted by:	linimon [1] [3], kris [2], lth [4], sem [5], eik [5] [6],
		Roman Neuhauser <neuhauser@chello.cz> [7]
PR:		68299 [1], 67705 [3], 67264 [4], 59696 [5], 66568 [6],
		68072 [7]
2004-07-14 08:18:16 +00:00
Murray Stokely
23cad417ec Modernize these two scripts a little bit to make it easier to deal
with 5.X or 4.X package sets (i.e., INDEX vs INDEX-5 and tgz vs tbz)

OKed by:    marcus
2004-06-08 21:57:01 +00:00
Oliver Eikemeier
52ba8d8267 Hack in master/slave support 2004-06-04 22:23:03 +00:00
Joe Marcus Clarke
fdbc9fa2c2 Add dopackages.wrapper, a wrapper script around dopackages that sets up
build locking, log files, and cleans things up if a build fails.

This script is the primary starting point for a package build.  Symlinks
should be created in the form of dopackages.${branch} -> dopackages.wrapper
where ${branch} is currently one of 4, 4-exp, or 5.  This script takes the
place of the unofficial (i.e. uncommitted) dopackages.steveX scripts.

Ok'd by:	kris
Tested by:	4.10-RELEASE package build
2004-06-03 05:03:58 +00:00
Oliver Eikemeier
5a9ce724fa parse $FreeBSD$ with yyyy-mm-dd format dates 2004-05-30 21:12:34 +00:00
Oliver Eikemeier
890f926dbd protect $FreeBSD: ... $ from being expanded
Noticed by:	mat
2004-05-30 15:15:54 +00:00
Oliver Eikemeier
0d19350b78 don't terminate the log entry with the first hyphen 2004-05-30 15:09:11 +00:00
Oliver Eikemeier
ea2c46a9b4 - make somewhat more robust against a corrupted ports tree
- CC committers and maintainer [1]
- include affected ports in the subject line [2]
- do a CVS log of the version checked out [3]

Suggsted by:	Ade Lovett <ade@FreeBSD.org> [1]
		Bjoern A. Zeeb <bzeeb-lists@lists.zabbadoz.net> [2]
		Pav Lucistnik <pav@FreeBSD.org> [3]
2004-05-30 10:44:51 +00:00
Kirill Ponomarev
a78c230b4a - Remove 'pkg-plist' from required files
Approved by:	sobomax
2004-05-27 08:49:29 +00:00
Oliver Eikemeier
2550a13d0b - fix a bug handling the maintainer field when ALLPORTS is used
- add an option to watch for maintainer changes

- change watch regex to match PKGORIGIN, not PKGNAME
2004-05-21 16:23:10 +00:00
Oliver Eikemeier
8e5aea1bea Turn chkversion into an all-dancing, all-singing notification tool.
You can even get notified of version changes in your favourite
perl modules by setting
  WATCH_REGEX='p5-.*'

Plus, it has a nice configurable nagging option.
2004-05-19 14:30:25 +00:00
Oliver Eikemeier
f21b7ffdfa small optimazation: don't compare versions that are equal 2004-05-18 08:53:39 +00:00
Oliver Eikemeier
ed499309f3 check only ports connected to the build. 2004-05-17 17:09:01 +00:00
Oliver Eikemeier
3f5f7aca90 - integrated chkorigin
- eliminated shell usage [1]

Submitted by:	mat [1]
2004-05-17 00:04:56 +00:00
Oliver Eikemeier
6c992223ae FWIIW, spawn fewer processes. 2004-05-16 10:46:47 +00:00
Oliver Eikemeier
1af7a456da support for symlinked portsdir (but no other symlinks in the ports tree)
chkversion: support for CVS blame with env CVSBLAME=yes
2004-05-14 21:07:39 +00:00
Oliver Eikemeier
1e3bf4436f add support for ignoring local ports / categories:
env 'EXCLUDE=local devel/local' /usr/ports/Tools/scripts/chkmodules.pl
2004-05-14 18:03:55 +00:00
Oliver Eikemeier
2b9f8d3add added chkversion, a script that ensures that PORTVERSIONs don't go backwards 2004-05-14 12:35:20 +00:00
Oliver Eikemeier
165c67df46 add a perl script to check CVSROOT-ports/modules,
based on a shell script by Clement Laforet.
2004-05-14 01:58:16 +00:00
Oliver Eikemeier
fbb1a3869a - don't flag empty lines
- callable without arguments:
  /usr/ports/Tools/scripts/MOVEDlint.awk
- do CVS annotate when called with env CVS=yes
2004-05-08 11:52:36 +00:00
Oliver Eikemeier
3b5d63ae7b awk script to check MOVED for consistency
Usage:
  [env PORTSDIR=/usr/ports] awk -f MOVEDlint.awk /usr/ports/MOVED
2004-05-08 02:46:29 +00:00
Mathieu Arnold
6e5777c670 While generating commit message, don't lowercase the first letter if the second
is upper case (ie : don't end up with pEAR)

Approved by:	will
Asked by:	thierry
2004-04-04 21:10:38 +00:00
Kris Kennaway
b318dd2a1c Set INDEX_PRISTINE and INDEX_QUIET to catch up to new index build
variables.
2004-04-02 07:43:43 +00:00
Oliver Eikemeier
74123e9733 added an -q option to enable usage in crontab.
Suggested by:	erwin
2004-03-28 19:13:34 +00:00
Mathieu Arnold
ba74778208 Fix a bug arising when you added a port which should have been at the end of
<category>/Makefile, and ended up at the begining

Approved by:	will
2004-03-20 18:52:33 +00:00
Oliver Eikemeier
8d16127344 Add chkorigin.sh, a script that checks the ports tree for ports with a wrong
PKGORIGIN. Useful especially after repocopies.

  env PORTSDIR=/usr/ports sh /usr/ports/Tools/scripts/chkorigin.sh

Approved by:	marcus (portmgr)
2004-03-19 11:08:09 +00:00
Trevor Johnson
dfc4c0a7ce Fill /mnt/ before each port and clear it afterward, to avoid running
out of inodes.
2004-03-15 21:46:49 +00:00
Akinori MUSHA
3d30f7c9c7 This script had served its purpose. 2004-03-14 11:48:40 +00:00
Trevor Johnson
d042f83b86 Add note about FETCH_BEFORE_ARGS=-s. 2004-03-12 20:03:51 +00:00
Trevor Johnson
fc9fc69007 script for finding "size mismatch" and "size unknown" errors 2004-03-12 18:56:53 +00:00
Kris Kennaway
58ec73aeee Run a command on all client machines of a certain architecture, or all
client machines.
2004-03-08 02:07:03 +00:00
Kris Kennaway
19d7957096 Walk through a package set and prune files that are not listed in INDEX
(e.g. packages from a previous build run, packages that incorrectly modify
their PORTNAME at install-time, etc.) as well as dangling symlinks.
2004-03-08 02:02:57 +00:00
Kris Kennaway
f71e690779 Verify the archive integrity of a package set, and move aside any that
are found to be bad.  Not currently in use, since we do not experience
package corruption and this takes quite a while to run.
2004-03-08 02:01:24 +00:00
Kris Kennaway
f2138752d2 To be run on the client, this script looks for chroot directories that have not been
used in 20 minutes, as well as directories listed as 'in use' that have not been touched
in 24 hours (corresponding to port builds that have timed out or shut down uncleanly)
and prunes them to reclaim space.  This is intended to be run as a cron job.
2004-03-08 01:56:16 +00:00
Kris Kennaway
9ee56fac4b Break out a script from dopackages for building the restricted.sh file
so it can be easily done manually
2004-03-08 01:52:45 +00:00
Kris Kennaway
3bfeb225a1 Replace gnome with gnome2 in quickports. I'm still not sure this actually
works as intended.
2004-03-08 01:38:34 +00:00
Kris Kennaway
858af6c802 Remove the integrity testing code now that the corruption bug has been
identified and those machines removed (restricted to Miatas running 5.2)
2004-03-08 01:37:34 +00:00
Kris Kennaway
3d97e9437e * Fix 4.x builds with 5.x host systems by copying some additional needed
files into the chroot to support host ps and killall binaries.
2004-03-08 01:36:30 +00:00
Kris Kennaway
5231db7af0 Expand out some shell globbing syntax 2004-03-08 01:29:03 +00:00
Kris Kennaway
c6484234da Prune out packages that will not be built because a dependency is marked
IGNORE/FORBIDDEN/etc (using duds.full).
2004-03-08 01:28:28 +00:00
Kris Kennaway
4215cfc4c1 Create a duds.full file that lists not only files that are marked IGNORE
but everything that depends on them.
2004-03-08 01:27:35 +00:00
Kris Kennaway
88ecf0ff35 Increase timeout on slow build machines (alpha, sparc64) to 16 hours.
This should probably be made a per-machine variable.
2004-03-08 01:25:25 +00:00
Kris Kennaway
6ebc6a8ffb * Set the PACKAGE_BUILDING variable in the build environment so ports can
detect they are being built on bento
* Update the list of "extra files" to filter to reduce some false positives
2004-03-08 01:23:20 +00:00
Kris Kennaway
eab18f688c Set up the DISTDIR and PACKAGES variables for use by client scripts 2004-03-08 01:20:36 +00:00
Akinori MUSHA
ac6314f977 Add sunshar, a "secure unshar" for ports committers, which:
- Does not execute unknown commands nor call sh(1) at all.
  - Does not overwrite existing files by default.
  - Does not extract files into upper directories.
  - Does have a dry run (-n) flag to see what would have been extracted.
  - Does have a strip (-p N) flag to strip any number of levels from
    pathnames.

It (so far) only supports shell archives made with BSD shar.
2004-02-28 14:29:09 +00:00
Brian Feldman
d7e662de4c Update "plist" to understand the rest of the mtree(5) file format,
thus fixing the extra-@dirrm-problem once the base mtree files
document the extra symlinks that are part of the local/etc. trees.
2004-02-27 21:01:02 +00:00
Joe Marcus Clarke
cc72b419cc Fix up the ordering and remove some duplicates so the resulting summary is
more accurate:

* The tests for "Cannot stat", "can't cd", and "tar command failed" are moved
  to the bottom.  This will sacrifice a little bit of performance for a gain
  in accuracy
* The tests for "configuration errors" needed to be combined and tweaked to
  better identify errors that are architecture-specific (usuallly the
  "all pointers are ints" assumption)
* The detection of chown was buggy
* There were some duplicate test cases
* As an experiment, another test for dependency problems is added

PR:		61914
Submitted by:	linimon
2004-02-04 05:31:52 +00:00
Alex Dupre
0374da0b6e - Fix synopsis
- Add 'ports/' PR category to commit log

Approved by:	will
2004-01-23 07:28:54 +00:00
Joe Marcus Clarke
377ca431d9 Comment out the munmap reason since it is quite unlikely this will be
encountered again, nad having it in there slows performance.  However,
I'm leaving it in the file in case a bad bindist slips back in, and it
becomes convenient to uncomment this for purposes of seeing what build
failures are cluster-related.

Requested by:	kris
2004-01-21 16:11:18 +00:00
Joe Marcus Clarke
83c1f7ffe2 Add domakedescribe and doportlint, two scripts that iterate over the ports
tree, and run "make describe" and portlint respectively.  They can be useful
as automated linting tools.

PR:		59226
Submitted by:	linimon
2004-01-19 22:35:58 +00:00
Joe Marcus Clarke
5b279805c7 * Refactor processlogs so that new error types can be added easily to a new
processonelog script, that contains all the per-errorlog logic [1]
* Add new error checks, one for detecting CPU problems, and the other for
  checking for broken libgnugetopt support [2]
* Add a new "munmap" error type to check for broken bindists
* Add imake and pthread detection to processonelog [3]
* Add errortype column to the bento "New Build Failures" report [4]

PR:		50258 56859 [1]
		54406 [2]
		57067 [3]
		59272 [4]
Submitted by:	linimon [1] [2] [3] [4]
2004-01-19 22:30:53 +00:00
Joe Marcus Clarke
63f09d3369 Add security-check.awk, a more efficient implementation of the ports
system's security checking algorithm.  This will be used in the upcoming
changes to bsd.*.mk.

PR:		55331
Submitted by:	Eugene M. Kim <ab@astralblue.com>
2004-01-19 22:19:00 +00:00
Joe Marcus Clarke
24f64c924d * Add support for linprocfs (needed for JDK ports) [1]
* Be smarter about adding directories to ldconfig
* Add code to test package integrity [1]

Submitted by:	kris [1]
2004-01-19 22:13:17 +00:00
Joe Marcus Clarke
5b6ccde0d9 Use editors/openoffice-1.1 instead of editors/openoffice since the latter is
now gone.
2004-01-15 21:56:23 +00:00
Dmitry Sivachenko
cb132627e5 When suggesting to add new port's submitter to Contributors' List,
also print the exact location of the file to checkout.
This is for those who rarely adds new ports and do not remember the
location of Additional FreeBSD Contributors article.

Approved by:	will
2004-01-07 20:03:52 +00:00
Pete Fritchman
6160a79b6c Refactor how we format the autofill message. With the slightly questionable
Perl before, sometimes we would word wrap too soon.  Now we should never
generate a line more than 72 characters long (but as close to 72 characters
long as we can without breaking up a word).

Approved by:	will (maintainer)
2004-01-06 06:04:31 +00:00
David E. O'Brien
5dda2933f1 There is nothing "future" about 'addport'. 2004-01-02 23:27:29 +00:00
Dmitry Sivachenko
75122bde71 Use 'make master-sites-all' instead of 'make -V MASTER_SITES' to obtain the list
of master sites.
Before that %SUBDIR% was not expanded and the resulting URL was malformed.

L-o-o-o-ng maintainer timeout waiting for review of a slightly different
solution.
2003-12-17 10:28:32 +00:00
Dag-Erling Smørgrav
cc1020551b fetch(1)'s -b and -t options were deprecated years ago, so stop using them. 2003-11-12 15:09:12 +00:00
Kris Kennaway
a36c5cd9ad Condense the table a bit 2003-10-13 06:33:04 +00:00
Kris Kennaway
2f9f9b16c8 The newfailure file is no longer updated by builds 2003-10-13 02:59:19 +00:00