The "build with Ports SSL" option is no longer valid. The SSL library is
selected through the SSL_DEFAULT value. While removing the PORTS_SSL
option, modernize the entire set of options under the general
infrastructure blanket. The SSL work, including the support for LibreSSL
was done under the SSL blanket.
The ssl.mk helper can augment the MAKE_ARGS variable with a OPENSSL_CFLAGS
definition which just happens to break this port. Add a filter to remove
any such definitions if they occur. The issue was introduced when
USES+=ssl was added to the makefile to document the SSL requirement.
The bounce-buffer I/O driver fix in patch-lib_ext2fs_unix__io.c is a
prototypical fix, and has been forwarded upstream, but it permits us to
pass all self-tests (mostly undo-related) that were still failing on
11.0-RC2 amd64. There is some potential for optimization,
posix_memalign() might save us quite a few memcpy() calls and replace
the now-repaired code paths by a simple pread[64]() or pwrite[64]().
Remove BROKEN, but insist (by setting BROKEN conditionally) on anything
that is FreeBSD 11 or newer, or non-i386/non-amd64, that the user runs
at least the small self-tests.
Revise option descriptions a bit.
Bump PORTREVISION.
Clang 3.9.0 has a new warning about undefined template variables, which
is triggered by including cryptopp headers in the spotify blob
downloader:
In file included from /wrkdirs/usr/ports/audio/clementine-player/work/Clementine-1.3.1/src/internet/spotify/spotifyblobdownloader.cpp:43:
/usr/local/include/cryptopp/pkcspad.h:74:53: error: instantiation of variable 'CryptoPP::PKCS_DigestDecoration<CryptoPP::SHA512>::decoration' required here, but no definition is available [-Werror,-Wundefined-var-template]
return HashIdentifier(PKCS_DigestDecoration<H>::decoration, PKCS_DigestDecoration<H>::length);
^
This warning could be silenced by hacking on cryptopp, but just suppress
it for now.
Approved by: sbruno (maintainer)
PR: 212343
MFH: 2016Q3
- Register proxy dependencies found by stage-qa
Changelog:
Correct blank frame fix from 2.6.8 (add one to last frame).
Fix coding error when centering windows.
Correctly parse the path variables for frei0r, libvisual and ladspa.
Set nicer defaults for RGBDelay effect.
Note for SSL_DEFAULT=libressl:
configure: error: Detected LibreSSL:
This is not supported, and may break consensus compatibility
It might be worth detecting that via SSL_DEFAULT and setting the
port to IGNORE. Or perhaps a newer version of litecoin will support
LibreSSL officially.
Approved by: SSL blanket
The update to libkolab in r421840 unfortunately broke desktuils/libkolab on the
current version of FreeBSD.
The issue is addressed in two upstream commits
* 62ebad910fa7d1843373056dd795fc5c36b20bb2
==> Workaround for qt not defining Q_DECL_IMPORT
* d0a2fda6059abda610afe6a8d29b8f5a1c6ae4ae
==> Fix multiple-definition-warning due to redefining Q_DECL_IMPORT.
Instead of applying said two patches and enabling them on Q_OS_FREEBSD, rakcuo@
suggested to instead just define MAKE_KOLAB_LIB while the proper fix isn't
upstreamed.
Reported by: Steve Wills <swills@FreeBSD.org> via jenkins
Approved by: rakcuo (mentor)
The file is accessible via http browser, but "make fetch" just times out
on both FreeBSD and DragonFly. The easiest fix would be to host the
file in LOCAL/ or elsewhere.
Given lack of maintainer and lack of development since 2007, let's see
if anyone cares enough to host the source file and fix the port.
This simplifies the logic involved. Now the port will present as BROKEN
if it's built on FreeBSD 9 using the base SSL library.
Approved by: SSL blanket