Commit graph

110 commits

Author SHA1 Message Date
Joe Marcus Clarke
1ecef33045 Don't check for DISTVERSION as apart of %makevars since it will be set
internally when PORTVERSION is set.  Instead, just scour the Makefile to
see if both PORTVERSION and DISTVERSION are defined.

Reported by:	krion
2004-12-17 17:25:32 +00:00
Joe Marcus Clarke
bd01e6b8f2 * Update to 2.6.10
* Add support for the new DISTVERSION macro

Submitted by:	lioux (plus some additional checks)
2004-12-17 03:46:50 +00:00
Joe Marcus Clarke
d9da40e963 Update to 2.6.9.
* Ignore comments when checking for absolute pathname usage
* Check DISTNAME for uses of PORTREVISION and PORTEPOCH [1]
* Make sure to quote meta-characters in PORTNAME before using it as a
  regular expression [1]
* Fix bug when matching OPTIONS in ".if defined(WITH_OPT1) &&
  defined(WITHOUT_OPT2)" [2]
* Update OMF checks to account for the new INSTALLS_OMF macro
* Update GConf checks to account for the new GCONF_SCHEMAS macro

PR:		73536 [2]
Submitted by:	mat [1]
		leeym [2]
2004-11-22 18:28:40 +00:00
Joe Marcus Clarke
5d94d62196 Support .ifndef and !defined when doing OPTIONS checking. 2004-10-12 19:40:05 +00:00
Joe Marcus Clarke
26f28bbd81 * Update to 2.6.8
* Check PLIST_FILES for shared libraries, and make sure
  INSTALLS_SHLIB is defined [1]
* Check DATADIR and MAN3PREFIX macros [2]
* Check OPTIONS [3]

PR:		71405 [2]
		71468 [3]
Requested by:	michael johnson <ahze@ahze.net> [1]
Submitted by:	leeym [2] [3]
2004-10-12 04:33:46 +00:00
Joe Marcus Clarke
cf8b7fbebf Update to 2.6.7
* Switch the direct use of ``echo'' check to suggest ${ECHO_CMD} or
  ${ECHO_MSG} instead of ${ECHO} [1]
* Tighten the check for improper GConf schema handling so that we only look
  in the GConf schemas directory [2]
* Correct some grammar mistakes [3]
* Avoid erroneous "direct use of command" warnings [4]

PR:		71159 [4]
Submitted by:	gerald [1]
		pav [3]
		eik [4]
Reported by:	pav [2]
2004-09-01 04:13:32 +00:00
Joe Marcus Clarke
35c8dae828 Update to 2.6.6
* Fix a typo in the libtool archive hint [1]
* Check for ports that have a poorly specified CONFLICTS line as well as ports
  that conflict with themselves [2]
* Check for proper handling of gconf schemas
* Check for explicit listing of %gconf keys in the plist

Spotted by:	lofi [1]
Submitted by:	eik [2]
2004-06-27 20:58:47 +00:00
Joe Marcus Clarke
c1b62aafb1 Update to 2.6.5.
* Fix a bug introduced in the "use strict" conversion, and don't check patch
  files for trailing blank lines
* Add a check to make sure pkg-config files are installed into the correct
  location [1]
* Fix some nearby spacing nits

Requested by:	pav [1]
2004-06-15 06:26:49 +00:00
Joe Marcus Clarke
b9675a58cf Update to 2.6.4.
* Remove check for SIZE and MD5 in distinfo since this was a rush job, and
  missed some common cases. [1]
* Re-enable use strict, and fix portlint to obey it

Requested by:	eik [1]
2004-06-06 17:04:28 +00:00
Joe Marcus Clarke
0bc1fe6be6 Update to 2.6.3.
* Add a generic check for deprecated macros (e.g. the recent autotools batch),
  and add USE_MESA to the set [1]
* Only use USE_LIBTOOL_VER for checking .la file installation [1]
* Add a check for USE_LIBLTDL and warn about directly using a libltdl
  dependency [1]
* Check distinfo to make sure each file in DISTFILES has SIZE and MD5 entries
  if NO_SIZE and NO_CHECKSUM are not defined

Submitted by:	krion and tobez [1]
2004-06-06 01:06:33 +00:00
Joe Marcus Clarke
53262e188e Update to 2.6.2.
* Do not complain about SIZE if NO_SIZE is set [1]
* Allow ``%%PORTDOCS%%@unexec rmdir %D/%%DOCSDIR%% 2>/dev/null || true'' in
  pkg-plist when using PORTDOCS
* Be a little smarter about complaining when .la files are seen in the plist.
  Also, point users to the GNOME site for elimintating .la files altogether [2]
* Super-scrub PKGNAME and PORTVERSION for illegal characters [3]
* Check for port versions that go backwards [3]

PR:		66891 [2]
Submitted by:	krion [1]
		leeym [2] (based on)
		eik [3]
2004-05-30 19:57:49 +00:00
Joe Marcus Clarke
ce673392c8 Update to 2.6.1.
* Add a check to see if PLIST_{FILES,DIRS} is defined and pkg-plist exists.
  If so, print an error [1]
* Add a check for direct usage of iconv.\d+ and intl.\d+ instead of USE_ICONV
  and USE_GETTEXT [1]
* If %%DOCSDIR%% is used in the plist, make sure @dirrm %%DOCSDIR%% is also
  present [1]
* Don't flag a missing distinfo as FATAL [2]

Submitted by:	krion [1]
		eik [2]
2004-05-01 02:25:00 +00:00
Joe Marcus Clarke
6ab42818d7 Update to 2.6.0
* Add some additional checks for USE_* variables included too late [1]
* Add a check for SIZE in distinfo [2]
* Fix a small style nit [2]
* Warn is USE_SIZE is used in a port's Makefile
* Check to see if a port supports WITHOUT_NLS if USE_GETTEXT is defined [3]

Submitted by:	eik [1]
		krion [2]
Requested by:	kris [3]
2004-03-26 20:43:13 +00:00
Joe Marcus Clarke
31441bb2d6 Update to 2.5.9.
* Add code for formal master/slave checking rules as defined in ports/64393 [1]:

  1. A port is a slave port if and only if MASTERDIR != .CURDIR
  2. Slave ports should define MASTERDIR using one of the following lines:

    MASTERDIR=	${.CURDIR}/../../<category>/<port>
    MASTERDIR=	${.CURDIR}/../<port>

  3. Non-slave ports shouldn't define MASTERDIR at all
  4. The last line of a slave port's Makefile has to be

    .include "${MASTERDIR}/Makefile"

  5. The last line of a non-slave ports Makefile must be one of:

    .include <bsd.port.mk>
    .include <bsd.port.post.mk>

  6. slave ports may not include bsd.port(.pre).mk

* Check to make sure MACHINE_ARCH is not defined and make sure it is never
  tested directly [2]
* Fix some grammar nits [3]

PR:		64420 [1]
Submitted by:	eik [1]
		krion [3]
Requested by:	kris [2]
2004-03-21 08:24:41 +00:00
Joe Marcus Clarke
26b0d5c789 Update to 2.5.8.
* Add dirname and egrep direct command use checks
* Add a missing '?' in checking for text after bsd.port(.post)?.mk [1]
* Add a check to make sure OPTIONS is set before bsd.port.pre.mk

Submitted by:	eik [1]
2004-03-10 06:33:00 +00:00
Joe Marcus Clarke
08837877ea * Update to 2.5.7
* Fix some grammar nits in portlint.1
* Add some missing options to the summary in portlint.1
* Reorganize some option descriptions in portlint.1
* Add an ENVIRONMENT section describing PL_CVS_IGNORE and PORTSDIR in
  portlint.1
* Don't check the MAINTAINER field for direct command use [1]
* Add a new PL_CVS_IGNORE environment variable that allows users to filter
  out certain patterns from the CVS files check [2]
* Only warn about CATEGORY problems if the user is in PORTSDIR [3]
* Sync new command macros with recent bsd.port.mk changes
* Correct a regular expression problem when looking for direct command use [4]

PR:		61562 [1]
		61449 [2] [3]
Submitted by:	Sergey Matveychuk <sem@ciam.ru> [1]
		sergei [3]
		leeym [4]
2004-01-22 20:06:36 +00:00
Joe Marcus Clarke
0038a81633 Update to 2.5.6.
* Check to make sure RCS tags begin with capital letters [1]
* Do not look direct command use in .for loops [2]

PR:		60947 [1]
Submitted by:	leeym [1]
		petef [2]
2004-01-07 06:42:55 +00:00
Joe Marcus Clarke
88454c9afc * Update to 2.5.5
* Fix up the usage text
* Ignore arguments passed to REINPLACE_CMD so portlint will not complain on
  things such as ${REINPLACE_CMD} -e 's,/usr/local,${PREFIX},g' [1]
* Only match libraries installed into lib when looking for .so's [2]
* Try to make the PKGCATEGORY check a little more forgiving to committers
  checking single ports [3]

PR:		60608 [1]
		60803 [2]
Submitted by:	leeym [1] [2] (based on)
		dougb [3]
2004-01-02 02:20:41 +00:00
Joe Marcus Clarke
5ca680f076 Catch the pkg-descr up with reality. 2003-12-27 00:57:31 +00:00
Joe Marcus Clarke
e02168c9a6 * Update to 2.5.4
* Correct a typo (-n should be -N) [1]
* Don't check comments for direct command use [2]

Submitted by:	pav [1]
		Sascha Holzleiter <sascha@root-login.org> [2]
2003-12-27 00:45:20 +00:00
Joe Marcus Clarke
debac8b327 Ack, I knew I forgot something. Add a new -C argument that enables pedantic
committer mode.  This is the identical to -A except it omits the new port
checks.

Requested by:	eik
2003-11-22 20:38:55 +00:00
Joe Marcus Clarke
c2d31c5361 Standardize all error messages to include the filename at least (and line
number where possible).  Bump version to 2.5.2.

Reviewed by:	eik
2003-11-22 20:29:03 +00:00
Joe Marcus Clarke
22030dac05 * Check to make sure new ports do not contain PORTREVISION [1]
* Check to make sure new ports do not contain PORTEPOCH
* Throw a FATAL error if an additional file exists in the port directory but
  not in CVS [2]
* Throw a FATAL error if a file is in CVS but not in the port's directory [2]
* Throw a FATAL error if a file was deleted from CVS but still in the port's
  directory [2]
* Warn if a new file contains a non-empty RCS Id [2]
* Add a missing ``if ($verbose)'' [2]

Submitted by:	arved [1]
		eik [2]
2003-11-21 02:55:08 +00:00
Joe Marcus Clarke
4f21abd357 Remove EXAMPLESDIR.
Submitted by:	krion
2003-11-17 21:19:02 +00:00
Joe Marcus Clarke
1f93b36619 Update to 2.5.0.
* Add some linenumbers to the whole file search
* Hack the direct command use code some more
* Add a check for the deprecated USE_MESA
* Allow PKGCATEGORY not in CATEGORIES [1]
* Allow %B in pkg-plist, as it has a valid prefix [1]
* Allow simple rm -f, it needs no redirection [1]
* Add portlintgrep.pl, an example on how to use portlint to find certain
  portlint problems in the ports tree [2]

Submitted by:	dinoex [1]
		eik [2]
2003-11-17 20:17:46 +00:00
Joe Marcus Clarke
be2f66b2f4 * Update to 2.4.8
* Add a check to make sure the last line of a slave port's Makefile contains
  an appropriate MASTERDIR include directive [1]
* study() the $whole string to improve performance [1]
* Fix the search for direct command use
* Check for ports that may break INDEX [1]
* Check for GNOME ports that use pre-patch and gnomehack

Submitted by:	eik [1]
2003-11-15 22:12:00 +00:00
Joe Marcus Clarke
12a03d742d * Add support for the arabic category [1]
* Check for variables that are used too late [1]
* Rename some of the language variables.  Admittedly, this needs more work.
* Check for anything after bsd.port(.post).mk [1]
* Fix the language category search code
* Bump version to 2.4.7

Submitted by:	Oliver Eikemeier <eikemeier@fillmore-labs.com> [1]
2003-11-09 00:44:31 +00:00
Joe Marcus Clarke
5b8604bff3 Whoops. Flush out my CVS repo, and share some missing bug fixes with the
rest of the world.

* Fix the -V option in the manpage [1]
* Handle the case where parentheses may not exist around NOPORTDOCS [2]
* Bump version to 2.4.6

Submitted by:	mat [1]
Reported by:	kris [2]
2003-11-01 22:46:25 +00:00
Joe Marcus Clarke
694151221a Recognize .ifndef(NOPORTDOCS) as well as .if !defined(NOPORTDOCS).
Reported by:	kris
2003-10-27 01:58:39 +00:00
Joe Marcus Clarke
abada95d3c * Add some @unexec checking for plists [1]
* Check for the common typo, NOPORTSDOC [2]
* Make sure .CURDIR is the primary category [3]
* Check for USE_* macros that are user-settable [4]
* Try to be a little more intelligent when checking for macros that need to
  appear earlier
* Ignore make directives when checking for extra items in certain sections

PR:		55921 [1]
		57751 [2]
		58292 [3]
		58525 [4]
Submitted by:	edwin [1]
		Oliver Eikemeier <eikemeier@fillmore-labs.com> [2] [3] [4]
2003-10-26 21:27:30 +00:00
Joe Marcus Clarke
dd5ea45c77 Update to 2.4.4.
* Add support for the Polish locale
* Try to add more intelligence to the direct command use code
* Fix up the wording about numbered info files [1]

Suggested by:	gerald [1]
2003-08-16 20:42:44 +00:00
Joe Marcus Clarke
12a8b0c085 Really fix the bug where portlint looks through COMMENT for direct command
usage.
2003-08-15 17:47:21 +00:00
Joe Marcus Clarke
0bd33bd673 * Add support for the new INFO macro
* Clean up some more Perl warnings
* Make sure all the MAN macros are printed in all uppercase
* Add perl, ruby, python, and the auto* tools to the list of direct
  commands [1]

PR:		55529 [1]
Submitted by:	Jens Rehsack <rehsack@liwing.de> [1]
2003-08-15 05:05:33 +00:00
Joe Marcus Clarke
18bbfe40c0 Update to 2.4.1.
* Document the -V option [1]
* Properly suggest ${STRIP_CMD} (not ${STRIP}) instead of strip [2]
* Correct the version string

PR:		54993 [1]
Submitted by:	Mark Linimon <linimon@lonesome.com> [1]
		gerald [2]
Pointy hat to:	me [2] (I should have used Gerald's patch as-is)
2003-07-28 20:23:32 +00:00
Joe Marcus Clarke
bebd089421 Update to 2.4.0.
* Document the -A option in the usage
* Add my name to the list of AUTHORS
* Clean up some warnings produced by perl -cwT
* Check for the existence of pkg-comment and flag it as FATAL [1]
* Add OMF checking support similar to the info checking code
* Add support for {DOCS,EXAMPLES}DIR macros [2]
* Don't check commented out URLs in MASTER_SITES [3]
* Add file, find, strip, and xargs to the list of direct command names [4]
* Don't search for command names in COMMENT [5]
* Add SITE_PERL support [6]
* Add DISTFILE/MASTER_SITE grouping support [7]
* Check to make sure the MAINTAINER field contains a valid email address
* Add support for {EXTRACT,PATCH}_DEPENDS
* Add USE_GETOPT_LONG support [8]

PR:		48199 [1]
		53371 [2]
		43537 [3]
		54381 [6]
		39487, 44099, 48221 [7]
		54497 [8]
Submitted by:	Sergei Kolobov <sergei@kolobov.com> [2] [8]
		gerald [4] (file and strip)
		Oliver Eikemeier <eikemeier@fillmore-labs.com> [6]
Reported by:	kris and nork [5]
2003-07-20 00:31:20 +00:00
Joe Marcus Clarke
c69e3dca1a I'll take this. 2003-07-17 04:42:07 +00:00
Michael Haro
beabe4fb0b I don't have the time to maintain this port.
Whoever takes maintainership should email me as I have some stuff that
was in progress.
2003-07-17 04:36:05 +00:00
Pete Fritchman
0b19c78609 - warn about incorrect usage of the pre-everything:: target
- don't give a warning to use binary mode because of a possible RCS tag
  if the tag is $FreeBSD$.
- bump PORTREVISION

Approved by:	maintainer timeout, portmgr (kris)
2003-03-07 17:00:43 +00:00
Ade Lovett
7e52725f2a Clear moonlight beckons.
Requiem mors pacem pkg-comment,
And be calm ports tree.

E Nomini Patri, E Fili, E Spiritu Sancti.
2003-03-07 06:14:21 +00:00
Kris Kennaway
65cf72ff7c Bump PORTREVISION for previous COMMENT changes
Reminded by:	sobomax
2003-02-10 17:47:18 +00:00
Kris Kennaway
dd95676c27 Catch up to new COMMENT semantics (contains comment string instead of
pointing to pkg-comment)

Submitted by:	lioux
2003-02-10 08:58:30 +00:00
Gerald Pfeifer
9bf9023ee4 Let the PORTSDIR environment variable override our defaults.
Approved by:	mharo (maintainer)
2003-02-02 21:17:40 +00:00
Akinori MUSHA
27754b5c4e Add a simple check for MAINTAINER not to include multiple addresses or
comments.

Approved by:	portmgr
2003-01-11 08:18:48 +00:00
Mario Sergio Fujikawa Ferreira
4345a7350f Add latest language categories: hungarian, portuguese and ukrainian
Approved by:	mharo (maintainer)
2002-11-18 21:28:12 +00:00
Anders Nordby
78e10f01d3 Bump PORTREVISION. 2002-11-18 02:40:28 +00:00
Anders Nordby
43e120b4b3 Add -A option for all additional checks.
Approved by:	(silence from) mharo
2002-11-18 02:37:30 +00:00
Michael Haro
2235407eff Teach portlint to recognize RUN_DEPENDS=${BUILD_DEPENDS} and the like
PR:		27182
Submitted by:	Anton Berezin <tobez@tobez.org>
2002-09-14 18:57:41 +00:00
Akinori MUSHA
77e106b384 Bring in the enhancements I submitted to mharo some time ago and bump
the version to 2.3.2.

- Add checks for empty files, empty directories, core files, more
possible backup files, dotfiles, symlinks and CVS directories.

- Do not assume PATCHDIR always includes "/files/".  Use the best
method to check whether a file is added to @checker as a patch file.

- Some trivial message style fixes.
2001-03-20 20:54:24 +00:00
FUJISHIMA Satsuki
afa075e6d8 o stop checking blank lines for files/patch-*
o fix getopt arguments: -B takes argument and -N don't.

Submitted by:		Peter Pentchev <roam@orbitel.bg>
Non-responce from:	maintainer
2001-02-17 12:20:32 +00:00
Michael Haro
1503c58d38 Fix docs
Submitted by:	olgeni
2001-02-14 10:56:10 +00:00